JD Community
 

Reply
 
Thread Tools Display Modes
  #1  
Old 06.05.2012, 21:28
Bazzu85 Bazzu85 is offline
Vacuum Cleaner
 
Join Date: May 2012
Posts: 16
Default Packagizer problem

Hi,

i've activate the packagizer basic rule that create a subfolder by packagename..

when i add a link in link grabber it works..

but if i change package name, linkgrabber set as download folder the default..

i think that the correct functionality is that after packagename change the download folder is set with the correct subfolder..

thx
Reply With Quote
  #2  
Old 06.05.2012, 21:58
raztoki's Avatar
raztoki raztoki is offline
Tasmanian JDevil
 
Join Date: Apr 2010
Location: Australia
Posts: 8,065
Default

Not entirely sure how <jd:packagename> works. It needs to be downloadlink setting and when the download takes place it checks for current package name vs the one it was made in to start with.

I assume what your describing is caused by: package customiser works for new links been added to linkgrabber. When you said move package around or rename it, no longer works.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #3  
Old 07.05.2012, 00:33
Bazzu85 Bazzu85 is offline
Vacuum Cleaner
 
Join Date: May 2012
Posts: 16
Default

Quote:
Originally Posted by raztoki View Post
Not entirely sure how <jd:packagename> works. It needs to be downloadlink setting and when the download takes place it checks for current package name vs the one it was made in to start with.

I assume what your describing is caused by: package customiser works for new links been added to linkgrabber. When you said move package around or rename it, no longer works.
let me know..
is a fix that are to improve??

in jd1 i've set the option to create always a subfolder with package name..

now i've to:
1 set package name
2 set dowload folder with the repetition of package name..does not make much sense
Reply With Quote
  #4  
Old 07.05.2012, 20:32
Jiaz's Avatar
Jiaz Jiaz is offline
The Hoss
 
Join Date: Mar 2009
Location: Germany
Posts: 25,474
Default

@raztoki: create ticket for this, maybe a special option would also be good here
__________________
JD-Dev & Server-Admin
Reply With Quote
  #5  
Old 07.05.2012, 20:51
editestowy's Avatar
editestowy editestowy is offline
Thou shalt not steal.
 
Join Date: May 2009
Location: PL
Posts: 2,549
Default

@Jiaz
Is in it slightly similar to #4824 we were discussing? To rerun Packagizer?
However for me renaming package changes the final directory according to the rule <jd:packagename>.

Last edited by editestowy; 07.05.2012 at 20:54.
Reply With Quote
  #6  
Old 07.05.2012, 20:57
Jiaz's Avatar
Jiaz Jiaz is offline
The Hoss
 
Join Date: Mar 2009
Location: Germany
Posts: 25,474
Default

renaming != manual selecting different package

rerunning packagizer is no option as
1.) we dont keep the complete history of the link during jd -session
2.) a package can only have 1 folder and when you move them into new folder, what rule to use?
and so on and so on...

i think best would be an option to have subfolder auto-attached to downloadfolder
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 08.05.2012, 04:44
raztoki's Avatar
raztoki raztoki is offline
Tasmanian JDevil
 
Join Date: Apr 2010
Location: Australia
Posts: 8,065
Default

is the best way to solve this by? making a new download link variable (boolean) when package name as subfolder = enabled (matched within package customiser rule or within properties setting) it sets true. At the file level it doesn't matter where you move the file into, or rename file or rename package, the file gets downloaded to the its current save path + <jd:packagename> at the point of download. This field can also be used with properties within linkgrabber and download tabs also.

It can then work as defined path in jd like "c:\blah\bla2\" + "<jd:packagename>" within the rule dialog box, but what's stored is just the path and then looks up downloadlink boolean reference variable. When a path changed by the user its only relative to the parent folder at any point in time. So user changes path to, "d:\meep\meep\" the <jd:packagename> is still present = "d:\meep\meep\" + "<jd:packagename>". This also allows rename the package name within JD GUI at any point in time.

This is what I was trying explain last night jiaz, or trying to figure out how it works currently so that I could find a design solution. I'll make this ticket along those lines, if you disagree with the approach no biggy ;p



Guess I should have said that the download controller, needs to look up the boolean field and download path at the time of processing the download, and save data according to what's defined/set.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]

Last edited by raztoki; 08.05.2012 at 05:08.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 10:10.
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.