Quote:
Originally Posted by Tyler
so then can you guys add the ability to delete duplicate links in the linkgrabber?
|
its impossible to add duplicates within linkgrabber when they already exist in linkgrabber.
the only time that isn't the case at this point in time is when components of the url are urlencoded, and I did mention this above.
Working example
https://board.jdownloader.org/images/logo.png
Code:
1618|http links_jd.plugins.hoster.raz_DirectHTTP.log 14/08/17 11:27:39 AM - INFO [ jd.controlling.linkchecker.LinkChecker(updateAvailableStatus) ] -> Link https://board.jdownloader.org/images/logo.png is TRUE
then try adding with parameter to bypass the dupe checking
https://board.jdownloader.org/images/logo.png?test
Code:
THREAD: 1625
1625|http links_jd.plugins.hoster.raz_DirectHTTP.log 14/08/17 11:27:54 AM - INFO [ jd.controlling.linkcrawler.LinkCrawler(processHostPlugin) ] -> Processing: httpsviajd://board.jdownloader.org/images/logo.png?test
THREAD: 1617
1617|jd.controlling.linkcollector.LinkCollector.log 14/08/17 11:27:54 AM - INFO [ jd.controlling.linkcollector.LinkCollector$11(run) ] -> Filtered Dupe: https://board.jdownloader.org/images/logo.png
as you can see above it prevents it been from added
currently the only time when this doesn't happen (as stated above) is when urlencoding is used within url structure
https://board.jdownloader.org/%69%6D...C%6F%67%6F.png
Code:
1651|http links_jd.plugins.hoster.raz_DirectHTTP.log 14/08/17 11:29:19 AM - INFO [ jd.controlling.linkchecker.LinkChecker(updateAvailableStatus) ] -> Link https://board.jdownloader.org/%69%6D%61%67%65%73%2F%6C%6F%67%6F.png is TRUE
not only doesn't it url decode it before sending the request off, it gets the filename wrong also (fall out).
the fix that Jiaz needs to change, is to full URLDecode the linkid when uses the url as failover (also mentioned above). Then and only then will it be impossible for dupes not to add to linkgrabber when already within linkgrabber, since the backend prevents them adding to Linkgrabber 'filtered dupe' event. It would also prevent dupes within linkgrabber when original is within downloadtab!
Quote:
Originally Posted by Tyler
It's possible to add duplicate links if you disable automatic checking first.
|
typically disabling the automatic linkchecking (for hoster plugins) doesn't cause this. When LinkID is set within a hoster, its done within the correctDownloadLink method. For memory this is called even though linkchecking isn't.
raztoki