[Dockel]

I had added YouTube links to the linkgrabber, removed the ones being marked as dups. Left the not dups in the grabber closed JD and started it the next day. Now all of the links in the grabber were marked as dups. Why is that?



I searched for some of the (dup) URLs in history.txt but I did not find any.

[mgpai]

Originally Posted by Amiganer

(I'm a littlebit confused, what script is which one).

Me too. Will let you know if I am able to figure it out.

[mgpai]

Originally Posted by Dockel

How could I avoid such messages:
They show up when I add a file to the history.

Going by the the title of the dialog box in your screenshot, looks like it was a temp script provided for trouble shooting and not required to add links to history file. You can just disable it.

Originally Posted by Dockel

I had added YouTube links to the linkgrabber, removed the ones being marked as dups. Left the not dups in the grabber closed JD and started it the next day. Now all of the links in the grabber were marked as dups. Why is that?

I searched for some of the (dup) URLs in history.txt but I did not find any.

Links are marked as duplicate only if a matching url is found in the 'history' file OR the download list (including download list to match dupes was implemented on your request some time back). A matching url was found in either of those lists at the time of dupe check.

[Dockel]

Going by the the title of the dialog box in your screenshot, looks like it was a temp script provided for trouble shooting and not required to add links to history file. You can just disable it.

Done, thank you.

Links are marked as duplicate only if a matching url is found in the 'history' file OR the download list (including download list to match dupes was implemented on your request some time back). A matching url was found in either of those lists at the time of dupe check.

Those were new links, never added before (and I manually searched in the history.txt for some, found any, if they had been in the downloadlist they would have been marked red in the linkgrabber, so I would have seen it), so actually I would think something else must have caused that. Well, may be I made a mistake. OK, may be it will never happen again.

Many thanks!

[mgpai]

Originally Posted by Dockel

Well, may be I made a mistake.

Not necessarily. It could also be a bug, in which case, it might happen again. Please feel free to report back if it does.

[Dockel]

I will do so, thank you!

[Dockel]

The same just happened again but without closing and starting JD, any idea why and when, the links are disabled, marked es dups:


May be it has anything to do with the reconnection? During, before or after the last reconnection, however, nothing happened to these links.

[mgpai]

Originally Posted by Dockel

The same just happened again but without closing and starting JD, any idea why and when, the links are disabled, marked es dups:

May be it has anything to do with the reconnection? During, before or after the last reconnection, however, nothing happened to these links.

Going by the the number of comments in your screenshot (2 in 1st and 4 is 2nd), it looks like the same script is running mulitple times or two similar scripts are running twice. Some crawling activity might be triggering the script.

If you provide me (in JD Chat) the current scripts value from advanced settings, I can take a look at it.

[Dockel]

I couldn't reproduce the issue with (really) new links (of files definitely not being downloaded before). I will keep on trying.

It seems the long urls are still added wihtout shortening them. So they still look like this one:

**External links are only visible to Support Staff****External links are only visible to Support Staff**

Could the script add the time stamp (of the time the urls were added to history) like it was some time / weeks before? Although there was some drawback of doing that, if I remember it right.

Edit: now the same issue occurred again.

[mgpai]

@Dockel: Contact me in IRC when you are free. I will chek the url issue and also add an option to include timestamp. But I will not be able to fix the first issue mentioned in the previous post, unless I know how to consistently reproduce the issue.

[Dockel]

When I moved to history.txt some links from the download window suddenly this message popped up:

net.sourceforge.htmlunit.corejs.javascript.EcmaError: TypeError: Cannot call method "getExtractionStatus" of null (#19)
at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.constructError(ScriptRuntime.java:3629)
at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.constructError(ScriptRuntime.java:3613)
at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.typeError(ScriptRuntime.java:3634)
at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.typeError2(ScriptRuntime.java:3650)
at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.undefCallError(ScriptRuntime.java:3664)
at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.getPropFunctionAndThisHelper(ScriptRuntime. java:2221)
at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.getPropFunctionAndThis(ScriptRuntime.java:2 215)
at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpretLoop(Interpreter.java:1333)
at script(:19)
at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpret(Interpreter.java:798)
at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:105)
at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.doTopCall(ContextFactory.java:411)
at org.jdownloader.scripting.JSHtmlUnitPermissionRestricter$SandboxContextFactory.doTopCall(JSHtmlUnitP ermissionRestricter.java:134)
at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3057)
at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.exec(InterpretedFunction.java:115)
at net.sourceforge.htmlunit.corejs.javascript.Context.evaluateString(Context.java:1212)
at org.jdownloader.extensions.eventscripter.ScriptThread.evalUNtrusted(ScriptThread.java:318)
at org.jdownloader.extensions.eventscripter.ScriptThread.executeScipt(ScriptThread.java:180)
at org.jdownloader.extensions.eventscripter.ScriptThread.run(ScriptThread.java:160)

I restarted JD.

When I then wanted to move links to the history from the download list they were not added anymore. Suddenly it sometimes is working, the URLs are added again, but now the URLs do not appear to be shortend anymore in the history.

Moving the URLs to the history from the link grabber seems to work always.
Is there anything I could do?

[Jiaz]

@Dockel: The script tries to call getExtractionStatus method of null element. I think the script is missing null check somewhere

[Dockel]

OK, strange it is occurring suddenly.

[Jiaz]

Can you show the script, then I can check

[mgpai]

@Dockel: Not caused by history scripts. They do not use that particular call. Most likely caused by JD 'example' scripts.

I have tested the history scripts from the github url, and they appear to be working fine and also saving short urls.

If in doubt, find me in JD Chat.

[Dockel]

Yes, of course, but I am not sure which script it is, let my try to find it.

[Dockel]

Actually it must be this one:

/*
Move selected links from linkgrabber list to history file
Trigger required: Linkgrabber Contextmenu Button Pressed
Customize linkgrabber context menu > Add new "Eventscripter Trigger" button > Rename it to "Move to history" (without quotes) > Change Icon (optional)
*/

if (name = "Move to history") {
var file = getPath(JD_HOME + "/cfg/history.txt");

var lock = getModifyLock(file.name);
lock.writeLock();

var urls = getProperty(file.name, true) || file.exists() && readFile(file) || "";
var unique = "";

lgSelection.getLinks().forEach(function(link) {
if (link.availableState == "ONLINE") {
var downloadLink = link.downloadLink;

if (downloadLink) {
var url = downloadLink.contentURL || downloadLink.pluginURL;

if (link.host == "youtube.com") {
url = link.containerURL;
}

if (urls.indexOf(url) == -1) {
unique += url + "\r\n";
}

link.remove();
}
}
})

if (unique) {
var date = Date().substr(4, 20);
writeFile(file, date + "\r\n" + unique + "\r\n", true);
}

setProperty(file.name, urls += unique, true);
lock.writeUnlock();
}

[Jiaz]

That's not the script causing this. It must be a script using getExtractionStatus method

[Dockel]

Yes, sorry, mgpai is just searching for the error in all of the scripts. I do not have any idea which one it might be.

[Jiaz]

@Dockel: Export Settings->Advanced Settings->EventScripter.scripts and send to support@jdownloader.org
easier to debug when we know what scripts you are using