JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 10.03.2017, 01:33
BloodyRain2k
Guest
 
Posts: n/a
Default Soundcloud.com: packagename altering only works for albums

First off thanks for so promptly fixing the plugin as it broke for whatever reason 2 or 3 days ago and didn't recognize any links at all.

But there's sadly still an issue left, or has been added, not really sure as I never noticed the issue before, which is that the plugin's pattern for changing the packagename does not apply to track links but only albumlinks.

This link for example **External links are only visible to Support Staff****External links are only visible to Support Staff** results in the proper "SerpentSound Studios" folder using the *channelname* pattern set in the plugin settings.

But this link however **External links are only visible to Support Staff****External links are only visible to Support Staff** (1st track of the album above) just lands in the default "Various Files" package instead of "SerpentSound Studios".



Also on a sidenote: is there a list of all supported <jd: placeholders?
If yes, where? If not, why?... It's a fricking nightmare finding out which exist and it doesn't even tell you when you have a typo leaving totally aside that the pattern test doesn't reflect successful usage on the download path (if changed through them)
: (
Reply With Quote
  #2  
Old 10.03.2017, 04:12
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,117
Default

Quote:
Originally Posted by BloodyRain2k View Post
First off thanks for so promptly fixing the plugin as it broke for whatever reason[...]
Soundcloud changed a value of their website which was hardcoded in our plugin so we had to update it.
Quote:
Originally Posted by BloodyRain2k View Post
But this link however [...] (1st track of the album above) just lands in the default "Various Files" package instead of "SerpentSound Studios".
It is a single URL and our crawler does not assign any names to such URLs which is fine.
The following solved your problem:
Settings --> Advanced Settings --> Type in "various" --> DISABLE "LinkgrabberSettings: Various Package"
Quote:
Originally Posted by BloodyRain2k View Post
Also on a sidenote: is there a list of all supported <jd: placeholders?
If yes, where? If not, why?... It's a fricking nightmare finding out which exist and it doesn't even tell you when you have a typo leaving totally aside that the pattern test doesn't reflect successful usage on the download path (if changed through them)
: (
You mean the tags inside the packagizer?
Use rightclick, then you'll see some.
Right now, I don't know which ones you mean / which other ones we have.
For some plugins you can also use these tags to get more information but that's more a rare case and no, usually (or let's say, 'until now') there is no list of these tags either.

GreeZ psp
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #3  
Old 10.03.2017, 04:53
BloodyRain2k
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by pspzockerscene View Post
It is a single URL and our crawler does not assign any names to such URLs which is fine.
Well if that's intended then I'd hereby like to request a <jd:soundcloud_uploader> placeholder because I want the tracks to be packaged by their uploader indepently of being in an album or single : /
Point being that it seems silly to me to not be able to have it put tracks into a package by uploader if I want so.
(and no, I don't really want that specialized placeholder ._. that was a joke)

Quote:
Originally Posted by pspzockerscene View Post
Settings --> Advanced Settings --> Type in "various" --> DISABLE "LinkgrabberSettings: Various Package"
Nope, it does not, it now throws them into a single package by trackname for single tracks.

Quote:
Originally Posted by pspzockerscene View Post
You mean the tags inside the packagizer?
Use rightclick, then you'll see some.
There's <jd:subfolderbyplugin> which I found somewhere through google, but as far as I can tell is that just the 2nd packagename that shows up in that context menu.
Either that or it just turns into an empty string instead of just staying as it is, whichever the case, it does NOT return the plugin's name.

And since I've needed <jd:hostplugin> to get for example "Soundcloud" out in the past, could that please be added?
Reply With Quote
  #4  
Old 10.03.2017, 05:12
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,117
Default

Hm now that was a total fail.

1. You misunderstood my answer.
Our crawler works fine.
Also, what you want now is something else... but that is already possible.
Settings --> Plugins --> soundcloud.com --> See custom filenames / packagenames
(And yes, this works a little bit different from the packagizer)

2. What do you mean by "them"?
Your URL pointed to a single track which you did not want to go into that "Various" package so I showed you how to get rid if the Various folder and actually have a name for that package even though it only contains that one item.

3. "jd:subfolderbyplugin" is for Cloud websites like GoogleDrive or MEGA.co.nz which have folder structures.
It is there to preserve the web-folderstructure in JD --> HDD
This is nothing any normal user would use via this tag - it is only used internally by the preddefined packagizer rule "Adopt folder structure".
This has nothing todo with what you want.

If you want the host-name, simply get it via RegEx or wildcards ("*") - there is no need for something like "<jd:hostplugin>".

GreeZ psp
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #5  
Old 10.03.2017, 12:59
BloodyRain2k
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by pspzockerscene View Post
Settings --> Plugins --> soundcloud.com --> See custom filenames / packagenames
(And yes, this works a little bit different from the packagizer)
I'm aware of this and I've already configured it in the way I want it to be, filenames are named the way I want and for album links it creates the packagename, which I need for the correct download subfolder, correctly too.
My issue is that this does not happen for singletrack links.

Quote:
Originally Posted by pspzockerscene View Post
Your URL pointed to a single track which you did not want to go into that "Various" package so I showed you how to get rid if the Various folder and actually have a name for that package even though it only contains that one item.
I did actually not state that I want to get rid of the Various Files packaging, I said that I want singletrack links to also get their *channelname* package created like JDL does for album links.


But I guess a few images will probably help better to show what I mean.
http://imgur.com/a/IypA0
First image shows my plugin settings and how I want the file and package names to be.
Second image shows my music packagizer rule.
Third image shows the difference between album link and singletrack link.

All I want is the singletrack links (the bottom one) to end up in the same *channelname* package as album links do.
Reply With Quote
  #6  
Old 10.03.2017, 15:20
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

wait for next plugin update
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 10.03.2017, 17:25
BloodyRain2k
Guest
 
Posts: n/a
Default

Ok thanks, I'll look forward to it :3
Reply With Quote
  #8  
Old 10.03.2017, 17:37
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

Update is already live
__________________
JD-Dev & Server-Admin
Reply With Quote
  #9  
Old 10.03.2017, 18:11
BloodyRain2k
Guest
 
Posts: n/a
Default

There was one indeed, but sadly nothing changed yet :<

It still throws singletracks into a per track package and not a package by uploader.

The only difference I notice so far is that it now does that by default, before it did that only when I turned off the Various Files grouping or my own packagizer rule on.

What I mean with that is that the screenshot with the album vs single comparison shows the singletrack in a package by trackname, that was due to my packagizer rule, even though I don't know why because I didn't exactly set it up for that, but it turned "Various Files" into the trackname.
When I turned that rule off it would simply result in the "Various Files" package, but now it does it either way.

Not that I mind that much since I want it packaged by uploader to begin with, just mentioning it.

Last edited by BloodyRain2k; 10.03.2017 at 18:16.
Reply With Quote
  #10  
Old 10.03.2017, 18:21
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

Hmm, then I did not understand correctly. I just updated the plugin so a single track will also go to package with correct naming and not into various package.

Maybe provide screenshots and tell me what you want to achive?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #11  
Old 10.03.2017, 18:43
BloodyRain2k
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by Jiaz View Post
Maybe provide screenshots and tell me what you want to achive?
http://i.imgur.com/kf3KZda.png

The result of the upper package for singletracks.
Singletracks result in that bottom package which is just the trackname so instead of several singletracks being packaged one after another into a package by their uploader name they get each a package with their trackname.

Last edited by BloodyRain2k; 12.03.2017 at 15:50.
Reply With Quote
  #12  
Old 15.03.2017, 15:10
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

Wait for next plugin update. Should be working as wished
__________________
JD-Dev & Server-Admin
Reply With Quote
  #13  
Old 16.03.2017, 02:24
BloodyRain2k
Guest
 
Posts: n/a
Default

Yay working as intended now :D

Edit: ok one last tiny thing: is it intentional that dots get replaced with spaces?
**External links are only visible to Support Staff****External links are only visible to Support Staff** has A.Ki as the artist but the result in both, packagename and folder is "A Ki".

Just wondering.

Last edited by BloodyRain2k; 16.03.2017 at 02:29.
Reply With Quote
  #14  
Old 16.03.2017, 02:38
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,117
Default

Quote:
Originally Posted by BloodyRain2k View Post
Edit: ok one last tiny thing: is it intentional that dots get replaced with spaces?
Yes but you can disable it via:
Settings --> Advanced Settings --> Type in "GeneralSettings: Clean Up Filenames" --> DISABLE that

I guess the name of the setting might be wrong - it should say "Clean Up Packagenames" if you ask me hmm

Thanks for your feedback

GreeZ psp
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #15  
Old 16.03.2017, 07:23
BloodyRain2k
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by pspzockerscene View Post
Yes but you can disable it
Thanks for that, sadly we're back to fixing weirdness right away.

For one did I discover that if the package mask contains not a single placeholder to begin with it will default to "*channelname* - *playlistname*".
Out of curiousity did I test just "Soundcloud" as packaging name and it just ignored that and used "*channelname* - *playlistname*" instead, however when I combined them to "Soundcloud *channelname* - *playlistname*" it gave the expected result of well, that mask being properly filled in.

I assume that is an "is the mask missing?" check going way past the idea, or something.
The results are varying though, while having the mask just set to "Soundcloud" single links turn into "*channelname*" while albums turn into "*channelname* - *playlistname*".
Makes sense that singletracks have no playlist as they, duh, don't have one, but it makes not really sense to ignore the mask just because it has 0 placeholders : /


The other thing I found out is that if you copy the link of an artist's profile then you get essentially "*channelname* - *channelname*" as result.
Likely Soundcloud's fault but it looks weird as a packagename.
Found it out by accidentally copying the wrong link when I tried to check whenever the placeholderfree ignoring of the mask was limited to singletracks or if it affected all links.
Reply With Quote
  #16  
Old 21.03.2017, 14:19
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,117
Default

@BloodyRain2k
Yes there is a check for placeholders as errorhandling.

I consider this an important feature.
If you do not want this errorhandling, I can add another setting to let you disable this ...

GreeZ psp
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #17  
Old 21.03.2017, 15:40
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

@pspzocker: I suggest to have no *auto correct* for filepackage patterns. If its empty or doesn't contain any placeholder, simply don't auto create packages
__________________
JD-Dev & Server-Admin
Reply With Quote
  #18  
Old 21.03.2017, 15:42
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,117
Default

Done.
---
[Please read]=>How/when do I get updates?
Read it carefully BEFORE complaining that something would still be not working!
Update cycles depend on your installed JD version!!

---
[Bitte lesen]=>Wie/wann bekomme ich Updates?
Bitte vollständig lesen bevor ihr euch beschwert, dass etwas immernoch nicht funktionieren würde!
Die Updatezyklen variieren je nach installierter JD Version!!


GreeZ pspzockerscene
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 02:00.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.