[monk e]

in the plugin settings clearly states plugin outdated for spankbang.com

a fix would be appreciated

[MrGonzo]

Same issue with spankbang as well....pluging needs an update please asap.

Thanks

[NatSpectre]

It keeps timing out and no downloads can be recognized.
It is the one site I use JDownloder for THE MOST
This needs a FIX ASAP!

[gandalf_grey91]

Yes, I can confirm, am experiencing the same issue.

[gandalf_grey91]

Yes, I can confirm, am experiencing the same issue.

[MrGonzo]

Admins...Any idea when this is going to be fixed?

[KennethR]

Yeah, it's broken. You have to open a page, start the clip, then right-click and copy-paste in JDL. Sucks big time.

Thanks for a very useful program when it works

[mr.danbg]

Originally Posted by NatSpectre

It keeps timing out and no downloads can be recognized.
It is the one site I use JDownloder for THE MOST
This needs a FIX ASAP!
Attachment 10430

+1

[monk e]

have all of you submitted tickets on this with debug logs etc etc. i can't believe its taking this long to fix this problem, i will be submitting a debug log after work today and i suggest that the rest of you also submit tickets on this issue because its clear that the answer to the problem isn't going to be solved merely with posts here on the forum

[dramaman]

Log
10.03.23 05.38.34 <--> 10.03.23 05.40.22 jdlog://1583311370661/
also, it seems to work perfectly fine on one computer but then not on another, perhaps This is why this is taking so long? I just noticed this a few days on my computer but my other computer works fine still, both have the same version and are up to date

[Bosco1]

Originally Posted by NatSpectre

It keeps timing out and no downloads can be recognized.
It is the one site I use JDownloder for THE MOST
This needs a FIX ASAP!
Attachment 10430

Have found same problem on SpankBang (and, so far, no other site on which jDownloader2 works). I am confident this is a recent development; Spankbang previously worked without a problem.
Am using Windows 10 Prof with all updates and latest version jDownloader2.

[gandalf_grey91]

I raised a ticket and provided logs and have since received an email response from Jiaz.

He has explained that the issue with the plugin is caused by the website now using Cloudflare for protection, as it breaks "login and whole process".

He suggested using the cookie login method to resolve the issue, which I can say absolutely does not resolve the issue.

I have emailed him back explaining that I have never been logged in and have had no issues with the plugin working with the Linkgrabber until now, thus I believe the explanation I have been provided is incorrect.

I have asked if there is anything else that can be investigated.

Not sure what will happen from here.

[omega59]

I was able to test this and I was able to grab a couple of video clip just now. I didn't get any cloudflare or captcha or needed a log-in. LinkGrabber picked up the file and everything for me. All i did was click a video, and copy the url. Mind you, it doesn't tell me the size,hoster. Just that it's a video and 1.

[gandalf_grey91]

I do not understand how any one is successfully getting the Linkgrabber to work with this website.

I have tried numerous ways of capturing the URL and the Linkgrabber will not register them at all.

I have opened the page of a video, nothing. I have tried playing the video and right clicking on it, nothing happens.

I have tried finding the video's location within the source code of the page and copying that to the Linkgrabber, doesn't work.

I have copying all three of the methods mentioned above and tried to use the add new links button on the Linkgrabber tab, to do a deep dive, it searches for a few seconds but never finds/adds any links.

I have tried to do all of the above after trying to log in, using the the cookie login method but it just says plugin outdated on the account manager tab in settings and just keeps cycling through a 60-minute countdown saying temp disabled.

[MrGonzo]

Update:

Suddenly today without doing anything on my end, SB links started DLing again. Before all I could get was the "Plugin outdated" error. Never had an issue with the linkgrabber grabbing the links. The error was my only issue.

So whoever/whatever fixed this...thank you.

[andy2]

Stacktrace: java.lang.NullPointerException
at org.appwork.storage.simplejson.JSonParser.skipWhiteSpace(JSonParser.java:615)
at org.appwork.storage.simplejson.JSonParser.parseValue(JSonParser.java:511)
at org.appwork.storage.simplejson.JSonParser.parse(JSonParser.java:215)
at org.jdownloader.scripting.JavaScriptEngineFactory.jsonToJavaObject(JavaScriptEngineFactory.java:998)
at jd.plugins.decrypter.SpankBangComCrawler.findQualities(SpankBangComCrawler.java:416)
at jd.plugins.decrypter.SpankBangComCrawler.parseCrawlSingleVideo(SpankBangComCrawler.java:250)
at jd.plugins.decrypter.SpankBangComCrawler.crawlSingleVideo(SpankBangComCrawler.java:210)
…

now check the source code of a spankbang.com video URL, you'll find a line like this:

    var stream_data = {'240p': ['…

the stacktrace from above shows that it tries to parse this as JSON, which it is not - it is JavaScript, it uses single quotes. JSON uses double quotes, i.e. if it should be parsable as JSON it would have look like this instead:

    var stream_data = {"240p": ["…

I think it's a reasonably safe bet that this line doesn't contain literal quotes and as quick and dirty workaround simply replace all single quotes with double quotes to make it parsable as JSON again: js.replaceAll("'","\"")

PATCH:

Index: src/jd/plugins/decrypter/SpankBangComCrawler.java
===================================================================
--- src/jd/plugins/decrypter/SpankBangComCrawler.java
+++ src/jd/plugins/decrypter/SpankBangComCrawler.java
@@ -437,7 +437,7 @@ public class SpankBangComCrawler extends PluginForDecrypt {
             /* 2021-06-10 */
             final String js = br.getRegex("var stream_data = (\\{.*?\\})").getMatch(0);
             try {
-                final Map<String, Object> entries = (Map<String, Object>) JavaScriptEngineFactory.jsonToJavaObject(js);
+                final Map<String, Object> entries = (Map<String, Object>) JavaScriptEngineFactory.jsonToJavaObject(js.replaceAll("'","\""));
                 for (final String q : knownQualities) {
                     final Object qO = entries.get(q);
                     if (qO == null) {

Edit: the forum-software seems to be eating one backslash in front of a double quote if it is not in a code-block when clicking "Preview Changed"; adjusted accordingly

[Chinesechicken420]

TYVM. Wish I wasn't as much of a n00b so I could patch this myself haha. But appreciate it.

[MrGonzo]

Update 2: So suddenly today the linkgrabber will not grab any SB links. Was working fine yesterday, did nothing here. Thought it was fixed but I guess have to try another way.

Please fix this plugin asap.

Thanks

[tony2long]

Looks like cloudflare to me.
The patch is for non cloudflare and won't help us directly because we still need to wait for core update.

[pspzockerscene]

Works fine here in stable and dev build.

Looks like Cloudflare and/or a website change that might have been reverted by spankbang.com(?)

If you keep having issues:

Please post your log-ID here | bitte poste deine Log-ID hier.

-psp-

[dbat]

Still cant download from Spankbang, copying link briefly pops up JDownloader Parse Clipboard dialog but immediately disappears and no links added to LinkGrabber. Other sites work ok.

Logs posted here:
14.03.23 15.49.03 <--> 14.03.23 15.50.42 jdlog://1104311370661/

Also cant add Spankbang account to account manager, get the message plugin outdated.

DB

[MrGonzo]

p2p....I have done nothing on my end. There have been no new core updates for awhile. 2 days ago the linkgrabber would grab SB links....now suddenly nothing. JD2 wont read the links.

Heres a log...hopfully you can tell me why its not reading the links anymore:
14.03.23 15.57.27 <--> 14.03.23 16.01.04 jdlog://4104311370661/

[Ridethepiggir]

Same here - two different PCs and it won't work on multiple browsers (private browsing) on either of them. The LinkGrabber Chrome extension works for this site, though I'm not sure how it's different from LinkGrabber in J2D.

Any other troubleshooting we can try and do from this end? Would try and login but it's still showing "Plugin outdated" so that's a no-go.


14.03.23 23.20.16 <--> 14.03.23 23.41.00 jdlog://6304311370661/

[KennethR]

Still not working 16.03.23 22.09.38 <--> 16.03.23 21.52.21 jdlog://7704311370661/

Dev build is not what we have installed...

[Trackademickz]

Not working for me as well

16.03.23 21.44.35 <--> 14.03.23 21.35.07 jdlog://7804311370661/

[omega59]

no go here. Pasted a direct link to the mp4 but just says offline.

[FLMB]

Hi,
FYI: ok, even if I'm logged-in to spankbang, the plugin doesn't work.
But what is funny: if I view the source-code of the page in my Browser, at roughly around 20% of the page you'll find the mentioned var by andy2, feel free to look for yourself, sth like that:

<main id="container">
<script type="text/javascript">
var ana_video_id = ' ';
var stream_data = {'240p': [' .....

Nicely in plain text available the links for the video-files in the according resolutions, bam!
One of these links just marked and copied (not even actively fed to JD), and JD will offer to d/l them just fine!!! Ok, the name is wrong, it has the name of the file itself, not the name the uploader chose (the "title").

But the Info ist there in plain text in the source of the page, should be really easy to fix.

Thanks in advance,
FLMB.

[Ridethepiggir]

Originally Posted by FLMB

Hi,
FYI: ok, even if I'm logged-in to spankbang, the plugin doesn't work.
But what is funny: if I view the source-code of the page in my Browser, at roughly around 20% of the page you'll find the mentioned var by **External links are only visible to Support Staff**..., feel free to look for yourself, sth like that:
Nicely in plain text available the links for the video-files in the according resolutions, bam!
One of these links just marked and copied (not even actively fed to JD), and JD will offer to d/l them just fine!!! Ok, the name is wrong, it has the name of the file itself, not the name the uploader chose (the "title").

But the Info ist there in plain text in the source of the page, should be really easy to fix.

Thanks in advance,
FLMB.

Makes sense too, since they offer manual downloads of (most) individual videos on the whole site. The username thing might be related to CloudFlare, but I don't think LinkGrabber failing is - it really seems like it's related to this.

[pspzockerscene]

@McGonzo
Youg log doesn't show any issues.

@Ridethepiggir
Youg log shows a login attempt.
Please first enable debug mode and provide a fresh logs so we can see everything, see:
https://support.jdownloader.org/Know...d-session-logs

@dbat, KennethR, Trackademickz and probably everyone having this issue:

Hi,

English / Englisch
the issue you've reported has been caused by our current Cloudflare issues.
Please read the first post of the linked thread and post in this thread if you have further questions!
In case you've posted a new thread and it will either get merged with the linked Cloudflare thread or we will lock it.
Please post Cloudflare related questions in the above linked thread only!
Attention: The first post of that linked thread contains useful information for you AND website-owners and also the hint that website-owners can solve this issue on their side which would also make our plugin work again!
There is no ETA for a Cloudflare fix from our side so it might be faster to ask website admins! Please read the first post of the linked thread completely and consider sending it to the admins of the website you are having issues with!

Deutsch / German
Das von dir gemeldete Problem wurde durch die aktuellen Cloudflare Probleme verursacht.
Bitte lies den ersten Post des Cloudflare Threads.
Falls du einen neuen Thread dazu geöffnet hast wurde dieser entweder in den bestehenden Cloudflare Thread verschoben oder mit diesem Post von mir beantwortet und geschlossen.
Weitere Fragen bitte im oben verlinkten Cloudflare Thread posten!
Achtung: Im ersten Post ist u.a. beschrieben, dass auch Webseiten-Admins das Problem auf ihrer Seite lösen können --> Unser Plugin würde dann sofort wieder funktionieren - das bitte beachten, den ersten Post vollständig lesen und ggf. an den Support der betroffenen Webseite weiterleiten!
Wie können derzeit nicht sagen, wann es von unserer Seite aus eine Lösung für das Cloudflare Problem geben wird!

-psp-

[Ridethepiggir]

25.03.23 23.04.25 <--> 15.03.23 22.13.04 jdlog://7034311370661/

Debug mode, both with and without "o=all" in the link. Thanks in advance.

[pspzockerscene]

@Ridethepiggir
I can't find any useful information.
Please make sure that debug mode is active, restart JD, trigger the problem and provide fresh logs.
(Yes I did read that you mentioned that debug mode would have already been turned on!)

Please post your log-ID here | bitte poste deine Log-ID hier.

-psp-

[MrGonzo]

p2p....
So still cant get JD2 linkgrabber to grab SB links....even after latest core update.
I enabled "debug mode" and made a new log for u to look at. All I did was startup JD2, goto SB.com, and just started copying SB links into JD2...it shows the clipboard working for a second, then just quits and does nothing on ALL links I try to copy. Then I shutdown JD2.

...Just thought Id mention too if this means anything, but for one little moment last night JD2s linkgrabber did grab 2-3 of the many links I tried...but then just stopped grabbing them again suddenly.

With those 2-3 links the grabber did pickup, JD2 DLed those links fine, but like I said it only grabbed 2-3 (for that little moment) but wont grab anymore.

Hope this log shows you something...
27.03.23 12.15.22 <--> 27.03.23 12.15.03 jdlog://5534311370661/

Thanks

[pspzockerscene]

@McGonzo
In your case Cloudflare is also blocking.
Please read my post #29 in this thread it contains all you need to know.
EDIT

Just for reference:
It is working fine here so this plugin is definitely working fine as long as you're not running into a Cloudflare block!

[MrGonzo]

Yes I read it, but does it basically mean I cant do anything from my end? I dont get why its blocking with some users and not with others.

This Cloudflare behavior is weird becuase like I mentioned before...if a user has installed any "Video Downloader" addons into their browser, most of these addons can still grab the video links from Spankbang...which JD2 linkgrabber does/is still reading for me...so this is a workaround.

Just dont get why JD2 will not read the main site link, but the video link from the embedded video within the page...JD2 still grabs fine...weird.

[pspzockerscene]

Originally Posted by MrGonzo

Yes I read it, but does it basically mean I cant do anything from my end?

All you can try is described in our Cloudflare FAQ:
https://board.jdownloader.org/showthread.php?t=83712

Originally Posted by MrGonzo

I dont get why its blocking with some users and not with others.

As described in that FAQ, the Cloudflare blocking logic is more or less a blackbox so I won't be the one who can answer you that question.
It is similar to how you can never know when/why Google captchas will be easy or hard to solve

Originally Posted by MrGonzo

This Cloudflare behavior is weird becuase like I mentioned before...if a user has installed any "Video Downloader" addons into their browser, most of these addons can still grab the video links from Spankbang...which JD2 linkgrabber does/is still reading for me...so this is a workaround.

Yap that is possible because such browser addons are intercepting the browsers traffic and once the video is playing, all Cloudflare checks are usually already processed.
Some websites however do also have Cloudflare checks when adding such video stream/directurls so yes you can call that a workaround but no it will not work for all websites so I think including it in our Cloudflare FAQ wouldn't be a good idea - what do you think?

Originally Posted by MrGonzo

Just dont get why JD2 will not read the main site link, but the video link from the embedded video within the page...JD2 still grabs fine...weird.

My above explanation should be enough to understand why.
Summary: Browser addons are working on another level - a level at which Cloudflare checks are usually already passed so whatever you do/grab afterwards will usually work fine.
At this level Cloudflare will already think that you are a human well...because you are (essentially you did by hand what JD usually automates) so it's not a big deal that you can now get those directurls.
That's also the reason why for some websites (again as explained in the Cloudflare FAQ), logging in via cookies will allow you to bypass Cloudflare (at least for some time) while the normal login via plugin will fail.

There are some open source projects that will try to bypass Cloudflare within a proxy to basically provide the html without Cloudflare for applications using that proxy.
Such projects could also be a possible solution e.g.:
github.com/NoahCardoza/CloudProxy
(Nope, I did not test this!)

For more information, please contact the website owner (in this case Spankbang.com support) but do not expect helpful replies of owners of free websites as they most likely don't have a problem with blocking applications like JDownloader as a side-effect of using Cloudflare because every user who is using only JDownloader instead of viewing their content in browser will obviously never see their ads...

[MrGonzo]

Thanks for detailed info...Ya I guess I'll just have to use work arounds untill Cloudflare shit has been figured out. At least I know its mainly just new updates to systems and everything.

It is what it is lol.

Thanks

[suuulan]

What can I do bypass the cloudfare crap?

09.04.23 23.28.40 <--> 09.04.23 23.28.55 jdlog://3564311370661/

[pspzockerscene]

Originally Posted by suuulan

What can I do bypass the cloudfare crap?

Read our Cloudflare FAQ:
https://board.jdownloader.org/showthread.php?t=83712

According to your log, your spankbang login is failing in JDownloader due to Cloudflare.

[gandalf_grey91]

I have found something called Locoloader that has no problem capturing the video URLs and downloading from Spankbang.

If they can do it, why can't Jdownloader?

I have never seen a Cloudflare page pop up when accessing SB.

[notice]

Originally Posted by gandalf_grey91

If they can do it, why can't Jdownloader?

As far as I can tell, this is a website only tool and nothing that runs on your computer?
Therefore you can't tell how it's working in background. They might be using paid cloudflare proxies. They might auto switch to different (non blocked) IPs to avoid cloudflare trigger. ....

Originally Posted by gandalf_grey91

I have never seen a Cloudflare page pop up when accessing SB.

Because it's the job of Cloudflare to distinguish Browser/normal use from tools/bots/scripts. In ideal situation you should never see a cloudflare page in browser.