JDownloader Community - Appwork GmbH
 

Notices

Reply
 
Thread Tools Display Modes
  #1  
Old 08.09.2019, 20:27
Iskelderon's Avatar
Iskelderon Iskelderon is offline
Bandwidth Beast
 
Join Date: Aug 2018
Location: Europe
Posts: 131
Default Some working GoogleVideo embeds only show up as "videoplayback"

**External links are only visible to Support Staff****External links are only visible to Support Staff** and some other Google Video links spit out by decrypter like **External links are only visible to Support Staff****External links are only visible to Support Staff** will simply show up as "videoplayback" in the link grabber and download tabs, without any related name information or file extension whatsoever.

Is this an plugin/API version problem? I've seen this happen multiple times. over the years, but in those cases there were always alternate hosts to fall back on.
Reply With Quote
  #2  
Old 09.09.2019, 06:49
tony2long's Avatar
tony2long tony2long is offline
English Supporter
 
Join Date: Jun 2009
Posts: 6,507
Default

What plugin are you talking about?
Sometimes filename should be set in decrypter plugin, except if you know that hoster plugin will handle filename.
__________________
FAQ: How to upload a Log
Reply With Quote
  #3  
Old 09.09.2019, 11:28
Iskelderon's Avatar
Iskelderon Iskelderon is offline
Bandwidth Beast
 
Join Date: Aug 2018
Location: Europe
Posts: 131
Default

In this instance it's coming from NewAsianTv.java (the second link above generates several examples), but it's more of a general problem.
Ideally, if the current logic of the VideoGoogle.java comes up empty trying to determine a file name, it should at least build something that won't cause overwrite conflicts (e.g., VideoGoogle_ + <hash of URL> + <Extension extracted from response header's MIME type>.
Reply With Quote
  #4  
Old 09.09.2019, 12:44
tony2long's Avatar
tony2long tony2long is offline
English Supporter
 
Join Date: Jun 2009
Posts: 6,507
Default

For this case, filename should be set in decrypter plugin, other users won't be happy with random filename.
__________________
FAQ: How to upload a Log
Reply With Quote
  #5  
Old 09.09.2019, 15:28
Iskelderon's Avatar
Iskelderon Iskelderon is offline
Bandwidth Beast
 
Join Date: Aug 2018
Location: Europe
Posts: 131
Default

They'll be happier with ten files, all named "videoplayback"? I'm talking about a fallback option if all previous ones have been fruitless, not default behavior.
Reply With Quote
  #6  
Old 10.09.2019, 18:34
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

I've updated plugin to set better filename (id+itag+extension)
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 10.09.2019, 18:37
Iskelderon's Avatar
Iskelderon Iskelderon is offline
Bandwidth Beast
 
Join Date: Aug 2018
Location: Europe
Posts: 131
Default

Thanks! That should fix the problem of conflicting filenames and format guessing.
Reply With Quote
  #8  
Old 10.09.2019, 18:47
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

you can still reach me in chat
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 15:12.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.