JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 28.02.2024, 16:14
mostafatefa2009 mostafatefa2009 is offline
JD Alpha
 
Join Date: Feb 2024
Posts: 20
Default [Not a bug] Delete Links: Selected & Disabled doesn't work

Hello,

"Clean Up -> Delete Links: Selected & Disabled" Doesn't delete other Disabled items in the LinkGrabber/Downloads tab.
Reply With Quote
  #2  
Old 28.02.2024, 16:19
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,260
Default

Hi,
looks like you mis-understood that function.
When doing a rightclick -> Cleanup, all actions that contain the text "Selected" will only be done on the selected items.

If at all, this is not a bug but a bad translation/wording.
Suggestions for another translation are welcome.
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?

-----------------------------------

On Vacation / Im Urlaub
Start: 2024-02-08
End: TBA

Reply With Quote
  #3  
Old 28.02.2024, 16:22
mostafatefa2009 mostafatefa2009 is offline
JD Alpha
 
Join Date: Feb 2024
Posts: 20
Default

Quote:
Originally Posted by pspzockerscene View Post
Hi,
looks like you mis-understood that function.
When doing a rightclick -> Cleanup, all actions that contain the text "Selected" will only be done on the selected items.

If at all, this is not a bug but a bad translation/wording.
Suggestions for another translation are welcome.
It says "& Disabled" at the end; which means all Disabled links will be deleted too which is a very useful function. Can you add it please?
Reply With Quote
  #4  
Old 28.02.2024, 16:28
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,260
Default

Quote:
Originally Posted by mostafatefa2009 View Post
It says "& Disabled" at the end
But it doesn't mean what you think it means.
It means "Delete all links which are currently selected && disabled".

As explained, suggestions for a better default wording are welcome.
If you do not want to suggest a better naming, you may as well just rename the text of that setting yourself in your installation using the menu manager.

Also you can add customized cleanup actions which will delete just the items you want:
Rightclick anywhere in your downloadlist -> Open menu manager -> Scroll down -> Customize the cleanup actions to your needs.
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?

-----------------------------------

On Vacation / Im Urlaub
Start: 2024-02-08
End: TBA


Last edited by pspzockerscene; 28.02.2024 at 16:30. Reason: Added more information
Reply With Quote
  #5  
Old 28.02.2024, 16:57
mgpai mgpai is offline
Script Master
 
Join Date: Sep 2013
Posts: 1,560
Default

Quote:
Originally Posted by pspzockerscene View Post
... suggestions for a better default wording are welcome.
Delete Links : Disabled links in selection.:)
Reply With Quote
  #6  
Old 28.02.2024, 17:05
mostafatefa2009 mostafatefa2009 is offline
JD Alpha
 
Join Date: Feb 2024
Posts: 20
Default

Quote:
Originally Posted by pspzockerscene View Post

Also you can add customized cleanup actions which will delete just the items you want:
Rightclick anywhere in your downloadlist -> Open menu manager -> Scroll down -> Customize the cleanup actions to your needs.
Great Solution! That worked!

I put a checkmark on "Affected Links: Disabled" and "Include Unselected Items" and this allowed me to delete all disabled links by using the function

Last edited by mostafatefa2009; 28.02.2024 at 17:08.
Reply With Quote
  #7  
Old 28.02.2024, 17:06
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,260
Default

Quote:
Originally Posted by mgpai View Post
Delete Links : Disabled links in selection.:)
Sounds good, I will do that.
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?

-----------------------------------

On Vacation / Im Urlaub
Start: 2024-02-08
End: TBA

Reply With Quote
  #8  
Old 04.03.2024, 17:52
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,260
Default

I've looked into this:
The types of items which will be deleted are appended to that language-string.
Thus I won't touch this pice of translation since it may make it unreadable in other translations and/or other translators might not understand the change.

This is the type of minor flaw that I'd only address whenever that pice of code gets reviewed next time.
I will not create a ticket for this since what has been reported here is so minor.
If it bothers anyone: You can change that translation locally.
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?

-----------------------------------

On Vacation / Im Urlaub
Start: 2024-02-08
End: TBA

Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 08:38.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.