JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #41  
Old 23.11.2023, 11:37
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,668
Default

Both links are working fine here.
Screenshot:
Spoiler:

Please provide a debug-log:

Please post your log-ID here
If your bugreport is about a specific website which JD supports via plugin, please also provide example URLs which can be used to reproduce the issue you are having.

Bitte poste deine Log-ID hier.
Falls dein gemeldetes Problem ein Problem mit einer Webseite ist, die per Plugin unterstŘtzt wird, stelle bitte zusńtzlich Testlinks zur VerfŘgung, mit denen sich dein Problem nachstellen lńsst.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #42  
Old 23.11.2023, 17:03
Perene Perene is offline
JD Adviser
 
Join Date: Jun 2019
Posts: 113
Default

You are correct, both are saying online.

But if you try with spaces, they are not working, only the one without the # symbol.

So, if you try the links from my previous posts, 2/2 online.

Try again with spaces, from here:

**External links are only visible to Support Staff****External links are only visible to Support Staff**

Just do a control + C and V from pastes.io, and you'll notice the issue.
Reply With Quote
  #43  
Old 23.11.2023, 17:05
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,668
Default

Again:
Your "First link" in that pastebin fails in JD & browser.
Your "Second" link in that pastebin works in JD & browser.

I still can't see any JDownloader bug here.
Also you didn't answer my question:
Quote:
Originally Posted by pspzockerscene View Post
Where did you get the non-url-encoded link from?
So again:
Where did you get the non-url-encoded links / links with spaces from?
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #44  
Old 23.11.2023, 19:19
Perene Perene is offline
JD Adviser
 
Join Date: Jun 2019
Posts: 113
Default

OK, sorry for not explaining.

Since I own the file, if I were to post something like this to you:

The%20Woody%20Woodpecker%20Show%20%281957-1977%29%20-%20Epis%C3%B3dio%202x23%20%28%2349%29%20-%20%C3%81udio%20Original%20-%20Legendado%20%28Web-DL%29.mp4

You would have a problem reading that.

So, it would be better if I opted to write like this:

URL from the server/The Woody Woodpecker Show (1957-1977) - Episˇdio 2x23 (#49) - ┴udio Original - Legendado (Web-DL).mp4

The thing is, JDW recognizes anything from IA if I write like in the 2nd method. Either way, it says ONLINE. Regardless of how you type.

But if you try to insert that symbol (non-URL encoded link), JDW refuses to tell it's online. But it is.

That's why I had to rename that same file to:

URL from the server/The Woody Woodpecker Show (1957-1977) - Episˇdio 2x23 (-49-) - ┴udio Original - Legendado (Web-DL).mp4

Bottom line:

JDW recognizes something like this:

The%20Woody%20Woodpecker%20Show%20%281957-1977%29%20-%20Epis%C3%B3dio%202x23%20%28%2349%29%20-%20%C3%81udio%20Original%20-%20Legendado%20%28Web-DL%29.mp4

But not like this:

URL from the server/The Woody Woodpecker Show (1957-1977) - Episˇdio 2x23 (#49) - ┴udio Original - Legendado (Web-DL).mp4

And the only reason is the # symbol.

Last edited by Perene; 23.11.2023 at 19:22.
Reply With Quote
  #45  
Old 24.11.2023, 12:03
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,668
Default

I still don't understand.

Here is my point of view:
For some reason you removed the URL-encoding of this URL.
This broke the URL in JDownloader in broweser but you expect JDownloader to recognize it anyways.

The correct solution would be to either fix the URL yourself or not break it in the first place.
See e.g.:
urlencoder.org/
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #46  
Old 24.11.2023, 21:51
Perene Perene is offline
JD Adviser
 
Join Date: Jun 2019
Posts: 113
Default

My point is:

******************************

When you click with your right button after visiting the Internet Archive server, and try to copy the URL from a file stored there, it will be showed like this:

The%20Woody%20Woodpecker%20Show%20%281957-1977%29%20-%20Epis%C3%B3dio%202x23%20%28%2349%29%20-%20%C3%81udio%20Original%20-%20Legendado%20%28Web-DL%29.mp4

The problem with that idea is if you are trying to display that URL in a blog or to a specific person, it will look like garbage (as if you are typing nonsense: KDdgjadgjadfgaskjfg927o98427942jbewfdsf5546bsfLSDASLDHA )

I can't tell from just looking at that the * real * filename.

So, I need to show it like this:

URL from the server/The Woody Woodpecker Show (1957-1977) - Episˇdio 2x23 (-49-) - ┴udio Original - Legendado (Web-DL).mp4

What's the difference between providing JDOWNLOADER's Link Collector with the two examples?

None whatsoever.

I can say the same about Internet Download Manager. Or any other program. They simply recognize (after checking IA's server) that URL is valid, regardless of you putting something between spaces or not.

Informing the filename with spaces (if they really exist, of course) or not, makes no difference. ZERO.

******************************
Right. Now I can proceed with the problem we are having here...

******************************

Since this is only a choice, nothing to do, right? Just do a control + C and V, so JDW will say the two methods are online.

Wrong.

If the filename contains the # symbol, this is what I discovered:

This will work:

The%20Woody%20Woodpecker%20Show%20%281957-1977%29%20-%20Epis%C3%B3dio%202x23%20%28%2349%29%20-%20%C3%81udio%20Original%20-%20Legendado%20%28Web-DL%29.mp4

This will not:

URL from the server/The Woody Woodpecker Show (1957-1977) - Episˇdio 2x23 (#49) - ┴udio Original - Legendado (Web-DL).mp4

Why? It's the same valid URL!

It is. The difference is that JDW is not seeing as it should.

What did I do to "fix" this issue in the meantime?

I had to rename all the files affected, and use -49- (or anything similar) instead of #49, because your link collector is not working in this scenario. The # symbol breaks the recognition. If, and only if, the provided URL has spaces.

Last edited by Perene; 24.11.2023 at 21:57.
Reply With Quote
  #47  
Old 27.11.2023, 13:18
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,668
Default

I do not see any JD issue here.
Please manually fix such URLs if you keep breaking them yourself by re-applying the URL-encoding to the part of said URLs which contains the filenames.
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #48  
Old 27.11.2023, 19:04
Perene Perene is offline
JD Adviser
 
Join Date: Jun 2019
Posts: 113
Default

Quote:
Originally Posted by pspzockerscene View Post
I do not see any JD issue here.
Then please check this log:

27.11.23 13.46.14 <--> 27.11.23 13.49.14 jdlog://4929311370661/

Also, check these screenshots, they help my argument more than what I wrote so far:

#1 - JDW makes a distinction because of the # symbol:

https://i.postimg.cc/0x4b5qmg/JDW-1.jpg

************************************

#2 - This is how JDW shows the URL with spaces + the # symbol: OFFLINE:

https://i.postimg.cc/dwTDLSmh/JDW-2.jpg

************************************

#3 - Now, look how JDW behaves if you try to copy-paste the same URL, without inserting spaces into the full link:

https://i.postimg.cc/vGFT9L33/JDW-3.jpg

************************************

What behavior I was expecting?

Picture #2 not saying it is offline (because it actually isn't). Somehow the # symbol makes JDW have a problem recognizing that same URL.

Why is that happening, I don't know. And why am I insisting on this? Because even if I tell JDW the provided link has spaces, your LINK-COLLECTOR automatically transforms them from this:

URL from the server/The Woody Woodpecker Show (1957-1977) - Episˇdio 2x23 (#49) - ┴udio Original - Legendado (Web-DL).mp4

Into this:

The%20Woody%20Woodpecker%20Show%20%281957-1977%29%20-%20Epis%C3%B3dio%202x23%20%28%2349%29%20-%20%C3%81udio%20Original%20-%20Legendado%20%28Web-DL%29.mp4

You are telling me to only use the latter, but the catch is: we don't need to be so precise. We never did.

We do now, because JDW is breaking the "transformation" due to the # symbol.

That's all.

If I were to guess, the # is some sort of forbidden character, which breaks the conversion since it's close to the ( ).

Last edited by Perene; 27.11.2023 at 19:07.
Reply With Quote
  #49  
Old 27.11.2023, 19:19
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,668
Default

Quote:
Originally Posted by Perene View Post
If I were to guess, the # is some sort of forbidden character, which breaks the conversion since it's close to the ( ).
The # symbol is the anchor element which can be located at the end of a URL.
If you want it to be part in a filename or in the path of the URL it needs to be URL-encoded.
In your case it's not URL encoded so that URL is invalid.
Explanation:
developer.mozilla.org/en-US/docs/Learn/Common_questions/Web_mechanics/What_is_a_URL

I will not repeat this anymore. If you want to have support for broken URLs in JDownloader, feel free to implement it yourself as JDownloader is open source:
https://support.jdownloader.org/Know...up-ide-eclipse

This is my last comment on this topic.
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #50  
Old 28.11.2023, 01:39
Perene Perene is offline
JD Adviser
 
Join Date: Jun 2019
Posts: 113
Default

No, it's not invalid. The URL is 100% fine either way, it's just a problem from your side, not ours.

If you don't want to implement fixes then this forum is pointless, If I could do your job I wouldn't be here asking for help. This forum is meant to exist for posting feedbacks on issues found on your app.

And the issue here is this (if you want me to be more precise):

JDownloader appears to have difficulty recognizing URLs that include spaces and an anchor (#) symbol, particularly when the URLs are not percent-encoded. The issue seems to affect the accurate parsing of URLs with these specific characteristics.

I suggested enhancing JDownloader's URL parsing logic to better handle URLs with spaces and the # symbol, even when these characters are not percent-encoded. This improvement could significantly benefit users who prefer providing URLs with spaces for better readability.

It would be great if JDownloader could automatically handle or convert spaces and # symbols in URLs to their proper percent-encoded equivalents to ensure compatibility and accurate parsing.

In URLs, the # symbol is often used to indicate a fragment identifier. The fragment identifier is not typically sent to the server but is processed by the client (browser or, in this case, JDownloader) to navigate within the document.

In some cases, special characters like # might interfere with how URLs are interpreted or parsed by certain software.

A few things to consider:

- Encoding the Fragment Identifier: While spaces are generally encoded as %20 in URLs, special characters like # should also be properly encoded, usually as %23. Ensure that if your URL includes a fragment identifier, it is correctly encoded.

Examples:

Original URL which JDW does not recognize:

Code:
URL from the server/The Woody Woodpecker Show (1957-1977) - Episˇdio 2x23 (#49) - ┴udio Original - Legendado (Web-DL).mp4
With the fixing applied:

Code:
URL from the server/The Woody Woodpecker Show (1957-1977) - Episˇdio 2x23 (%2349) - ┴udio Original - Legendado (Web-DL).mp4
Sure there are other priorities, but I believe this enhancement could improve the overall user experience and make JDownloader even more user-friendly.

P.S. You didn't mention if there are internal options related to URL encoding or handling special characters. I am going to assume there are none that impact how URLs are processed.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 05:40.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.