JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 19.10.2016, 12:49
madcowpig
Guest
 
Posts: n/a
Default FileFactory SHA-1 turns back to MD5 adopt checksums issue

Basically, FileFactory has MD5 within it's system to begin with. If I use Adopt Checksums to give the links SHA-1 and start the downloads, it reverts back to MD5. If the link says server too busy and starts a count down timer, it also reverts back to MD5. Anytime the links have to do some kind of change, they revert back to MD5. This happens with both free and free account. At the moment I can't create a log because JD is too busy, but when it's done I will recreate and post a log. In the mean time you can try to recreate the issue with these links (I got small files for quick testing),

Spoiler:
**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**


**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**


**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**


**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**


**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**


**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**
Reply With Quote
  #2  
Old 19.10.2016, 13:59
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,117
Default

Ticket:


GreeZ psp
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #3  
Old 19.10.2016, 14:08
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

Because Filefactory offers its own MD5 hash it will set/use it.
There are two possible solutions I can think of

1.) manually set/adopted checksums will not be overwritten by plugin
2.) *strongest* checksum wins. So in case you adopt/set a SHA256 and plugin tries to set MD5, the SHA256 will be kept.

What solution do you prefer?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #4  
Old 19.10.2016, 15:30
madcowpig
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by Jiaz View Post
Because Filefactory offers its own MD5 hash it will set/use it.
So does RapidGator, but when I use Adopt Checksums it does not revert back to it's offered MD5. At least in my past experience, if it's changed, then correct me.

Quote:
Originally Posted by Jiaz View Post
There are two possible solutions I can think of

1.) manually set/adopted checksums will not be overwritten by plugin
2.) *strongest* checksum wins. So in case you adopt/set a SHA256 and plugin tries to set MD5, the SHA256 will be kept.

What solution do you prefer?
Please help me understand this better. Option two sounds like the current Adopt Checksums feature, which also gives the "strongest" checksum. If this is the case, then I prefer option two. Option one I'm confused what you mean by manually? Like copy and paste? If that's what you mean, then I definitely don't prefer option one, since I can't waste time copy and pasting over one hundred links.

Also I see this,



in the ticket history. Listen, this isn't that serious of an issue, so if you don't want to work on it, because you're busy with other issues, that's fine. I don't use FileFactory like that, since it's slow for free. I just made this report in case someone else needed it. I noticed the bug and thought I'd bring it to the attention of everyone here. I already use a workaround for the extremely rare times I use FileFactory, disable SHA-1 links, add to download list, wait for all FileFactory links to finish, then adopt checksums from the disabled links, then manually start CRC. Also, there is a way bigger issue in the FileFactory plugin that I've been testing to make sure isn't a fluke, which is far more problematic than this issue (Last two downloads never start, because two downloads try to start simultaneously. Will report after confirmation with recreation.). Yeah, so you can definitively skip this request, until someone else asks for it. Sorry if I wasted your time.

Side note: Somebody please answer this question. When I made my first thread about uploading.site, UploadRocket and clicknupload.link, I put it in "International Support" "JDownloader 2" because it says in the English Support,



and I use JD2. But it got moved to "English Support" "Host Plugin Reports". This time I put this FileFactory thread in the "English Support" "Host Plugin Reports" and it got moved to "International Support" "JDownloader 2". This seems like a contradiction to me. I asked in my first thread, why it got moved, but never got an answer.

Quote:
Originally Posted by madcowpig View Post
Lastly I see my thread was moved. Sorry if I put it in the wrong place. I was going to put it here, but then I saw, "NO posts concerning JD2! Please use International Support." So I put it in there instead. Is that message outdated? Is there a guide to the proper sections? It would be helpful for the future. Thanks.
Reply With Quote
  #5  
Old 19.10.2016, 15:32
madcowpig
Guest
 
Posts: n/a
Default

BTW, I just wanna know about the sections, so I don't waste anyone's time. I wanna put it in the correct place the first time.
Reply With Quote
  #6  
Old 19.10.2016, 15:36
madcowpig
Guest
 
Posts: n/a
Default

Most importantly, as always, thanks for the response.
Reply With Quote
  #7  
Old 19.10.2016, 15:40
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

Rapidgator is the same but ONLY when not using premium with api. In all other cases the same happens.
The adopt method simply sets all available/known checksums and Sha256 is the last one. So it will be set if available. But plugins can still change it any time. There is no support to pin a hash at the moment. That's what I offered two possible solutions
Solution also includes Adopt feature
1.) once adopt OR manually set, it will never change by plugin any more
2.) *strongest* hash will be used
__________________
JD-Dev & Server-Admin
Reply With Quote
  #8  
Old 19.10.2016, 15:57
madcowpig
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by Jiaz View Post
Rapidgator is the same but ONLY when not using premium with api. In all other cases the same happens.
I see, thank you for the wisdom, sensei.

Quote:
Originally Posted by Jiaz View Post
The adopt method simply sets all available/known checksums and Sha256 is the last one. So it will be set if available. But plugins can still change it any time. There is no support to pin a hash at the moment. That's what I offered two possible solutions
I understood this part already. Here's where I'm confused,

Quote:
Originally Posted by Jiaz View Post
Solution also includes Adopt feature
1.) once adopt OR manually set, it will never change by plugin any more
2.) *strongest* hash will be used
So option one I can adopt checksums and use copy and paste and it will stick, correct?

In option two if I adopt a lesser value than the one offered by the host, JD will go by the host?

Listen, you choose for me. I want the most strongest check available, so if that's option two, then option two it is. If not, then option one it is. The reason I'm confused is because, option one has adopt checksum, which adopts the "strongest" hash, so option two sounds redundant to me, but I'm sure you didn't put something redundant, so I'm clearly missing something. HAHAHA
Reply With Quote
  #9  
Old 19.10.2016, 16:04
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

Correct, that's the idea
So which one would you prefer?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #10  
Old 19.10.2016, 16:08
madcowpig
Guest
 
Posts: n/a
Default

This is scary for me. I hate decisions. I think I choose option one, because everyone strives to be number one in life.
Reply With Quote
  #11  
Old 20.10.2016, 14:14
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

Check again with next update. Please note that you only *fresh* adopted or manually set hashes wont be overwritten
__________________
JD-Dev & Server-Admin
Reply With Quote
  #12  
Old 20.10.2016, 16:36
madcowpig
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by Jiaz View Post
Check again with next update. Please note that you only *fresh* adopted or manually set hashes wont be overwritten
Cool, thank you. What do you mean by fresh? What's considered non-"fresh"?
Reply With Quote
  #13  
Old 20.10.2016, 16:38
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

All hashes before the update don't have the *forced* flag and may still be overwritten by plugins
__________________
JD-Dev & Server-Admin
Reply With Quote
  #14  
Old 20.10.2016, 16:40
madcowpig
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by Jiaz View Post
All hashes before the update don't have the *forced* flag and may still be overwritten by plugins
Okay, thank you. I should have known, this is the message you always tell everyone before an update.
Reply With Quote
  #15  
Old 20.10.2016, 16:43
madcowpig
Guest
 
Posts: n/a
Default

Also, does this update apply to all hosters? I ask because this is an "[Wait for JD2 Core Update]" update, not a plugin only update.
Reply With Quote
  #16  
Old 20.10.2016, 17:04
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

It's independant of hoster
__________________
JD-Dev & Server-Admin
Reply With Quote
  #17  
Old 21.10.2016, 11:52
madcowpig
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by Jiaz View Post
It's independant of hoster
Awesome. I'll test it later.
Reply With Quote
  #18  
Old 22.10.2016, 01:14
madcowpig
Guest
 
Posts: n/a
Default

I couldn't test earlier, because I had some DNS issues. After I fixed it, I can confirm this is working now. Thank you, very much.
Reply With Quote
  #19  
Old 24.10.2016, 10:11
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,554
Default

Thanks for the feedback!
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 02:51.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.