JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 29.04.2019, 16:28
ninguno ninguno is offline
Mega Loader
 
Join Date: Oct 2010
Posts: 67
Default Imgspice.com not working

Hello guys

Imgspice links seems to stop working.

Using this test link
**External links are only visible to Support Staff****External links are only visible to Support Staff**

I get this log when checking link
Spoiler:

--ID:14955TS:1556547896722-4/29/19 11:24:56 AM - [jd.plugins.hoster.ImgSpiceCom(requestFileInformation)] -> filename equals null, throwing "plugin defect"
--ID:14955TS:1556547896722-4/29/19 11:24:56 AM - [] -> Exception thrown at jd.controlling.linkchecker.LinkChecker.updateAvailableStatus(LinkChecker.java:564):
jd.plugins.PluginException: ERROR_PLUGIN_DEFECT|Value:-1
at jd.plugins.hoster.ImgSpiceCom.requestFileInformation(ImgSpiceCom.java:160)
at jd.plugins.PluginForHost.checkLink(PluginForHost.java:1879)
at jd.controlling.linkchecker.LinkChecker.updateAvailableStatus(LinkChecker.java:562)
at jd.controlling.linkchecker.LinkChecker.access$200(LinkChecker.java:38)
at jd.controlling.linkchecker.LinkChecker$1.run(LinkChecker.java:423)

--ID:14955TS:1556547896723-4/29/19 11:24:56 AM - [jd.controlling.linkchecker.LinkChecker(updateAvailableStatus)] -> Link **External links are only visible to Support Staff****External links are only visible to Support Staff** is UNCHECKABLE


And this log when trying to bypass checking and download directly
Spoiler:

--ID:15013TS:1556548005217-4/29/19 11:26:45 AM - [jd.plugins.hoster.ImgSpiceCom(requestFileInformation)] -> filename equals null, throwing "plugin defect"
--ID:15013TS:1556548005217-4/29/19 11:26:45 AM - [] -> Exception thrown at jd.controlling.downloadcontroller.SingleDownloadController.download(SingleDownloadController.java:42 4):
jd.plugins.PluginException: ERROR_PLUGIN_DEFECT|Value:-1
at jd.plugins.hoster.ImgSpiceCom.requestFileInformation(ImgSpiceCom.java:160)
at jd.plugins.hoster.ImgSpiceCom.handleFree(ImgSpiceCom.java:216)
at jd.plugins.PluginForHost.handle(PluginForHost.java:1128)
at jd.controlling.downloadcontroller.SingleDownloadController.download(SingleDownloadController.java:41 9)
at jd.controlling.downloadcontroller.SingleDownloadController.run(SingleDownloadController.java:598)

--ID:15013TS:1556548005217-4/29/19 11:26:45 AM - [jd.controlling.downloadcontroller.SingleDownloadController(download)] -> Exception:
--ID:15013TS:1556548005218-4/29/19 11:26:45 AM - [] -> Exception thrown at jd.controlling.downloadcontroller.SingleDownloadController.download(SingleDownloadController.java:48 4):
jd.plugins.PluginException: ERROR_PLUGIN_DEFECT|Value:-1
at jd.plugins.hoster.ImgSpiceCom.requestFileInformation(ImgSpiceCom.java:160)
at jd.plugins.hoster.ImgSpiceCom.handleFree(ImgSpiceCom.java:216)
at jd.plugins.PluginForHost.handle(PluginForHost.java:1128)
at jd.controlling.downloadcontroller.SingleDownloadController.download(SingleDownloadController.java:41 9)
at jd.controlling.downloadcontroller.SingleDownloadController.run(SingleDownloadController.java:598)

--ID:15013TS:1556548005218-4/29/19 11:26:45 AM - [jd.controlling.downloadcontroller.SingleDownloadController(run)] -> StopDownloadMarker:1556548003061
------------------------Thread: 15011:imgspice.com_jd.plugins.hoster.ImgSpiceCom-----------------------
--ID:15011TS:1556548005219-4/29/19 11:26:45 AM - [jd.controlling.downloadcontroller.DownloadWatchDog(handleReturnState)] -> Plugin Defect.1
--ID:15011TS:1556548005220-4/29/19 11:26:45 AM - [jd.controlling.downloadcontroller.DownloadWatchDog$27(execute)] -> Rename after Download?


Tried to check the source code to help but seems harder to understand compare to other hosts.

Hope it can be fixed
Thanks!
Reply With Quote
  #2  
Old 29.04.2019, 16:36
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

those sites imgspice/space....always change javascript/layout to break plugin again..and again..and again
__________________
JD-Dev & Server-Admin
Reply With Quote
  #3  
Old 29.04.2019, 16:38
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

it's not that complex but using a template for xfs which has multiple modes (image, video, download...)
you should first try to rewrite plugin to extend XFileSharingProBasic and implement/override the required methods. but yes, definite more complex for *first time* plugins
__________________
JD-Dev & Server-Admin
Reply With Quote
  #4  
Old 29.04.2019, 20:48
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 48,702
Default

Fixed.

-psp-
__________________

Ad-free installers || Werbefreie Installer
Windows Setup<--JD2 BETA-->Linux Setup x86 || Linux Setup x64 || Mac Setup
-----=>Support Chat<=-----
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #5  
Old 30.04.2019, 02:52
ninguno ninguno is offline
Mega Loader
 
Join Date: Oct 2010
Posts: 67
Default

Thank you so much @Jiaz and @pspzockerscene, that was fast!

I think my problem was checking the source code through and old version (something similar than the one available at github that doesn't extend XFileSharingProBasic)

Just one small thing, I notice from my example link that the picture is saved as "6wfkkzpt0bhx.jpg".
**External links are only visible to Support Staff****External links are only visible to Support Staff**

Do you think the name could be taken from the original url, or from the "alt" attribute that is included in the html within the img tag?

<img id="imgpreview" src="**External links are only visible to Support Staff** style="border: 1px #e4e4e4 solid; max-width: 90%;margin-top: 20px;" class="pic" alt="test.jpg" onclick="ghisthendsx()">
Reply With Quote
  #6  
Old 30.04.2019, 10:01
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

@ninguno: You can find out subversion repositories here, https://svn.jdownloader.org/projects/jd
Did you test if alt provides useful/real names or maybe always test.jpg or is it the upload filename?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 30.04.2019, 16:07
ninguno ninguno is offline
Mega Loader
 
Join Date: Oct 2010
Posts: 67
Default

Yes, i already check several links, and both the "alt" attribute or the url last part has the correct filename.

I tried to check the source code and found some methods for picking the filesize from alt attributes but didn't found something similar for filename.
Reply With Quote
  #8  
Old 30.04.2019, 16:14
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

You could try to add support for it ?
I've also linked your suggestion in ticket
__________________
JD-Dev & Server-Admin
Reply With Quote
  #9  
Old 30.04.2019, 16:59
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 48,702
Default

@ninguno
I know that "alt" tag plus that new plugin is also using more ways to determine the filename.
For me, it already works fine (version using current SVN Code) and it gets displayed- and saved as "test.jpg".

-psp-
__________________

Ad-free installers || Werbefreie Installer
Windows Setup<--JD2 BETA-->Linux Setup x86 || Linux Setup x64 || Mac Setup
-----=>Support Chat<=-----
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #10  
Old 30.04.2019, 17:16
ninguno ninguno is offline
Mega Loader
 
Join Date: Oct 2010
Posts: 67
Default

Thanks @pspzockerscene, maybe is because i'm not using the full svn version then, i just download and compile the new ImgSpiceCom plugin but using the official release.

For reference I temporary resolved this overriding scanInfo on ImgSpiceCom class, but surely is not the right thing.
Spoiler:

@Override
public String[] scanInfo(final String[] fileInfo) {
if (inValidate(fileInfo[0])) {
fileInfo[0] = new Regex(correctedBR, "class="pic" alt="([^<>"]*?)"").getMatch(0);
}
return super.scanInfo(fileInfo);
}
Reply With Quote
  #11  
Old 30.04.2019, 18:19
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

@ninguno: I suggest to setup IDE and just run JDownloader from within IDE. That way you will get changes fastest and can always debug/work on latest version
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 13:07.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.