JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 19.06.2019, 01:09
madmax2 madmax2 is offline
JD VIP
 
Join Date: Sep 2009
Posts: 385
Default disabled clipboard monitor not working properly

I disabled clipboard monitor so that I can copy and paste some links into a document that I didn't want to be loaded into jdownloader

After I enabled clipboard monitor I noticed jdownloader started loading those links that I had copied and paste in my documents..

So how can I prevent this from happening?

Last edited by madmax2; 19.06.2019 at 01:11.
Reply With Quote
  #2  
Old 19.06.2019, 04:50
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 16,200
Default

copy something else into the clipboard, like any text ?
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #3  
Old 19.06.2019, 09:27
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

Quote:
Originally Posted by raztoki View Post
copy something else into the clipboard, like any text ?
either that or Settings-Advanced Settings-GraphicalUserInterfaceSettings.clipboardskipmode to ON_ENABLED
__________________
JD-Dev & Server-Admin
Reply With Quote
  #4  
Old 19.06.2019, 09:56
madmax2 madmax2 is offline
JD VIP
 
Join Date: Sep 2009
Posts: 385
Default

Quote:
Originally Posted by Jiaz View Post
either that or Settings-Advanced Settings-GraphicalUserInterfaceSettings.clipboardskipmode to ON_ENABLED
so this setting will skip what was just copied while clipboard monitoring was disabled
but will now monitor any new links that is copied after we enable the clipboard again?
Reply With Quote
  #5  
Old 19.06.2019, 09:58
madmax2 madmax2 is offline
JD VIP
 
Join Date: Sep 2009
Posts: 385
Default

Quote:
Originally Posted by raztoki View Post
copy something else into the clipboard, like any text ?
yes this is a workaround solution..
though I wonder why jdownloader does this?

since for many who disabled the clipboard temporary
they expected the behavior would be to ignore what was copied while it was disabled.
Not immediately load what was copied, since that would defeat the purpose of why someone would need to temporary disable the clipboard monitor.

Last edited by madmax2; 19.06.2019 at 10:21.
Reply With Quote
  #6  
Old 19.06.2019, 09:59
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

Quote:
Originally Posted by madmax2 View Post
so this setting will skip what was just copied while clipboard was disabled
but will now monitor any new links that is copied after we enable the clipboard again?
When the clipboard monitoring is disabled, it's disabled.
When you enable the monitoring, it will check the clipboard and process it according to
GraphicalUserInterfaceSettings.clipboardskipmode
ON_ENABLED -> skip the first content change
NEVER- > never skip, always process first content change
ON_STARTUP -> only skip first content change on startup
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 19.06.2019, 10:00
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

Quote:
Originally Posted by madmax2 View Post
yes this is a workaround solution..
though I wonder jdownloader just this?

since for many who disabled the clipboard temporary
they expected the behavior would be to ignore what was copied while it was disabled.
That's what it does. But when you enable the monitoring again, your text/content is still in clipboard
__________________
JD-Dev & Server-Admin
Reply With Quote
  #8  
Old 20.06.2019, 05:38
madmax2 madmax2 is offline
JD VIP
 
Join Date: Sep 2009
Posts: 385
Default

Quote:
Originally Posted by Jiaz View Post
When the clipboard monitoring is disabled, it's disabled.
When you enable the monitoring, it will check the clipboard and process it according to
GraphicalUserInterfaceSettings.clipboardskipmode
ON_ENABLED -> skip the first content change
NEVER- > never skip, always process first content change
ON_STARTUP -> only skip first content change on startup
I just tested the advance setting ON_ENABLED
and it doesn't work

it is still importing the link I just copied while the clipboard was disabled
after I re-enable the clipboard monitoring
Reply With Quote
  #9  
Old 20.06.2019, 06:29
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 16,200
Default

Quote:
Originally Posted by madmax2 View Post
yes this is a workaround solution..
though I wonder why jdownloader does this?

since for many who disabled the clipboard temporary
they expected the behavior would be to ignore what was copied while it was disabled.
Not immediately load what was copied, since that would defeat the purpose of why someone would need to temporary disable the clipboard monitor.
why? it has always done this far as I can recall even prior to 0.9.581
I've always just copied some random text (not a link) if you don't want to trigger.

I guess thats why Jiaz or Coalado created the newer clipboard monitoring settings. When developing I know when he changed the default behaviour it was annoying for testing purposes as I would always toggle the clipboard button in order to quickly re-add the link for debugging.

I totally agree, if the user disabled monitoring for a reason, but how do you know exactly that the content that the user didn't want scanned is still on the clipboard and not new content? o_O. I personally some times forget that I disabled it and then goto add newly copied content, and notice clipboard hasn't picked it up. So re-enabled and under your example it would ignore it. So you can see under different circumstances you can't find a perfect default behaviour.

raztoki
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #10  
Old 20.06.2019, 07:02
madmax2 madmax2 is offline
JD VIP
 
Join Date: Sep 2009
Posts: 385
Default

Quote:
Originally Posted by raztoki View Post
why? it has always done this far as I can recall even prior to 0.9.581
I've always just copied some random text (not a link) if you don't want to trigger.

I guess thats why Jiaz or Coalado created the newer clipboard monitoring settings. When developing I know when he changed the default behaviour it was annoying for testing purposes as I would always toggle the clipboard button in order to quickly re-add the link for debugging.

I totally agree, if the user disabled monitoring for a reason, but how do you know exactly that the content that the user didn't want scanned is still on the clipboard and not new content? o_O. I personally some times forget that I disabled it and then goto add newly copied content, and notice clipboard hasn't picked it up. So re-enabled and under your example it would ignore it. So you can see under different circumstances you can't find a perfect default behaviour.

raztoki
I think your example is more of an case of forgetting to renabled the clipboard rather than why someone would typically intentionally disable the clipboard monitor,

Under normal usage, clipboard monitoring is always on
because we like JD to automatically grab links

When someone goes to the effort of intentionally disabling the the clipboard monitoring, it is because they know that they will be copying some data that contains links they don't want JD to grab..that is why they purposely disabled the clipboard.
So they expect that data that was just copied not to be immediately be grabbed after they re enabled the clipboard..

This is an unexpected behavior.
Like if someone steps on the brakes but the car instead accelerates.

Therefore the default behavior should be to ignore what was copied when the clipboard was disabled because it goes back to the intention of the user when they first disabled the clipboard monitor..
and only monitor any new clipboard data after the clipboard monitor is re-enabled.

This all goes back to what was the intention of doing the action in the first place.

This is a typical user behavior with regards to intentionally disabling the clipboard.
1. User disables clipboard monitor (to prevent grabbing of some links)
2. User copies data/links that don't want grabbed
3. User re-enabled clipboard monitor

What happens afterwards like your case is because you simply forgot to re-enable the clipboard, and has nothing to do with what the original intention for disabling the clipboard was..ie to ignore what was just copied.

What is the point of a user intentionally disabling the clipboard monitoring (to stop grabbing links)
if immediately after they re enabled the clipboard, it grabs all the links that was just copied?
It then becomes a pointless action.

=====

Anyways the advance setting is not working
when I enabled it, it is still grab the links that was just copied when the clipboard was disabled.

Last edited by madmax2; 20.06.2019 at 07:35.
Reply With Quote
  #11  
Old 20.06.2019, 07:43
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 16,200
Default

for sure, I was agreeing with you (mostly), just pointing out my experiences. I personally do forget / or purposely not re-enable and then forget, more so than disabling and re-enabling straight then after.

see what jiaz has to say when he gets into work today. Hopefully he can assist you sort out your issue =]

raztoki
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #12  
Old 21.06.2019, 14:24
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

Quote:
Originally Posted by madmax2 View Post
I just tested the advance setting ON_ENABLED
and it doesn't work

it is still importing the link I just copied while the clipboard was disabled
after I re-enable the clipboard monitoring
going to check/fix it
__________________
JD-Dev & Server-Admin
Reply With Quote
  #13  
Old 21.06.2019, 14:26
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

Quote:
Originally Posted by madmax2 View Post
What is the point of a user intentionally disabling the clipboard monitoring (to stop grabbing links)
if immediately after they re enabled the clipboard, it grabs all the links that was just copied?
It then becomes a pointless action.
I will check the ON_ENABLED because it should work like you describe. You don't want the clipboard to be parsed when you enable the monitoring. Others(for example myself) exactly want this feature to work like this. That's why we've added option to change behaviour. I'm looking into why it fails for you
__________________
JD-Dev & Server-Admin
Reply With Quote
  #14  
Old 21.06.2019, 14:55
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

I'm sorry but I can't reproduce the issue. Settings to ON_ENABLED , JDownloader won't parse clipboard on enabling the clipboard monitoring (tested on Linux/Windows). A restart is required. Will update so that no restart is required
__________________
JD-Dev & Server-Admin
Reply With Quote
  #15  
Old 22.06.2019, 00:15
madmax2 madmax2 is offline
JD VIP
 
Join Date: Sep 2009
Posts: 385
Default

Quote:
Originally Posted by Jiaz View Post
I'm sorry but I can't reproduce the issue. Settings to ON_ENABLED , JDownloader won't parse clipboard on enabling the clipboard monitoring (tested on Linux/Windows). A restart is required. Will update so that no restart is required
so with this setting ON_ENABLED
does it means that when re-enabling the clipboard monitoring
it will not parse what was just copied while it was disabled
but it will monitor/parse for any new links/new data change in the clipboard that is copied to the clipboard from this moment on?

Yeah I think the reason it was not working cos I didn't know it required a restart, since changing the setting never prompted to restart.

Last edited by madmax2; 22.06.2019 at 00:32.
Reply With Quote
  #16  
Old 24.06.2019, 09:22
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 65,456
Default

Quote:
Originally Posted by madmax2 View Post
so with this setting ON_ENABLED
does it means that when re-enabling the clipboard monitoring
it will not parse what was just copied while it was disabled
but it will monitor/parse for any new links/new data change in the clipboard that is copied to the clipboard from this moment on?
yes




Quote:
Originally Posted by madmax2 View Post
Yeah I think the reason it was not working cos I didn't know it required a restart, since changing the setting never prompted to restart.
I think so too, that's why I added support to apply these changes without a restart. sorry for missing *restart required* message and the confusion because of that
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 17:52.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.