[Dockel]

@dockel: All 3 new scripts needed to be updated. Please replace your existing scripts with the latest version.

Yes yes, I had done already, many thanks.

You mean if there are multiple variants in the list, select one you want and disable the other variants?

That would be a good alternatvie, I guess. Disable or move / get the other variants to history.txt. I actually meant, I download one variant of a video. When I add that video again to JD I (unwanted) might download it again because I load another variant of the video I have downloaded before. To avoid that, it would be good if all of the variants would be disabled / marked as dups.

[mgpai]

Originally Posted by Dockel

... it would be good if all of the variants would be disabled / marked as dups.

Do you mean, the variant added via add links dialog or clipboard is disabled, but other variants of the same video, when added via context menu are not disabled?

[Dockel]

Sorry, I am not quite sure to understand. I want to avoid to download the same video again, independently of the version. Once I have download one of the offered versions, e.g. 720 p I never again want to download any version of that video, for example I do not want to download the 1080 p version or 480 p version and none of the others, I never want to download that video again. So because of that it would be good if all of those varaints (I chose one from to download) would be disabled / marked as dups because I never again want to download the same video independently of the variant.

[mgpai]

Originally Posted by Dockel

... it would be good if all of those varaints (I chose one from to download) would be disabled / marked as dups because I never again want to download the same video independently of the variant.

For YT links, the script has been modified to match the video url and not the variant url, which means when you add YR links to JD, all variants of that video url, should automatically be disabed Is it not doing that?

[Dockel]

Ay, yes, indeed, it does it, I just tried. Didn't notice that before, sorry. That's extremely useful.

Thank you very much!

[Jiaz]

@mgpai: for YT videos, better process the properties, you can directly fetch the videoID via getProperty("YT_ID")

[Dockel]

Since yesterday there are some links shown to be duplicates which (actually) cannot be duplicates.

Why could this happen? How could one avoid that?

[mgpai]

Originally Posted by Dockel

Since yesterday there are some links shown to be duplicates which (actually) cannot be duplicates.

Why could this happen? How could one avoid that?

Which site?

[Dockel]

Do you mean the hoster (zippy, anonfiles) or the website the links are from?

[mgpai]

Originally Posted by Dockel

Do you mean the hoster (zippy, anonfiles) or the website the links are from?

Hoster url. Does it happen only on particular sites or all sites? Are they direct links or obtained from container like filecrypt?

I think you had requested to run dupe check on download list links. So, check if the url is present there. It obviously is matching some string from the history file or download list . You have to just find out which url is it matching and on which list.

[Dockel]

Hoster url. Does it happen only on particular sites or all sites? Are they direct links or obtained from container like filecrypt?

Until now it's only the mentioned ones. Just transferred by copying the link (to the clipboard and automatically added to JD then).

I think you had requested to run dupe check on download list links.

Sorry, I do not understand what that means. The links are marked (disabled) as dupes in the link grabber window. There is no dupe in the downloadlist then.

You have to just find out which url is it matching and on which list.

I am not quite sure to understand. I would think there is only one option, the history.txt (there is no dupe in the downloadlist). So I thought the same link is already contained there. May be the dupe links are the same but they are leading to other content / another rar / zip file.

[mgpai]

@Dockel: Please contact me in chat when you are free.

[Dockel]

Sorry, I do not know how to ping

[DragoBleaPiece]

Originally Posted by mgpai

Replacement scripts

Script #3

/* 
    Disable duplicate link in Lingrabber list
    Trigger required: A new link has been added
*/

var link = crawledLink;

if (link.availableState == "ONLINE") {
    var file = getPath(JD_HOME + "/cfg/history.txt");

    var lock = getModifyLock(file.name);
    lock.writeLock();

    var urls = getProperty(file.name, true);

    if (urls == null) {
        urls = file.exists() && readFile(file) || "";
        setProperty(file.name, urls, true);
    }

    lock.writeUnlock();

    if (urls) {
        var url = link.contentURL || link.pluginURL;

        if (link.host == "youtube.com") {
            url = link.containerURL;
        }

        if (urls.indexOf(url) > -1) {
            var text = "#duplicatelink";
            var comment = link.comment;

            if (comment) {
                text = text + " " + comment;
            }

            link.comment = text;
            link.enabled = false;
        }
    }
}

the app sorta hang up every time i add link when i enable the script. i can't click any option in the pop-up message, i can't close the app. i even have to force close it via task manager. can u help me pls? thanks

[mgpai]

Originally Posted by DragoBleaPiece

the app sorta hang up every time i add link when i enable the script. i can't click any option in the pop-up message, i can't close the app. i even have to force close it via task manager. can u help me pls? thanks

Caused by a bug. Yet to be fixed by the developers.

Solution: Disable "Synchronous Execution of script" checkbox in the top panel of the script editor.

[Dockel]

Hello mgpai,

the same happens again with the same kind of links: https://board.jdownloader.org/showpo...&postcount=147

The links are not in history.txt.

[mgpai]

Originally Posted by Dockel

... the same happens again with the same kind of links ... The links are not in history.txt.

The 'new link added' script only marks as dupe, if a matching entry is found in the hsitory file. Maybe it is matching a different format, but it is matching something.

For testing purposes, temporarily replace the existing history file with an empty one and see if the link will still be marked as duplicate.

You can also use the following script to find the matching entry (if any) in history file.

/* 
    Find matching entry for the selected link in history file
    Trigger required: Linkgrabber Contextmenu Button Pressed
*/

if (name = "Find in history") {
    var link = lgSelection.contextLink;
    var file = getPath(JD_HOME + "/cfg/history.txt");
    var entries = readFile(file).split("\r\n");
    var line = null;
    var url = link.contentURL || link.pluginURL;

    if (link.host == "youtube.com") {
        url = link.containerURL;
    }

    entries.some(function(entry, index) {
        if (entry == url) {
            line = index + 1;
            return true;
        }
    })
    
    if (line) {
        alert("Found \"" + url + "\" on Line " + line + " in \"" + file + "\"");
    } else {
        alert("No matching entriy found for \"" + url + "\".");
    }
}

To fix the issue, should be able to find the cause and reproduce the same outcome consistently. Contact me in chat after you run the tests.

[Dockel]

Thank you!

I added four links which are marked as dupes. Did not find them in history.txt. Replaced that file, added those links again, they were marked as dupes:



I added the script:


I am in the chat now.

[Amiganer]

Hello.

Thanks for thw ork to the problem.
Can someone please put alle actual Scripts in one post (I'm a littlebit confused, what script is which one). Thank You.

Bye, Christian

[Dockel]

How could I avoid such messages:


They show up when I add a file to the history.