JDownloader Community - Appwork GmbH
 

Closed Thread
 
Thread Tools Display Modes
  #1  
Old 20.02.2019, 23:07
djmakinera djmakinera is offline
JD Legend
 
Join Date: May 2010
Location: Poland
Posts: 7,910
Default LinkGrabber - can not filter *.js

LinkGrabber
It still shows .js links. What is wrong?


Enabled: Regex
Enabled: File Name: contains:

Code:
.*(spacer|favicon|apple|thumb|upic|small|avatar|tmbanner|banner|picclick-logo|picclick|rightnow-en|paypal|jquery-1|jquery|html5|jquery.easing|kindeditor-min|slides.min.jquery|common|soundmanager2-nodebug-jsmin|player|mirror_m|popup_window|register_check|functions|common_n)\\.(ico|png|jpeg|jpg|gif|js)
Deep scan:
**External links are only visible to Support Staff****External links are only visible to Support Staff**
  #2  
Old 21.02.2019, 10:25
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 60,406
Default

works fine with correct pattern

Code:
.*(spacer|favicon|apple|thumb|upic|small|avatar|tmbanner|banner|picclick-logo|picclick|rightnow-en|paypal|jquery-1|jquery|html5|jquery.easing|kindeditor-min|slides.min.jquery|common|soundmanager2-nodebug-jsmin|player|mirror_m|popup_window|register_check|functions|common_n)\.(ico|png|jpeg|jpg|gif|js)
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 22.02.2019 at 10:39.
  #3  
Old 22.02.2019, 08:30
djmakinera djmakinera is offline
JD Legend
 
Join Date: May 2010
Location: Poland
Posts: 7,910
Default

But with me it still shows after deep decryption - unnecessary links. So what's wrong?

Screenshot 1:

**External links are only visible to Support Staff****External links are only visible to Support Staff**


screenshot 2:
**External links are only visible to Support Staff****External links are only visible to Support Staff**
  #4  
Old 22.02.2019, 10:39
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 60,406
Default

You did use the fixed pattern that I gave you, right?
__________________
JD-Dev & Server-Admin
  #5  
Old 22.02.2019, 17:18
djmakinera djmakinera is offline
JD Legend
 
Join Date: May 2010
Location: Poland
Posts: 7,910
Default

Quote:
Originally Posted by Jiaz View Post
You did use the fixed pattern that I gave you, right?
Your pattern was different in that you used one Escape \
But you always said you should use \\

Ok, I changed for one Escape \
and it works fine now, but other unnecessary links still appear. You need to add other names to the exclusion, but what?

Some package names jquery and file names are different.
**External links are only visible to Support Staff****External links are only visible to Support Staff**
  #6  
Old 22.02.2019, 21:33
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 60,406
Default

It depends on syntax and escaping if you can use \ normally or have to escape it
Using \ in JSON -> you have to escape it
Using \ in Java String -> you have to escape it
Using \ in normal text -> you might have to escape it
__________________
JD-Dev & Server-Admin
  #7  
Old 22.02.2019, 21:33
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 60,406
Default

Quote:
Originally Posted by djmakinera View Post
Some package names jquery and file names are different.
**External links are only visible to Support Staff****External links are only visible to Support Staff**
why not simply block all .js files?!
__________________
JD-Dev & Server-Admin
  #8  
Old 23.02.2019, 09:39
djmakinera djmakinera is offline
JD Legend
 
Join Date: May 2010
Location: Poland
Posts: 7,910
Default

Quote:
Originally Posted by Jiaz View Post
why not simply block all .js files?!
Regex is matched, I checked it in EmEditor,

but it does not work correctly in JD2

File Name contains: (.*)\.js

Screen:
**External links are only visible to Support Staff****External links are only visible to Support Staff**
  #9  
Old 24.02.2019, 00:24
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 15,981
Default

The pattern is fine, just you don't need the brackets unless you're going to use it capture or multiple argument (not that it would hurt your findings).
fyi This is JDownloader support, not EmEditor.
test your regex within the package customiser/linkgrabber filter rule tester? I tested .*\.js within linkgrabber filter with the same filename (with a https and domain name so linkgrabber can work), and boom works....

closing thread because there is NO issue within JDownloader, its either your Regex pattern OR user error within GUI
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Closed Thread

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 03:30.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.