JDownloader Community - Appwork GmbH
 

Notices

Reply
 
Thread Tools Display Modes
  #1  
Old 22.02.2020, 23:28
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default Sorting issue

Hi,

It looks like when sorting packages by name, the content of the packages is not sorted properly, it looks like it's ignoring case in file names:

alpha.beta.gamma
Alpha.Beta.Gamma
alpha.beta.gamma
alpha_beta_gamma

but it should be:

Alpha.Beta.Gamma
alpha.beta.gamma
alpha.beta.gamma
alpha_beta_gamma

Can somebody take a look at it, please?

Thanks,
M
Reply With Quote
  #2  
Old 23.02.2020, 02:55
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

Believe its now been changed to that maybe 12 months ago, as a desired outcome.
the first three would be randomly sorted (based on entry) or sorted by secondary criteria.
Think the the change is that way because the download core doesn't match to case either. Mainly due to windows file systems, and you would get dupes if you did match to case on mirror detection. If you did sort it solely based on case, that mirror would always be preferred, as it would always be on the top of the list.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #3  
Old 26.02.2020, 06:00
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,

There are other OSes capable of handling case sensitive file names, so I think there should be an option to control whether we want case sensitive sorting (or ignore case when matching file names) instead of declaring something as the "desired outcome"...

Cheers,
M
Reply With Quote
  #4  
Old 26.02.2020, 12:57
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

far as I'm aware JD has never been alpha sensitive on case. It did in the GUI for sorting and thats all that changed in that ~12months ago guesstimate.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #5  
Old 26.02.2020, 17:49
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,

It makes sense to ignore case for grouping files, but for sorting and displaying in the GUI - it's a disaster, especially for case sensitive file systems.

Can we restore the case sensitive display order, please?

Thanks in advance,
M
Reply With Quote
  #6  
Old 26.02.2020, 17:52
pspzockerscene's Avatar
pspzockerscene pspzockerscene is online now
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,912
Default

Hm interesting this was changed a loong time ago:
https://board.jdownloader.org/showthread.php?t=45494

-psp-
EDIT

No nothing was changed back then.

Raztoki are you able to find a ticket related to your proposed change ~12 months ago?
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #7  
Old 26.02.2020, 18:29
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,

I think we're talking about different things.

In the quoted ticket, the words are completely different (Apple vs airplane) while my example above the phrases using different capitalization but the words are the same (Alpha vs alpha).
And that's how a package should look like by default (grouping together file names matching a certain pattern).

I think the former is better for sorting packages and the latter for sorting package content.

That's why we need configuration options, instead of hard coding arbitrary chosen options, in my opinion.

Thanks in advance,
M

Last edited by Maelcum; 26.02.2020 at 18:35.
Reply With Quote
  #8  
Old 26.02.2020, 18:34
pspzockerscene's Avatar
pspzockerscene pspzockerscene is online now
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,912
Default

Ticket:


-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #9  
Old 27.02.2020, 01:03
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

@psp
check the thread, yes its been that way for a long time. Maybe Im thinking about different sorting change... believe it was todo with numbers. it could been ~2 years ago
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #10  
Old 27.02.2020, 01:37
pspzockerscene's Avatar
pspzockerscene pspzockerscene is online now
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,912
Default

I guess I've never used sorting.
To me it does not matter - an option won't hurt I guess.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #11  
Old 27.02.2020, 01:42
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

Guess not in the scheme of things, but can adverse effects introducing undesirable behaviour at least from the design end.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #12  
Old 27.02.2020, 05:05
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,

Just a note: the ticket says "Package sorting case sensitive" but it's actually two things:
- user selectable option whether the sorting of the package names is case sensitive
- user selectable option whether the sorting of the package content (file names) is case sensitive

Thanks,
M
Reply With Quote
  #13  
Old 27.02.2020, 16:27
pspzockerscene's Avatar
pspzockerscene pspzockerscene is online now
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,912
Default

Sorry I was in a hurry. I've updated the ticjet accordingly.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #14  
Old 28.02.2020, 05:45
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Thanks!

Cheers,
M
Reply With Quote
  #15  
Old 05.04.2020, 22:34
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,

Any update on this one? It's still an issue I keep running into.

Thanks in advance,
M
Reply With Quote
  #16  
Old 06.04.2020, 06:06
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

no updates, please follow the svn issue ticket & progress percentage. When completed usually programmer will comment on the thread and change thread tag to solved.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #17  
Old 25.04.2020, 23:21
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

It's actually getting worse, unfortunately :-(
I noticed a few almost completely unordered file lists in packages...

Cheers,
M
Reply With Quote
  #18  
Old 26.04.2020, 11:32
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

You can try to help and tell us what SortAlgo/Comparator you think would fit best for you.
Currently JDownloader uses NaturalOrderComparator.
Also there won't be different sorter for files and packages as this would require more major changes. At the moment there is only support for 1 sorter and not two/multiple. So I think of advanced setting to change used sorter algo
__________________
JD-Dev & Server-Admin
Reply With Quote
  #19  
Old 30.04.2020, 07:11
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi Jiaz,

As soon as I run into a sorting issue I'll update this thread.

Cheers,
M
Reply With Quote
  #20  
Old 11.05.2020, 03:29
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi Jiaz,

Here's an example of messed up sorting: **External links are only visible to Support Staff****External links are only visible to Support Staff**

I'm not sure where the issue comes from but it's definitely not sorted properly.

Cheers,
M
Reply With Quote
  #21  
Old 11.05.2020, 04:37
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

@Maelcum
Interesting, maybe sorting or maybe deemed as a mirror? Jiaz will have a look no doubt =]
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #22  
Old 11.05.2020, 17:08
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

Please provide example links. Are those the actual file names of the links? I'm asking because auto filename feature might have auto renamed those to match mirrors.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #23  
Old 11.05.2020, 17:13
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

Issue is most likely caused by the internal sort speed up,
Hmm, is this about the DownloadList? because the _2 looks like auto rename feature and in DownloadList, the items are NOT auto sorted on rename
__________________
JD-Dev & Server-Admin
Reply With Quote
  #24  
Old 15.05.2020, 01:26
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi Jiaz,

I have more, I'll compile them into a single image and send it.

Cheers,
M
Reply With Quote
  #25  
Old 15.05.2020, 04:55
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

as the original image was just the filenames, a bit hard to determine if download has been started and rename took place.

do you use rename if file exists at all? if so its most likely the cause like Jiaz indicated.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #26  
Old 23.05.2020, 06:55
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,

It was in the Lingrabber tab, download not started yet.

M
Reply With Quote
  #27  
Old 25.05.2020, 16:59
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

The Linkgrabber doesn't have any auto-rename feature at all. So this must be caused by original filenames or any eventscripter script in place.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #28  
Old 26.05.2020, 05:14
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,
Here's another one with file sizes and other stuff, still in link grabber.
**External links are only visible to Support Staff****External links are only visible to Support Staff**

Cheers,
M

Last edited by raztoki; 26.05.2020 at 11:54.
Reply With Quote
  #29  
Old 26.05.2020, 05:36
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

screen shot of what you mean?
also please provide complete sample of example links so that we can reproduce reported issue.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #30  
Old 26.05.2020, 11:32
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

I'm sorry but your post doesn't contain any information?!
__________________
JD-Dev & Server-Admin
Reply With Quote
  #31  
Old 26.05.2020, 12:03
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

screen shot was there, just not shown at least in my browser (hence my previous post).. just double checked and image was provided though was in img bbtag, i removed via edit.

I believe the renaming issue is caused by mirror hosting services / multiupload (would have easily been determined if url was given to us originally) or the given hoster. Some providers change filenames on uploads, we need to identify these to treat said chars as wildcards or just remove them in comparison matching. We already have handling for this within our backend (I requested feature like ~7 years ago). Note: If the issue is caused by the multiupload/mirroring party we probably can't fix. As for the _2 I do not know why that would happen even with files that are of the same name on service doesn't cause an issue.. but Id still say a platform issue by either multiuploader/mirror or host itself, this is very hard to fix or identify.

you can easily test if the hoster is at fault, by uploading test files to the service with probable illegal characters and see if they get auto renamed.

Please give us working examples, and we can try and 'fix' this accordingly within hoster plugins. Thread is multiple is over 30posts now and no example urls.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]

Last edited by raztoki; 26.05.2020 at 12:06.
Reply With Quote
  #32  
Old 27.05.2020, 00:26
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,

I don't think any of those links coming from multiupload hosts, but I'll check next time.

To be honest, I don't understand why do you need URLs to sort a bunch of strings :-)
I probably miss something here, but if you can crawl/parse file names and package them, what's so challenging about sorting them properly?

Cheers,
M
Reply With Quote
  #33  
Old 27.05.2020, 03:27
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

We need links to test what is the actual cause, a screen shot does not do this. Trying to guess where the fault lies from screen shot is next to impossible when it comes to plugins. Example links is a must, logs can also help (say geolocation issue).

Sorting issue isn't a problem if my hunch is correct, its just the side effect of a 3rd party bug. But links will confirm this.

With multimirror/upload sites the respective decrypters plugins only return links and does not set filenames/filesize/online status. The hoster plugin is called and the task is primarily done within checklinks[many] or requestfileinfomation(single) methods due to sourceurl not having an accurate online status.

Anyway next time you reproduce this issue, please provide example links, else issue is really dead in the water.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #34  
Old 27.05.2020, 15:27
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

The issue is not caused by sorting but by the auto filename correction routine that tries to find mirror candidates and tries to rename them to have matching file names. That happens AFTER sorting.
We need the URLs to be able to reproduce the issue and properly work on it/fix it.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #35  
Old 27.05.2020, 15:29
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

Quote:
Originally Posted by raztoki View Post
As for the _2 I do not know why that would happen even with files that are of the same name on service doesn't cause an issue.. but Id still say a platform issue by either multiuploader/mirror or host itself, this is very hard to fix or identify.
I agree and that's why we are asking for example links
__________________
JD-Dev & Server-Admin
Reply With Quote
  #36  
Old 27.05.2020, 15:32
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

You can disable that *auto filename correction* via Settings->Advanced Settings->LinkgrabberSettings.autofilenamecorrectionenabled
__________________
JD-Dev & Server-Admin
Reply With Quote
  #37  
Old 31.05.2020, 02:54
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,

Here are a bunch of links to reproduce the sorting issue using the latest jDownloader:

Spoiler:
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**




**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**


Cheers,
M
Reply With Quote
  #38  
Old 31.05.2020, 02:55
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Quote:
Originally Posted by Jiaz View Post
You can disable that *auto filename correction* via Settings->Advanced Settings->LinkgrabberSettings.autofilenamecorrectionenabled
Tried it, didn't help.

Cheers,
M
Reply With Quote
  #39  
Old 05.06.2020, 19:01
Maelcum Maelcum is offline
JD VIP
 
Join Date: Nov 2014
Posts: 337
Default

Hi,

Any update on this one?
Thanks in advance,
M
Reply With Quote
  #40  
Old 05.06.2020, 20:47
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

@Maelcum: Didn't find time yet but at least I can see some issue with sorting! Thanks for the links.
The used comparator doesn't care about Case sensitivity and that's the reason for the strange sorting.
I will try to work on to provide advanced settings to change sort method
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 05.06.2020 at 20:54.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 16:00.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.