JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 22.02.2020, 22:28
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default Sorting issue

Hi,

It looks like when sorting packages by name, the content of the packages is not sorted properly, it looks like it's ignoring case in file names:

alpha.beta.gamma
Alpha.Beta.Gamma
alpha.beta.gamma
alpha_beta_gamma

but it should be:

Alpha.Beta.Gamma
alpha.beta.gamma
alpha.beta.gamma
alpha_beta_gamma

Can somebody take a look at it, please?

Thanks,
M
Reply With Quote
  #2  
Old 23.02.2020, 01:55
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,196
Default

Believe its now been changed to that maybe 12 months ago, as a desired outcome.
the first three would be randomly sorted (based on entry) or sorted by secondary criteria.
Think the the change is that way because the download core doesn't match to case either. Mainly due to windows file systems, and you would get dupes if you did match to case on mirror detection. If you did sort it solely based on case, that mirror would always be preferred, as it would always be on the top of the list.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #3  
Old 26.02.2020, 05:00
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default

Hi,

There are other OSes capable of handling case sensitive file names, so I think there should be an option to control whether we want case sensitive sorting (or ignore case when matching file names) instead of declaring something as the "desired outcome"...

Cheers,
M
Reply With Quote
  #4  
Old 26.02.2020, 11:57
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,196
Default

far as I'm aware JD has never been alpha sensitive on case. It did in the GUI for sorting and thats all that changed in that ~12months ago guesstimate.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #5  
Old 26.02.2020, 16:49
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default

Hi,

It makes sense to ignore case for grouping files, but for sorting and displaying in the GUI - it's a disaster, especially for case sensitive file systems.

Can we restore the case sensitive display order, please?

Thanks in advance,
M
Reply With Quote
  #6  
Old 26.02.2020, 16:52
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 54,549
Default

Hm interesting this was changed a loong time ago:
https://board.jdownloader.org/showthread.php?t=45494

-psp-
EDIT

No nothing was changed back then.

Raztoki are you able to find a ticket related to your proposed change ~12 months ago?
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #7  
Old 26.02.2020, 17:29
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default

Hi,

I think we're talking about different things.

In the quoted ticket, the words are completely different (Apple vs airplane) while my example above the phrases using different capitalization but the words are the same (Alpha vs alpha).
And that's how a package should look like by default (grouping together file names matching a certain pattern).

I think the former is better for sorting packages and the latter for sorting package content.

That's why we need configuration options, instead of hard coding arbitrary chosen options, in my opinion.

Thanks in advance,
M

Last edited by Maelcum; 26.02.2020 at 17:35.
Reply With Quote
  #8  
Old 26.02.2020, 17:34
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 54,549
Default

Ticket:


-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #9  
Old 27.02.2020, 00:03
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,196
Default

@psp
check the thread, yes its been that way for a long time. Maybe Im thinking about different sorting change... believe it was todo with numbers. it could been ~2 years ago
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #10  
Old 27.02.2020, 00:37
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 54,549
Default

I guess I've never used sorting.
To me it does not matter - an option won't hurt I guess.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #11  
Old 27.02.2020, 00:42
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,196
Default

Guess not in the scheme of things, but can adverse effects introducing undesirable behaviour at least from the design end.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #12  
Old 27.02.2020, 04:05
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default

Hi,

Just a note: the ticket says "Package sorting case sensitive" but it's actually two things:
- user selectable option whether the sorting of the package names is case sensitive
- user selectable option whether the sorting of the package content (file names) is case sensitive

Thanks,
M
Reply With Quote
  #13  
Old 27.02.2020, 15:27
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 54,549
Default

Sorry I was in a hurry. I've updated the ticjet accordingly.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #14  
Old 28.02.2020, 04:45
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default

Thanks!

Cheers,
M
Reply With Quote
  #15  
Old 05.04.2020, 21:34
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default

Hi,

Any update on this one? It's still an issue I keep running into.

Thanks in advance,
M
Reply With Quote
  #16  
Old 06.04.2020, 05:06
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,196
Default

no updates, please follow the svn issue ticket & progress percentage. When completed usually programmer will comment on the thread and change thread tag to solved.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #17  
Old 25.04.2020, 22:21
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default

It's actually getting worse, unfortunately :-(
I noticed a few almost completely unordered file lists in packages...

Cheers,
M
Reply With Quote
  #18  
Old 26.04.2020, 10:32
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 67,320
Default

You can try to help and tell us what SortAlgo/Comparator you think would fit best for you.
Currently JDownloader uses NaturalOrderComparator.
Also there won't be different sorter for files and packages as this would require more major changes. At the moment there is only support for 1 sorter and not two/multiple. So I think of advanced setting to change used sorter algo
__________________
JD-Dev & Server-Admin
Reply With Quote
  #19  
Old 30.04.2020, 06:11
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default

Hi Jiaz,

As soon as I run into a sorting issue I'll update this thread.

Cheers,
M
Reply With Quote
  #20  
Old 11.05.2020, 02:29
Maelcum Maelcum is offline
Black Hole
 
Join Date: Nov 2014
Posts: 254
Default

Hi Jiaz,

Here's an example of messed up sorting: **External links are only visible to Support Staff****External links are only visible to Support Staff**

I'm not sure where the issue comes from but it's definitely not sorted properly.

Cheers,
M
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 22:26.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.