[mgpai]

Originally Posted by Jiaz

containerURL might be undefined/null, you should add some checks for it

Of course. The example was just to demonstrate how to extract the hostname from url.

Originally Posted by Jiaz

@mgpai: I think your duplicate scripts would be great template for this, don't you think?

Guess so.

@BJN01: Related thread

[BJN01]

thank you guys !!! I found some interesting things that I will try to adapt to my approach / starting idea.

[BJN01]

I tried to follow the scripts of the discussion linked above, but I do something wrong:

1)

--- Trigger required: A new link has been added -------------
test purpose = find the name of the site / host (x use it + forward).

wrong code

var link = crawledLink;
if (link.availableState == "ONLINE") {
var url = link.contentURL || link.pluginURL;
 var StartLink = link.getContainerURL();
 var Hostname = StartLink.match(/:\/\/([^/]+)/)[1];   // for Host name
     alert (Hostname);
}

error : <Cannot cal method "match" of null>

2) --- Trigger required: Linkgrabber Contextmenu button pressed ------------
test purpose = find the name of the site / host of the link Selected in LinkGRabber windows (x use it + forward).

wrong code

if (name == "Aggiungi Host Monitoring") {    
    
    getAllCrawledLinks().forEach(function(fileNameHost) {
        var links = lgSelection.getLinks()//getDownloadLinks();
    var urls = [];

    for (i = 0; i < links.length; i++) {
        var link = links[i];
                var downloadURL = link.getContentURL();
               var HostName = downloadURL.match(/:\/\/([^/]+)/)[1];
                alert(HostName);
       }}  )}

error = I selec 1 (one) link for test the script , and i get a "thousand" windows alerts...


what did I do wrong?
[I guess that I was wrong in indicating how to locate the links, but after many attempts I could not figure it out ]



3) with the command like :

<< writeFile(SaveLinkFile, daaata.join("\r\n") + "\r\n", true); >>

you add a "date" to the txt, but is there a way to delete that "date" (if it exists) from the txt?

ex :
txt -->

A00
A01
A02
A03
...
AXX

var date0 = "A02"

read txt
If date0 find --> delete it from txt
else date0 notfind --> Do nothing.

opening the txt manually and editing it is + easy but I was wondering if there is a scripted way?

[Jiaz]

@BJN01:

Originally Posted by BJN01

var StartLink = link.getContainerURL();
var Hostname = StartLink.match(/:\/\/([^/]+)/)[1]; // for Host name
error : <Cannot cal method "match" of null>

link.getContainerURL may return null, you have to check for it



You can use existing methods for this
link.getHost(), returns host name of the plugin
link.getDownloadHost(), returns actual host name of the internal download url

[mgpai]

Originally Posted by BJN01

error : <Cannot cal method "match" of null>

Add error handling for links which do not have container url.

var link = crawledLink;

if (link.availableState == "ONLINE") {
    var StartLink = link.getContainerURL();
    
    try {
        var Hostname = StartLink.match(/:\/\/([^/]+)/)[1]; // for Host name
        alert(Hostname);
    } catch (e) {};
}

Originally Posted by BJN01

error = I selec 1 (one) link for test the script , and i get a "thousand" windows alerts...

Use only lgSelection links. Also, the alert should be placed outside the loop. Store/append the hostnames in a variable and use alert at the end to display them.

if (name == "Aggiungi Host Monitoring") {
    var HostNames = [];

    lgSelection.getLinks().forEach(function(link) {
        try {
            var HostName = link.contentURL.match(/:\/\/([^/]+)/)[1];
            HostNames.push(HostName);
        } catch (e) {};
    })

    alert(HostNames.join("\n"));
}

Originally Posted by BJN01

.. opening the txt manually and editing it is + easy but I was wondering if there is a scripted way?

var file = getPath("path/to/file");
var text = readFile(file, true);
var update = false;
var str = "A02";

if (text.indexOf(str + "\r\n") > -1) {
    text.replace(str + "\r\n", "");
    update = true;
}

if (update) {
    file.delete();
    writeFile(file, text, true);
}

Originally Posted by Jiaz

@BJN01:
You can use existing methods for this
link.getHost(), returns host name of the plugin
link.getDownloadHost(), returns actual host name of the internal download url

Example in post #1777 was to get host name from container url.

[BJN01]

on some sites I find files with names like this:

13-ba2646388a7dd350a8f252f79664f87f979bbe8182cc1576742f68af3cf307be.png

2-3578f8d84a541f5e536f56fefa2b6a0b4cd67d5ffe1e3322301e2f4c128a0aef.png

302-f8fc9e3f3fd7828767e87c55b0453e31d1780203e4d61041671acd00a6066144.jpg

I would like to make them things like:

13.png
02.png
302.jpg

but to use the < ..... replace ("old", "new") ..... >
I can't find a valid regex to use [ especially to eliminate the part between "-" and the file extension ] ,
how should the regex be?

[mgpai]

Originally Posted by BJN01

I can't find a valid regex to use [ especially to eliminate the part between "-" and the file extension ] , how should the regex be?

^(\d+)(-[a-z0-9]{64})(\.(?:jpg|png))$

[radix]

Originally Posted by Taobaibai

To extract archives only after all downloads have finished, use this new script:

github.com/mgpai/resources/blob/master/jdownloader/eventscripter/scripts/Taobaibai_2.js

Thank you, that was what I was looking for!!!!

bei mir tut es nichts.
ich habe beim "archiventpacker" plugin den haken bei "Archive nach dem Download entpacken" entfernt. Und Trigger ist "Pakt fertiggestellt"

muss ich noch etwas ein- und/oder ausschalten?

[mgpai]

Originally Posted by radix

bei mir tut es nichts.
ich habe beim "archiventpacker" plugin den haken bei "Archive nach dem Download entpacken" entfernt. Und Trigger ist "Pakt fertiggestellt"

muss ich noch etwas ein- und/oder ausschalten?

It seems to be working fine. Please note, completed archives will be extracted only if all packages in the download list are finished.

[BJN01]

Originally Posted by mgpai

^(\d+)(-[a-z0-9]{64})(\.(?:jpg|png))$

sorry, but it doesn't work.
(I also checked through F2 on various files and inserting the string, but it does nothing [in the preview the name remains the same] )

[mgpai]

Originally Posted by BJN01

sorry, but it doesn't work.
(I also checked through F2 on various files and inserting the string, but it does nothing [in the preview the name remains the same] )

Works fine. Please post your script OR screenshot of your rename dialog.

[BJN01]

Originally Posted by mgpai

Works fine. Please post your script OR screenshot of your rename dialog.

screenshot of rename dialog here --> ht#ps://i.postimg.cc/D0sBCVxW/F2-And-Preview.jpg
[ maybe I was wrong to copy the string between one first and another, this time it does something (but does everything change?) ]


x the script
I did a test, and if I write the piece I want to remove in the script it works, that is:

ex file :
2-3578f8d84a541f5e536f56fefa2b6a0b4cd67d5ffe1e3322301e2f4c128a0aef.png

+ script with:

blabla ... replace ("-3578f8d84a541f5e536f56fefa2b6a0b4cd67d5ffe1e3322301e2f4c128a0aef",""); .....


the file it becomes ---> 2.png [ok]

[mgpai]

Originally Posted by BJN01

("-3578f8d84a541f5e536f56fefa2b6a0b4cd67d5ffe1e3322301e2f4c128a0aef",""); .....
the file it becomes ---> 2.png [ok]

OK. But, how are you using the regex pattern? You need to use the correct capture groups to replace.

regex101.com/r/qbj3rm/1

[BJN01]

ok , with the F2 I did not put "$1$3" ... so , i'm an idi#t ...

but , the script doesn't want to do its job ... am I doing something wrong then?

//trigger = a new link has been added  

var link = crawledLink;
if (link.availableState == "ONLINE") {
    var StartLink = link.getContainerURL();
    
    try {
        var Hostname = StartLink.match(/:\/\/([^/]+)/)[1]; // for Host name
        //alert(Hostname);
    } catch (e) {};
    
     if (Hostname == "#Site#" ) {            
          getAllCrawledLinks().forEach(function(i) {
        var replace = function(a, b) {
            i.name = i.name.split(a).join(b);
        }
   
 replace("^(\d+)(-[a-z0-9]{64})(\.(?:jpg|png))$" , "$1$3"); // not work , do nothing , the file name dont change
 replace("-07145d3f75219e8fa82c4d2335addb98f2ec54d1de7478a3edea333ce5a22ac8",""); // ok , do is job 
    })
    }
}

[mgpai]

Originally Posted by BJN01

but , the script doesn't want to do its job ... am I doing something wrong then?

Split/join can be used when find/replace parameters are both strings. Since you are using regex here, you will need to use it as find parameter and, str (static) or capture groups as replace parameter.

var replace = function(a, b) {
    i.name = i.name.replace(a, b);
}

replace(/(\d+)(-[a-z0-9]{64})(\.(?:jpg|png))$/, "$1$3");

[BJN01]

replace(/(\d+)(-[a-z0-9]{64})(\.(?:jpg|png))$/, "$1$3");

now the files become something like this:

$1$32$1$3-31171572ee3982a2fb88bafee6bea0df33a55af07f6b95d442752a3dbb22147e$1$3.png$1$3

??? why ??

[mgpai]

Originally Posted by BJN01

now the files become something like this: ...
??? why ??

Should be working fine:

var i = {
    name: "3-31171572ee3982a2fb88bafee6bea0df33a55af07f6b95d442752a3dbb22147e.png"
}

var replace = function(a, b) {
    i.name = i.name.replace(a, b);
}

replace(/(\d+)(-[a-z0-9]{64})(\.(?:jpg|png))$/, "$1$3");

alert(i.name);

Find me in JD chat if you want me to take a look at your script.

kiwiirc.com/nextclient/irc.libera.chat/#jdownloader

[BJN01]

hello ,

starting from the script I use to rename files and packages, I am creating one in which I change the name of the package and / or files only if they come from a given host / starting link.

that is, if the initial link is:
-from : vvvvv.siteAAA.A ---> change package name
-from : vvvvv.siteAAB.A ---> DO NOT change package name, leave it like this.

.... the problem is that I don't get any results.

trigger : hook packager
simplified version but not working

if (name = CuoPHv2 = "Cleanup packagenamesfromHost") {
    getAllCrawledPackages().forEach(function(i) {
        var replace = function(a, b) {
              link.name = link.name.replace(a, b);
             }
if (link.downloadHost == "SiteA.AAA"){// 
  replace ("[English]","[Eng]");// for test 
  replace (/(\[English])/,"[Eng]");// for test
  //... list of replace for that host.
}          

if (link.downloadHost == "SiteB.BBB"){// 
  replace ("ONE","[1]");// for test 
    //... list of replace for that host.
}          
// etc.


            }
//.....
 )
}

where am i wrong? what - how should I correct?

[mgpai]

Originally Posted by BJN01

where am i wrong? what - how should I correct?

Change:

function(i)

to:

function(link)

[Jiaz]

@BJN01: Just in case you are familiar with java coding language, you could also directly write extensions/code in java.