JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 24.11.2017, 19:12
Derp Derp is offline
JD VIP
 
Join Date: Oct 2011
Posts: 336
Default Were there changes to duplicate-detection recently?

When I add videos which I've already added more than two or three days ago, they aren't picked up as duplicates in the LinkGrabber anymore.

E.g. comparing the entries in downloadList.zip of **External links are only visible to Support Staff****External links are only visible to Support Staff**, the HD-entry has
Code:
    "LINKDUPEID" : "130716015_HD_1920x800_DOWNLOAD_ORIGINAL",
instead of
Code:
    "LINKDUPEID" : "130716015_HD_1920x800_DOWNLOAD",
in the new entry,
and it has an additional entry called
Code:
    "ORG_LINKID" : "130716015_HD_1920x800_DOWNLOAD"
which the new entry lacks.

But only video-files seem to be affected, any other filetype still gets picked up as a duplicate when linkgrabbed again.

EDIT:
Imgur-URLs of GIF and MP4-files are nor handled as being mirrors of each other or being the same file, too.

For Example:
- In the Imgur-options, check "download .mp4 instead of gif"
- Copy the URL: https://i.imgur.com/EeoDa9O.mp4
- In the Imgur-options, uncheck "download .mp4 instead of gif"
- Copy the URL: https://i.imgur.com/EeoDa9O.gif

Before, you'd have two entries in LinkGrabber, the MP4 and the GIF, and you could download both.
Now you only have the MP4.

I assume the changes were made for https://svn.jdownloader.org/issues/84724

Last edited by Derp; 24.11.2017 at 22:39.
Reply With Quote
  #2  
Old 27.11.2017, 18:28
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,532
Default

Yes, there have been changes about this. I'm sorry for the inconvenience this causes but the changes were required because the internal unintended ID change has caused many side effects.

I've updated imgur plugin to handle different formats again.
I will also add workaround to handle old links in list. Please wait for next core update
__________________
JD-Dev & Server-Admin
Reply With Quote
  #3  
Old 04.12.2017, 18:45
Derp Derp is offline
JD VIP
 
Join Date: Oct 2011
Posts: 336
Default

Working again, thanks!
Reply With Quote
  #4  
Old 05.12.2017, 12:05
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,532
Default

Thanks for the feedback!
__________________
JD-Dev & Server-Admin
Reply With Quote
  #5  
Old 24.12.2017, 08:23
Derp Derp is offline
JD VIP
 
Join Date: Oct 2011
Posts: 336
Default

The two Imgur-URLs are working now to not be picked up as duplicates, but when an URL of an album is processed, GIF and MP4 are still considered duplicates regardless of the ""Download .mp4 files instead of .gif?"-setting with "Use API" enabled.
https://imgur.com/a/j9ZMB

Last edited by Derp; 24.12.2017 at 08:29.
Reply With Quote
  #6  
Old 16.01.2018, 09:37
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,532
Default

Not that easy to fix because the album decrypter has no information about final file type.
May require larger changes to plugin
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 28.04.2020, 12:26
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 71,103
Default

Hi,

I've now changed it back to the initial behavior which means every ID = unique which means you cannot add a .gif and a .mp4 version of one fileID.

This should be the best default behavior for most of all users because:
- Ultimately both will lead to different files but the same content
- You can set your preferred filetype via imgur.com plugin setting

If you want this to work differently, please let me know so I might add a plugin setting to add a "extension" modifier to the internal unique ID so that you can addthe same items multiple times with different extensions.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 02:25.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.