JDownloader Community - Appwork GmbH
 

Closed Thread
 
Thread Tools Display Modes
  #1  
Old 09.03.2016, 17:23
bugnotme bugnotme is offline
BugMeNot Account
 
Join Date: Apr 2013
Posts: 332
Default Linkfilter - possibly changed behaviour?!

hey guys,
i just (like 15min ago) updated jd
and now the behaviour of the linkfilter seems to be changed...

i'm using a filter to automatically remove dead links
(just a very simple filter: [x]file [is] [offline])

now, after the update, the state [offline] seems to include [can't tell state atm]
(sry, don't know the actual description, since i'm using a different language)
basically, if jd can't tell if a file is offline or not it's being filtered!

so atm it's filtering most of what i've been trying to add...
...mainly uploaded- and depositfiles-links, dunno why jd cant tell the state.
when i open the links in firefox they are clearly online!

is anyone having similar problems??
  #2  
Old 09.03.2016, 20:29
greenshoes
Guest
 
Posts: n/a
Default

Wednesday, March 9, 2016


My problem was that after the update, JD2 Linkgrabber could no longer find any files.

The pop-up box in Linkgrabber kept showing zero files online for every host that I tried.

Under "Advanced Settings", I unchecked Link Filter.




.

Last edited by greenshoes; 09.03.2016 at 22:12.
  #3  
Old 09.03.2016, 22:46
hannebembel hannebembel is offline
Baby Loader
 
Join Date: Feb 2014
Posts: 6
Default

i can confirm this behavior also. For example every MEGA-link is being filtered even if its online. If i uncheck the option for dead files, it shows up and i can add it to the download list. The other option would be to restore the links that have been filtered by JD.
  #4  
Old 10.03.2016, 16:45
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 48,652
Default

Please post your filters here and some example urls.

GreeZ psp
EDIT

Because multiple users reported issues I opened a ticket:
__________________

Ad-free installers || Werbefreie Installer
Windows Setup<--JD2 BETA-->Linux Setup x86 || Linux Setup x64 || Mac Setup
-----=>Support Chat<=-----
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist

Last edited by pspzockerscene; 10.03.2016 at 16:54.
  #5  
Old 10.03.2016, 16:58
Winnie613 Winnie613 is offline
Junior Loader
 
Join Date: Aug 2009
Posts: 13
Default Problems with linkgraber

Hi,
I have a similar problem: the only active filter is "file is offline!", but every link I used is filtered.
If I uncheck this filter - there's no problem whatsoever.
Any comment?
  #6  
Old 10.03.2016, 17:04
humma
Guest
 
Posts: n/a
Default

maybe, it had forgotten to correct with other modification.
Spoiler:

org.jdownloader.controlling.filter.LinkFilterController 33182
Code:
201                 if (lgr.isAccept()) {
202-                    if (compiled.getConditionFilter() == null) {
202+                    if (compiled.getConditionFilter() != null) {
203                         newacceptUrlFilter.add(compiled);
204                     } else {
205                         newacceptFileFilter.add(compiled);
206                     }
207                 } else {
208-                    if (compiled.getConditionFilter() == null) {
208+                    if (compiled.getConditionFilter() != null) {
209                         newdenyUrlFilter.add(compiled);
210                     } else {
211                         newdenyFileFilter.add(compiled);
212                     }
213                 }
  #7  
Old 10.03.2016, 17:33
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 64,732
Default

will be working correct again with next core update
__________________
JD-Dev & Server-Admin
  #8  
Old 10.03.2016, 18:03
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 64,732
Default

please report back after update
__________________
JD-Dev & Server-Admin
  #9  
Old 10.03.2016, 18:32
Winnie613 Winnie613 is offline
Junior Loader
 
Join Date: Aug 2009
Posts: 13
Default

Hi, Jiaz (JDiaz? ),
Back to business!
Updated JD and now linkgraber + filters works fine.
Many thanks.
  #10  
Old 10.03.2016, 18:33
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 64,732
Default

thanks for the feedback. please report any non working filters
__________________
JD-Dev & Server-Admin
  #11  
Old 10.03.2016, 19:03
humma
Guest
 
Posts: n/a
Default

I tried the Updates(#33254) with example filter "URL includes jdownloader.org" and put "https://board.jdownloader.org/index.php" to crawl, there is no crawl action.
Is this matched your intention?

I think there is missing throws clause at LinkFilterController#matches.
Uncaught Exception(WTFException) will arise and terminates the thread when all links are filtered.
#dropByUrl needs to handle checked exception to continue loop if someone wants same behavior as old one.
  #12  
Old 10.03.2016, 19:21
hannebembel hannebembel is offline
Baby Loader
 
Join Date: Feb 2014
Posts: 6
Default

After the last update it doesn't work at all anymore. NO links are in the collector anymore, the only workaround is to uncheck the complete option for the linkfilter, not only single options inside the linkfilter.
  #13  
Old 10.03.2016, 19:23
maddy1111sk maddy1111sk is offline
Junior Loader
 
Join Date: May 2014
Posts: 13
Default

it is not solved, I have a same problem as hannebembel
  #14  
Old 10.03.2016, 19:35
hoobanger
Guest
 
Posts: n/a
Default

The problem still exist..
  #15  
Old 10.03.2016, 19:39
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 64,732
Default

Can you please export your rules and send with some example links to support@jdownloader.org
__________________
JD-Dev & Server-Admin
  #16  
Old 10.03.2016, 19:47
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 64,732
Default

Please update and test again, should work okay again then. Please give feedback
__________________
JD-Dev & Server-Admin
  #17  
Old 10.03.2016, 19:48
maddy1111sk maddy1111sk is offline
Junior Loader
 
Join Date: May 2014
Posts: 13
Default

Still not working, even after this update.
  #18  
Old 10.03.2016, 19:53
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 64,732
Default

Quote:
Originally Posted by Jiaz View Post
Can you please export your rules and send with some example links to support@jdownloader.org
please do this. I need to reproduce this.
__________________
JD-Dev & Server-Admin
  #19  
Old 10.03.2016, 20:00
maddy1111sk maddy1111sk is offline
Junior Loader
 
Join Date: May 2014
Posts: 13
Default

Okay, but you need to help me here, captain
How do I export my rules?
  #20  
Old 10.03.2016, 20:01
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 64,732
Default

bottom right corner, the export button
or
select -> rightclick export

and please also include example links!
__________________
JD-Dev & Server-Admin
Closed Thread

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 00:39.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.