JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 13.06.2022, 14:48
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 349
Default Bug: '?' in search field no longer working as expected

Please have a look at the screenshot:



P? should only return packages that start with P followed by one single character.

But it also returns 2022-03-28 TP-GR

If I remember correctly, I tested this before after your changes and it did work correctly.

*P?, however, returns only P followed by one single character.
Attached Thumbnails
2022-06-13_144059.jpg  
Reply With Quote
  #2  
Old 13.06.2022, 14:50
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

It's not a bug. I've implemented it this mode, see en.wikipedia.org/wiki/Wildcard_character
Quote:
? matches exactly one character. In DOS, if the question mark is placed at the end of the word, it will also match missing (zero) trailing characters; for example, the pattern 123? will match 123 and 1234, but not 12345.
If necessary I can add advanced setting to change the ? mode
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 13.06.2022 at 14:53.
Reply With Quote
  #3  
Old 13.06.2022, 15:26
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 349
Default

Quote:
Originally Posted by Jiaz View Post
It's not a bug. I've implemented it this mode, see en.wikipedia.org/wiki/Wildcard_character


If necessary I can add advanced setting to change the ? mode
Yes, I would appreciate "Windows" mode functionality.
As far as I know, it's the same in Linux, right?

BTW:
In my first tests after your changes (your implementation of '?')
file1.?? returned file1.rm but not file1.ram
Now, this has changed. :(
It also returns file1.ram

Not as wanted/expected
Reply With Quote
  #4  
Old 13.06.2022, 15:34
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

Quote:
Originally Posted by StefanM View Post
Yes, I would appreciate "Windows" mode functionality.
As far as I know, it's the same in Linux, right?
That's fine for me. Easier to implement Will change it to this mode then.

Quote:
Originally Posted by StefanM View Post
BTW:
In my first tests after your changes (your implementation of '?')
file1.?? returned file1.rm but not file1.ram
Now, this has changed. :(
It also returns file1.ram
Yes, you are right, I've *fuxxxx* up the logic and broke it. But as I will remove the trailing special handling, no longer will be problem with next core update.

check again with next core update
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 13.06.2022 at 15:40.
Reply With Quote
  #5  
Old 13.06.2022, 16:10
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 349
Default

Quote:
Originally Posted by Jiaz View Post
That's fine for me. Easier to implement Will change it to this mode then.


Yes, you are right, I've *fuxxxx* up the logic and broke it. But as I will remove the trailing special handling, no longer will be problem with next core update.

check again with next core update
Not working correctly!!!

p? now returns everything, where the second last character is a p.

p? may only return strings starting with a p and having exactly 2 characters.

Last edited by StefanM; 13.06.2022 at 16:13.
Reply With Quote
  #6  
Old 13.06.2022, 16:34
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

@StefanM: I'm sorry but working fine here, can't reproduce the issue
Filename: test.txt
yes: test.txt
yes: test.*
yes: test.???
yes: *.???
no: test.??
no: test.?
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 13.06.2022 at 16:36.
Reply With Quote
  #7  
Old 13.06.2022, 16:37
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

@StefanM: now I understand. wait for next core update
update will be available in next 5 mins
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 13.06.2022 at 16:50.
Reply With Quote
  #8  
Old 13.06.2022, 17:16
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 349
Default

Quote:
Originally Posted by Jiaz View Post
@StefanM: now I understand. wait for next core update
update will be available in next 5 mins
Looking good again!
But I will perform a more thorough test later, maybe tomorrow.

Now I will test a few scenarios from my prio question.
Yes, I know the last sentence doesn't belong here.......
Reply With Quote
  #9  
Old 15.06.2022, 20:32
Search&Destroy Search&Destroy is offline
DSL User
 
Join Date: Aug 2009
Posts: 38
Default

I also have some Problems with Wildcard character.
I search a lot with *
If I have a package, lets call it:
This is an example Name for a Package

If I put in Search:
This*Package
it should find the Package name, but it does not anymore (it worked this way a few days ago).
I have to search for this, than it will work again:
This*Package*

Is this a bug or a feature
Reply With Quote
  #10  
Old 15.06.2022, 21:31
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 349
Default

It is a feature/correction, as * and ? now work as in any other standard search:

This*Package should only return results which start with This and end with Package

As soon as there are additional characters after Package you have to enter This*Package*.
That's the definition.
Reply With Quote
  #11  
Old 15.06.2022, 21:31
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

@Search&Destroy
Can you please check if there is a space or something else behind Package?
I will test myself by tomorrow
__________________
JD-Dev & Server-Admin
Reply With Quote
  #12  
Old 16.06.2022, 08:54
radorn radorn is offline
JD Alpha
 
Join Date: May 2019
Posts: 21
Default

Quote:
Originally Posted by StefanM View Post
It is a feature/correction, as * and ? now work as in any other standard search:

This*Package should only return results which start with This and end with Package

As soon as there are additional characters after Package you have to enter This*Package*.
That's the definition.
I was going to ask about this.
So, if I understand correctly, the idea is to enforce * for any variable content instead of assuming * for incomplete ends? But why not beginnings too for consistency?
For example searching for is*package* will also match this package and, in the same way this*package* will match in this package.
Why not treat the head the same way as the tail?
Reply With Quote
  #13  
Old 16.06.2022, 09:50
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

@radorn: thanks for the report! could reproduce the issue and will be fixed with next core update
__________________
JD-Dev & Server-Admin
Reply With Quote
  #14  
Old 16.06.2022, 10:09
radorn radorn is offline
JD Alpha
 
Join Date: May 2019
Posts: 21
Default

It enforces the use of asterisks in many searches where they weren't necessary before, which is not all that intuitive, but I guess it allows for more precise searches, and if it's going to be done for ends, I think it should also be done also for beginnings, for consistency and for the gains in precision.

Thank you for your work
Reply With Quote
  #15  
Old 16.06.2022, 10:15
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

Quote:
Originally Posted by radorn View Post
and if it's going to be done for ends, I think it should also be done also for beginnings, for consistency
That's the bug that will be fixed with next core update. As soon as ? or * is in use, the wildcard mode will be used. there was a bug where this mode switch was not correct.


Quote:
Originally Posted by radorn View Post
It enforces the use of asterisks in many searches where they weren't necessary before
Correct, I'll look forward to more user feedback on this and most likely add advanced settings to enable *old behaviour* if preferred
__________________
JD-Dev & Server-Admin
Reply With Quote
  #16  
Old 16.06.2022, 17:57
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 349
Default

Quote:
Originally Posted by Jiaz View Post
...I'll look forward to more user feedback on this and most likely add advanced settings to enable *old behaviour* if preferred
Pooooh!
So glad to hear that you will not remove the new behavior - which is in compliance with the official definition - once again.
Reply With Quote
  #17  
Old 16.06.2022, 19:33
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 02:47.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2022, Jelsoft Enterprises Ltd.