JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 13.06.2022, 12:40
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 354
Default Changing priority of a package does not affect files inside

Example:
I have a package which contains 10 files to be downloaded.
The files inside have highest priority.
Also the package is shown as highest priority in prirority column.
I don't have that package expanded.
I right-click on that package and select default priority.
Now the package is shown as default priority in priority column.
I expand the package.
All files inside still are being displayed as highest priority

Expected Behavior:
When I set a package priority to a certain priority, I expect that all files inside will be set to that priority, too.

But their priority stays the same as before.

Last edited by StefanM; 13.06.2022 at 12:52.
Reply With Quote
  #2  
Old 13.06.2022, 12:45
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

@StefanM: Packages inherit their priority to its links. That means it defines the *default* prriority of its links. When you customize the links, then this custom priority will be used instead.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #3  
Old 13.06.2022, 12:47
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

Quote:
Originally Posted by StefanM View Post
Expected Behavior:
When I set a package priority to a certain priority, I expect that all files inside will be set to that priority, too.
Then you should not customize the files (default priority)

If you want to priority changes of packages to be applied on its links, you have to customize the action via rightclick context menu editor and enable *force change of priority*
__________________
JD-Dev & Server-Admin
Reply With Quote
  #4  
Old 13.06.2022, 12:48
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

this is expected behaviour because priority changes of package should not override custom priorities set on links. that way you can lower priority of package and leave custom priorities as they are, else you would have to manually re-set all the custom priorities again.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #5  
Old 13.06.2022, 12:53
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 354
Default

@Jiaz
Or is the specification as follows?


Example:
Package 1 has highest priority
Package 2 has default priority
In package 1 there are files with default priority and with low priority
In package 2 there are files with highest priority and with high priority

JD will start with package 1 as this has the highest priority.
And JD will start with default priority files in package 1 and then continue with low priority files in package 1.

JD will only start with package 2 when all files from package 1 have been downloaded/started.

JD will then again start with files in package 2 which have highest priority.
...
Reply With Quote
  #6  
Old 13.06.2022, 12:54
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

@StefanM: Please don't mix topics! your topic was about how priority setting works.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 13.06.2022, 12:56
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

@StefanM: packages inherit their priority to its links that have set *default priority*. all links are sorted according to their priority/position in list and then candicate/download selection will look for next possible download in that list.
see my example with next post
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 13.06.2022 at 13:00.
Reply With Quote
  #8  
Old 13.06.2022, 12:59
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

Quote:
Originally Posted by StefanM View Post
Example:
Package 1 has highest priority
Package 2 has default priority
In package 1 there are files with default priority and with low priority
In package 2 there are files with highest priority and with high priority
Package 1: highest
-File 1.1 - default - > highest (inherited)
-File 1.2 - default - > highest (inherited)
-File 1.3 - low - > low (not inherited)
Package 2: default
-File 2.1 - highest -> highest (not inherited)
-File 2.2 - high -> high (not inherited)

sorted list
File 1.1(highest), File 1.2(highest), File 2.1(highest), File 2.2(high), File 1.3(low)
__________________
JD-Dev & Server-Admin
Reply With Quote
  #9  
Old 13.06.2022, 12:59
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 354
Default

Or let me ask in a different way:

Example:
I have 10 packages, each with a number of files with different priorities inside.

What do I have to do, that downloading will start with package 1?

Would it be sufficient to set all packages e.g. to default priority and only package 1 to highest priority?
Reply With Quote
  #10  
Old 13.06.2022, 13:04
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

Quote:
Originally Posted by StefanM View Post
Or let me ask in a different way:
Example:
I have 10 packages, each with a number of files with different priorities inside.
What do I have to do, that downloading will start with package 1?
Would it be sufficient to set all packages e.g. to default priority and only package 1 to highest priority?
Either you have update the priorities of the customized links to inherit the package priority.
Or you customize the priority action to *force* it on the links of the package.
Or you use the *force download* action, that have highest priority (higher than highest)
__________________
JD-Dev & Server-Admin
Reply With Quote
  #11  
Old 13.06.2022, 13:05
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

Quote:
Originally Posted by StefanM View Post
Example:
What do I have to do, that downloading will start with package 1?
Would it be sufficient to set all packages e.g. to default priority and only package 1 to highest priority?
Package priority is only used for inheritance to the links that have default priority.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #12  
Old 13.06.2022, 13:05
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 354
Default

Quote:
Originally Posted by Jiaz View Post
@StefanM: Please don't mix topics! your topic was about how priority setting works.
Well, actually I was just asking if the expected behavior I mentioned first, was the one from the URS.

And later I was asking, if the one I described as "or is this..." was the behavior defined in the URS.
Reply With Quote
  #13  
Old 13.06.2022, 13:10
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 354
Default

After lunch I will create a table with example packages and files and what I understand downloading order would be.

I'm still unsure what the order should be, the one the user should expect.

My initial intention was, to have JD download the package which I set to highest priority first. As this did not work the way I expected, I started this thread.

Will be back with table before 3 pm.
Reply With Quote
  #14  
Old 13.06.2022, 13:13
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

@StefanM: I've already provided example https://board.jdownloader.org/showpo...88&postcount=8
What is unclear about this?
I've explained that package priorities are inherited to its links and that you still can customize the priority of the links. But you can also change action so it changes the priority of the links too, and then it works like you expect it to work.

But of course you may prepare your example if it is still unclear.
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 13.06.2022 at 14:04.
Reply With Quote
  #15  
Old 13.06.2022, 15:31
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 354
Default

I defined numbers for priorities for better reading and understanding

1 = Highest
2 = Higher
3 = High
4 = Default
5 = Low
6 = Lower
7 = Lowest


And I assume that I only have one download at any one time (Max. simultaneous downloads = 1)



1.jpg
20 files from one single package with prio 1 have been moved to P1…P4. Prio of those 4 packages was automatically set to 4 by JD.






2.jpg



I set prio only for packages to P1 = 7, P2 = 6, P3 = 2, P4 = no change: 4

What is the expected download order now?




3. jpg



mixed prios for all 20 files, but prio for packages left the same as in 2.jpg

What is the expected download order now?
Attached Thumbnails
1.jpg   2.jpg   3.jpg  
Reply With Quote
  #16  
Old 13.06.2022, 18:23
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

Quote:
Originally Posted by StefanM View Post
What is the expected download order now?
Already explained here https://board.jdownloader.org/showpo...87&postcount=7 and example here https://board.jdownloader.org/showpo...88&postcount=8

for 2.jpg:
1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20
because all links have highest priority (customized), so they do not inherit the package priority.

for 3.jpg:
7(custom, highest),10(custom, highest),11(custom, highest),15(custom, highest)
1(custom, higher),8(custom higher), 13(inherit package higher), 18 (custom higher)
2(custom, higher)
16(inherit package normal), 17 (inherit package normal)
4(custom, low), 14(custom low), 19 (custom low)
5(custom lower), 9 (inherit package lower)
3(inherit package lowest), 6 (custom lowest), 12 (custom lowest), 20 (custom lowest)
__________________
JD-Dev & Server-Admin
Reply With Quote
  #17  
Old 13.06.2022, 18:55
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 354
Default

Quote:
Originally Posted by Jiaz View Post
Already explained here...
Now, at the bottom of this post please find my real life result, which you will also find in the attachments.

And I also attached a screenshot from the Downloads list.

What I still don't understand:
Why can the user change/set the priority of a package, while at the same time, it does not have any effect at all.

The download priority is regardless of the priority I set for the packages.

report as csv:

Priority,Package,Name,Finished,Download Order
7,P1,,,
2,P1, file1.mp4,05:39:29,5
3,P1, file2.mp4,05:45:02,9
4/7,P1, file3.mp4,05:51:12,17
5,P1, file4.mp4,05:46:16,12
6,P1, file5.mp4,05:48:37,15
6,P2,,,
7,P2, file6.mp4,05:51:46,18
1,P2, file7.mp4,05:30:33,1
2,P2, file8.mp4,05:39:58,6
6,P2, file9.mp4,05:50:18,16
1,P2, file10.mp4,05:35:01,2
2,P3,,,
1,P3, file11.mp4,05:36:51,3
7,P3, file12.mp4,05:53:00,19
4/2,P3, file13.mp4,05:43:53,7
5,P3, file14.mp4,05:47:00,13
1,P3, file15.mp4,05:39:23,4
4,P4,,,
4,P4, file16.mp4,05:45:11,10
4,P4, file17.mp4,05:45:59,11
2,P4, file18.mp4,05:44:39,8
5,P4, file19.mp4,05:47:26,14
7,P4, file20.mp4,05:53:09,20
Attached Thumbnails
Order-Test-Marked.jpg   Excel.jpg  
Reply With Quote
  #18  
Old 13.06.2022, 19:20
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

Quote:
Originally Posted by StefanM View Post
The download priority is regardless of the priority I set for the packages.
It is NOT. The package priority is used by links from that package that are set to default, that means they will inherit the priority of the package. see https://board.jdownloader.org/showpo...1&postcount=11

Quote:
Originally Posted by StefanM View Post
Why can the user change/set the priority of a package, while at the same time, it does not have any effect at all.
You change the priority of the package. If you have customized link priorities within that package, then those have higher *priority* and
links do not inherit priority from package.
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 13.06.2022 at 19:33.
Reply With Quote
  #19  
Old 13.06.2022, 19:22
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

@Stefan: Without this default behaviour, you cannot customize links at all as a single change of package priority would again reset/change your customization. So you would have to go through all links again and apply custom priorities again. This way you can fast/easily set priority on package AND still use custom link priority.

If you don't want this mode/behaviour, then you can customize the *set priority* actions via rightclick context menu -> menu editor -> and change to *force priority*
and then it works exactly like you want package priority to change link priority
__________________
JD-Dev & Server-Admin
Reply With Quote
  #20  
Old 13.06.2022, 19:31
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,851
Default

Quote:
Originally Posted by StefanM View Post
Now, at the bottom of this post please find my real life result, which you will also find in the attachments.
They are in the same order as I've calculated in my head, https://board.jdownloader.org/showpo...1&postcount=16
__________________
JD-Dev & Server-Admin

Last edited by Jiaz; 13.06.2022 at 19:42.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 18:48.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2022, Jelsoft Enterprises Ltd.