JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 07.10.2021, 10:19
DukeM's Avatar
DukeM DukeM is offline
JD Beta
 
Join Date: Sep 2019
Posts: 56
Default Enable Undo on File Name/Package Name?

This is the closest I've found regarding this:

https://board.jdownloader.org/showthread.php?t=67045

And in the thread, Jiaz mentioned:

Quote:
Where to place the undo for rename? How long to remember old name?
Not sure how JD2 textbox works but is it not possible to just be able to Ctrl+Z while the textbox is still active? Similar to how you can Ctrl+Z pretty much anywhere you can type.

I don't think we really need to make a more complicated version, like the post above seems to be alluding to.

Just a basic one where while you're still typing and made a mistake or pasted a long-ass link instead of the file name, you can just hit Ctrl+Z. If you've already pressed Enter or clicked outside the box then you're just SOL but I think most naming mistakes/typos are caught while the textbox is still active anyway.

Right now, I have to highlight the whole thing and it sometimes takes a while especially when it's one of those really really long direct links. Or when highlighting text, due to the small nature of the text box, the highlight will apply on the opposite part of the text on click release and now you have the retype the whole thing, etc. Lol.

Thanks!

Last edited by DukeM; 07.10.2021 at 10:22.
Reply With Quote
  #2  
Old 07.10.2021, 11:52
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 72,936
Default

@DukeM: to support UNDO a text(edit) component requires a so called UndoManager assigned, that keeps tracking of previous states. Those must be explicit assigned.

To abort current edit/change, ESC key should work in most places.

Can you tell me where you would need such feature most? then I can start working on the ticket at those places first and we/you can check if it works as expected.
Please know that I need to know where you edit something? Within the table is a different component, than a dialog or the property window.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #3  
Old 07.10.2021, 13:56
DukeM's Avatar
DukeM DukeM is offline
JD Beta
 
Join Date: Sep 2019
Posts: 56
Default

Quote:
to support UNDO a text(edit) component requires a so called UndoManager assigned, that keeps tracking of previous states. Those must be explicit assigned.
Ahhhhh, I see, I honestly assumed that textboxes or any fields that allows you to input text automatically just has that. I thought it relies on your OS to handle that text field rather than the individual software itself. Didn't occur to me that it would have been a separate feature. Now, it makes sense, thanks for clarifying that.


Quote:
To abort current edit/change, ESC key should work in most places.
Wow, I never figured that one. It certainly would be less painful now. Thanks again!

Quote:
Can you tell me where you would need such feature most?
I use it most on the box that appears at the bottom of the Linkgrabber tab when you select a file on the list. The one with the fields for Package name, File name, Save to, Download Password, MD5/SHA1/SHA256, etc. And like 99% of the time, I just use the "File name" part.

But to be fair, now that I know I can use Esc for the mess-ups I'd be making, I don't mind not having this feature, at least not immediately. Haha. Thanks, @Jiaz!
Reply With Quote
  #4  
Old 07.10.2021, 14:03
DukeM's Avatar
DukeM DukeM is offline
JD Beta
 
Join Date: Sep 2019
Posts: 56
Default

Oh no, I just messed up a rename and pasted a link on the text field. Tried pressing Esc and it just highlighted the whole text and didn't "reset" it. Hahaha.
Reply With Quote
  #5  
Old 07.10.2021, 14:21
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 59,617
Default

Works fine here.
While it does select the whole text, it also resets it to the text there was before.
Did you maybe click outside of the comment field in between?
If you lost important information you might be able to restore it this way.

If you think you found a bug:
Please post your log-ID here | bitte poste deine Log-ID hier.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #6  
Old 07.10.2021, 14:26
DukeM's Avatar
DukeM DukeM is offline
JD Beta
 
Join Date: Sep 2019
Posts: 56
Default

Hey @psp! I was just about to edit that additional comment. Haha. I'm making a fool of myself here but it doesn't matter.

So yeah, for me at least, it still doesn't revert the file name after pasting text BUT if I type in anything after that (even just one character) then pressing Esc, it reverts it back to the text before the paste. Haha. So, it works! My JD2 is probably just a little bit special and needs extra attention.
Reply With Quote
  #7  
Old 07.10.2021, 14:28
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 59,617
Default

Ahh so you were talking about the filename field, not comment field?
Anyways - works fine here too, the behavior is the same as descibed in my last post hmm
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 02:31.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2021, Jelsoft Enterprises Ltd.