[mgpai]

Originally Posted by Dockel

Here are some errors shown while adding two uloz
Is there anything I could do?

I may need to run some tests. Can you contact me again in chat?

[Dockel]

Yes, OK.

[Dockel]

Just added three zippy links, the message appeared again

all three download links marked as duplicate:


One of the files has a combination of numbers and letters (as it often is) instead of file.html.

I added three more zippy downloads without a problem. Not being marked as duplicates. All of their file names were a combination of numbers and letters, without extension.

Unfortunately I cannot find script_errors.txt file, may be there is not one created after to log that error?

But, it seems (like it was yesterday) or may be the error only appears once in a JD session (from start to close of JD) and never again in the sesson, so one could leave it as it is.

[mgpai]

Originally Posted by Dockel

Just added three zippy links, the message appeared again

This seems to be from a different script. Not from the one modified yesterday. You can also see that the error messages are different. Contact me in chat when you are free.

[pspzockerscene]

Originally Posted by mgpai

To reproduce, add a dummy (non-working) connection in connection manager, which will make ZS links un-checkable and all links will be added to linkgrabber with same package/file name.

Did this and found out that my fix did not work the way I wanted it to.
Fixed!

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!
---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

-psp-

[Dockel]

I am sorry, but the same problem again: "html.file" links are marked as duplicates (also before chainging the last script yesterday). May be there is anything....

[mgpai]

Originally Posted by Dockel

I am sorry, but the same problem again: "html.file" links are marked as duplicates (also before chainging the last script yesterday). May be there is anything....

Please contact me in chat.

[Dockel]

Suddenly (since the updated script(s)) the duplicates are not disabled anymore (https://board.jdownloader.org/showth...led#post457412) but shown as duplicates with a message for each link. How could I turn showing the messages off and let the script(s) disable the links?

[mgpai]

Originally Posted by Dockel

How could I turn showing the messages off and let the script(s) disable the links?

I only added a code to display message for troubleshooting purpose. It should not affect any other function of the script. The script which you have linked appears to be different. You will have to again contact me in chat to check it.

[Dockel]

Links are added to the Linkgrabber and JD marks them in red as dups (so they are already in the download list). When I then delete the dup links in the download list the dups in the grabber are not marked / indicated anymore as dups (by JD) and will be downloaded? So the script does not indicate them as dups (although they have been added to history.txt?

[Jiaz]

@Dockel: dupe is no property but just a runtime evaluated information when required, eg during rendering of table or when filtering the links.....
Or do you mean something different?

[Dockel]

Sorry, I do not understand what that means, but I meant the script mgpai made. To not to download dups.

[Jiaz]

Originally Posted by Dockel

JD marks them in red as dups

That's something the script cannot do! I tried to explain that this is no property to a link (being a dupe or not) but just evaluated in real time when this information is required.
The script for example could modify the link comment text and add a marker like DUPE. in combination with custom view filter you can easily filter those entries in linkgrabber list.
@mgpai: script just need to modify the comment field

[Dockel]

That's something the script cannot do!

Sorry for my bad expression. The script shall not do it, just JD does it. The script should mark them as dupes (what it does), e.g. it adds something to the comment if there is a dupe.

The script for example could modify the link comment text and add a marker like DUPE

Yes, that is what it does.

[Jiaz]

@Dockel: Can you link/show the script?
Onces you've removed the link from downloadlist, JDownloader will no longer highlight the link in linkgrabber as dupe (different colour), the script cannot do this

[Dockel]

I am not sure which one this does:

// Skip link if it present in download history (has "#duplicatelink" in comment)
// To download the file (prevent skipping), remove "#duplicatelink" from comment
// Trigger required: A Download Started

var comment = link.getComment() || "";

if (comment.indexOf("#duplicatelink") > -1) {
    // var url = link.getContentURL() || link.getPluginURL(); // Nur tatsächlich runtergeladene Varianten von YouTube werden als Duplikate behandelt
    var url = link.getHost() == "youtube.com" ? link.getContainerURL() : link.getContentURL() || link.getPluginURL(); // alle Varianten auf YouTube werden als Duplikate behandelt
    link.setEnabled(false); //To disable the link instead of skipping it, replace link.setSkipped(true); with link.setEnabled(false); in both the scripts
    alert("Download Skipped: \"" + url + "\" is present in history file.");
}

It must be one ot those: https://board.jdownloader.org/showpo...4&postcount=18

Onces you've removed the link from downloadlist, JDownloader will no longer highlight the link in linkgrabber as dupe (different colour),

Yes, I know.

the script cannot do this

Yes, that is OK, it shouldn't do that either. But it should mark the dups as dups (in the comments).

[Jiaz]

@Dockel: When I understant the scripts right, the following happens
you add the link to download list, then add again to linkgrabber list. Now the dupe support of JDownloader highlights the link via color. then you use script to mark as dup and remove from download list. At that moment the *mark as duplicate* script in Linkgrabber is already done. the link was not part of history.txt at time of link adding, no comment has changed.
When you remove the link from linkgrabber and add again, then it should contain the comment.
For this to work @mgpai has to modify the scripts.

[Dockel]

@Dockel: When I understant the scripts right, the following happens
you add the link to download list, then add again to linkgrabber list. Now the dupe support of JDownloader highlights the link via color.

Yes, that is right.

then you use script to mark as dup and remove from download list.

It does it automatically. It e.g. disables the links and I can delelte them.

At that moment the *mark as duplicate* script in Linkgrabber is already done.

It would / could mark the links again, if the get in the download list window, if I see it right.

the link was not part of history.txt at time of link adding

The links I meant were part of the history.txt but not marked as dups, if I saw it right. So the comment had have to be changed.

When you remove the link from linkgrabber and add again, then it should contain the comment.

Yes, correct.

OK, so we will wait for what mgpai will say.

[mgpai]

@Jiaz has correctly explained it. The whole point of the script was to check for dupes which are not already in the download list. There doesn't seem to be much point in the script again doing what JD has already done (highlighted as dupe). You can use the sidebar to filter and disable/delete the highlighted links.

[Dockel]

@Jiaz has correctly explained it. The whole point of the script was to check for dupes which are not already in the download list. There doesn't seem to be much point in the script again doing what JD has already done (highlighted as dupe).

Yes, absolutely.

Obviously I explained completly bad, very sorry:

Links are added to the Linkgrabber and JD marks them in red as dups (because they are already in the download list). When I then delete the dup links in the download list the dups in the grabber correctly are not marked / indicated anymore as dups (by JD). These links are not marked / disabled as dups by the script (although they are dups snf already available in history.txt. So the script obviously does not indicate them as dups (although they have already been added to history.txt. Could those links be marked / disabled as dups anyway?