[mgpai]

Originally Posted by sherbee

Thank you for idea. But I like complicated.

Here is a new script, but if you need help to troubleshoot/fix yours, contact me in JD Chat.

// Move archive files after extraction
// Trigger: Archive Extraction Finished

var links = archive.getDownloadLinks() || [];
var destinationFolder = "C:/sherbee/check";

links.forEach(function(link) {
    var filePath = getPath(link.getDownloadPath());
    var i = 0;

    while (getPath(destinationFolder + "/" + filePath.getName()).exists()) {
        i++;
        newPath = getPath(link.getDownloadPath().toString().replace(/(.+)(\..+)/, "$1" + i + "$2"));
        getPath(filePath).renameTo(newPath);
        filePath = newPath;
    }

    filePath.moveTo(destinationFolder);
});

[mgpai]

Originally Posted by Jiaz

... we can't forbid/prevent such a script..here or anywhere else

True, but I am not comfortable helping anyone scam the hosters. If (I feel) the requirement is legitimate (as in this case), I will try to help in any way I can.

[mgpai]

Originally Posted by Tarantino

... if I download part by part and repeat, I will be able to download all the content before they got deleted.

Can you contact me in JD Chat? Use the chat extension available in JD or use the webchat:

webchat.freenode.net/?channels=jdownloader

[sherbee]

Originally Posted by mgpai

Here is a new script, but if you need help to troubleshoot/fix yours, contact me in JD Chat.

// Move archive files after extraction
// Trigger: Archive Extraction Finished

var links = archive.getDownloadLinks() || [];
var destinationFolder = "C:/sherbee/check";

links.forEach(function(link) {
    var filePath = getPath(link.getDownloadPath());
    var i = 0;

    while (getPath(destinationFolder + "/" + filePath.getName()).exists()) {
        i++;
        newPath = getPath(link.getDownloadPath().toString().replace(/(.+)(\..+)/, "$1" + i + "$2"));
        getPath(filePath).renameTo(newPath);
        filePath = newPath;
    }

    filePath.moveTo(destinationFolder);
});

I think this is very good. Thank you. I understand better now. Replace with regex is very clever.

2 Questions I have:

1. Is there more docu to understand better return of methods? For example if I put

   var myString = myFilePath.getPath();

   Is output with "\" or with "/" or has it slash at end. Or when I put

   var myString = myFilePath.getExtension();

   is output with "." or without? That is make it more easy to know better what exactly is return not only return type. Then more easy to use and put back together.
   

2. newPath = getPath(link.getDownloadPath().toString().replace(/(.+)(\..+)/, "$1" + i + "$2"));

   Is link.getDownloadPath() not string type already? Why you put ".toString()"? I think that is the only thing I cannot understand now.

All other is so very good that I want to my head for better thinking.

Only thing I must change is

replace(/(.+)(\..+)/, "$1" + i + "$2"));

to

replace(/(.+)(\..+)/, "$1 (" + i + ")$2"));

then it is like Windows Explorer original rename.

[mgpai]

Originally Posted by sherbee

Questions I have ...

1. var myString = "c:/sherbee/check/file.txt"; // string
   var myFilePath = getPath(myString); // Converts myString to myFilePath object
   var myString = myFilePath.toString(); // Output :  "c:\sherbee\check\file.txt"
   var myString = myFilePath.getParent(); // Output: "c:\sherbee\check"
   var myString = myFilePath.getName(); // Output: file.txt
   var myString = myFilePath.getExtension(); // Output: "txt"

   
   
2. I had intitally used a path object while testing a different version of the script, which required converting it to string. I forgot to remove it in the final script.

[Jiaz]

1.) depends on your OS, Unix(/) vs Windows (\)
2.1) without dot
2.2) I guess in the past it was different instance or just wanted to make sure that string return type

Hello,

the code example
Save youtube links and basic information to a html page
contains the following invalid line:

if (youtubeMedia) {
    var output = [];
    var variant = JSON.parse("YT_VARIANT".prop());
    var variantData = JSON.parse(variant.data);
    var youtube = "<a href=\"External links are only visible to Support Staff;

Can someone be so kind and correct that?


Many thanks and greetings
JDFan

[mgpai]

Originally Posted by JDFan

... the code example Save youtube links and basic information to a html page contains the following invalid line: ...

 var youtube = "<a href=\"External links are only visible to Support Staff;

Script:

gist.github.com/mgpai/defe23044e32d7cec7756053997295e1/download

Hello,

the result of the following script is always null:

if (name == "YT Test") {
  sYT_Channel_Title = downloadLinks[0].getProperty("YT_CHANNEL_TITLE") ;
  alert("YT_Channel_Title: " + sYT_Channel_Title) ;
}

YT_CHANNEL_ID works.

My filename contains an CHANNEL, so the package should contain one.


Many thanks and greetings
JDFan

[mgpai]

Originally Posted by JDFan

... YT_CHANNEL_ID works. ...

var channelName = myDownloadLink.getProperty("YT_CHANNEL");

[thecoder2012]

Originally Posted by Bach

The script shows errors in the 23 line.
Syntax Error: Unterminated objekt literal
Error Report
net.sourceforge.htmlunit.corejs.javascript.EcmaError: SyntaxError: Unterminated object literal (#23)

I have updated my example with better errorhandling and retries. See my post #93 in this topic.

[bobolecoco]

Hi.
The trigger is "A download started".
With the following code, downloads are "freezed" :

function Stream() {
    if (isDownloadControllerRunning()) {
        alert("OK !");
        sleep(30000);
        Stream();
    }
}
Stream();

Why ? Is the "sleep" function is "sleeping" the whole JDownloader process or just the script ?

(This is for testing purpose, my idea is to replace "alert("OK !");" with a function I want to check every 30 seconds while the "Download Controller" is running).

Is there a way to achieve that (pausing only the script) ?

Thanks !

[mgpai]

Originally Posted by bobolecoco

With the following code, downloads are "freezed"

Disable the "Synchronous execution of script" checkbox.

Originally Posted by bobolecoco

Is there a way to achieve that (pausing only the script) ?

If you can provide information on what you want to achieve with the function/script, we can look into it.

[bobolecoco]

Thanks, it worked. So if 2 downloads start, the script will run twice ? Should I use "Download controller started" trigger instead if I want only one instance to run ?

I already have a working script, it runs every 30 seconds (interval 30000). But it's relevant only when a download is running. It allows me to put a speed limit when a twitch channel is streaming, so bandwidth stay available to watch the stream. Here it is :

var myBrowser = getBrowser();
myBrowser.setHeader("Accept", "application/vnd.twitchtv.v3+json");
myBrowser.setHeader("Client-ID", "HereIsMyPrivateClientId");
myBrowser.getPage("**External links are only visible to Support Staff**);

if (!/"stream":null/.test(myBrowser.getHTML())) {
    setSpeedlimit(1.5 * 1024 * 1024);
} else {
    setSpeedlimit(0);
}

It's not relevant to run it when no file is being downloaded, but it need to be run periodically (every 30sec) when it is the case. That's why I was looking for triggers like "A download started" or "Download controller started" and use a while loop or a function that calls itself while "isDownloadControllerRunning()" is true.

Am I clear enough (English is not my natural language) ?

A problem I have is when twitch's server is not reachable for a brief moment : it triggers an error, and the script disables itself. So running it only when downloading reduce the probability to trigger that error. An other solution would be to extent time before a timeout error is fired, but I didn't find any option like this with getBrowser().

A reliable way to do it would be to create an external script that check if there is a streaming, that JD runs from event scripter. But my idea was to NOT use an external script.

[mgpai]

Originally Posted by bobolecoco

So if 2 downloads start, the script will run twice ?

Yes

Originally Posted by bobolecoco

Should I use "Download controller started" trigger instead if I want only one instance to run ?

Yes

Originally Posted by bobolecoco

A problem I have is when twitch's server is not reachable for a brief moment : it triggers an error, and the script disables itself.

Use try/catch.

Sample Code (Totally untested) :

// Toggle Speed Limit
// Trigger: Download Controller Started
// IMPORTANT: Disable 'Synchronous Execution'

while (isDownloadControllerRunning()) {
    if (streaming()) {
        setSpeedlimit(1.5 * 1024 * 1024);
    } else {
        setSpeedlimit(0);
    }
    sleep(30000);
}

//Functions
function streaming() {
    try {
        var myBrowser = getBrowser();
        myBrowser.setHeader("Accept", "application/vnd.twitchtv.v3+json");
        myBrowser.setHeader("Client-ID", "HereIsMyPrivateClientId");
        myBrowser.getPage("hxxps://api.twitch.tv/kraken/streams/TheNameOfTheTwitchChannel");
        return /"stream":null/.test(myBrowser.getHTML());
    } catch (e) {
        //On error assume it is atreaming?
        return true;
    }
}

[bobolecoco]

It seems to work. I'll see if errors appear in the future.

Thanks ! I'll keep you posted if anything new happens !

Hello,

erroneous scripts are automatically disabled in the Settings -> Event Scripter after the first run. That makes sense, but not during testing. Any way to switch that behaviour off?


Many thanks and greetings
JDFan

[Jiaz]

@JDFan: Script won't get disabed when testing script. you want a way to disable *auto disable* in script?

Mgpai,
I would like create a script to download some steaming with a scheduler that consider days, hours and minutes. I am not a programmer...can tell me how I can work out it?

Originally Posted by Jiaz

@JDFan: Script won't get disabed when testing script. you want a way to disable *auto disable* in script?

I would prefer a global switch in Advanced Settings. I assume that's easier to implement compared to a change in the script engine.

[Jiaz]

Originally Posted by JDFan

I would prefer a global switch in Advanced Settings. I assume that's easier to implement compared to a change in the script engine.

script command is much easier than global switch also script command has the advantage that yuo can enable/disable it within the same script and not have impact on all other scripts as well

I'm wondering because I get always null!

Originally Posted by Jiaz

script command is much easier than global switch also script command has the advantage that yuo can enable/disable it within the same script and not have impact on all other scripts as well

Then a script command please! Many thanks in advance.

[Jiaz]

@JDFan: it contains the description/text but only temporarily and currently not available via normal getProperty because those details are fetched and cached during session, not stored.

[Jiaz]

Originally Posted by JDFan

Then a script command please! Many thanks in advance.

after next core update there are
setNotifyOnException(true/false), show(yes,no) dialog to inform about exception
setDisableOnException(true/false), disable(yes,no) script on exceptions

Complex problem, really. Script triggered by Script Downloadlist Contextmenu Button Pressed (name Test). YouTube video is downloaded. Flickers only with that link (others too). BUT when you change only some letters of 0Mp2kwE8xY0 no flickering (e. g. M -> 1)! Can someone reproduce that crazy behaviour?

if ( name == "Test" )
{
  //      123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890\
  alert( "Line1: **External links are only visible to Support Staff**) ;
}

And when no flickering occurs, the height is too small.

1. Optional (checkbox) non-proportional font like Courier New. Better readable debug outputs.
2. Properties for x, y, w(idth) and h(eight).
3. Copy to Clipboard button. Maybe Paste too.

Reading from and writing to the clipboard should be possible. Maybe with special security flag via Advanced Settings.

Would simplify automation (passing parameters from other apps, e. g. AutoHotkey and speech recognition). Maybe with special security flag via Advanced Settings.

Maybe via the Environment Object? getHostname()?? Different PCs/notebooks, different folder structures. Want to set pathes depending on the PC/notebook in use.

Edit: There seems to be an environment variable COMPUTERNAME.

sComputerName = getEnv( "COMPUTERNAME" ) ;
alert( sComputerName ) ;

Should be accessible by all scripts. For a limited number of global script variables environment variables could be used of course, like JD_VarName.

The possibility to export all marked scripts would be great. Should be an xml file so it could be created/modified with other tools. And of course the corresponding import functionallity.
Maybe with support by the event scripter itself? Methods like listScripts(), exportScripts(), importScripts(), enableScripts(), disableScripts(). Parameter an arrray of scripts. Propeties enabled, name, trigger plus all the GUI settings.

[Jiaz]

Originally Posted by JDFan

The possibility to export all marked scripts would be great. Should be an xml file so it could be created/modified with other tools. And of course the corresponding import functionallity.
Maybe with support by the event scripter itself? Methods like listScripts(), exportScripts(), importScripts(), enableScripts(), disableScripts(). Parameter an arrray of scripts. Propeties enabled, name, trigger plus all the GUI settings.

I don't think we have to create new commands for this. you can already access the advanced settings storage from the scripts via callapi and accessing the advanced settings and then read/write/modify or export/import. I'm sure mgpai can help you with that

[Jiaz]

Originally Posted by JDFan

Should be accessible by all scripts. For a limited number of global script variables environment variables could be used of course, like JD_VarName.

What *global variables* do you mean? You already can use set/getProperty(key,boolean) method with local(script,false)) or global(shared,true) and share information accross different scripts with help of global properties

[Jiaz]

Originally Posted by JDFan

Maybe via the Environment Object? getHostname()?? Different PCs/notebooks, different folder structures. Want to set pathes depending on the PC/notebook in use.

Edit: There seems to be an environment variable COMPUTERNAME.

sComputerName = getEnv( "COMPUTERNAME" ) ;
alert( sComputerName ) ;

You can either use getEnv to access the environment variables and/or use getEnvironment to access the EnvironmentSandbox object

[Jiaz]

Originally Posted by jdfan

reading from and writing to the clipboard should be possible. Maybe with special security flag via advanced settings.

Originally Posted by jdfan

3. Copy to clipboard button. Maybe paste too.

[Jiaz]

Originally Posted by JDFan

Complex problem, really. Script triggered by Script Downloadlist Contextmenu Button Pressed (name Test). YouTube video is downloaded. Flickers only with that link (others too). BUT when you change only some letters of 0Mp2kwE8xY0 no flickering (e. g. M -> 1)! Can someone reproduce that crazy behaviour?

if ( name == "Test" )
{
  //      123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890\
  alert( "Line1: **External links are only visible to Support Staff**) ;
}

And when no flickering occurs, the height is too small.

The flickering happens because of resize loop of auto break on text caused by the space. This is more complex to handle better and sorry to say but at the moment not that important.

@mgpai:

Can you be so kind and support me with some basic hints, e. g. concerning callapi and where I can find the corresponding methods:

Originally Posted by Jiaz

I don't think we have to create new commands for this. you can already access the advanced settings storage from the scripts via callapi and accessing the advanced settings and then read/write/modify or export/import. I'm sure mgpai can help you with that

I really like INI files. And JSON, too. Scripter support?

[Jiaz]

@JDFan: see https://my.jdownloader.org/developers/ for list of api methods and their parameters