JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 15.07.2017, 19:53
ludob ludob is offline
I will play nice!
 
Join Date: Jul 2017
Posts: 4
Default links with @ in the url are not sent correctly to decrypter

Hi,

security-links has urls with @ in it. Ex:

**External links are only visible to Supporters****External links are only visible to Supporters**

The decrypter however is stared with the url cut off at @ :

------------------------Thread: 2349:security-links.com_jd.plugins.decrypter.SecurityLinksCom.log-----------------------
--ID:2349TS:1500134931350-7/15/17 6:08:51 PM - [jd.controlling.linkcrawler.LinkCrawler(crawl)] -> Crawling: **External links are only visible to Supporters****External links are only visible to Supporters**
--ID:2349TS:1500134934402-7/15/17 6:08:54 PM - [jd.http.Browser(openRequestConnection)] -> Caller: jd.plugins.decrypter.SecurityLinksCom.decryptIt(SecurityLinksCom.java:42)

and obviously doesn't find anything.

trunk/src/jd/plugins/decrypter/SecurityLinksCom.java has the following definition:
@DecrypterPlugin(revision = "$Revision: 35652 $", interfaceVersion = 2, names = { "security-links.com" }, urls = { "**External links are only visible to Supporters** })

Adding @ [A-Za-z0-9:;/\\.] will probably solve this problem.

Thanks,
Reply With Quote
  #2  
Old 16.07.2017, 05:11
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 15,468
Default

added couple components.

raztoki
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #3  
Old 16.07.2017, 09:25
ludob ludob is offline
I will play nice!
 
Join Date: Jul 2017
Posts: 4
Default

Thanks a lot for the prompt reaction.

In the mean time found another exception:

**External links are only visible to Supporters**
It is copied to the clipboard (linux) as

**External links are only visible to Supporters****External links are only visible to Supporters**

This one solves it for me:

urls = { "**External links are only visible to Supporters** })

Obviously % allows to encode any character.

Thanks again.
Reply With Quote
  #4  
Old 16.07.2017, 09:40
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 15,468
Default

think you will find its more so function of the browser to copy url as text or urlencoded.

which website are you sourcing the links from? I could confirm
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #5  
Old 16.07.2017, 09:53
ludob ludob is offline
I will play nice!
 
Join Date: Jul 2017
Posts: 4
Default

**External links are only visible to Supporters****External links are only visible to Supporters**

Links for hoster 1fichier (11 uses { )

Both Firefox (54.0) and Chromium (59.0.3071.109) copy as urlencoded. Firefox shows the link unencoded in the status bar when hovering over the link but "Copy Link Location" will urlencode. Chromium both shows the link urlencoded in the status bar and copies urlencoded to clipboard.

Using [A-Za-z0-9:;/\\.@#%{] would cater for both cases if and when other browsers/platforms would not encode while copying to clipboard.
Reply With Quote
  #6  
Old 16.07.2017, 12:14
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 15,468
Default

html source hrefs are not url encoded, browser encodes them on click/copy due to containing chars which require it.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #7  
Old 16.07.2017, 13:12
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 15,468
Default

ok I've made my changes.

should be good to go!

raztoki
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #8  
Old 16.07.2017, 13:23
ludob ludob is offline
I will play nice!
 
Join Date: Jul 2017
Posts: 4
Default Catalpa avenue

Yep, that works great.

Thanks a lot.

Last edited by raztoki; 16.07.2017 at 13:38. Reason: yes. but we will keep that between us.
Reply With Quote
  #9  
Old 16.07.2017, 13:38
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 15,468
Default

most welcome
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 07:52.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.9
Copyright ©2000 - 2017, Jelsoft Enterprises Ltd.