JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 15.07.2021, 13:53
nss nss is offline
Modem User
 
Join Date: Jul 2021
Posts: 3
Default browserDetection script in JDExtension wrongly detects supported browsers

Hi there,
I'm using Win10Pro and Vivaldi as my default browser. It's based on chromium. Sadly the detection script checks for specific browser and not a userAgent (why). Therefore I'm getting message box saying I need to download the extension (which I have) and somewhere below the is another message box saying I need to restart the browser because it detects the extension is installed. This change seems to be relatively recent (like this year) because I didn't have this problem before.

I recommend either to import some library from cnd which has proper detection or change it to something more universal like userAgent. Now the extension is unusable for anyone using chromium based browser (like Vivaldi or Brave).

Regards
Reply With Quote
  #2  
Old 15.07.2021, 13:56
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 76,440
Default

It's not the extension that checks for supported browser. Either it's installed or not.
The website is shown and then the browser extension takes over. There are no browser checks done.
What extension version have you installed? should be minimum current 3.3.20
also make sure that nothing blocks the extension
__________________
JD-Dev & Server-Admin
Reply With Quote
  #3  
Old 15.07.2021, 19:06
nss nss is offline
Modem User
 
Join Date: Jul 2021
Posts: 3
Default

I have: Version: 3.3.20

Maybe the script is not shipped via extension but from JD itself. I don't know, didn't really dig that much.

I see that the browserDetection function is not called here but it errors as browser variable is not defined. Maybe it is set from other script but I do not see any and in the console it is undefined.



I do not have this error on Chrome.



And the function here doesn't detect my browser properly.
Reply With Quote
  #4  
Old 15.07.2021, 21:05
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 76,440
Default

I will check Vivaldi browser tomorrow but I'm not aware of any issues. JDownloader opens a website. It doesn't matter if that website shows anything about not supported browser because with installed extension in browser, the extension will recognize the website and proceed with captcha handling.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #5  
Old 15.07.2021, 21:12
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 76,440
Default

Just tested on Linux/Windows. Installed Chromed Extension, working fine out of the box.
So something must be messing with the installed extension, check other installed extensions
__________________
JD-Dev & Server-Admin
Reply With Quote
  #6  
Old 16.07.2021, 21:06
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 76,440
Default

Any feedback on this?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 18.07.2021, 12:11
nss nss is offline
Modem User
 
Join Date: Jul 2021
Posts: 3
Default

Hey, sorry about the delay.

I managed to isolate the issue. It was the extension problem, namely the Violentmonkey script manager. No idea why it conflicts as I've been using it for years and the problem came up recently. I have to completely disable the extension from the browser to make it work.

Anyway this is resolved. Thanks for your time
Reply With Quote
  #8  
Old 19.07.2021, 09:14
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 76,440
Default

Thanks for the feedback! Glad you could found the cause and solve the issue
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 04:27.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2022, Jelsoft Enterprises Ltd.