JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 28.01.2018, 15:49
NesteaZen's Avatar
NesteaZen NesteaZen is offline
Fibre Channel User
 
Join Date: Apr 2009
Posts: 129
Default implement flat extraction

I searched the website and asked raztoki on irc and haven't found anything in the adv options.
Please consider adding flat extraction. Downloading some independent files but still related to later have to hassle with moving them into one folder isn't optimal.
Reply With Quote
  #2  
Old 29.01.2018, 09:43
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 71,520
Default

I'm sorry but what exactly is *flat extraction* ? Do you mean ignore subfolders within the archive and just extract all files into one destination folder?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #3  
Old 29.01.2018, 12:12
NesteaZen's Avatar
NesteaZen NesteaZen is offline
Fibre Channel User
 
Join Date: Apr 2009
Posts: 129
Default

yes
Reply With Quote
  #4  
Old 29.01.2018, 12:14
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 71,520
Default


Can you please provide example archives/links for such a use case?
Please send them to support@jdownloader.org
__________________
JD-Dev & Server-Admin
Reply With Quote
  #5  
Old 29.01.2018, 12:38
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,331
Default

this will cause possible conflicts, for example what do you do with files of the same filename, now that they share the same path?
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]

Last edited by raztoki; 29.01.2018 at 15:42.
Reply With Quote
  #6  
Old 29.01.2018, 14:22
NesteaZen's Avatar
NesteaZen NesteaZen is offline
Fibre Channel User
 
Join Date: Apr 2009
Posts: 129
Default

>what do you do with files of the same name and that they share the same path?
skip them? Make it "hidden" in the advanced config. The path is irrelevant anyway.

**External links are only visible to Support Staff****External links are only visible to Support Staff**
Reply With Quote
  #7  
Old 29.01.2018, 15:44
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,331
Default

for instance
test.zip contains
Code:
a.txt
directory1/a.txt
directory2/a.txt
...
without any directories you have 3 filename conflicts as you want to extract to same path (as you call it flat) as they all have the same filename.

raztoki
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #8  
Old 29.01.2018, 20:43
NesteaZen's Avatar
NesteaZen NesteaZen is offline
Fibre Channel User
 
Join Date: Apr 2009
Posts: 129
Default

I mean come on. What do you think the likelihood will be this will be the case? Unless these are meta files like thumbs.db or _dstore mac files.
And it's not an option that will be turned on by default. People who will have set that will hopefully know they did.
This is QOL.
Reply With Quote
  #9  
Old 30.01.2018, 00:30
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,331
Default

I never implied it will be common, though it will happen (yes meta files are the most likely, though so are install.txt, readme.txt. etc.). When programming a feature like you requested, you will need to make allowances for it. It will most likely mean additional options within archive setting pane or dialog popups (like general settings when file exists).

raztoki
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #10  
Old 30.01.2018, 14:12
NesteaZen's Avatar
NesteaZen NesteaZen is offline
Fibre Channel User
 
Join Date: Apr 2009
Posts: 129
Default

oh I'm sorry. I thought it be easy since it's something unrar provides anyway.
thank you guys for considering and incorporating it. May you be blessed.
Reply With Quote
  #11  
Old 05.02.2018, 20:38
netgearjd netgearjd is offline
Giga Loader
 
Join Date: Aug 2014
Posts: 92
Default

Quote:
Originally Posted by raztoki View Post
this will cause possible conflicts, for example what do you do with files of the same filename, now that they share the same path?
Not that I'm interested in this feature, but the above is a very real possibility so you'd need to provide at least the following options IMO:

1. Overwrite: Each successive file with the same name would overwrite the previous one till in the end only the last one is left (which exactly that is would depend upon how unrar steps through the archive).

2. Skip: Each successive file with the same name would be skipped till in the end only the first one is left (which exactly that is would depend upon how unrar steps through the archive).

3. Rename: Each successive file with the same name would be auto-renamed (perhaps with numbers like (1), (2) etc.) so that none are left out.
Reply With Quote
  #12  
Old 06.02.2018, 09:06
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 71,520
Default

@netgearjd: I like those 3 options which can also be used for normal extraction
__________________
JD-Dev & Server-Admin
Reply With Quote
  #13  
Old 06.02.2018, 10:00
NesteaZen's Avatar
NesteaZen NesteaZen is offline
Fibre Channel User
 
Join Date: Apr 2009
Posts: 129
Default

I have no idea why you guys are complicating this so much. This feature is meant for media files and quality of life not software packages. You have to put this into context dont think aboslutely.
If one turns this on, turns on delete archives after extraction, you're pretty much effed anyway, then you wont care about skipping and renaming.

also it seems jd2 is using 7zip not unrar (anymore?).
Reply With Quote
  #14  
Old 06.02.2018, 10:14
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 71,520
Default

@NesteaZen: JDownloader is using 7zip since years now
__________________
JD-Dev & Server-Admin
Reply With Quote
  #15  
Old 07.02.2018, 16:32
netgearjd netgearjd is offline
Giga Loader
 
Join Date: Aug 2014
Posts: 92
Default

Quote:
Originally Posted by NesteaZen View Post
I have no idea why you guys are complicating this so much. This feature is meant for media files and quality of life not software packages.
There can be archives with duplicate media file names in sub-folders too, plus it makes no sense to think only of media file archives when adding the feature. Are people supposed to remember to turn on flat extraction only when they're downloading media file archives, and then turn it off for other archives?

IMO auto-rename should be the default for max. safety, so that even if delete archives after extraction is selected no files with the same names will be lost. Those users who don't care and want to live dangerously can change the setting to overwrite or skip and enjoy. Best of both worlds, and no-one can complain that they lost files because JD didn't provide an auto-rename option.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 21:19.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2021, Jelsoft Enterprises Ltd.