[fuknuckle]

so JD is using a filename scheme that often creates filenames that are so long that the file can't be downloaded unless they are manually trimmed and the Reddit plugin doesn't have options for customizing filenames. This is really annoying when often downloading entire subreddits or user profiles. I am surprised this hasn't already been addressed considering how many people use Reddit

one example is this post...

**External links are only visible to Support Staff****External links are only visible to Support Staff**

the filename on Reddit is p0ajhiy69o581.jpg

but JD includes the post title and makes it...

2021-12-15_EarthPorn - The River Lethe cuts a narrow canyon through the Valley of Ten Thousand Smokes in Katmai National Park, Alaska. [OC] [2048x1365] In 1912, Novarupta erupted for over 60 hours, was heard as far away as Fairbanks and Juneau, and filled the 40-square-mile valley with over 700 feet of ash..jpg

which will fail to download and give an "invalid directory" error.

I like having the date and subreddit info in the filename but not the post title. May I suggest a new default scheme that replaces the post title with the post ID and the actual hosted filename? so something like...

2021-12-15_EarthPorn_rguwyk_p0ajhiy69o581.jpg

by including both the post ID and original filename, it ensures that there can never be any conflicts even if the same image already hosted on Reddit is posted to different subs.

[Jiaz]

@fuknuckle: I agree
I will talk to pspzockerscene when he's back from his holidays

[fuknuckle]

@Jiaz

did you have a chance to talk to pspzockerscene yet?

[Jiaz]

@fuknuckle: he was in holidays all the time, he will return today/tomorrow

[pspzockerscene]

I've already stated in multiple threads that a "shorten filename" option for individual plugins is a waste of time if you ask me.
We have a ticket for this:

As explained in other threads (example), you can already shorten filenames using our Packagizer feature.
You could also easily use that mentioned feature to set "p0ajhiy69o581.jpg" as your preferred filename for your example.

I also disagree with the ticket Jiaz has created.
Filename customizations in form of plugin settings for reddit are not required.
I much prefer storing the available metadata on the downloadlinks so users can costomize filenames using Packagizer plugin-properties (see linked Packagizer article).

However I do agree that one simple setting to avoid such issues might make sense - in this case it would be something like "Prefer server filenames" to simply prefer "p0ajhiy69o581.jpg" instead of our current plugin naming scheme.

Originally Posted by fuknuckle

which will fail to download and give an "invalid directory" error.

Again this varies depending on the OS you're using.

Originally Posted by fuknuckle

I like having the date and subreddit info in the filename but not the post title. May I suggest a new default scheme that replaces the post title with the post ID and the actual hosted filename? so something like...

Already possible via Packagizer.
...or maybe we could find 1-2 more nice default naming scheme settings for the reddit plugin.

Originally Posted by fuknuckle

did you have a chance to talk to pspzockerscene yet?

Hello there I'am

-psp-

[fuknuckle]

Hello pspzockerscene. thanks for replying. hope you your holiday vacation was awesome.

Originally Posted by pspzockerscene

I've already stated in multiple threads that a "shorten filename" option for individual plugins is a waste of time if you ask me.
We have a ticket for this:

As explained in other threads (**External links are only visible to Support Staff**...), you can already shorten filenames using our **External links are only visible to Support Staff**....
You could also easily use that mentioned feature to set "p0ajhiy69o581.jpg" as your preferred filename for your example.

I kind of get your point but filename settings are not needed for most hosts/services/plugins outside of some niche cases I think

I have been using JD for about 10 years to download millions of many different files from many sources and in that time, issues arising from filenames being too long or having incompatible characters were rare.

off of the top of my head, I can only think of reddit and youtube being an issue although I am sure there were other hosts where too long filenames were a problem.

the problem with your solution is that it requires (if I understand you correctly) the user to know or understand regex or other forms of scripting syntax which I don't and I have tried for years to. The average user isn't going to know regex which is why I personally hate it.

Also with reddit specifically, just limiting filename length isn't a proper fix in my opinion although JD should have that as a global setting.

Originally Posted by pspzockerscene

Filename customizations in form of plugin settings for reddit are not required.
I much prefer storing the available metadata on the downloadlinks so users can costomize filenames using Packagizer plugin-properties (see linked Packagizer article).

I disagree and I'm not saying JD can't or shouldn't store that metadata to give other users more options or control if they want it. The issue here is just the default setting for reddit already creates issues with posts that have really long titles and that is what needs to be addressed.

Originally Posted by pspzockerscene

However I do agree that one simple setting to avoid such issues might make sense - in this case it would be something like "Prefer server filenames" to simply prefer "p0ajhiy69o581.jpg" instead of our current plugin naming scheme.

Shouldn't "Prefer server filenames" already be in the advanced settings as a global setting for all hosts/plugins along with a max filename character length setting? I've looked and can't find it if it is

Originally Posted by pspzockerscene

Again this varies depending on the OS you're using.

well most people are using windows so...

Originally Posted by pspzockerscene

...or maybe we could find 1-2 more nice default naming scheme settings for the reddit plugin.

That's all I'm asking for. that's all this post is about. The default filename setting for the reddit plugin are trash and need updating and some plugins like reddit do need plugin specific filename settings since filename issues/conflicts aren't a universal problem with every host or service JD supports. People who want finely tuned filename control and who can also understand regex and scripting syntax can always use JD's advanced features but your average user should have simpler settings in the plugins that need them like reddit.

For reddit, because it is such a huge and popular site, the default filename should include the subreddit, post ID and possibly the username. I can't tell you how many times I have tried finding the subreddit or user source for an image I saved from reddit years ago with only the default reddit server filename which is a huge pain in the ass.

[pspzockerscene]

Originally Posted by fuknuckle

the problem with your solution is that it requires (if I understand you correctly) the user to know or understand regex or other forms of scripting syntax which I don't and I have tried for years to.

Nope - only for parts of the Packagizer functionality, not for everything and not for using custom plugin properties to create custom filenames.

A custom syntax is even needed in other plugins for custom filenames...it's just much simpler (e.g. save.tv, soundcloud.com --> see plugin settings).

Originally Posted by fuknuckle

Shouldn't "Prefer server filenames" already be in the advanced settings as a global setting for all hosts/plugins along with a max filename character length setting? I've looked and can't find it if it is

No.

Originally Posted by fuknuckle

well most people are using windows so...

No.

Originally Posted by fuknuckle

The default filename setting for the reddit plugin are trash and need updating and some plugins like reddit do need plugin specific filename settings since filename issues/conflicts aren't a universal problem with every host or service JD supports.
...
For reddit, because it is such a huge and popular site, the default filename should include the subreddit, post ID and possibly the username. I can't tell you how many times I have tried finding the subreddit or user source for an image I saved from reddit years ago with only the default reddit server filename which is a huge pain in the ass.

I get your point.
I'll work on possible solutions once I find the time...

-psp-

[pspzockerscene]

I've added some settings for the next update:

New default setting is: Date + Subreddit + server internal filename

I've also added some plugin properties you can freely use in our Packagizer if you want to have filenames outside of my pre defined schemes:

• subreddit
• title
• username
• date
• index (e.g. position of image inside gallery)

For now, I haven't touched the package-names.
If you got suggestions for those, please let me know.

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!
---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

-psp-

[fuknuckle]

Originally Posted by pspzockerscene

I've added some settings for the next update:

New default setting is: Date + Subreddit + server internal filename

I've also added some plugin properties you can freely use in our **External links are only visible to Support Staff**... if you want to have filenames outside of my pre defined schemes:

• subreddit
• title
• username
• date
• index (e.g. position of image inside gallery)

For now, I haven't touched the package-names.
If you got suggestions for those, please let me know.

AWESOME!

The only thing that is missing is Post ID. In my example post it would be "rguwyk". this can be helpful in quickly going to the exact post the image came from.

as for package names, I don't really think that needs to change as a default except for a character limit so on posts with long titles, the images won't fail to download. I am assuming we will be able to use the new packagizer rules for the folder as well

[pspzockerscene]

Originally Posted by fuknuckle

The only thing that is missing is Post ID. In my example post it would be "rguwyk". this can be helpful in quickly going to the exact post the image came from.

See changes for the next update mentioned at the end of this post.

Originally Posted by fuknuckle

as for package names, I don't really think that needs to change as a default except for a character limi[...]

This! A lot of users (including me) are using the "Subfolder by packagename" option thus even with the new default filenames the initial issue will still happen.
I've added another setting for packagenames and new default packagenames (see changes listed below).


Reddit plugin changes for the next update:

• new packagizer properties: slug and postid
• new default (shorter) packagename: date + subreddit + postID + slug
• added packagename setting
• included post-ID into existing filename schemes
• image galleries: set caption as comment if existent

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!
---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

-psp-

[fuknuckle]

so the reddit plugin doesn't appear in the list of plugins. when I type "red" or "reddit" the only plugin it points me to is redbull.tv

I did a search in the JD directory just to make sure they exist and they do.

https://i.imgur.com/5IV9IE7.png

my JD is updated to the latest version.

This is really annoying because some of the reddit hosted images have too long filenames and you guys recently added options for that to the plugin but JD is for whatever reason not loading/seeing this plugin and has reverted to the old behavior of using post titles in the filenames.

14.02.22 19.13.06 <--> 14.02.22 19.14.35 jdlog://2135925302851/

[pspzockerscene]

@fuknuckle
The answer is easy:
1. The list of plugins in plugin settings only contains those which acrtually have settings.
2. The reddit.com plugin did not have any settings before my proposed changes in this thread.
Those changes haven't been released yet (see thread prefix).

Please waiot for the update and/or use Packagizer rules to modify "too long" filenames in the meanwhile.

Bitte auf das nächste CORE-Update warten!

Please wait for the next CORE-Update!

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!
---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

-psp-

[pspzockerscene]

CORE-Updates have been released!
Please update your JDownloader and report any issues you find asap.

CCORE-Updates wurden released!
Bitte JDownloader updaten und eventuelle Bugs schnellstmöglich an uns melden.

-psp-