JDownloader Community - Appwork GmbH
 

Notices

Reply
 
Thread Tools Display Modes
  #1  
Old 18.04.2018, 02:16
vanx vanx is offline
Junior Loader
 
Join Date: May 2012
Posts: 13
Default Plus in file names is dropped

Hello,

When using JD to download a file that has a plus (+) in the file name, the end result is a file with a space instead of the plus.

Windows supports pluses, so why does JD drop it?

Cheers
Reply With Quote
  #2  
Old 18.04.2018, 09:49
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

Please provide example links. + is a sign that must be correct encoded because
URLDecode("+") = " "
URLDecode("%2b" = "+"
__________________
JD-Dev & Server-Admin
Reply With Quote
  #3  
Old 18.04.2018, 09:50
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

__________________
JD-Dev & Server-Admin
Reply With Quote
  #4  
Old 05.05.2018, 23:53
vanx vanx is offline
Junior Loader
 
Join Date: May 2012
Posts: 13
Default

The links in question are non-public, so I cannot provide those specific examples.

However, when I mouse over such files, it shows a plus in the browser bar.

Also, when I use right click and Save As in Chrome, the downloaded file does have a "+" in it as expected.
Reply With Quote
  #5  
Old 07.05.2018, 15:13
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

Can you provide logs ? Enable Debug Mode in Settings-Advanced Settings-Log.debugmodeenabled and restart JDownloader. Download the file and create a log, https://support.jdownloader.org/Know...d-session-logs and post shown logID here.

I need either log or example links as filenames can be parsed from headers and urls and both can have different encodings.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #6  
Old 01.06.2018, 00:09
vanx vanx is offline
Junior Loader
 
Join Date: May 2012
Posts: 13
Default

jdlog://0030954433151/
Reply With Quote
  #7  
Old 01.06.2018, 19:48
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

Thanks, I will try to fix that as soon as possible
__________________
JD-Dev & Server-Admin
Reply With Quote
  #8  
Old 05.09.2018, 02:23
vanx vanx is offline
Junior Loader
 
Join Date: May 2012
Posts: 13
Default

Quote:
Originally Posted by Jiaz View Post
Thanks, I will try to fix that as soon as possible
It's been a while but no fix. Any news?
Reply With Quote
  #9  
Old 05.09.2018, 19:23
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

I just started working on this but need more time with testing.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #10  
Old 23.01.2019, 18:19
vanx vanx is offline
Junior Loader
 
Join Date: May 2012
Posts: 13
Default

Quote:
Originally Posted by Jiaz View Post
I just started working on this but need more time with testing.
Any idea when this will be fixed? Within a couple of months, it'll be a year since the bug was reported.
Reply With Quote
  #11  
Old 23.01.2019, 19:31
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

I did lot of work in this and in my tests it is working fine. can you please provide fresh log? or example links?
It still might be plugin specific (as those can special handling filename and encoding) or some special case I haven't tested before
__________________
JD-Dev & Server-Admin
Reply With Quote
  #12  
Old 06.04.2019, 19:03
vanx vanx is offline
Junior Loader
 
Join Date: May 2012
Posts: 13
Default

Here you go:

06.04.19 11.46.31 <--> 06.04.19 12.03.24 jdlog://3697776935451/
Reply With Quote
  #13  
Old 09.04.2019, 17:55
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

Thanks for the logs. I could setup my testserver in same way and now able to reproduce the issue. Will fix it as soon as I find time
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 02:30.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.