JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 18.06.2020, 17:50
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 186
Default gfycat.com: Add support for redgifs and gifdeliverynetwork

gfycat added two domains redgifs.com and gifdeliverynetwork.com and a lot of gfycat videos now redirect to them
For e.g. -
**External links are only visible to Support Staff****External links are only visible to Support Staff**
redirects to -
**External links are only visible to Support Staff****External links are only visible to Support Staff**
which is the same as -
**External links are only visible to Support Staff****External links are only visible to Support Staff**

So, can you please add support for these two domains. And also support adding gfycat urls which redirect to them.
Reply With Quote
  #2  
Old 18.06.2020, 23:16
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 54,876
Default

Hi,

done.

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!


-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #3  
Old 19.06.2020, 08:16
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 186
Default

Hello,
Can you please tell me if the update has been released? Because my installation of jdownloader2 does not show any updates (and the links in the first post do not work.)
Reply With Quote
  #4  
Old 19.06.2020, 09:06
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,205
Default

updates for plugins are silent, and download and install without any interaction. It will just work, so give it a try. If not updates might not be pushed out live but is pending core update (core updates can block plugin updates from going live)
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #5  
Old 19.06.2020, 09:16
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 186
Default

It does not work, so I assuming it's waiting for core update.

Anyways, @pspzockerscene, can you add a quality selector option to the gfycat+redgifs+gifdeliverynetwork plugin? AFAIK, the same url has *.webm format, *.mp4 format, and *-mobile.mp4 format, with the mp4 video being the highest quality.

So, I would like an option in the plugin that allows me to default to the mp4 videos always, if available, otherwise webm.
Reply With Quote
  #6  
Old 19.06.2020, 09:21
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 186
Default

Actually, I am not sure if mp4 is higher quality than webm for all videos. But, the videos have an HD option. So, maybe jdownloader2 can figure out which is the higher quality version and always prefer that?
Reply With Quote
  #7  
Old 19.06.2020, 13:12
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 54,876
Default

Quote:
Originally Posted by plaintext View Post
It does not work, so I assuming it's waiting for core update.
Exactly.
Next time please read the linked FAQs - it should have explained that already.
I've also updated it - please let me know if it's better now.

Quote:
Originally Posted by plaintext View Post
Anyways, @pspzockerscene, can you add a quality selector option to the gfycat+redgifs+gifdeliverynetwork plugin? AFAIK, the same url has *.webm format, *.mp4 format, and *-mobile.mp4 format, with the mp4 video being the highest quality.

So, I would like an option in the plugin that allows me to default to the mp4 videos always, if available, otherwise webm.
Done.

I've added a simple format quality selection for the NEXT update.
I've also updated the filenames which now also contain the date when the content was uploaded.
From what I've found out on my tests, highest quality .webm and .mp4 are exactly the same.



Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!


-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #8  
Old 19.06.2020, 16:47
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 186
Default

Okay thank you. One last question/request - does the plugin consider these two urls equivalent -
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
?
(These urls only for demonstration purposes, check first post if you want actual url)
If not, can you please make the plugin consider them same for de-duplication purposes. I don't want to accidentally download two copies of the same video if I have both these equivalent urls.
Reply With Quote
  #9  
Old 22.06.2020, 12:47
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 54,876
Default

Yes, de-duplication is already ensured

Updates are still pending ...

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #10  
Old 27.06.2020, 14:18
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 186
Default

Hello, I build jdownloader from svn to try this. Can you please make it so that once a gfycat url redirects to either of redgifs or gifdeliverynetwork, the url in jdownloader itself gets updated to it.
Because right now, the main url remains gfycat and everytime the download is started, it fetches the gfycat url then the redirected url and from where it parses the download url. This made gfycat (probably) ban my ip for some time.
Storing the redirected url in jdownloader itself will make reduce the number of requests make to gfycat which will be better for both gfycat and jdownloader users.
Reply With Quote
  #11  
Old 12.07.2020, 20:49
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 186
Default

Quote:
Originally Posted by pspzockerscene View Post
Exactly.
I've added a simple format quality selection for the NEXT update.
I've also updated the filenames which now also contain the date when the content was uploaded.
These changes seem to cause some problems:
  • With format set to webm, the downloaded files appear to be the mp4 files with only the file extension renamed to webm instead of the actual webm files.
  • Adding multiple links from the same author of the same day lacking individually given titles on gfycat, all get renamed to the same new title of the new title format.
  • Trying to download a package full of these same-name files results in only one downloaded file, with all other links apparently discarded into the nether.
  • Re-adding the links and downloading with the previous file already existing in the download folder promts the "duplicate name" options - choosing to rename and apply that selection for the package only results in one additional file being renamed & downloaded, all other links are again discarded.
Reply With Quote
  #12  
Old 13.07.2020, 12:23
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 54,876
Default

Hi again,

1. Please post example URLs.
2. Please post example URLs.
3. Caused by 2.
4. Caused by 2.

-psp-
EDIT

I've fixed the .webm bug.


Regarding the redirects:
What exactly do you mean?
Do you expect JD to change the URLs you add according to where they redirect to so that when you copy them out of JD again, you got the "correct" one right away?
JD itself does e.g. change "gifdeliverynetwork.com" to "redgibs.com" right away to avoid unnecessary redirects.
I'm sorry if I failed to understand what you mean - in this case, please explain again.
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist

Last edited by pspzockerscene; 13.07.2020 at 14:13.
Reply With Quote
  #13  
Old 18.07.2020, 08:02
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 186
Default

I am not the guy who posted this https://board.jdownloader.org/showpo...5&postcount=11 so i can't say anything regarding that.

But regarding https://board.jdownloader.org/showpo...0&postcount=10 and
> JD itself does e.g. change "gifdeliverynetwork.com" to "redgibs.com" right away to avoid unnecessary redirects.
I meant gfycat.com redirecting to gifdeliverynetwork/redgifs. Because when I used jdownloader built from svn, I saw the logs in the output panel of eclipse according to which - If i start a download which redirects from gfycat to gdn/redgifs, then on first attempt it should store the redirected url. But instead if I pause and start the download again, it was resending the request to gfycat and then redirecting again.

I don't remember exactly but I think this was what I was talking about then.
Reply With Quote
  #14  
Old 20.07.2020, 18:34
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 54,876
Default

I'm not really able to recreate this redirect.
Sure we can store- and re-use direct URLs but not all of our plugins are doing this.

If you have an example URL which can be used to recreate this I'am more than willing to improve our plugin to re-use these direct-URLs in order to be faster and avoid unnecessary http requests.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 17:32.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.