JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 17.09.2024, 15:50
svArtist's Avatar
svArtist svArtist is offline
DSL User
 
Join Date: Mar 2015
Posts: 39
Exclamation Weird parsing in LinkGrabber breaks URL

Example URL: **External links are only visible to Support Staff****External links are only visible to Support Staff**
Somehow gets turned into **External links are only visible to Support Staff****External links are only visible to Support Staff**

Why, and please make it stop 😅
Reply With Quote
  #2  
Old 17.09.2024, 16:07
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 81,272
Default

Ah, you're talking about the 2nd found url with info.txt, right?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #3  
Old 17.09.2024, 16:15
svArtist's Avatar
svArtist svArtist is offline
DSL User
 
Join Date: Mar 2015
Posts: 39
Default

Yes, JD seems to only check and try to download that URL
Reply With Quote
  #4  
Old 17.09.2024, 16:39
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 81,272
Default

How do you add the URL?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #5  
Old 17.09.2024, 16:41
svArtist's Avatar
svArtist svArtist is offline
DSL User
 
Join Date: Mar 2015
Posts: 39
Default

As plain text in the clipboard
Reply With Quote
  #6  
Old 17.09.2024, 19:18
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 81,272
Default

Working on it. Issue is caused by "finding embedded URLs" and
Quote:
info.txt#package=testName;filename=# info.txt
found as valid URL as it can be parsed into correct/valid URL. Trying to find better condition for this
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 17.09.2024, 19:25
svArtist's Avatar
svArtist svArtist is offline
DSL User
 
Join Date: Mar 2015
Posts: 39
Default

Quote:
Originally Posted by Jiaz View Post
Working on it. Issue is caused by "finding embedded URLs" and
found as valid URL as it can be parsed into correct/valid URL. Trying to find better condition for this
That's what I thought. It's a tough one when we don't know if the desired URL is somewhere in there or the whole thing 😅
In this case I'd say "stop parsing, you already have a valid URL", but I can imagine that it might not be as clear cut in the general case.

Thank you for looking into this 🙌
Reply With Quote
  #8  
Old 17.09.2024, 19:32
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 81,272
Default

Update will be released by tomorrow. I've updated decision on what embedded URL looks legit
__________________
JD-Dev & Server-Admin
Reply With Quote
  #9  
Old 17.09.2024, 19:33
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 81,272
Default

Quote:
Originally Posted by svArtist View Post
In this case I'd say "stop parsing, you already have a valid URL", but I can imagine that it might not be as clear cut in the general case.
There might be an expired/no longer working complete URL with still working/valid URL as part of it thus the handling checks for embedded URLs and only proceeds with normal/full URL in case the embedded one cannot be handled. But in this case it is found as valid due to .txt is known as valid file extension and thus picked up by generic http plugin.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #10  
Old 17.09.2024, 19:50
svArtist's Avatar
svArtist svArtist is offline
DSL User
 
Join Date: Mar 2015
Posts: 39
Default

Quote:
Originally Posted by Jiaz View Post
Update will be released by tomorrow. I've updated decision on what embedded URL looks legit
🤩 amazing! 🥳
Quote:
Originally Posted by Jiaz View Post
There might be an expired/no longer working complete URL with still working/valid URL as part of it thus the handling checks for embedded URLs and only proceeds with normal/full URL in case the embedded one cannot be handled. But in this case it is found as valid due to .txt is known as valid file extension and thus picked up by generic http plugin.
Yeees 🤓 that makes sense

Thank you for your help and insight!
Reply With Quote
  #11  
Old 24.09.2024, 20:16
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 73,475
Default

CORE-Updates have been released!
All announced bugfixes and features are live!
Please update your JDownloader and report any issues you find asap.
If this thread gets marked as "[Solved]" by our forum staff you can still post in it and we will read- and reply to it!

CORE-Updates wurden released!
Alle angekündigten Bugfixes/Features sind nun verfügbar!
Bitte JDownloader updaten und eventuelle Bugs schnellstmöglich an uns melden.
Falls dieser Thread vom Team als "[Erledigt]" markiert wird, kannst du weiterhin darin antworten und wir lesen/beantworten auch solche Threads!

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 15:12.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.