JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 12.01.2019, 08:16
Luke M Luke M is offline
Wind Gust
 
Join Date: May 2012
Posts: 44
Default Archive (HJ_SPLIT) required file count reduced by plugin rename

When a plugin renames a file, this can cause the archive (HJ_SPLIT) required file count to be reduced from (for example) 3 to 2. This causes extraction to mysteriously fail.

Example: with solidfiles.com, spaces are replaced by underscores. So "test 1.zip.001" becomes "test_1.zip.001" when the download starts. If all parts are downloaded at the same time, there's no problem. The problem occurs when only the first two parts are started.

My workaround is to pre-rename the files:
Code:
// Description: Replaces spaces with underscores in filenames
// Event Trigger: Packagizer Hook

if (/.*solidfiles\.com.*/.test(link.getURL())) {
    link.setName(link.name.replace(/ /g, "_"));
}

Last edited by Luke M; 12.01.2019 at 10:05.
Reply With Quote
  #2  
Old 12.01.2019, 08:44
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 15,981
Default

Thanks for your report! Plugins have the ability specify filename character which get renamed by provider, this allows mirror handling within JD to work correctly and subsequently extraction. By the quick look solidfiles plugin lacks this currently
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]

Last edited by raztoki; 12.01.2019 at 08:47.
Reply With Quote
  #3  
Old 22.01.2019, 12:29
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 60,380
Default

Can you please provide some example links/archives. Then I will take a look at it
__________________
JD-Dev & Server-Admin
Reply With Quote
  #4  
Old 22.01.2019, 16:45
Luke M Luke M is offline
Wind Gust
 
Join Date: May 2012
Posts: 44
Default

Quote:
Originally Posted by Jiaz View Post
Can you please provide some example links/archives. Then I will take a look at it
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
Reply With Quote
  #5  
Old 22.01.2019, 19:41
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 60,380
Default

I've updated plugin. Wait for next plugin update. In case you encounter other sites, just let us know and provide examples
__________________
JD-Dev & Server-Admin
Reply With Quote
  #6  
Old 22.01.2019, 19:44
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 60,380
Default

It's not easy to handle this in generic solution so it's better to try to update/handle it in plugin itself.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #7  
Old 22.01.2019, 20:16
Luke M Luke M is offline
Wind Gust
 
Join Date: May 2012
Posts: 44
Default

Ok, thanks!
Reply With Quote
  #8  
Old 22.01.2019, 20:23
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 60,380
Default

Update is already available
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 09:15.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.