JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 26.11.2020, 08:54
HydroLogic HydroLogic is offline
Super Loader
 
Join Date: Sep 2019
Posts: 26
Exclamation redgifs.com JDownloader not renaming properly

JDownloader is apparently not renaming properly in a certain condition.

Example links (NSFW):
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**

All of these links will be named the exact same thing. Even though the last few are from a completely different day, they still get the same date. :\ That might be a separate issue?

But one thing is for sure, all the ones from November 6th, are all labeled the same and when downloading, JDownloader will *not* rename them.

Instead I get this:
https://i.imgur.com/dHOZCFa.png

JDownloader seems to think they're all the same. You can check the links yourself and see that they are clearly *not* the same. And only the very first link gets downloaded.

EDIT: If I download them manually by clicking on them one by one, renaming works fine. But if I download them in bulk, the situation described above happens.

Last edited by HydroLogic; 26.11.2020 at 10:06.
Reply With Quote
  #2  
Old 26.11.2020, 14:05
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 55,297
Default

Hi,
seems like that "title" can be set independantly from the "title inside the URL" you're adding.
Just open two of your URLs and search their HTML code for:
Code:
"headline"
or also:
Code:
"name":"fullsize
This is where JD grabs the file-titles from.

I've updated our plugin to include both - thetitle inside the URL and this other title/headline to make sure that different files get different titles.
If you got a better suggestion, go ahead and let me know.

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!


-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist

Last edited by pspzockerscene; 26.11.2020 at 14:58. Reason: Replaced "source code" with "their HTML code"
Reply With Quote
  #3  
Old 26.11.2020, 14:29
HydroLogic HydroLogic is offline
Super Loader
 
Join Date: Sep 2019
Posts: 26
Default

I think the main problem is that JDownloader fails to rename properly when bulk downloading. It's not a specifically redgifs.com issue.
Reply With Quote
  #4  
Old 26.11.2020, 14:38
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 55,297
Default

Quote:
Originally Posted by HydroLogic View Post
I think the main problem is that JDownloader fails to rename properly when bulk downloading.
No.

Quote:
Originally Posted by HydroLogic View Post
It's not a specifically redgifs.com issue.
Yes it is.
I've even included ways for you to check what I wrote in my post.

You can either wait for the next update or let JD auto-rename such redgifs.com items via Packagizer rule until the next CORE-update gets released.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #5  
Old 26.11.2020, 14:43
HydroLogic HydroLogic is offline
Super Loader
 
Join Date: Sep 2019
Posts: 26
Default

Try it yourself.

1. Put all those links in JDownloader.
Ctrl-A ---> Download
You will get this:https://i.imgur.com/dHOZCFa.png

2. Put all those links in JDownloader.
Manually download them one by one. Right click, download. Right click, download.
JDownloader will now rename correctly.

Something is wrong with bulk downloading...
Reply With Quote
  #6  
Old 26.11.2020, 14:54
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 55,297
Default

1. Yes.
2. I'm unable to reproduce this but I know what you mean.
I've additionally defined an internal Mirror-ID so JD knows for sure that these aren't mirrors.
Either way it won't happen anymore after the next update - the content of my last post stays the same:
Quote:
Originally Posted by pspzockerscene View Post
You can either wait for the next update or let JD auto-rename such redgifs.com items via Packagizer rule until the next CORE-update gets released.
-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #7  
Old 26.11.2020, 15:11
HydroLogic HydroLogic is offline
Super Loader
 
Join Date: Sep 2019
Posts: 26
Default

I know I've had #1 happen to me on YouTube as well. So I know it's not just redgifs.com. I will update when I find suitable links.

As for #2, do you have "If the file already exists" in General settings set to "Auto rename"? That's what I have and it renames perfectly if I manually download one by one.
Reply With Quote
  #8  
Old 26.11.2020, 15:28
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 55,297
Default

Quote:
Originally Posted by HydroLogic View Post
I know I've had #1 happen to me on YouTube as well. So I know it's not just redgifs.com. I will update when I find suitable links.
Yes please do that.
We either need a log or the ability to reproduce your issue.

Quote:
Originally Posted by HydroLogic View Post
As for #2, do you have "If the file already exists" in General settings set to "Auto rename"? That's what I have and it renames perfectly if I manually download one by one.
I had it set to rename to mimic your situation.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #9  
Old 26.11.2020, 17:30
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 68,457
Default

@HydroLogic:
Your screenshot shows "Finished Mirror" and that happens when JDownloader detects the links as mirrors.

The situation is as follow, the filename were all the same and the filesize was not marked as safe/verified but just known, so JDownloader will NOT use that filesize for mirror detection.
So, all filenames are same -> mirrors. With next plugin update, filesizes are marked as safe

You can change the mirror detection via Settings->Advanced Settings->
GeneralSettings.mirrordetectiondecision (can change on what information the mirror check is decided on)
and
GeneralSettings.forcemirrordetectionfilesizecheck (enforce JD to check safe/verified file size)

Please know that enforcing filesize check can result in Captcha->Mirror detection. Before the safe/verified filesize/name
is not available, so download has to be processed (try to download, so wait time, captcha...) until those details are available.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #10  
Old 26.11.2020, 17:59
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 68,457
Default

I've updated filename handling and remove the "..GIF by..." part
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 00:47.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.