Delete comment & password after extraction

Hello, I ever asked this on chat with mgpai but I think I asked it wrong and our chat ending without resolve this.

So what I asked is JDownloader2 delete comment and password after file extracted (with auto extraction) (for that package only or other package who successfully extracted)

So far mgpai script (with my costume script) has failed

getAllDownloadLinks().forEach(function(link) {
    if (link.getExtractionStatus == true) {
        if (link.getProperty("pass")) link.setProperty("pass", "");
        if (link.getComment()) link.setComment("");
    }
})

I kinda confuse because lack of logic & variable.
In "package finished" triger, system can automaticly get package name. But in "archieve extraction finished" triger, system cannot get package name. I think I can transfer package name, but I don't know how use it.

[thecoder2012]

Originally Posted by Bunga

So far mgpai script (with my costume script) has failed

But it works without trigger? Says mgpai with the Original script.

Originally Posted by Bunga

I kinda confuse because lack of logic & variable.
In "package finished" triger, system can automaticly get package name. But in "archieve extraction finished" triger, system cannot get package name. I think I can transfer package name, but I don't know how use it.

See this thread

var packageName = archive.getDownloadLinks()[0].getPackage().getName();

With try and catch it's thinkable or with the save system (setProperty/getProperty with global flag) and two triggers (e.g. extraction finished, interval)

[raztoki]

bit of information if your unaware
'pass' DownloadLink property purpose is for pre-download password requirement.
the extract module does utilise for extraction also, more so as a failover.

extraction has its own stored field and is called archive.getSettings().getPasswords(); within ExtractionController.run().

raztoki

[thecoder2012]

I have tested your script and link.getExtractionStatus() has not "true" or "false", only a string like "SUCCESSFUL" in my tests with your trigger "Archive extraction finished".

Originally Posted by raztoki

bit of information if your unaware
'pass' DownloadLink property purpose is for pre-download password requirement.

Yes.

Originally Posted by raztoki

the extract module does utilise for extraction also, more so as a failover.

FinalPassword is not removable (empty string or null) and can only be overwritten with the callapi in my tests.

Example:

// Remove passwords and comments
// Trigger "Archive extraction finished"
archive.getDownloadLinks().forEach(function(link) {
    if (link.getExtractionStatus() == "SUCCESSFUL") {
        if (link.getProperty("pass")) link.setProperty("pass", "");
        if (link.getComment()) link.setComment("");
        var linkId = link.UUID;
        var archiveId = callAPI("extraction", "getArchiveInfo", [linkId], [])[0].archiveId;

        callAPI("extraction", "setArchiveSettings", "" + archiveId, {
            "archiveId": "" + archiveId,
            "passwords": [""],
            "finalPassword": "REMOVED"
        });
    }
});

Originally Posted by raztoki

extraction has its own stored field and is called archive.getSettings().getPasswords(); within ExtractionController.run().

In the JD source code, yes. Without "getSettings" in the Event Scripter says the help page.
Example myArchive.setPasswords([""]); like my script "GPU Password detection" or the way with getInfo like Get Archive Password (Downloads) (Downloads/Contextmenu).

/* =============== Classes =============== */
/* === Archive === */
/* =========  Methods =========*/
var myBoolean = myArchive.equals(myObject);
var myString = myArchive.getArchiveType();
var myDownloadLink[] = myArchive.getDownloadLinks();
var myString = myArchive.getExtractToFolder();
var myFilePath[] = myArchive.getExtractedFilePaths();
var myString[] = myArchive.getExtractedFiles();
var myString = myArchive.getExtractionLog();
var myString = myArchive.getFolder();
var myObject = myArchive.getInfo();
var myString = myArchive.getName();
var myList = myArchive.getPasswords();
var myString = myArchive.getUsedPassword();
var myInt = myArchive.hashCode();
var myBoolean = myArchive.isPasswordProtected();
myArchive.setPasswords(myList);