[Jiaz]

Update: i got new api specs from fileserve, will add it as soon as possible

Great you are working on it. But i cant understand this, they say we can use fileserve manager but that keeps coming up with errors like jdownloader sometimes do also.

Very frustrating.

Thanks Jiaz for the hard work.

Originally Posted by zixer92

they say we can use fileserve manager but that keeps coming up with errors...

That's their problem, not jD's.

Jiaz - any idea when the update will be posted


Thanks in advance

Mark

In http://board.jdownloader.org/showthr...t=30858&page=5 you'll find :-

Originally Posted by grambax

Any idea how long we are talking about until jdownloader is updated? Hours? Days?

Originally Posted by Jiaz

i will do it today

Jiaz is working during the WE for you!

I say to hell with their API. Who's to say they won't have similiar problems in the future? I got tired of waiting for FileServe to fix their issues, so I modified the current FileServe plugin to not use the API. I'm currently downloading without any problems.

Screenshot:

**External links are only visible to Support Staff**Full-Size Screenshow

;)

If I were a JD dev, I'd modify the plugin to work with the API first...then without it as a fail-safe. But I don't really have the time to commit.

Thanks for your great commitment to jD, but I can also produce such a screen-shot.

Lol....for what it's worth, the screenshot isn't fake. I wouldn't waste my time with such a thing. As proof, my changes to the FileServe hoster plugin are below.....

Added string:

    private static final String COOKIE_HOST = "**External links are only visible to Support Staff**;

Custom login method...because I didn't want to change or remove the loginAPI method:

    private void login(final Browser useBr, final Account account) throws Exception {
        Browser br = useBr;
        if (br == null) br = new Browser();
        this.setBrowserExclusive();
        br.getPage(COOKIE_HOST + "/index.php");
        Form loginform = br.getForm(1);
        if (loginform == null) throw new PluginException(LinkStatus.ERROR_PLUGIN_DEFECT);
        loginform.put("loginUserName", Encoding.urlEncode(account.getUser()));
        loginform.put("loginUserPassword", Encoding.urlEncode(account.getPass()));
        br.submitForm(loginform);
        br.getPage(COOKIE_HOST + "/dashboard.php");
        if (!br.containsHTML("Login Name")) throw new PluginException(LinkStatus.ERROR_PREMIUM, PluginException.VALUE_ID_PREMIUM_DISABLE);
        if (br.getCookie(COOKIE_HOST, "cookie") == null)
            throw new PluginException(LinkStatus.ERROR_PREMIUM, PluginException.VALUE_ID_PREMIUM_DISABLE);
        else
            return;
    }

Modified handlePremium method:

    public void handlePremium(final DownloadLink link, final Account account) throws Exception {
        this.requestFileInformation(link);
        this.login(br, account);
        br.setFollowRedirects(false);
        br.getPage(link.getDownloadURL());
        String dllink = br.getRedirectLocation();
        this.dl = jd.plugins.BrowserAdapter.openDownload(this.br, link, dllink, true, 0);
        if (this.dl.getConnection().getResponseCode() == 404) {
            this.br.followConnection();
            throw new PluginException(LinkStatus.ERROR_FILE_NOT_FOUND);
        }
        if (this.dl.getConnection().getContentType().contains("html")) {
            this.br.followConnection();
            if (this.dl.getConnection().getLongContentLength() == 0) { throw new PluginException(LinkStatus.ERROR_FILE_NOT_FOUND); }
            this.handleErrors(br);
            throw new PluginException(LinkStatus.ERROR_PLUGIN_DEFECT);
        }
        if (link.getFinalFileName() == null) {
            /* workaround for buggy server response, see #3545 */
            String name = Plugin.getFileNameFromHeader(dl.getConnection());
            if (name != null) {
                name = name.replaceAll("\\%\\%", "%25%");
                name = Encoding.htmlDecode(name);
                link.setFinalFileName(name);
            }
        }
        this.dl.startDownload();
    }

Modified fetchAccountInfo method:

    @Override
    public AccountInfo fetchAccountInfo(final Account account) throws Exception {
        final AccountInfo ai = new AccountInfo();
        try {
            login(br, account);
        } catch (PluginException e) {
            account.setValid(false);
            return ai;
        }
        String expire = br.getRegex("Premium Until<\\/h4><\\/th>.*?<td><h5>(.*?)<\\/h5").getMatch(0);
        String type = br.getRegex("Account Type<\\/h4><\\/td> <td><h5 class\\=\\\"inline\\\">(.*?) <\\/h5").getMatch(0);
        account.setValid(true);
        if (type != null) ai.setStatus(type);
        if (!"Premium".equals(type)) {
            try {
                account.setMaxSimultanDownloads(1);
            } catch (final Throwable e) {
                /* not available in 0.9xxx */
            }
            account.setProperty("type", "free");
            account.setValid(false);
        } else {
            if (expire == null) {
                ai.setExpired(true);
                account.setValid(false);
                return ai;
            } else {
                ai.setValidUntil(TimeFormatter.getMilliSeconds(expire, "dd MMMM yyyy zzz", null));
                ai.setStatus("Premium User");
                return ai;
            }
        }
        return ai;
    }

As you can see, I did away with the API in my customization. Instead, I used the built-in browser. Also, as a plus, with these customizations, the loginAPI, getShorten, getDirectLink, parse, and decrypt methods could all be removed.

[editestowy]

But everytime they change anything in their page: i.e. "Login Name" -> "User Name" - the plugin requires rewriting.
This is why using API is independent from whatever they change in layout of the pages and should not care about what they are changing in their internal soft - 3rd party app calls specified API functions and expects specified response.
But the fileserve moroons instead of adding new API functions changed specification of the existing API - this is why 3rd party apps stopped to work. They made it (and probably started to test it) on living organism - even their own tool stopped to work with Premium accounts.
They do not care about customers because they exactly knew how many of them are using jD and didn't warn jD developers before applying the new API specification.

While that is understandable completely, I made those specific strings as a quick fix to work right now. More permanent strings could be used to check logins and expiration and such. Plus, that's also why I made the suggestion to modify the plugin to try the API first, and if that fails, then go ahead without it. That way, at least the plugin would work even if the FileServe API isn't.

Can someone explain this how to solve this FileServe issue???
I have no clue about JAVA. Can someone explain this what changes needs to be done??

Thanks in advance...

[editestowy]

@PutterPlace
I have nothing against your idea and I think it's good backup method for situation like this.

I simply made the statement that fileserve guys completely fu...ed up the rules of good programming.
Imagine that Microsoft changed completely their DirectX API, put the changes in their monthly updates and millions of games (and other apps) stopped to working? This will probably lead to mass riot.

I can understand the changes sometimes are needed but fileserve made them unprofessionally and completely ignoring many customers. At least for the period they were making the changes - the old specification should work to give the 3rd party developers required time for changing their apps without stopping them to work.

When you change something so touchy, in a true profesional business I mean, you make lots of tests BEFORE applying your changes. Even their own download manager was affected !

Originally Posted by editestowy

@PutterPlace
I have nothing against your idea and I think it's good backup method for situation like this.

I simply made the statement that fileserve guys completely fu...ed up the rules of good programming.
Imagine that Microsoft changed completely their DirectX API, put the changes in their monthly updates and millions of games (and other apps) stopped to working? This will probably lead to mass riot.

I can understand the changes sometimes are needed but fileserve made them unprofessionally and completely ignoring many customers. At least for the period they were making the changes - the old specification should work to give the 3rd party developers required time for changing their apps without stopping them to work.

I understand. I was just saying. In no way would my method be a good replacement simply because of the fact that the search strings are so precise, and could change at any given moment. But yea....they did mess up pretty royally by taking their API down like that. It's like live-testing a web site....bad for business to put it simply.

Originally Posted by lionelboy

When you change something so touchy, in a true profesional business I mean, you make lots of tests BEFORE applying your changes. Even their own download manager was affected !

I agree....there was no reason for them to make such drastic changes to live code, and have it down for so long to the point that even their own products wouldn't work properly.

Originally Posted by MrT69

Can someone explain this how to solve this FileServe issue???
I have no clue about JAVA. Can someone explain this what changes needs to be done??

Thanks in advance...

Jiaz is on it....just wait for the update.

[pspzockerscene]

@PutterPlace
We KNOW what we're doing and it is NOT up to us to FIX mistakes of hosters or to make workarounds for those.
If there is an API we trust it 100% and if it fails it's up to our users to contact the hosters support and ask why it doesn't work!

GreeZ pspzockerscene
EDIT

Closed till we have news!

[Jiaz]

thanks to PutterPlace for his help. the official api i got from fileserve.....i dont find any words for it.....
wait for plugin update then it will work again

many thanks for sorting this much appreciated

mark

Originally Posted by Jiaz

thanks to PutterPlace for his help. the official api i got from fileserve.....i dont find any words for it.....
wait for plugin update then it will work again

Very welcome, I'll help out where I can.

hi,
i cant use jdownloader for fileserve links for 2-3 days, my premium account did not expire yet.. in "status" part of my account in premium section it's written "ServerError, will try later", is there a general problem?