[Dockel]

A script that removed all of the (really) empty folders (without a single file, even a 0 byte file) in the default download folder each time when closing / restarting JD would be good.

After some time there are pretty many folders in the default download folder, so it would be good / clearer removing them.

https://board.jdownloader.org/showth...191#post544191

[mgpai]

/*
    delete empty folders
    trigger : jdownloader started
*/

var downloadFolder = callAPI(
    "config", "get",
    "org.jdownloader.settings.GeneralSettings", null,
    "DefaultDownloadFolder"
)

getPath(downloadFolder).children.forEach(function(item) {
    item.directory && item.delete();
})

[Dockel]

Very fast, thank you very, very much!

[Dockel]

Sorry, I cannot get it working, what is wrong here:

Spoiler:

So there is no folder removed.

[mgpai]

To test the script, create an empty folder in the JD default download directory, then click 'test run' in the script top panel, and see if that folder you created is removed.

[Dockel]

OK, thank you, nothing is removed.

[Jiaz]

@Dockel: how do you test it? click the *Test Run" button.
Script will look look into default download folder (from your settings) and only delete empty folders

[Dockel]

click the *Test Run" button.

Yes, I did. The button on the screenshot above.

[pspzockerscene]

Here is my assumption on what's going on:
You got the setting "subfolder by package name" activated so your path ends with dynamic tag "/<jd:packagename>".
This will result in the script failing as the path is now wrong.
I've created another version of the script with the following changes:
- Remove trailing "<jd:packagename>" from path
- Throw exception if after path correction, path still does not exist (e.g. due to other dynamic tags used in path)

Code:

/*
    delete empty folders
    trigger : jdownloader started
*/

var downloadFolder = callAPI(
    "config", "get",
    "org.jdownloader.settings.GeneralSettings", null,
    "DefaultDownloadFolder"
);

// Remove dynamic tag "<jd:packagename>" from the end of the path if present
if (downloadFolder.endsWith("<jd:packagename>")) {
    downloadFolder = downloadFolder.substring(0, downloadFolder.length - "<jd:packagename>".length);
}

// Check if the path exists, otherwise throw an exception
if (!getPath(downloadFolder).exists()) {
    throw new Error("Download folder does not exist: " + downloadFolder);
}

// Delete all subdirectories inside the download folder
getPath(downloadFolder).children.forEach(function(item) {
    item.directory && item.delete();
});

I've tested it and it has worked.

[Dockel]

Thank you very much! I will try at next occasion.

You got the setting "subfolder by package name" activated so your path ends with dynamic tag "/<jd:packagename>".
This will result in the script failing as the path is now wrong.

OK, but why does the part of the path from after the download folder name matter at all? Because just each folder shall be removed independently of the name?

// Delete all subdirectories inside the download folder

This means all EMPTY sub directories (and sub sub directories, etc.) inside the download folder?

Ja, geht, gerade probiert.

[Jiaz]

Originally Posted by Dockel

OK, but why does the part of the path from after the download folder name matter at all? Because just each folder shall be removed independently of the name?

It matters because the script starts at that folder
c:\test -> exists and script can list the content and look for empty folders to delete
c:\test\<jd:packagename> -> does not exist on disk, nothing to list, nothing to delete

Originally Posted by Dockel

Ja, geht, gerade probiert.

Perfekt!

@Dockel: Du solltest im Default Ordner keine Platzhalter verwenden/haben, sondern dafür den Paketverwalter nutzen

[Dockel]

Okay, ich verstehe.

@Dockel: Du solltest im Default Ordner keine Platzhalter verwenden/haben, sondern dafür den Paketverwalter nutzen

Ja, habe ich auch nicht, nur einen ganz normaler Ordner-Pfad.

Vielen Dank!