I'm trying to make a simple Packagizer Hook to replace "_" with " ":

if (link.getHost() == "myhost.com") {
	link.setName(link.name.replace(/_/g, " "))
}

getHost returns "http links", not the host name, so the compare always fails. The links are being added by the crawler, if that matters. What am I doing wrong?

[raztoki]

link gethost isn't the domain of the site, its the plugin names entry
hence 'http links' as its supported by directhttp plugin

Originally Posted by raztoki

link gethost isn't the domain of the site, its the plugin names entry
hence 'http links' as its supported by directhttp plugin

How do you get the download URL?

[raztoki]

you can either use the package customiser and remove the chars with simple filename rule
contains *_* replace with $1$2

or you can use eventscripter, my guess would be myDownloadLink.getUrl()

raztoki

This seems to work: (note: getURL not getUrl)

// Packagizer Hook to replace "_" with " "

if (/.*myhost\.com.*/.test(link.getURL())) {
	link.setName(link.name.replace(/_/g, " "))
}

[raztoki]

good stuff

Have fun with your filename renamer ;]

Originally Posted by mgpai

Convert AAC/M4A/OGG files to MP3.

// Convert aac/m4a/ogg files to mp3.
// Trigger required: "A Download Stopped".
// Requires ffmpeg/ffprobe. Uses JD ffmpeg/ffprobe settings if available.
// Overwrites destination file (mp3) if it already exists.

if (link.isFinished()) {
    var fileName = link.name.replace(/(.+)(\..+$)/, "$1");
    var fileType = link.name.replace(/(.+)(\..+$)/, "$2");
    var sourceFile = link.getDownloadPath();
    var audioFile = /\.(aac|m4a|ogg)$/.test(sourceFile);

    if (audioFile) {
        var downloadFolder = package.getDownloadFolder();
        var destFile = downloadFolder + "/" + fileName + ".mp3";
        var ffmpeg = callAPI("config", "get", "org.jdownloader.controlling.ffmpeg.FFmpegSetup", null, "binarypath");
        var ffprobe = callAPI("config", "get", "org.jdownloader.controlling.ffmpeg.FFmpegSetup", null, "binarypathprobe");
        var data = JSON.parse(callSync(ffprobe, "-v", "quiet", "-print_format", "json", "-show_streams", "-show_format", sourceFile));
        var streamsBitrate = data.streams[0].bit_rate ? data.streams[0].bit_rate : 0;
        var formatBitrate = data.format.bit_rate ? data.format.bit_rate : 0;
        var bitrate = Math.max(streamsBitrate, formatBitrate) / 1000;
        var deleteSourceFile = false; // Set this to true to delete source file after conversion.

        if (bitrate > 0) {
            callSync(ffmpeg, "-y", "-i", sourceFile, "-b:a", bitrate + "k", destFile);
            if (deleteSourceFile && getPath(destFile).exists()) deleteFile(sourceFile, false);
        }
    }
}

Hi Mgpai,

I'm new with JDownloader and i really like it. When i'm trying to copy the script above in my MyJDownloader eventscripter i'm receiving the following message: sorry failed to set value.
Would you know why ?

I'm using Jdownloader on my Dlink dns-325 nas to download audio file (m4a) but i would like them to be transfered in .mp3.

Thanks

[Jiaz]

The most easiest way is to use a JDownloader with GUI, setup the script there via GUI and then copy/paste the value from advanced settings.

Originally Posted by Jiaz

The most easiest way is to use a JDownloader with GUI, setup the script there via GUI and then copy/paste the value from advanced settings.

Hi Jiaz,
setup the script via GUI, do you mean in MyJDownloader ? Thats where i tried to copy the script to the event scripter in the setting and i got the error message. Not sure where i could have another GUI.

Thanks

[raztoki]

no he meant another JDownloader install with a GUI not webui.

gui jd
copy paste into the event scripter
then goto advanced > copy the advanced setting, this will contain all the json formatting/encoding > paste into the webui or just copy the json file across to the other system

raztoki

Originally Posted by raztoki

no he meant another JDownloader install with a GUI not webui.

gui jd
copy paste into the event scripter
then goto advanced > copy the advanced setting, this will contain all the json formatting/encoding > paste into the webui or just copy the json file across to the other system

raztoki

Ok Thanks for the clarification raztoki.

Hello,
is there a way to do a dry run of the script ?

I'm trying to setup filebot using the provided link **External links are only visible to Support Staff****External links are only visible to Support Staff**

I don't understand how I'm supposed to add these scripts.
At first I thought I had to add both scripts inside the root path of jdownloader /usr/jdownloader

And then copy the *eventscript*.json inside */cfg/

Now, reading the thread here.
I did add both script *.js inside a gui jdownloader and then went inside advanced settings and copy/paste the json inside myjdownloader.

But I still got the error " Sorry, failed to set the new value".
Sorry, if the question is silly or the answer obvious !

Thanks.

[Jiaz]

Most easist way to setup this is to use a JDownloader with GUI and setup two events (Filename is Eventtype) and then copy/paste the value from Settings-Advanced Settings-EventScripter.scripts to your other JDownloader

Originally Posted by Jiaz

Most easist way to setup this is to use a JDownloader with GUI and setup two events (Filename is Eventtype) and then copy/paste the value from Settings-Advanced Settings-EventScripter.scripts to your other JDownloader

So what I did the second time is the right way of doing but it doesn't work.
I get "" Sorry, failed to set the new value".

[mgpai]

Originally Posted by Psychoteur

So what I did the second time is the right way of doing but it doesn't work.
I get "" Sorry, failed to set the new value".

You may get that error if you are trying to paste the code inside the square brackets '[]' in web UI. Try removing those brackets first and then pasting the code. Alternatively, you can copy the "org.jdownloader.extensions.eventscripter.EventScripterExtension.scripts.json" file from 'JD Desktop' to 'JD Headless'.

Originally Posted by mgpai

// Auto stop/restart downloads if the current average speed is below limit.
// Trigger Required: "Interval"

var minSpeed = 128; // (KiB/s) <- minimum average download Speed.
var minDuration = 1; // (minutes) <- minimum download duration per link.
var waitTime = 1; // (minutes) <- wait time before restart.

if (running() && getAverageSpeed() < minSpeed * 1024) {
    stopDownloads();
    sleep(waitTime * 60 * 1000);
    startDownloads();
}

// Check if all downloads have been running for atleast the minimum duration.
function running() {
    var links = getRunningDownloadLinks();
    if (links.length > 0) {
        for (i = 0; i < links.length; i++) {
            var link = links[i];
            if (link.getDownloadDuration() < minDuration * 60 * 1000) {
                return false;
            }
        }
        return true;
    } else {
        return false;
    }
}

This not Work
No Parts are stop and Start. No Reaction from Script?

Edit
Ok this Script Work. Restart Part under 600 kb

//check if downloads are running at all
if (isDownloadControllerRunning() && !isDownloadControllerStopping()) {
    var running = getRunningDownloadLinks();
    //loop through all running Downloads
    for (var i = 0; i < running.length; i++) {
        //check if the download has been running at least 30 seconds
        if (running[i].getDownloadDuration() > 30000) {
            //check if the current speed is below 50kb/s
            if (running[i].getSpeed() < 600 * 1024) {
                //reset the download
                //running[i].reset();
                //stop the download and restart it
                running[i].abort();
            }

        }
    }
}

Example Script in JDownloader 2 :-)

[Jiaz]

@Koto99: The script from mgpai works fine. His script is about global average speed while yours is about individual download speed thats huge difference. Your screenshot shows nearl 5mb/s but the script triggers at global average speed < 128 kb/s

Thanx

I missunderstod this.

Im Searching for Part Speed reset not Global Speed:)

[Jiaz]

@Koto99: your modified script should work fine

Hi,

The script for saving comments doesn't work for couple of weeks now, I thought it was temporary issue but it still have a problem. comments aren't saved.

I'm not sure whether it's script related or JDownloader related.

could you please have a look? :-)

Thank you,
0r3n.

[Jiaz]

@or3n: you know the script only works for packages, not individual links?

[mgpai]

Originally Posted by 0r3n

... The script for saving comments doesn't work for couple of weeks now ...

The script is working fine. For which site do you use the script? Does that plugin still write the description to the comments field?

Originally Posted by Jiaz

@or3n: you know the script only works for packages, not individual links?

Hi Jiaz, yes.

Originally Posted by mgpai

The script is working fine. For which site do you use the script? Does that plugin still write the description to the comments field?

I'm trying to use it for Instagram, I noticed that comments doesn't appear in JDownloader as before but thought maybe it's internal issue and that they are there anyway.
so if the comments doesn't appear in JDownloader "comments" column it's a plugin issue?

[Jiaz]

@0r3n: wait for plugin update. comment handling was broken because of instagram site changes

hi
sorry to disturb you for that but the mgpai script for sorting files by duration (https://board.jdownloader.org/showpo...&postcount=159) cant be started for every "files" but only "bundle" we dont have "file finished" trigger in "event scripter" is it possible to fix that by something more inside the script or a new trigger

ps : if i select "interval" i have an error (https://i.imgur.com/jzou6a2.png)
thx in advance

[Jiaz]

You have to use the trigger "Download Stopped" as commented in the script

ho my bad sry thank you im gonna try this

Originally Posted by Jiaz

@0r3n: wait for plugin update. comment handling was broken because of instagram site changes

Thanks Jiaz, after the update everything is working

[Jiaz]

@03rn: you're welcome

[Informativ]

good morning,
will it work for me? (deleted files in download folder)

// Delete from download folder, any file/folder which contains user specified keywords
// Trigger required: "A Download Stopped"

package.getDownloadFolder().forEach(function(file) {
    var re = /.*(ajax-loader|url).*/;
    var junkFile = re.test(file.getName());
    var junkFolder = re.test(file.getParent().getName());

    if (junkFile) file.delete();
    if (junkFolder) file.getParent().deleteRecursive();
});

other question:

I want the download to be finished, check if there is a pdf file, if so, this is started
F:\Downloads\files\PDFConverter.exe "%DEPACKFOLDER%" "%DEPACKFOLDER%" -c PNG -p 1 -pd 4x5
"%DEPACKFOLDER%" = DownloadFolder

is that possible?

[mgpai]

Originally Posted by Informativ

... will it work for me? (deleted files in download folder) ...

The script will not work in its present form. You have to to get the download links for the package and then query and delete them.

If you always want to delete such files, it is better to use linkfilter and prevent the links from being added to JD in the first place, rather than downloading, and deleting them later using event scripter.

Originally Posted by Informativ

I want the download to be finished, check if there is a pdf file, if so, this is started ...

// Run external program if package contains 'pdf' file
// Trigger: "Package finished"

var pdf = package.getDownloadLinks().some(function(link) {
    return getPath(link.getDownloadPath()).getExtension() == "pdf";
});

if (pdf) {
    var downloadFolder = package.getDownloadFolder();
    var converter = "f:/downloads/files/pdfConverter.exe";
    callAsync(function() {}, converter, downloadFolder, downloadFolder, "-c", "PNG", "-p", "1", "-pd", "4x5");
}

[Informativ]

hi mgpai,
if no pdf available, that comes

Spoiler:

The script will not work in its present form. You have to to get the download links for the package and then query and delete them.

If you always want to delete such files, it is better to use linkfilter and prevent the links from being added to JD in the first place, rather than downloading, and deleting them later using event scripter.

that a option, but over word is better

[Jiaz]

looks like copy/paste error or invalid script. error is about syntax error in script

[Informativ]

hi,
is it possible to stop this part and then restart it?

Spoiler:

Hi.
Textbox contents in messagebox is invisible height.
How change height?

alert("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");

[mgpai]

Originally Posted by pachi

Textbox contents in messagebox is invisible height. How change height?

Know issue. Workaround: Add "\r\n" at the end of the object/string.

alert("myString"+"\r\n");

Originally Posted by mgpai

Know issue. Workaround: Add "\r\n" at the end of the object/string.

alert("myString"+"\r\n");

Thank you!

[Jiaz]

[Tyler]

Originally Posted by fred_gaou

Hi,

Here is a script to help you to auto clean/format filename during the link grabbing process. This is done automatically in background for each added link.

You can set some options at the top of the script.

This is useful in any case as soon as you notice a recurring pattern in your filenames that you'll want to get rid of or format.

if you set custom filename for video files such as:

[*CHANNEL*] (*PLAYLIST_NAME* *PLAYLIST_POSITION[00]*) *DATE[YY.MM.dd]* - *VIDEO_NAME*.*EXT*

it will be perfect for playlist but not for one video file only because then you will end with a filename with empty brackets:

[Any Youtuber Channel] ( ) 17.03.11 - Video Title

This script will take care of it removing those bracket:

[Any Youtuber Channel] 17.03.11 - Video Title

// LINK NAME CLEANER (auto)
// Trigger required: Packagizer Hook

/* *************************************************************************
Set the characters that will be removed from both ends of the filename.
Be sure to double escape special chars such as "\\s" instead of "\s".
****************************************************************************/

var leadAndTrailTrimChars = "\\s-_";

/* *************************************************************************
Set the characters that will be replaced with whitespace.
Be sure to double escape special chars such as "\\s" instead of "\s".
****************************************************************************/

var charToSpace = "_";

/* *************************************************************************
Set the words or phrases to remove. Words/phrases must be separated with | such as
"word one|word two|word three"
Be sure to double escape special chars such as "\\s" instead of "\s".
****************************************************************************/

var wordsToRemove = "with subtitles";

/***************************************************************************/

if (linkcheckDone) {


    /* =========================== INITIALIZE ============================ */

    var myPackagizerLink = link;
    var fileName = myPackagizerLink.getName();
    var re, ext;

    // Remove the extension from the end and save it for later.
    // And make it lower case at the same time.
    ext = fileName.slice((fileName.lastIndexOf(".") - 1 >>> 0) + 2);
    if (ext !== "") {
        ext = "." + ext.toLowerCase();
    }

    // If extension exists, then we will work with the filename without extension
    fileName = fileName.substr(0, (fileName.length - ext.length));

    /* ========================= REGEX PATTERNS ========================== */

    // Remove these words/phrase : wordsToRemove
    re = new RegExp("\\b(?:" + wordsToRemove + ")\\b", "gi");
    fileName = fileName.replace(re, "");

    // Replace these characters with whitespace : charToSpace
    re = new RegExp("[" + charToSpace + "]", "gi");
    fileName = fileName.replace(re, " ");

    // Delete empty bracket content. "( )", "[ ]" or "{ }" will be removed from filename.    
    re = new RegExp("(\\(\\s+?\\))|(\\[\\s+?\\])|({\\s+?})", "gi");
    fileName = fileName.replace(re, "");

    /* ====== ALWAYS APPLY NEXT REPLACEMENTS AT THE END OF PROCESS ======= */

    // Remove unwanted characters from both ends of the filename
    re = new RegExp("^[" + leadAndTrailTrimChars + "]*(.+?)[" + leadAndTrailTrimChars + "]*$", "gi");
    fileName = fileName.replace(re, "$1");

    // Replace multiple spaces with only one
    re = new RegExp("\\s\\s+", "gi");    
    fileName = fileName.replace(re, " ");

    // Removes whitespace from both ends of the filename (just to be sure)
    fileName = fileName.trim();

    /* ====== APPLY NEW FILE NAME ======= */
    myPackagizerLink.setName(fileName + ext);
}

can you fix this?

says ReferenceError: "linkcheckDone" is not defined. (#28)

[fred_gaou]

Originally Posted by Tyler

can you fix this?

says ReferenceError: "linkcheckDone" is not defined. (#28)

It works here on last JD 2.0 #617. So nothing to fix.