[Dockel]

I have never seen such happen here. What settings does it?

Spoiler:

So after a reconnect is executed and the router / modem does not get an Internet connection JD automatically reconnects after a special time?

[pspzockerscene]

I don't know but afik:
- It definitely tries multiple times
- If you got the same IP after a reconnect, a retry will also be triggered

If you want to discuss this topic in a deeper way, please open a new thread and describe your current problem.
As script really shouldn't be needed in this case.

[Dockel]

- It definitely tries multiple times

Not here, I would say.

If you want to discuss this topic in a deeper way, please open a new thread and describe your current problem.

Okay, mache ich nachher.

[mgpai]

Originally Posted by StefanM

format hh:mm:ss.xxx

/*
    generate "video_duration_formatted" property from "video_duration" property
    trigger: packagizer hook
    Enable "synchronous execution of script" checkbox in top panel
*/

if (linkcheckDone && state == "BEFORE") {
    var duration = link.getProperty("video_duration");

    if (duration != null) {
        var fmt = function(n) {
            return ("0" + parseInt(n)).slice(-2);
        }
        var [seconds, milliseconds] = ("" + duration).split(".");
        var hours = fmt(seconds / 3600);
        seconds %= 3600;
        var minutes = fmt(seconds / 60);
        seconds = fmt(seconds % 60);
        milliseconds = ((milliseconds || "000") + "000").slice(0, 3);
        duration = ([hours, minutes, seconds].join(":") + "," + milliseconds)
        link.setProperty("video_duration_formatted", duration);
    }
}

[Fierro3612]

[EventScripter] Downloadlist cleanup / Aufräumen

Eine Möglichkeit zum Aufräumen der Downloadliste wäre toll.
Ich meine Einträge für die es keine Files mehr im Downloadordner mehr gibt zu löschen.


Hat vielleicht schon so ein Script gesehen?

****

A way to clean up the download list would be great.
I mean deleting entries for which there are no more files in the download folder.


Has anyone seen a script like this?

[mgpai]

Originally Posted by jDX007

...

That script is to add the metadata to the descriptions text file. Which field from the media metadata appears as in the OS file properties dialog?

[mgpai]

Originally Posted by John19234

but av doesnt scan the files instantly, I wanted a feature like fdm where it scans it instantly. I deal with files that might not be safe so I scan them before unpacking. Just want to automate it.

Also periodic av scans take time and might scan files that have already been scanned. I want a selective scan of one file.

/*
    run external command on dowloaded file
    trigger : download finished
*/


if (link.finished) {
    var program = ["/path/to/myexternalprogram.exe"];
    var parameters = ["paremeter1", "parameter2", "paremeter..."].join(",");
    var file = getPath(link.downloadPath);

    callSync(program, parameters, file);
}

[mgpai]

Originally Posted by Fierro3612

[EventScripter] Downloadlist cleanup / Aufräumen

Eine Möglichkeit zum Aufräumen der Downloadliste wäre toll.
Ich meine Einträge für die es keine Files mehr im Downloadordner mehr gibt zu löschen.


Hat vielleicht schon so ein Script gesehen?

****

A way to clean up the download list would be great.
I mean deleting entries for which there are no more files in the download folder.


Has anyone seen a script like this?

/*
    remove orphaned links
    trigger : jdownloader started
*/

getAllDownloadLinks().forEach(function(link) {
    link.finished && !getPath(link.downloadPath).exists() && link.remove();
})

[Fierro3612]

Thank You very much

[StefanM]

Originally Posted by mgpai

/*
    generate "video_duration_formatted" property from "video_duration" property
    trigger: packagizer hook
...

Sorry about my late reply!
I was away for some time and must have overlooked this.
Now, thank you very, very much for your help.

Will test the script probably this weekend and then let you know about the result.

Best regards,
Stefan

[StefanM]

Originally Posted by mgpai

/*
    generate "video_duration_formatted" property from "video_duration" property
    trigger: packagizer hook
    Enable "synchronous execution of script" checkbox in top panel
*/

if (linkcheckDone && state == "BEFORE") {
    var duration = link.getProperty("video_duration");

    if (duration != null) {
        var fmt = function(n) {
            return ("0" + n).slice(0, 2);
        }
        var [seconds, milliseconds] = ("" + duration).split(".");
        var hours = fmt(seconds / 3600);
        seconds %= 3600;
        var minutes = fmt(seconds / 60);
        seconds = fmt(seconds % 60);
        duration = ([hours, minutes, seconds].join(":") + "," + milliseconds)
        link.setProperty("video_duration_formatted", duration);
    }
}

Tested it thoroughly. Unfortunately in some 50 % of all tested cases it produces incorrect results, e.g.

for 895,019 sec
it returns
00:01:05,019 (incorrect)

the correct result would be
00:14:55,019 (correct)

Sent you an example link in a PM

Thanks again for any efforts taken.

BR
Stefan

[mgpai]

Originally Posted by StefanM

the correct result would be
00:14:55,019 (correct)

Fixed?

[StefanM]

Originally Posted by mgpai

/*
    generate "video_duration_formatted" property from "video_duration" property
    trigger: packagizer hook
    Enable "synchronous execution of script" checkbox in top panel
*/

if (linkcheckDone && state == "BEFORE") {
    var duration = link.getProperty("video_duration");

    if (duration != null) {
        var fmt = function(n) {
            alert(parseInt(n));
            return ("0" + parseInt(n)).slice(-2);
        }
        var [seconds, milliseconds] = ("" + duration).split(".");
        var hours = fmt(seconds / 3600);
        seconds %= 3600;
        var minutes = fmt(seconds / 60);
        seconds = fmt(seconds % 60);
        duration = ([hours, minutes, seconds].join(":") + "," + milliseconds)
        link.setProperty("video_duration_formatted", duration);
    }
}

Calculation/conversion is correct now!

Three minor issues:
1. I'm getting a popup message "Alert message from MyScript@Packagizer Hook" for each digit group.
Probably a leftover from your own tests?
EDIT: Removed it myself...

2. Trailing zeroes are not shown:
e.g. the script shows 00:03:25,6 instead of 00:03:25,600 (which I would prefer, if possible)

3. When there are no digits after the decimal separator
e.g. 00:03:25,000, the script shows 00:03:25,undefined I would prefer ",000" if possible

[mgpai]

Originally Posted by StefanM

...

Example links?

[StefanM]

Originally Posted by mgpai

Example links?

Sent as PM

Thanks once again!

[mgpai]

Originally Posted by StefanM

...

updated

[StefanM]

Originally Posted by mgpai

**External links are only visible to Support Staff**...

Working like a charm.

Thanks once again for the great work!
I admire your skills. It was probably not that simple to write this script.

[Fetterbr]

Hi.
I need some help with a little script what will check if i have the movie already before download.
I have a base folder with 5-6000 movie folders.
The movies are all starting with the DVD ID-Title-Year

The movie folder has the same name as the movie.

I need the script to check the section before the "-" Dash and after the "-" Dash before the "space". This way it docen't matter how many letters there is in the DVD-ID.

example AARM-018 Best Of Thigh Job Threesomes (2021)

Does this sound plausibel, than please let me know, i would really appreciate it.
I am not sure if the script was already made but i could not find any thing like this.
Thanks

[mgpai]

Originally Posted by Fetterbr

I need the script to check the section before the "-" Dash and after the "-" Dash before the "space".

Check against what? file/folder name in download list?

[Fetterbr]

Originally Posted by mgpai

Check against what? file/folder name in download list?

It needs to check in download folder and any subfolders for any files with mp4 or mkv extension.

[Fetterbr]

Originally Posted by mgpai

Check against what? file/folder name in download list?

Can you make it ?

[pspzockerscene]

@mgpai
Where is the most recent version of the convert2mp3 script?
I had a user in a ticket who seemed to have been using an older version.
The bitrate calculation of that one caused it to fail.
Seemingly old version:
pastebin.com/raw/4wvQ3Hqz
If that version is old: Where can I find your latest version?

I've created a newer version compared to that one:
- Do not overwrite mp3 target file if it already exists
- Display human readable error messages
- Added comments in English (I admit that I used chatGPT for this part, I was lazy).
Newer version by me:
pastebin.com/raw/PPb4G5DV

[mgpai]

Originally Posted by pspzockerscene

@mgpai
Where is the most recent version of the convert2mp3 script?

The second script (alternate version) in the first post of this thread, which includes error handling. I am not aware of any issues, but if there are please let me know.

[pspzockerscene]

Thanks.

I'am not aware of any issues either.
I just have a user in a ticket who claims that it sometimes randomly fails and then of course it gets disabled in JD.

Most of my changes were done to auto add comments (for said user) and also I did not like the amount of indentation levels so I've refactored it to the "early return" principle.

[mgpai]

Originally Posted by pspzockerscene

Thanks.

I'am not aware of any issues either.
I just have a user in a ticket who claims that it sometimes randomly fails and then of course it gets disabled in JD.

Most of my changes were done to auto add comments (for said user) and also I did not like the amount of indentation levels so I've refactored it to the "early return" principle.

Most likely the user had the original (first version) script, which does not contain any error handling

Thanks for jumping in.

[pspzockerscene]

I've made him a german version with special error handling.
Again I don't think any of this is needed but I was in the mood to do this so I'll post it here too in case it's helpful for others:
pastebin.com/raw/stqgZtm8

Please don't judge me for using ChatGPT - I've mainly used it for auto comment generation.
The script is tested and working.

[mgpai]

Originally Posted by pspzockerscene

Please don't judge me for using ChatGPT - I've mainly used it for auto comment generation.

I believe in taking help wherever we can get it.

ChatGPT can be quite useful. But those not familiar with JD API may find it confusing, since it tends to create scripts with non-existent APIs.

[pspzockerscene]

Originally Posted by mgpai

I believe in taking help wherever we can get it.

:)

Originally Posted by mgpai

But those not familiar with JD API may find it confusing, since it tends to create scripts with non-existent APIs.

Yap I've already seen that.
For refactoring or adding comments though I need to say it works pretty well though I'd never trust it 100% and always perform tests.

[pspzockerscene]

@mgpai
Is there a simple script which downloads the comment of an item as same file name but with .txt extension?
If so, where can I find that?

If none exists, I will create one since I know that the demand is there.

[mgpai]

Originally Posted by pspzockerscene

@mgpai
Is there a simple script which downloads the comment of an item as same file name but with .txt extension?
If so, where can I find that?

If none exists, I will create one since I know that the demand is there.

Remeber creating one, but could not find it. Let me know if I can be of any help with the script.

[pspzockerscene]

Here is roughly what I want slahs what I would try to create (so far I didn't start).
A script that has the following features:

• Save package comment or item-comment into .txt file
• The ability to define allowed file types in an array/regex or some variable to easily control, for which items the description should be saved*
• The ability to define allowed host(s) for which the script should work

* Specifically this will be tested/used for soundcloud items and in that case, there can be audio files and image files (covers) but the description should only be saved once [per package slash per audio item]
I have yet to update the soundcloud crawler to set said description as comment. EDIT that was already implemented.

I want the code of this script to be in the script inside an extra function so we can easily do a "return early" thing to keep the structure flat so, similar to how the structure of the other script I posted is but without exceptions.

It shouldn't be too complicated.

[mgpai]

Originally Posted by pspzockerscene

Here is roughly what I want ...

/*
    save comment to text file
    trigger : download finished
*/

var myHosts = ["soundcloud.com","audiocloud.com"];
var myExts = ["mp3", "jpg"];
var saveComment = function(link) {
    var finished = link.finished;

    if (!finished) {
        throw new Error("download not finished");
    }

    var host = link.downloadHost;

    if (myHosts.indexOf(host) == -1) {
        throw new Error("host is excluded");
    }

    var ext = getPath(link.downloadPath).extension;

    if (myExts.indexOf(ext) == -1) {
        throw new Error("extension is excluded");
    }

    var comment = link.comment;

    if (!comment) {
        throw new Error("comment not found");
    }

    var file = getPath(link.downloadPath.replace(/(.+)\..+/, "$1.txt"));

    if (file.exists()) {
        throw new Error("file already exists");
    }

    try {
        writeFile(file, comment, false);
    } catch (e) {};
}

saveComment(link);

Let me know if anything is amiss.

[pspzockerscene]

At the exact same time, I made my attempt lol
I'll just post it here for comparison:

Spoiler:

// Writes link comment to text file
// Trigger: "A download has stopped"
// Has some settings, just search for "settings" in this code

// Main function that runs the script based on the early return principle
function run() {
    // Early return if the download is not finished
    if (!link.isFinished()) {
        // console.log("Link is not yet downloaded");
        return;
    }

    var comment = link.getComment(); // Retrieve the comment from the link

    // Early return if the comment is empty
    if (!comment) {
        return;
    }

    // Retrieve the link's file name and download folder path
    var fileName = link.name;
    var sourcePath = package.getDownloadFolder();
    
    // "Settings", see vars down below
    // Define allowed file types (set to null or undefined to allow all types)
    var allowedFileTypes = null; // Example: set to null to allow all file types
    // var allowedFileTypes = [".mp3"];
    // Option to overwrite existing files
    var overwriteExisting = false; // Set to true to overwrite existing files

    // Check if the file type is allowed (skip check if allowedFileTypes is null or undefined)
    if (allowedFileTypes && !allowedFileTypes.some(function(extension) { return fileName.endsWith(extension); })) {
        return;
    }

    // Change the file name to add ".txt" as the new extension
    var outputPath = sourcePath + "/" + fileName + ".txt";

    // Early return if the file exists and overwriting is disabled
    if (!overwriteExisting && getPath(outputPath).exists()) {
        return;
    }
    
    // Write the comment to the file
    writeFile(outputPath, comment, true);
}

// Execute the run function
run();

Pastebin:
pastebin.com/raw/DcpjqF2f

Before you ask:
The reason I put all the code into a function is to be able to do "return;" instead of an exception since otherwise it won't compile in our framework.

I guess your "inline function" would also allow a "return;".
I'm not in the position to judge which one is "better"; I guess we'll make a merged one that contains all 'features'.
EDIT
Here is a merged version:

Spoiler:

// Writes link comment to text file
// Trigger: "A download has stopped"
// Has some settings, just search for "settings" in this code

// Main function that runs the script based on the early return principle
function run() {
    // "Settings", see vars down below
    // Define allowed file types (set to null or undefined to allow all types)
    var allowedFileTypes = null; // Example: set to null to allow all file types
    // var allowedFileTypes = [".mp3"];
    
    // Option to overwrite existing files
    var overwriteExisting = false; // Set to true to overwrite existing files
    
    // Allowed hosts (only these hosts will proceed; set to null to allow all hosts)
    var myHosts = ["soundcloud.com", "audiocloud.com", "ping.online.net"];

    // Early return if the download is not finished
    if (!link.isFinished()) {
        // console.log("Link is not yet downloaded");
        return;
    }

    var comment = link.getComment(); // Retrieve the comment from the link

    // Early return if the comment is empty
    if (!comment) {
        return;
    }

    // Retrieve the link's file name, download folder path, and host
    var fileName = link.name;
    var sourcePath = package.getDownloadFolder();
    var host = link.downloadHost;

    // Skip host check if myHosts is null or undefined
    if (myHosts && myHosts.indexOf(host) === -1) {
        return;
    }

    // Skip file type check if allowedFileTypes is null or undefined
    var fileExtension = fileName.split('.').pop();
    if (allowedFileTypes && allowedFileTypes.indexOf(fileExtension) === -1) {
        return;
    }

    // Change the file name to add ".txt" as the new extension
    var outputPath = sourcePath + "/" + fileName + ".txt";

    // Early return if the file exists and overwriting is disabled
    if (!overwriteExisting && getPath(outputPath).exists()) {
        return;
    }
    
    // Write the comment to the file
    writeFile(outputPath, comment, true);
}

// Execute the run function
run();

I liked your "inline function" more since it eliminates one indentation.

[mgpai]

Originally Posted by pspzockerscene

The reason I put all the code into a function is to be able to do "return;" instead of an exception since otherwise it won't compile in our framework.

If you mean the script gets disabled on exception, you an either use it in throw/catch or use 'setDisableOnException' and "setNotifyOnException" methods to prevent it.

Originally Posted by pspzockerscene

I guess your "inline function" would also allow a "return;".

Yes.

Originally Posted by pspzockerscene

I liked your "inline function" more since it eliminates one indentation.

You can also use self-invoking/anonymous function.

(function() {
    if (!link.finished) {
        return;
    }
    alert(link.name);
})();

[pspzockerscene]

Originally Posted by mgpai

If you mean the script gets disabled on exception, you an either use it in throw/catch or use 'setDisableOnException' and "setNotifyOnException" methods to prevent it.

No I just mean that something like this is not possible as script (can't even compile):

    if (!link.isFinished()) {
        return;
    }

While this is working:

function run() {

    if (!link.isFinished()) {
        return;
    }
}

run();

Originally Posted by mgpai

You can also use self-invoking/anonymous function.

Thanks.
I've never really delt much with js.
I mostly read all of the js related memes on reddit lol

[Trap]

I need a script that takes the postContentIndex (kemono.su indexing, my current packagizer rule is filename: <jd:prop:postContentIndex>_<jd:orgfilename>) number and adds a +1 to it or somehow fixes the numbering to be in the correct order, start from 1 instead of 0 (as i want to download files from kemono.su in the order they appear in the linkgrabber and due to how naming works the files will have their index broken by the 0 (the order will be like 1,2,3,4,5,6,0 this places the first image or file at the end instead of the start).

The reason i need this modification is so jdownloader would download the files in the order that they appear on the website (simultaneous downloads limited to 1 so it downloads one by one), allowing me to sort by date and be able to easily bulk rename image sets with odd names.

Thank you!

[mgpai]

Originally Posted by Trap

I need a script ...

/*
    modify postContentIndex property
    trigger : packagizer hook
*/

if (state == "BEFORE" && linkcheckDone && link.host == "kemono.su") {
    link.setProperty("postContentIndex", link.getProperty("postContentIndex") + 1 + "");
}

Originally Posted by Trap

All of this is just so jdownlaoder would download the files in the order that they appear on the website.

Be kind.

[Trap]

Originally Posted by mgpai

/*
    modify postContentIndex property
    trigger : packagizer hook
*/

if (state == "BEFORE" && linkcheckDone && link.host == "kemono.su") {
    link.setProperty("postContentIndex", link.getProperty("postContentIndex") + 1 + "");
}

Be kind.

oops, let me fix the wording there...
i did not mean it to read like that

odd, the order stays the same for me, trigger is set correctly and i get no errors.

Tried a few posts with different numbers of images and files but the order is still something like 1,2,3,4,5,0
does the script work on your end?

[mgpai]

Originally Posted by Trap

oops, let me fix the wording there...
i did not mean it to read like that

Thanks

Originally Posted by Trap

does the script work on your end?

Yes.

[mgpai]

Originally Posted by Trap

... bulk rename image sets with odd names.

While simple search/replace is possible using packagizer or GUI, eventscripter can be used for complex/global search and replace using dictionary object.