[mgpai]

Originally Posted by Biohazmatz

... When ... archive extraction has started, I want the downloading to be paused/stopped ...

github.com/mgpai/resources/blob/master/jdownloader/eventscripter/scripts/Biohazmatz.js

[patriks]

Hello, I'm using this script to generate files with the name I want while I wait for this new functionality (link), however I had a problem recently, I periodically delete the downloadlist to be able to check if the vk.com images have a new version, but it does not can I ignore the duplicates and show an error, can I suppress this error and cause jd to detect and ignore the existing file?

script

// Trigger: "A Download Stopped"
disablePermissionChecks(); {
    link.setName(link.getProperty("LINKDUPEID") + " - " + link.getProperty("FINAL_FILENAME"));
    link.setComment(link.getProperty("picturedirectlink"));
}

I reproduced the error in a test and created a log:

Spoiler:

url used for test: **External links are only visible to Support Staff****External links are only visible to Support Staff**

logs:
03.04.18 10.18.57 <--> 03.04.18 10.33.35 jdlog://8805654433151/

error details
jd.plugins.FileExistsException: Creating file C:\Users\Disaeon\Desktop\tst\_x3\392220242_00\album392220242_00_392220242_456239144 - XcPSjYTp12c.jpg failed. C:\Users\Disaeon\Desktop\tst\_x3\392220242_00\album392220242_00_392220242_456239144 - XcPSjYTp12c.jpg already exists.
at jd.plugins.PluginForHost.renameOrMove(PluginForHost.java:2278)
at jd.plugins.PluginForHost.handle(PluginForHost.java:2272)
at jd.plugins.PluginForHost.move(PluginForHost.java:2230)
at jd.controlling.downloadcontroller.DownloadWatchDog.move(DownloadWatchDog.java:4519)
at jd.controlling.downloadcontroller.DownloadWatchDog$41.execute(DownloadWatchDog.java:4399)
at jd.controlling.downloadcontroller.DownloadWatchDog$34.processJobs(DownloadWatchDog.java:3241)
at jd.controlling.downloadcontroller.DownloadWatchDog$34.run(DownloadWatchDog.java:3622)
[/CODE]

If it is a very complicated thing, like needing to update in the core, you can disconsider because I am only using this temporarily.

Note: I'm using "LINKDUPEID" because it's easy to remove album information at the beginning of the name (album392220242_00_), when functionality is available.

[mgpai]

You can use

var myBoolean = myFilePath.exists();

to check if the file exists on disk and then use

var myBoolean = myDownloadLink.remove();

to remove it, or use

myDownloadLink.setEnabled(true);

to disable it.

Hope I have understood your problem correctly.

[patriks]

Originally Posted by mgpai

You can use

var myBoolean = myFilePath.exists();

to check if the file exists on disk and then use

var myBoolean = myDownloadLink.remove();

to remove it, or use

myDownloadLink.setEnabled(true);

to disable it.

Hope I have understood your problem correctly.

The script renames the file "XcPSjYTp12c.jpg" to
"album392220242_00_392220242_456239144 - XcPSjYTp12c.jpg"
link.setName(link.getProperty("LINKDUPEID") + " - " + link.getProperty("FINAL_FILENAME"));

but when the downloadlist is cleaned and I make a new download (it checks for new versions), it detects the duplicate file, shows error message and ignores the script, downloading with normal name "XcPSjYTp12c.jpg", generating a duplicate file.

I could not use your commands, I do not have much experience with the scripts yet.

[mgpai]

@patriks: Please contact me in JD Chat. I will be available there for the next 2 hours or so.

[dariusmk]

Originally Posted by mgpai

To extract archives only after all downloads have finished, use this new script:

github.com/mgpai/resources/blob/master/jdownloader/eventscripter/scripts/Taobaibai_2.js

If you want the links which are currently on your list to be extracted by the script, make sure that 'auto extraction' has been disabled for those links. You can select those links and view/change their extraction settings using "Archive(s)" sub menu in the context menu or "Package/Link Properties Panel" in the bottom tool bar.

As advised, I’ve disabled the setting „LinkgrabberSettings: Auto Extraction“ in „Advanced Settings“.

Following that, I‘ve tried to add the aforementioned Skript to the script Eventer by copying the script to the text field. However, when I try to safe the script, I’m getting an error „Sorry, failed to set the new value“ and the text field turns empty. I’m somewhat frustrated that I cannot get a simple copy and paste job done.

Any help is appreciated.

[Jiaz]

@dariusmk: the script is not meant to be insert directly into Advanced Settings!
It's for the eventscript editor in GUI version. Easiest way would be to setup Eventscripter with JDownloader with GUI and then copy/paste Settings-Advanced Settings-EventScripter.scripts

[dariusmk]

Originally Posted by Jiaz

@dariusmk: the script is not meant to be insert directly into Advanced Settings!
It's for the eventscript editor in GUI version. Easiest way would be to setup Eventscripter with JDownloader with GUI and then copy/paste Settings-Advanced Settings-EventScripter.scripts

Thanks. Will try.

As mentioned above, I would like to extract archives only after all downloads have finished. For that purpose the „LinkgrabberSettings: Auto Extraction“ in „Advanced Settings“ must be set to “disabled“. Right? Is there any other setting I need to modify?

[Jiaz]

Yes, you need to disable default auto extraction in settings

[Takhen]

Hi, I would need some help for a function that seems not to be included in JD. We also have "don't download the file if it's already in the folder", but I think that would be precious have "don't download the file if it's already in the folder or in a subfolder". That's because you must keep your files in the folder if you want the filter to work: if subfolder are included we could at least organize that folder instread of keep thousands of files of each kind and name. What do you think about this? Thanks

[mgpai]

Originally Posted by Takhen

... "don't download the file if it's already in the folder or in a subfolder"...

While it is possible to detect if the exists on disk, it is not possible to extend the GUI functionality of 'skip file if exists' to the event scripter. The links can only be disabled/removed or temporarily skipped to prevent it from being downloaded.

The current method limits the number (depth) of sub-folders which can be checked. Please wait for Jiaz to respond regarding request for new API method.

@Jiaz: Would it be possible to provide recursive list of the files and folders on the disk, something like:

var myFilePath[] = myFilePath.getChildrenRecursive();

Also can a method similar to "Mark as Finished" menu command be added?

[Jiaz]

@mgpai: no new method required.

PseudeoCode:
function getAllChildrend(path){
var ret=[];
var files=path.getChildren();
for (file:files){
if (file.isFile(){
ret.push(file);
}else{
ret.concat(getAllChildren(file));
}}
return ret;
}

var all=getAllChildren(startfolder);

[mgpai]

@Jiaz: Thanks

Originally Posted by mgpai

Also can a method similar to "Mark as Finished" menu command be added?

Any decision on second request?

[mgpai]

Originally Posted by Takhen

... "don't download the file if it's already in the folder or in a subfolder"...

github.com/mgpai/resources/blob/master/jdownloader/eventscripter/scripts/Takhen.js

Hi,

Jiaz had said that you were very talented scripter and may be able to help...
I need a solution that will allow me to add YouTube channels, download links, but then later automatically check those channels to see if there are new links available and then download just the new ones.

Thanks for any help!

[FlyAway]

hI:)

I found the example event to restart the download if the speed is low. Unfortunately it's not good for me :( I don't want an event that checks the speed of the single file I'm downloading. I need an event that analyzes the TOTAL speed and that if the total speed drops below a threshold (400kbs), it reconnects the router. Can you help me? Thank you

[mgpai]

Originally Posted by Professor S

... I need a solution that will allow me to add YouTube channels, download links, but then later automatically check those channels to see if there are new links available and then download just the new ones ...

There is a basic script which can check channels, but it is does not detect any duplicate links. I would suggest you take a look at full fledged RSS readers like flexget (there are examples on the forum on how to integrate it with JD). You will also be able to filter content based on keyword, URL etc.

[mgpai]

Originally Posted by FlyAway

... I need an event that analyzes the TOTAL speed and that if the total speed drops below a threshold (400kbs), it reconnects the router ...

github.com/mgpai/resources/blob/master/jdownloader/eventscripter/scripts/FlyAway.js

Thank you. I’ll check it out.

[FlyAway]

Originally Posted by mgpai

github.com/mgpai/resources/blob/master/jdownloader/eventscripter/scripts/FlyAway.js

Thanks mgpai. I m not expert, How can I download this file and where should I put it? Or do I have to copy only the text and paste it in a new script?

and, last help sorry, is possible add a rule that limits the maximum number of reconnections. Leaving the modem on at night I would not want it to burn

edit:

I have pasted your code in a new script, I hope I have done well. But it does not work, the router will not restart. I am attaching the screens

[mgpai]

Originally Posted by FlyAway

... is possible add a rule that limits the maximum number of reconnections. Leaving the modem on at night I would not want it to burn

The script performs reconnects (only when there are active downloads) based on your speed limit and the duration taken by the downloads to reach that speed. As long as you determine/set optimal values for those parameters, there will be no risk your modem 'burning' out. The script currently waits till all downloads have been running for atleast 60 seconds (60000ms), before checking the speed limit. If your connection takes longer to reach the minimum speed, you can try increasing that value in the script, to prevent any unnecessary reconnects. If you want to track the number of reconnects triggered by the script, I can provide you a code which can log the timestamps to a file.

I have pasted your code in a new script, I hope I have done well. But it does not work, the router will not restart. I am attaching the screens

I am unable to make out much from the thumbnails of your screenshot (Please wait for Jiaz to check it). Make sure you have followed all the instructions given in the script (selected the right trigger, set interval correctly, enabled checkbox etc.).

[Takhen]

Originally Posted by mgpai

While it is possible to detect if the exists on disk, it is not possible to extend the GUI functionality of 'skip file if exists' to the event scripter. The links can only be disabled/removed or temporarily skipped to prevent it from being downloaded.

The current method limits the number (depth) of sub-folders which can be checked. Please wait for Jiaz to respond regarding request for new API method.

@Jiaz: Would it be possible to provide recursive list of the files and folders on the disk, something like:

var myFilePath[] = myFilePath.getChildrenRecursive();

Also can a method similar to "Mark as Finished" menu command be added?

Sorry for late answer, I tried to read more times but I'm not sure to understand. That's not my motherlanguage and informatics is not too...

Maybe I could better explain my request: I'm not talking only for "search folder and subfolder and skip to download existing files", the general idea was to avoid to donwload duplicates, each method is ok (I said about "search in the folder" because if JD skip downloads by using an "internal memory" of links downloaded, a format of windows could totally unable the skill). However: the general idea is for moving downloaded files. This can be done out from the donwload folder, or can be done in a subfolder if easier to do.

Did you said there is a way, no care which one, to do something like this, or you said there is no way? Thanks, sorry for my missunderstanding

[FlyAway]

Originally Posted by mgpai

The script performs reconnects (only when there are active downloads) based on your speed limit and the duration taken by the downloads to reach that speed. As long as you determine/set optimal values for those parameters, there will be no risk your modem 'burning' out. The script currently waits till all downloads have been running for atleast 60 seconds (60000ms), before checking the speed limit. If your connection takes longer to reach the minimum speed, you can try increasing that value in the script, to prevent any unnecessary reconnects. If you want to track the number of reconnects triggered by the script, I can provide you a code which can log the timestamps to a file.



I am unable to make out much from the thumbnails of your screenshot (Please wait for Jiaz to check it). Make sure you have followed all the instructions given in the script (selected the right trigger, set interval correctly, enabled checkbox etc.).

Is it possible to set the script to run for a defined number of times?


Ok We wait Jiaz...in any case I have only copied and pasted your script without modifying anything and I have checked the item "synchronous execution of the scripts" as specified in the script. And obviously enabled the script.
Thanks!

[mgpai]

Originally Posted by Takhen

... Did you said there is a way, no care which one, to do something like this, or you said there is no way? ...

I have already posted a script in Post #414. If the file already exists in the sub-folders (of the download folder), the link will be disabled, to prevent it from being downloaded again.

[mgpai]

Originally Posted by FlyAway

Is it possible to set the script to run for a defined number of times?

If you just want to know if it is possible. Yes it is possible. But if you are asking me if I can add it to this script. Sorry I will have to decline.

[FlyAway]

Originally Posted by mgpai

If you just want to know if it is possible. Yes it is possible. But if you are asking me if I can add it to this script. Sorry I will have to decline.

thanks anyway, do not worry it was just for the history of the modem turned on at night. Mega.co, I do not know why, sometimes download certain files at low speed and if it happens at night, with your script, the router would continue to be rekindled.

how stupid I am, I had not read that, in the script, there is specified to set "Interval" as Target :( I think that's the problem, I try it tonight and I'll let you know

[mgpai]

Originally Posted by FlyAway

... it was just for the history of the modem turned on at night. Mega.co, I do not know why, sometimes download certain files at low speed and if it happens at night, with your script, the router would continue to be rekindled ...

You can use this code to control the time at which the script will run. Insert it after Line 10:

var h = new Date().getHours();
if (h < 6 || h > 20) return;

In this example the script will run only between 6 AM and 9 PM.

[FlyAway]

Originally Posted by mgpai

You can use this code to control the time at which the script will run. Insert it after Line 10:

var h = new Date().getHours();
if (h < 6 || h > 20) return;

In this example the script will run only between 6 AM and 9 PM.

thanks for the help but 6 or 7 hours of reconnections I think disinterrupt the router Do not worry, it's not important.

Unfortunately I tried your script having enabled the trigger but it does not work, does not reconnect :(

[Jiaz]

@FlyAway: you should modify script to test it first if reconnect works at all
Does Reconnect work for you? did you setup it first?

[FlyAway]

Originally Posted by Jiaz

@FlyAway: you should modify script to test it first if reconnect works at all
Does Reconnect work for you? did you setup it first?

I do not think I understood. The reconnect function works correctly, it does not work when it is invoked by the script

[Jiaz]

did you enable Settings-Reconnect -> Reconnects can interrupt resumable downloads?
Not resumeable downloads will block the reconnect. you would need to modify script to stop running downloads first

[FlyAway]

Originally Posted by Jiaz

did you enable Settings-Reconnect -> Reconnects can interrupt resumable downloads?
Not resumeable downloads will block the reconnect. you would need to modify script to stop running downloads first

yes, I have all enabled

I have deleted all list of file in queue, restart JD2 and seem to be working. This night I test it.
Any idea for limit of number of reconnection?

[Jiaz]

You can modify script to check global map of reconnects done and add an additional script that always increases when reconnect is started 'Before A Reconnect' and 'After A Reconnect'. Better ask mgpai for help with this

[Takhen]

Originally Posted by mgpai

I have already posted a script in **External links are only visible to Support Staff**.... If the file already exists in the sub-folders (of the download folder), the link will be disabled, to prevent it from being downloaded again.

I'm trying it, it seems to work, many many thanks

[FlyAway]

Originally Posted by Jiaz

You can modify script to check global map of reconnects done and add an additional script that always increases when reconnect is started 'Before A Reconnect' and 'After A Reconnect'. Better ask mgpai for help with this

mgpai have no time for it, but thanks for all:biggrin:
I hope that, in the future, someone can run this script because you can assign a number of executions of your choice, it could be useful in many cases

[Jiaz]

@FlyAway: what exactly do you need this *number of executions* ?

[FlyAway]

Originally Posted by Jiaz

@FlyAway: what exactly do you need this *number of executions* ?

I have to limit the number of reconnections because I leave the router on at night and, using the mgpai scipt, is likely to burn if it continues to reconnect for many hours

[Jiaz]

you can easily modify to check last reconnect timestamp in your script
for example store timestamp last time you requested reconnect and only allow script when last reconnect is more than x mins/hours ago. should be easy to modify for mgpai

[FlyAway]

Originally Posted by Jiaz

you can easily modify to check last reconnect timestamp in your script
for example store timestamp last time you requested reconnect and only allow script when last reconnect is more than x mins/hours ago. should be easy to modify for mgpai

sorry I was not clear. Can you read my previous posts? There I explained well what the problem is. I think your solution is not good

[Jiaz]

@FlyAway: Limiting the execution is about the same result as only allowing for example 2 reconnects per hour. Because with limited executions, you have to reset it manually while my solution just prevents endless/too many reconnects. You could easily mix time check and time interval check. For example between 22:00 and 06:00 only allow 2 reconnects per hours