JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 11.08.2022, 14:22
Rocket Rocket is offline
I will play nice!
 
Join Date: Dec 2020
Posts: 5
Default Allow more than 5 or custom number of connections in sxyprn plugin.

Hi,

right now the plugin for sxyprn has a hardcoded limit of 5 connections.

Please allow a custom number of connections to be set there. This will allow me to better use my download bandwith.

If not for everyone, please just compile a version with 12 connections hardcoded in it and provide the .class file for download.

Thanks!
Reply With Quote
  #2  
Old 11.08.2022, 18:32
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 63,166
Default

Quote:
Originally Posted by Rocket View Post
right now the plugin for sxyprn has a hardcoded limit of 5 connections.
* max simultaneous downloads limit.
Connections are limited to max 1 per file.

Quote:
Originally Posted by Rocket View Post
Please allow a custom number of connections to be set there.
No. Doesn't work for me.

Quote:
Originally Posted by Rocket View Post
If not for everyone, please just compile a version with 12 connections hardcoded in it and provide the .class file for download.
We're open source.
You can get our source code here:
https://support.jdownloader.org/Know...up-ide-eclipse
See jd.plugins.hoster.SxyprnCom functions getMaxSimultanFreeDownloadNum and getMaxSimultanPremiumDownloadNum.
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #3  
Old 11.08.2022, 18:46
Rocket Rocket is offline
I will play nice!
 
Join Date: Dec 2020
Posts: 5
Default

OK. Please delete this thread. Thanks!
Reply With Quote
  #4  
Old 11.08.2022, 19:12
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,935
Default

@Rocket: Instead of using multiple connections/chunks per file, I recommend to use multiple downloads (max 5) from this host. We have limited max connections/chunks to 1 because higher number easily results in errors for us while testing the plugin
__________________
JD-Dev & Server-Admin
Reply With Quote
  #5  
Old 11.08.2022, 22:44
Rocket Rocket is offline
I will play nice!
 
Join Date: Dec 2020
Posts: 5
Default

Yes I understand.

Its a good thing to limit the max number of connections because too many connections and the downloads will fail.

However in my case I wanted more than 5 connections to max out my line.

I fixed my issue myself by compiling the code myself after making the changes I wanted. It was surprisingly easy.

In general it would be better to allow setting the max number of connections in the settings instead of hardcoding them into the code and only giving a predefined default number that works best.

But I agree, my case is special and it was best to just edit the code myself and compile my own version.

You can close and delete this thread.
Reply With Quote
  #6  
Old 12.08.2022, 14:44
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 63,166
Default

Quote:
Originally Posted by Rocket View Post
In general it would be better to allow setting the max number of connections in the settings instead of hardcoding them into the code and only giving a predefined default number that works best.
For some plugins we got settings for that but it would be a waste of time to copy & paste those.

If at all, adding this as a generic setting, applicable for all plugins would be the way to go.
You're of course free to work on this and contribute code to the JDownloader project.
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #7  
Old 12.08.2022, 15:45
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,935
Default

Quote:
Originally Posted by Rocket View Post
I fixed my issue myself by compiling the code myself after making the changes I wanted. It was surprisingly easy.
That's great to hear!

Please know that you can either:
1.) replace the plugin .class file with your own compiled one, but it might be replaced by updates
or
2.) create a custom plugin that extends the original plugin and use higher interface number, that way this custom plugin
will be used instead of the default one
__________________
JD-Dev & Server-Admin
Reply With Quote
  #8  
Old 12.08.2022, 17:38
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,935
Default

@Rocket:
I was not able to use more than 2 concurrent connections/chunks, because with every further connection the server responded with
Quote:
Something went wrong. Please try your request again.
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 10:25.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2022, Jelsoft Enterprises Ltd.