[Dockel]

Thank you very much!

I have to replace the last two of these (three related) scripts with that new one, is it right:


Is there a way to mark (by color or so) / recognize scripts belonging together in the Even Scripter?

[mgpai]

Originally Posted by Dockel

I have to replace the last two of these (three related) scripts with that new one, is it right:

Yes. Correct.

[Dockel]

OK, all done. Works great! Many thanks again!

[Jiaz]

Originally Posted by Dockel

Is there a way to mark (by color or so) / recognize scripts belonging together in the Even Scripter?

Nice idea! For example in edit dialog you can specify a colour, okay?

[Dockel]

Yes, that would be great, of course! Thank you!

So here, may be a second (colored) arrow (within a column or so):

[abrenoch]

Could someone maybe help me out please?

I am trying to make a 'new crawler job' script, but the 'var myCrawlerJob = job;' line to get the added job doesn't seem to work. it always results in an undefined variable.

Thanks in advance!

[mgpai]

Originally Posted by abrenoch

I am trying to make a 'new crawler job' script, but the 'var myCrawlerJob = job;' line to get the added job doesn't seem to work. it always results in an undefined variable.

Appears to be working fine. Can you post the script here or provide more information it?

[Jiaz]

@Dockel: It would prefer "color picker" within the already existing edit dialog

@abrenoch: please provide your script and also what trigger you are using

[Dockel]

@Dockel: It would prefer "color picker" within the already existing edit dialog

Sorry, I do not know what that means, but I assume, whatever you will build will be good.

[abrenoch]

Originally Posted by Jiaz

@abrenoch: please provide your script and also what trigger you are using

Here is the code I am fiddling with:

// Trigger required: "New Crawler Job".
var myCrawlerJob = job;
function log(content) {
  writeFile(JD_HOME + "/log.txt", JSON.stringify(content) + "\r\n", true);
}
log(Date.now())
log(myCrawlerJob)

That is the same trigger I am using. If I pass something like "**External links are only visible to Support Staff** (but it could be anything), I only ever get this output:

1603847718298
undefined

Per the help section, it seems like I should be getting something:
// ========= Properties for the EventTrigger 'New Crawler Job' =========
var myCrawlerJob = job;

I'm just trying to test things at this point

[Jiaz]

Working fine here. Have you made sure to set the trigger to "New Crawler Job"?

[mgpai]

Originally Posted by abrenoch

// ========= Properties for the EventTrigger 'New Crawler Job' =========
var myCrawlerJob = job;

It is a sandbox object, and as such you cannot 'stringify' it. You have to use the corresponding object methods to access the listed properties and then write them to a file.

[abrenoch]

Originally Posted by Jiaz

Working fine here. Have you made sure to set the trigger to "New Crawler Job"?

Yup, absolutely certain. Event tried removing that job and remaking it. I do have some updates available so I'll try again after applying those.

Originally Posted by mgpai

It is a sandbox object, and as such you cannot 'stringify' it. You have to use the corresponding object methods to access the listed properties and then write them to a file.

I was trying that as well... But when I tried to 'getSourceUrl' I would only ever get a "cannot call method getSourceUrl of undefined". I'll try again after updating, but I had that thought as well and calling a method didn't seem to help.

[Jiaz]

@abrenoch: no updates because no issues. Just tried and worked fine on first try.
Can you show a screenshot of the eventscripter extension, table/list of scripts

[abrenoch]

Originally Posted by Jiaz

@abrenoch: no updates because no issues. Just tried and worked fine on first try.
Can you show a screenshot of the eventscripter extension, table/list of scripts

Sending the url to this forum post, for example, yielded a couple triggers but always an 'undefined' job:

1603922086067
undefined
1603922097095
undefined

Thanks for the help!

[Jiaz]

As mgpai already explained, you cannot JSON.stringify on the job as it is no Object/Map that supports JSON conversion.
You have to write out the fields you are interested in

/* === CrawlerJob === */
/* ========= Methods =========*/
var myList = myCrawlerJob.getArchivPasswords();
var myString = myCrawlerJob.getOrigin();
var myString = myCrawlerJob.getPassword();
var myString = myCrawlerJob.getSourceUrl();
var myString = myCrawlerJob.getText();
var myString = myCrawlerJob.getUUID();
var myBoolean = myCrawlerJob.isAssignJobID();
var myBoolean = myCrawlerJob.isDeepAnalysisEnabled();
myCrawlerJob.setAssignJobID(myBoolean);
myCrawlerJob.setDeepAnalysisEnabled(myBoolean);
myCrawlerJob.setPassword(myString);
myCrawlerJob.setText(myString);

[dereks10]

Hey guys, ive been looking to enable some sort of multi directory duplicate check, just like it is now, except multiple directories ( 2nd - 3rd ssd , external hdds ) etc. I searched a good while, came upon this thread, and have searched it. Didnt find a final solution, anyone point me in the right direction?
Thanks.

[mgpai]

Originally Posted by dereks10

... ive been looking to enable some sort of multi directory duplicate check, just like it is now, except multiple directories ( 2nd - 3rd ssd , external hdds ) etc.

JD checks if a file exists, only in the save location/folder of the link (not the sub-folders).

Scanning/matching entire contents of multiple drives using a script is resource intensive and time consuming. By the time a dupe is detected, the file would have triggered captcha and/or will be partially downloaded.

The download locations are usually limited to certain folders. Optimal method would be to use a script to specify/scan only those folders and disable the links.

Such a script can be found HERE.

[GreenXIII]

Hi. I've been wondering if it's possible to tidy up my download list with a script.

Is it possible to combine multiple downloaded links, with the same package name and same download directory, into a single package?

I've got over 127,000 downloaded links that I keep to avoid adding duplicates. If I could combine packages and sort files within them from newest to oldest, it would look much more organized.

EDIT: if matching both package name and directory is too much, I'd say grouping by directory and using its name as the package name would suffice.

[Jiaz]

@GreenXIII: should be possible , maybe mgpai can help you with it He's the script master of the universe

[mgpai]

Originally Posted by GreenXIII

... combine multiple downloaded links, with the same package name and same download directory, into a single package?

Keep a backup of your link list before testing/using the script.

/*
    Merge download packages which have matching name and download folder, sorting links in descending order by ID.
    Trigger: Toolbar button pressed
    Customize main toolbar > Add a new "Eventscripter Trigger" button > Rename it to "Merge Packages" (case-sensitive) > Change Icon (optional)
*/

if (name == "Merge Packages") {
    
    getAllFilePackages().forEach(function(package) {

        if (package) {
            var packages = [];

            getAllFilePackages().forEach(function(package2) {
                if (package2.name + package2.downloadFolder == package.name + package.downloadFolder) {
                    packages.push(package2);
                }
            })

            if (packages.length > 1) {
                var linkIds = [];

                packages.forEach(function(package3) {
                    package3.downloadLinks.forEach(function(link) {
                        linkIds.push(link.UUID);
                    })
                })

                linkIds.sort().forEach(function(linkId) {
                    callAPI("downloadsV2", "moveLinks", [linkId], -1, package.UUID);
                })
            }
        }
    })
}

[DragoBleaPiece]

Originally Posted by mgpai

/*
    Toggle packagizer extension
    Trigger: Toolbar Button Pressed
    Customize main toolbar > Add a new 'Eventscripter Trigger' button > Rename it to "Toggle Packagizer" (without quotes, case-sensitive) > Change Icon (optional)
*/

if (name == "Toggle Packagizer") {
    var interfaceName = "org.jdownloader.controlling.packagizer.PackagizerSettings",
        key = "PackagizerEnabled",
        value = callAPI("config", "get", interfaceName, null, key),
        message = "Packagizer " + (value ? "disabled." : "enabled.");

    callAPI("config", "set", interfaceName, null, key, !value) && alert(message);
}

Hello, Script Master!
Can we use this script for enabling/disabling particular packagizer rules, not all of em? Thank you so much

[DragoBleaPiece]

Originally Posted by mgpai

Keep a backup of your link list before testing/using the script.

/*
    Merge download packages which have matching name and download folder, sorting links in descending order by ID.
    Trigger: Toolbar button pressed
    Customize main toolbar > Add a new "Eventscripter Trigger" button > Rename it to "Merge Packages" (case-sensitive) > Change Icon (optional)
*/

if (name == "Merge Packages") {
    
    getAllFilePackages().forEach(function(package) {

        if (package) {
            var packages = [];

            getAllFilePackages().forEach(function(package2) {
                if (package2.name + package2.downloadFolder == package.name + package.downloadFolder) {
                    packages.push(package2);
                }
            })

            if (packages.length > 1) {
                var linkIds = [];

                packages.forEach(function(package3) {
                    package3.downloadLinks.forEach(function(link) {
                        linkIds.push(link.UUID);
                    })
                })

                linkIds.sort().forEach(function(linkId) {
                    callAPI("downloadsV2", "moveLinks", [linkId], -1, package.UUID);
                })
            }
        }
    })
}

I wanna put all my link that i have into one package, rite now it's all over the place. Could you help me plz? Thx in advance

[DragoBleaPiece]

I don't know where should i ask about this. So, i wanna put all my download URLs after the file has been downloaded into a file (txt or smth), and for the next download, the URL should be checked first with that file containing finished download URLs
Any solution for this? Thank you

[GreenXIII]

Originally Posted by mgpai

Keep a backup of your link list before testing/using the script.

Merge download packages which have matching name and download folder, sorting links in descending order by ID.
Trigger: Toolbar button pressed
Customize main toolbar > Add a new "Eventscripter Trigger" button > Rename it to "Merge Packages" (case-sensitive) > Change Icon (optional)
*/

if (name == "Merge Packages") {

...
}[/CODE]

Thank you very much. But the script is not working for me.
I'm setting the script to start as JDownloader starts, is that correct?
I'm getting a "ReferenceError: "name" is not defined (#7)" error when JD2 loads.

[Jiaz]

@GreenXIII: made sure to set the correct trigger event type?

[GreenXIII]

Originally Posted by Jiaz

@GreenXIII: made sure to set the correct trigger event type?

Ok, found my mistake, had to configure the toolbar button and set the script to "Toolbar button pressed"

It's working! But it's very slow. I think it does one link per second. Isn't there a way to make it check the packagenames instead of each link at a time?

EDIT: it was slow because it was running all morning and afternoon. After I restarted JD and ran it again, it got fast again.

EDIT: also, it ignores uppercases/lowercases and treat them as different

[mgpai]

Originally Posted by GreenXIII

... it's very slow. I think it does one link per second. Isn't there a way to make it check the packagenames instead of each link at a time?

It does match only package names and download folders. But, the additional task of sorting links in a desired order can considerably slow it down. Can also be caused by insufficient memory. You can try allocating more memory to JD.

Originally Posted by GreenXIII

...it ignores uppercases/lowercases and treat them as different

That is the default behavior, which is in line with case-sensitive file systems. To ignore both package and folder case, replace the following code:

if (package2.name + package2.downloadFolder == package.name + package.downloadFolder) {

with:

if ((package2.name + package2.downloadFolder).toLowerCase() == (package.name + package.downloadFolder).toLowerCase()) {

[mgpai]

Originally Posted by DragoBleaPiece

Can we use this script for enabling/disabling particular packagizer rules, not all of em?

While possible, will require you to create separate buttons for each rule you want to disable, which may not be practical. A better option would be to make the rule more restrictive and force it to match only under certain conditions.

Originally Posted by DragoBleaPiece

I wanna put all my link that i have into one package, rite now it's all over the place.

Feature already present in GUI. You can select links and use the context menu command "Move to new package". Please note that the corresponding files existing on disk will also be moved to single/same folder. You can disable the following advanced setting to move only the links and keep the files in their original location.

GeneralSettings.movefilesifdownloaddestinationchangesenabled

Originally Posted by DragoBleaPiece

... i wanna put all my download URLs after the file has been downloaded into a file (txt or smth), and for the next download, the URL should be checked first with that file containing finished download URLs

THIS thread contains a script for similar request.

[GreenXIII]

I've been using this script for restarting downloads that are too slow. It works, many sites get a faster DL speed after resuming.
But it has two flaws: I don't think it excludes non-resumable downloads. And it restarts the download way too fast. Some sites don't like that. For example, video.fc2 gets corrupted videos due to it.

// Stop and restart slow links.
// Trigger Required: "Interval" (Recommended: 30000 or more).
// IMPORTANT: Enable "Synchronous execution of script" (checkbox).

var minSpeed = 500; // (KiB/s) <- minimum download speed per link.
var minDuration = 1; // (minutes) <- minimum download duration per link.

var links = getRunningDownloadLinks();

for (i = 0; i < links.length; i++) {
    var link = links[i];
    if (link.getDownloadDuration() < minDuration * 60 * 1000) continue;
    if (link.getSpeed() > minSpeed * 1024) continue;
    link.abort();
    sleep(30000); //I've added this, but it's not working
}

I'd like it to do one of two things (or both, via a toggeable variable):
1) Go to another download and come back after that to the current one;
2) Have a longer timer between retrying the current download.

I haven't tried a non-resumable download yet, but if the script doesn't ignore those, I'd like it to do so.

[mgpai]

Originally Posted by GreenXIII

... script for restarting downloads that are too slow ...

/*
    Skip/Unskip resumable links, based on user-specified speed and duration
    Trigger: Interval (Recommended 60000 or more)
*/

var links = [];

getRunningDownloadLinks().forEach(function(link) {
    if (
        link.resumeable &&
        link.downloadDuration > 60 * 1000 && // minimum download duration (milliseconds)
        link.speed < 500 * 1024 // minimum speed (bytes)
    ) {
        link.skipped = true;
        links.push(link);
    }
})

if (links.length) {
    sleep(30000); // time to wait before unskipping links (milliseconds);

    links.forEach(function(link) {
        link.skipped = false;
    })
}

[Rodark]

is there a script that when a download speed drops at 130kbs, it can stop all downloads and immediately restart them?
i found one but it takes time to stop and restart
im downloading from a site that has only a 64~kbps per download(max 2) BUT when the download starts, it starts with max speed and drops.
Meaning, when i start the download its 6-7Mbps and it gradually drops to 130kbps . So i need a script that when it drops at that, it stop and restarts asap. the one im using it takes a couple of minutes to restart

[mgpai]

Originally Posted by Rodark

is there a script that when a download speed drops at 130kbs, it can stop all downloads and immediately restart them?
i found one but it takes time to stop and restart

Which script did you use? Stopping downloads usually takes a few seconds.

[Rodark]

Originally Posted by mgpai

Which script did you use? Stopping downloads usually takes a few seconds.

sleep(waitTime * 60 * 1000);
startDownloads();
}

// Check if all downloads have been running for atleast the minimum duration.
function running() {
var links = getRunningDownloadLinks();
if (links.length > 0) {
for (i = 0; i < links.length; i++) {
var link = links[i];
if (link.getDownloadDuration() < minDuration * 60 * 1000) {
return false;
}
}
return true;
} else {
return false;
}
}
thats the one im using. found it on another page/thread

it isnt instant for me, it takes a little time to restart. so currently im manually stop/restarting. can it be modified to stop and restart on the spot if the speed is less than 140 kbps?

[mgpai]

Originally Posted by Rodark

... stop and restart on the spot if the speed is less than 140 kbps?

Try this:

/*
    Restart download links if the current average speed is less than user-specified speed
    Trigger Required: Interval (Recommended 30000 or more)
*/    

var minSpeed = 140, // (KiB/s) <- minimum average download Speed
    minDuration = 60, // (seconds) <- minimum download duration per link
    running = getRunningDownloadLinks().every(function(link) {
        return link.downloadDuration > minDuration * 1000;
    });

if (running && getAverageSpeed() < minSpeed * 1024) {
    getRunningDownloadLinks().forEach(function(link) {
        link.abort();
    })
}

[Rodark]

Originally Posted by mgpai

Try this:

/*
    Restart download links if the current average speed is less than user-specified speed
    Trigger Required: Interval (Recommended 30000 or more)
*/    

var minSpeed = 140, // (KiB/s) <- minimum average download Speed
    minDuration = 60, // (seconds) <- minimum download duration per link
    running = getRunningDownloadLinks().every(function(link) {
        return link.downloadDuration > minDuration * 1000;
    });

if (running && getAverageSpeed() < minSpeed * 1024) {
    getRunningDownloadLinks().forEach(function(link) {
        link.abort();
    })
}

thank you for this! it does take around a minute for it to realize it has dropped speed, but the stop/start action is instant! thanks mate

[mgpai]

Originally Posted by Rodark

... it does take around a minute for it to realize it has dropped speed...

For faster response, you can reduce the script interval (recommended is 30000 ms) and also the minDuration (default in the script is 60 seconds).

The download will usually require a few seconds to reach max speed. Experiment with different values and keep them large enough to prevent false stop/start loops.

[Rodark]

thanks for the info mate!

[little]

Originally Posted by fred_gaou

Hi,

Here is a script to help you to auto clean/format filename during the link grabbing process. This is done automatically in background for each added link.

You can set some options at the top of the script.

This is useful in any case as soon as you notice a recurring pattern in your filenames that you'll want to get rid of or format.

if you set custom filename for video files such as:

[*CHANNEL*] (*PLAYLIST_NAME* *PLAYLIST_POSITION[00]*) *DATE[YY.MM.dd]* - *VIDEO_NAME*.*EXT*

it will be perfect for playlist but not for one video file only because then you will end with a filename with empty brackets:

[Any Youtuber Channel] ( ) 17.03.11 - Video Title

This script will take care of it removing those bracket:

[Any Youtuber Channel] 17.03.11 - Video Title

// LINK NAME CLEANER (auto)
// Trigger required: Packagizer Hook
// Version 2017.11.14
/* *************************************************************************
Set the characters that will be removed from both ends of the filename.
Be sure to double escape special chars such as "\\s" instead of "\s".
****************************************************************************/

var leadAndTrailTrimChars = "\\s-_";

/* *************************************************************************
Set the characters that will be replaced with whitespace.
Be sure to double escape special chars such as "\\s" instead of "\s".
****************************************************************************/

var charToSpace = "_";

/* *************************************************************************
Set the words or phrases to remove. Words/phrases must be separated with | such as
"word one|word two|word three"
Be sure to double escape special chars such as "\\s" instead of "\s".
****************************************************************************/

var wordsToRemove = "avec sous-titres";

/***************************************************************************/

if (linkcheckDone) {


    /* =========================== INITIALIZE ============================ */

    var myPackagizerLink = link;
    var fileName = myPackagizerLink.getName();
    var re, ext;

    // Remove the extension from the end and save it for later.
    // And make it lower case at the same time.
    ext = fileName.slice((fileName.lastIndexOf(".") - 1 >>> 0) + 2);
    if (ext !== "") {
        ext = "." + ext.toLowerCase();
    }

    // If extension exists, then we will work with the filename without extension
    fileName = fileName.substr(0, (fileName.length - ext.length));

    /* ========================= REGEX PATTERNS ========================== */

    // Remove these words/phrase : wordsToRemove
    re = new RegExp("\\b(?:" + wordsToRemove + ")\\b", "gi");
    fileName = fileName.replace(re, "");

    // Replace these characters with whitespace : charToSpace
    re = new RegExp("[" + charToSpace + "]", "gi");
    fileName = fileName.replace(re, " ");

    // Delete empty bracket content. "( )", "[ ]" or "{ }" will be removed from filename.    
    re = new RegExp("(\\(\\s+?\\))|(\\[\\s+?\\])|({\\s+?})", "gi");
    fileName = fileName.replace(re, "");

    /* ====== ALWAYS APPLY NEXT REPLACEMENTS AT THE END OF PROCESS ======= */

    // Replace & with &
    re = new RegExp("&", "gi");
    fileName = fileName.replace(re, "&");

    // Remove unwanted characters from both ends of the filename
    re = new RegExp("^[" + leadAndTrailTrimChars + "]*(.+?)[" + leadAndTrailTrimChars + "]*$", "gi");
    fileName = fileName.replace(re, "$1");

    // Replace multiple spaces with only one
    re = new RegExp("\\s\\s+", "gi");
    fileName = fileName.replace(re, " ");

    // Removes whitespace from both ends of the filename (just to be sure)
    fileName = fileName.trim();

    /* ====== APPLY NEW FILE NAME ======= */
    myPackagizerLink.setName(fileName + ext);
}

I wanted to try it :

java.lang.NullPointerException
        at org.jdownloader.extensions.eventscripter.ScriptThread$1.compare(ScriptThread.java:301)
        at org.jdownloader.extensions.eventscripter.ScriptThread$1.compare(ScriptThread.java:298)
        at java.base/java.util.Arrays.mergeSort(Arrays.java:1338)
        at java.base/java.util.Arrays.mergeSort(Arrays.java:1350)
        at java.base/java.util.Arrays.mergeSort(Arrays.java:1350)
        at java.base/java.util.Arrays.mergeSort(Arrays.java:1349)
        at java.base/java.util.Arrays.mergeSort(Arrays.java:1350)
        at java.base/java.util.Arrays.mergeSort(Arrays.java:1350)
        at java.base/java.util.Arrays.legacyMergeSort(Arrays.java:1317)
        at java.base/java.util.Arrays.sort(Arrays.java:1304)
        at java.base/java.util.ArrayList.sort(ArrayList.java:1721)
        at java.base/java.util.Collections.sort(Collections.java:179)
        at org.jdownloader.extensions.eventscripter.ScriptThread.cleanupClasses(ScriptThread.java:298)
        at org.jdownloader.extensions.eventscripter.ScriptThread.executeScipt(ScriptThread.java:178)
        at org.jdownloader.extensions.eventscripter.ScriptThread.run(ScriptThread.java:160)

Any idea on how to fix it ? Thank you very much.

[Jiaz]

@little: please create a log, see https://support.jdownloader.org/Know...d-session-logs
and post logID here