#1
|
|||
|
|||
![]()
When multiple images are bundled under a single link, JD only finds the first image.
Would it be possible to integrate support for multi images? Example: h**ps://www.deviantart.com/nono62/art/Shego-from-KIM-POSSIBLE-1142326345 |
#2
|
||||
|
||||
![]()
@slumber6974:
Multi image is new to me and plugin doesn't yet support it Can you please provide more example links?
__________________
JD-Dev & Server-Admin |
#3
|
|||
|
|||
![]()
Thanks for your answer. Please, more examples:
h**ps://www.deviantart.com/nono62/art/What-if-Borg-Daenerys-GOT-StarTrek-1138912023 h**ps://www.deviantart.com/murex90/art/Enchanting-Ice-Queen-with-Mesmerizing-Blue-Eyes-1142172496 h**ps://www.deviantart.com/ctmartstudio/art/Neon-Horizon-Cityscape-12K-1141622063 h**ps://www.deviantart.com/missaibondagelover/art/Busty-princess-1142144938 Sometimes there are 2 images, some have 20 or more. Last edited by slumber6974; 04.01.2025 at 13:56. Reason: addition |
#4
|
||||
|
||||
![]()
@slumber6974: thanks. will take some time because we have to change how current plugin works
__________________
JD-Dev & Server-Admin |
#5
|
|||
|
|||
![]()
Thank you, I'll wait patiently...
|
#6
|
||||
|
||||
![]()
Thanks for your understanding
![]()
__________________
JD-Dev & Server-Admin |
#7
|
||||
|
||||
![]()
Is there no way to display those images in another kind of overview?
I mean they're still individual links so deviantart really only added some kind of overlay to make a gallery out of the single image view they had so far.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download |
#8
|
|||
|
|||
![]() Quote:
One can only laboriously search out the individual links of the pictures, that's why I requested ![]() |
#9
|
||||
|
||||
![]()
Ok.
Well then you will either need to collect those links manually for now or wait until one of us finds time to enhance the plugin.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download |
#10
|
||||
|
||||
![]()
I've taken a closer look at this:
According to DeviantArt's internals, this is considered "related content," so I assume this type of collection is auto-generated by DeviantArt. For this reason, I would decline adding extra crawling functionality for it. Since all of these images come from the same profile, you might as well use the existing crawler functionality to:
Please let me know if you think my assumptions or findings are incorrect.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download Last edited by pspzockerscene; 31.01.2025 at 14:26. |
#11
|
|||
|
|||
![]() Quote:
Try as an example: **External links are only visible to Support Staff****External links are only visible to Support Staff** You get all the (at the moment) existing 153 pics, but not those that are left in multi image links! Same as crawl a single link with 100 images, you only get the first one: **External links are only visible to Support Staff****External links are only visible to Support Staff** It seems the functionality is more and more used to avoid and increase the 40.000 file limit - 100 images under one link count as one.... ;-) Last edited by slumber6974; 31.01.2025 at 14:52. Reason: add |
#12
|
||||
|
||||
![]() Quote:
1. Crawling the entire profile: Code:
deviantart.com/comestomindart/gallery/all 2. I then opened an item with multiple images, e.g.: Code:
deviantart.com/comestomindart/art/A-Night-at-the-Ball-set-of-3-1153556126 Code:
deviantart.com/comestomindart/art/Queen-of-the-Forest-1082340358 So far, your theory seems to be incorrect. However, if you can provide suitable examples, I am more than open to being convinced otherwise.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download |
#13
|
|||
|
|||
![]()
I can't get it right.
In the first example, there are more than 153 pictures in total. It would simply be convenient to download all images under a single link - instead of all images of the user or complete galleries. |
#14
|
||||
|
||||
![]() Quote:
Never said that this won't happen, but only explained that it means more work required to rewrite plugin because current way it works, doesn't support multiple images with a single link
__________________
JD-Dev & Server-Admin |
#15
|
|||
|
|||
![]() Quote:
PS. Take your time. I won't push. Last edited by slumber6974; 31.01.2025 at 17:30. Reason: add |
#16
|
||||
|
||||
![]()
Ah okay, did not check that. Thanks for the feedback!
__________________
JD-Dev & Server-Admin |
#17
|
|||
|
|||
![]()
Unfortunately, I'm too untalented to contribute much, would like to help.
Have a nice weekend! |
#18
|
||||
|
||||
![]()
Ahh I'm sorry guys but while I indeed didn't decline this one, I'am still not able to find more than 153 images of that particular user.
As long as this is not clarified, there is no point to add "multi image support". I'm still waiting for a proof that I can reproduce here. To be absolutely clear: When I'm adding "all" images of that user using the already available crawler, I was unable to find any extra items hidden inside those "multi image galleries" as all of them were already crawled, at least this is my test-result.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download |
#19
|
|||
|
|||
![]()
Maybe this link and statement of the user will convince you?
**External links are only visible to Support Staff****External links are only visible to Support Staff** "40k seems to be the limit (yes, it is also a ridiculous high number), so here I will try to make a workaround, and upload multiple image to each file..." |
#20
|
||||
|
||||
![]()
@slumber6974: "convince" is the wrong word
![]() We will work on this one but, as already explained, this might take some time = may take longer
__________________
JD-Dev & Server-Admin |
#21
|
|||
|
|||
![]()
Is the link above proof enough?
Other users there do it the same way for the same reason. And yes, there are also examples where images can be found in both - the regular galleries and under multi links, but more unusual. Take your time, I can wait ![]() |
#22
|
||||
|
||||
![]()
I'm still not 'convinced'.
I neither want to make a stupid argument about this nor do I want to put any more time into more tests. Maybe send me a video explanation or do a quick Teamviewer live session with me to clear things up. I still don't see me implementing this.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download Last edited by pspzockerscene; 10.02.2025 at 20:14. Reason: Updated wording of last sentence. |
#23
|
|||
|
|||
![]()
Why?
If I load the gallery above **External links are only visible to Support Staff****External links are only visible to Support Staff** I get exactly 12 images from the single links there in - in fact, there are 87 in the first link alone. The other 86 are not found by JDownloader, even if I try to load "all" galleries. ![]() But ok, if you reject my suggestion and don't want to change anything... it's your right and I can live with it ![]() Last edited by slumber6974; 10.02.2025 at 20:35. |
#24
|
||||
|
||||
![]()
Indeed this example shows that for galleries, the feature is indeed needed because the user does not get what he expects: All images.
This is the proof I was looking for; thanks. Previously I've compared the crawl results of a whole user profile vs items inside ther same users' multi image galleries and when doing this, nothing was missing. So it looks like when you currently crawl a user profile, all items (also the ones inside multi image galleries) will be added but when crawling a gallery, this is not the case. I've changed this threads prefix again to "See Bugtracker". EDIT I've started working on this.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download Last edited by pspzockerscene; 10.02.2025 at 23:15. Reason: EDIT I've started working on this. |
#25
|
||||
|
||||
![]()
@slumber6974: this change simply requires some non minor changes to the plugin for this site and thus we wanted to make sure that there was no *different/more easier* way to get hands on those images
![]() ![]()
__________________
JD-Dev & Server-Admin |
#26
|
|||
|
|||
![]()
Thank you, and thank you all for your help and patience!
![]() |
#27
|
||||
|
||||
![]()
Better wait to thank us when the updated plugin is ready
![]()
__________________
JD-Dev & Server-Admin |
#28
|
||||
|
||||
![]()
I've carefully started working on this.
It requires some more changes (all with making sure that older links in downloadlist keep working) -> Will take some time.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download |
#29
|
||||
|
||||
![]() Example: Code:
deviantart.com/sigried81/art/I-just-can-t-recommend-it-highly-enough-1157577702 However under the first image there are a bunch more. Are those "similar items" or do they belong to the gallery? Screenshot:
Spoiler:
![]() EDIT Okay my guess is that it's about the images below the main once which cannot be opened in a separate link. Funny enough, even when logged in, the "official download" button will also always only download the first image.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download Last edited by pspzockerscene; 11.02.2025 at 16:39. |
#30
|
||||
|
||||
![]()
Deviantart multi image gallery support is ready to be released.
In addition, I've added a setting that allows user to prohibit the crawler from looking for multi image galleries. This can make things faster for users who know that they are only adding '/art/' items with single images. Screenshot:
Spoiler:
![]() By default, the crawler will look for multi image items. Other changes include: - fixed sometimes missing file size: set file size of original image even if original is not downloadable or image is not downloadable at all. Having a file size set is always better than none. Side note: During testing yesterday I noticed that DA looks to be having troubles with displaying the first image of multi image galleries (it's often unavailable, also in browser). Bitte auf das nächste CORE-Update warten! Please wait for the next CORE-Update! Wartest du auf einen angekündigten Bugfix oder ein neues Feature? Updates werden nicht immer sofort bereitgestellt! Bitte lies unser Update FAQ! | Please read our Update FAQ! --- Are you waiting for recently announced changes to get released? Updates to not necessarily get released immediately! Bitte lies unser Update FAQ! | Please read our Update FAQ! -psp-
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download |
#31
|
|||
|
|||
![]()
Many thanks for your work!
Just tested it after last update, using the example I had posted before... **External links are only visible to Support Staff****External links are only visible to Support Staff** But something goes wrong here, JD loads the first pic just 86 times - always the same. It also shows 86 times the same file size in the link grabber window. Tried another link - same result. Checking plugin settings brought no help. Last edited by slumber6974; 14.02.2025 at 18:35. Reason: add |
#32
|
||||
|
||||
![]()
@slumber6974: Thanks for the feedback, we will look into it
__________________
JD-Dev & Server-Admin |
#33
|
||||
|
||||
![]()
Ohh sorry I didn't want to let things burn before the weekend.
I just noticed that the problem only happens when an active DA account is available in JD (looks like this is what I haven't tested...). I'm working on it. Quick workaround for now: 1. Disable or remove your DA account from JD. 2. Delete previosuly added DA links. 3. Re-add those links. Now it should work fine -> Only the first item has a file size set, the others have "Unknown size" until the download is started.
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download |
#34
|
|||
|
|||
![]()
Much thanks!
With disabled account it works fine indeed for free visible content - of course not if an account is needed to view... ![]() Have a nice weekend. |
#35
|
||||
|
||||
![]()
Fixed multiple logic mistakes that caused this problem.
Plugin-Update with the fix should be there in some minutes. Please provide some examples for that case. I came across some tricks... ![]() Thanks, you too!
__________________
JD Supporter, Plugin Dev. & Community Manager
Erste Schritte & Tutorials || JDownloader 2 Setup Download |
#36
|
|||
|
|||
![]() Quote:
![]() (Same example as above - with deactivated account JD shows "media broken?" for the first pic.) Last edited by slumber6974; 14.02.2025 at 19:56. Reason: edit |
#37
|
||||
|
||||
![]()
@slumber6974: have you updated and tested again? still failing?
__________________
JD-Dev & Server-Admin |
#38
|
|||
|
|||
![]()
Seems to work perfectly now!
Except as I wrote above for links where an account is needed for: If have no or deactivated or outdated account, first image always shows the "Media broken?" error but all other images load... hmmm That's maybe a minor problem and none for me ![]() Great work! ![]() |
#39
|
||||
|
||||
![]()
@slumber6974: Thanks for the feedback. could you please provide a log for this error = reproduce the media broken and create log and post logID
__________________
JD-Dev & Server-Admin |
#40
|
|||
|
|||
![]()
Ok, first time done, I hope it's right:
14.02.25 22.40.57 <--> 14.02.25 22.48.56 jdlog://6809411370661/ |
![]() |
Thread Tools | |
Display Modes | |
|
|