JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 30.10.2011, 02:30
tessus
Guest
 
Posts: n/a
Default Growl notifications do not work

I'm using version 0.9.581.

Growl notifications do not work on MacOSX systems with any other locale than German. I was able to get it working by changing the growlNotification.scpt file as follows:

on run argv
tell application "GrowlHelperApp"

set varDescription to item 1 of argv
set varFilename to item 2 of argv
set varTitle to item 3 of argv

set the allNotificationsList to {"Default"}
set the enabledNotificationsList to {"Default"}

register as application ¬
"jDownloader" all notifications allNotificationsList ¬
default notifications enabledNotificationsList ¬
icon of application "jDownloader"

notify with name ¬
"Default" title varTitle ¬
description varFilename & " " & varDescription ¬
application name "jDownloader"

end tell

end run


This problem is known for several years now, but nobody seems to be interested in fixing it, although it wouldn't take longer than 2 minutes to do so.
I just wanted to bring it up again.

Cheers,
Helmut

P.S.: If you give me write access to your repository, I'll fix it.
Reply With Quote
  #2  
Old 30.10.2011, 04:18
kdean kdean is offline
Black Hole
 
Join Date: Jul 2010
Posts: 278
Default

Fixed in Nightly version... not sure when they'll release it as a stable version with the fix.
Reply With Quote
  #3  
Old 30.10.2011, 04:32
tessus
Guest
 
Posts: n/a
Default

Sounds good. Thanks.
Reply With Quote
  #4  
Old 30.10.2011, 06:09
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 16,216
Default

Think this has also been fixed in the next major version. You will have to wait for the next major update to test and make sure..
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #5  
Old 30.10.2011, 07:51
tessus
Guest
 
Posts: n/a
Default

Ok, let's hope it will be really fixed. :-)

Can't wait to test it!
Reply With Quote
  #6  
Old 30.10.2011, 10:30
remi
Guest
 
Posts: n/a
Cool

Quote:
Originally Posted by tessus View Post
This problem is known for several years now, but nobody seems to be interested in fixing it, although it wouldn't take longer than 2 minutes to do so.
I think you're way too modest. Some problems can only be solved by knowledgeable people. You're the first one who can because you've the knowledge to do so.
Reply With Quote
  #7  
Old 29.11.2011, 14:35
Sk1nk
Guest
 
Posts: n/a
Default

Just to make sure, would this work with Growl 1.3 or just with the old one? Because atm I got Growl from the AppStore and the latest Version of jDownloader but they don't seem to work together, even in the german local.
Reply With Quote
  #8  
Old 05.12.2011, 03:30
celerondude celerondude is offline
Banned
 
Join Date: Dec 2010
Posts: 165
Default

Hi,

according to the documentation on the Growl website (**External links are only visible to Support Staff****External links are only visible to Support Staff**) there should be an additional check if Growl is actually running. The modified script looks like this:

Code:
on run argv
	
	tell application "System Events"
		set isRunning to (count of (every process whose bundle identifier is "com.Growl.GrowlHelperApp")) > 0
	end tell
	
	if isRunning then
		
		tell application id "com.Growl.GrowlHelperApp"
			
			set varDescription to item 1 of argv
			set varFilename to item 2 of argv
			set varTitle to item 3 of argv
			
			set the allNotificationsList to {"Default"}
			set the enabledNotificationsList to {"Default"}
			
			register as application ¬
				"jDownloader" all notifications allNotificationsList ¬
				default notifications enabledNotificationsList ¬
				icon of application "jDownloader"
			
			notify with name ¬
				"Default" title varTitle ¬
				description varFilename & " " & varDescription ¬
				application name "jDownloader"
			
		end tell
	end if
end run
I tested it with Growl 1.3.1 from the App Store and it works nicely for me.

Note: i am using a bugmenot account because i didn't want to create one just to post this.

bye
Reply With Quote
  #9  
Old 09.12.2011, 23:50
tessus
Guest
 
Posts: n/a
Default

I just saw that there were 650 files that were updated and after the update Growl notifications still do not work.
Just wondering: what is considered a major update?
Reply With Quote
  #10  
Old 10.12.2011, 00:11
Statter Statter is offline
JD VIP
 
Join Date: Aug 2010
Posts: 455
Default

hmm not sure on this as I have growl installed but turned off for most apps as It is annoying to me for most of the various app popups.

Be sure though that you have checked the settings in the system preferences for Growl and you may need to also add Jdownloader to the list of applications and be sure it is configured correctly for what you wish to happen that Growl allows.
__________________
OS X !0.6.8 Mac Pro Intel (Workhorse)
OS X 10.10.5 MBP Intel (Secondary)
Reply With Quote
  #11  
Old 10.12.2011, 00:32
tessus
Guest
 
Posts: n/a
Default

You are joking right now, right? The growlNotification.scpt file is still the same, so how do you think the notifications will work all of a sudden.
Reply With Quote
  #12  
Old 10.12.2011, 01:51
Statter Statter is offline
JD VIP
 
Join Date: Aug 2010
Posts: 455
Default

Im not talking about the growlNotification.scpt which has not changed since 2009 within JD but, the OS System Preferences Growl PrefPane settings.

It may be that the growlNotification.scpt needs updating but, again tht script I think is ok but of course a dev will need to look at changes for the latest Growl from that dev and the growlNotification.scpt within JD to be sure something did not get broken from either Dev for JD.
__________________
OS X !0.6.8 Mac Pro Intel (Workhorse)
OS X 10.10.5 MBP Intel (Secondary)
Reply With Quote
  #13  
Old 10.12.2011, 02:06
tessus
Guest
 
Posts: n/a
Default

Ok, did you actually read this thread?

The growl notification settings are correct and notifications only work, if a German locale is used, because some very intelligent person hard coded German into the script.

Unless development does not change the script as I have posted earlier, IT WILL NOT WORK except for a German system.

As soon as I exchange the script, everything works perfectly with any locale. The only problem is that development did not commit my changes to the repository.

Do you understand what I am talking about?
Reply With Quote
  #14  
Old 10.12.2011, 03:56
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 16,216
Default

the next major update will be coming in a few months away and a couple months for the beta, the updates for stable and beta (nightly) are only plugin updates. The quantity of updates you've seen is due to refactoring (eg. one small change across all of the plugins).
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 08:59.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.