[MaybeGrimm]

Hi there! I have found a few errors when I tried to backup my images. I'll describe them and add a public example board to test it:

1 - Images on boards don't load, just in subboards.
Ex: **External links are only visible to Support Staff****External links are only visible to Support Staff**
So, when I paste this link in the Link Grabber, it only shows the package of the subboard (4P) and doesn't include the images of the board that are out of the subboard.

2 - Boards without subboards don't get recognized.
Ex: **External links are only visible to Support Staff****External links are only visible to Support Staff**
I assume is related to the previous one. Literally it processes the link, but never grabs the images.

3 - On boards with larger images, it doesn't "scroll down" properly, missing a few images.
Ex: **External links are only visible to Support Staff****External links are only visible to Support Staff**
(subboard: Styles - SFW)
Since this subboard includes a lot of large images, it loads only a few and ignores around 20, cause it doesn't reach until the end of the board. Hope I explained it well, hopefully it'll be more easy to understanding looking at the board.

As a note, all this things worked fine on previous version of the plugin, but I can't tell exactly which version I had before it auto-updated.

Thanks for reading!

[pspzockerscene]

Hi MaybeGrimm,
The next update will fix all the issues you've mentioned.
In fact it was already finished but I forgot my last batch of changes in "debug mode only" by mistake.

Just a sidenote to your point 3: missing images:
While the crawler found all 107 items of your example URL in my test, "missing items" can still happen though my investigation pointed to this being a serverside pinterest.com bug.
If this is interesting for you, you can read more about this here:
https://board.jdownloader.org/showthread.php?t=95115
Also the changes I mentioned in the linked thread will be active once the update I was talking about in your thread goes live.

Feel free to double-check my findings and report them to the pinterest support if you think that's worth it.

Please post your log-ID here
If your bugreport is about a specific website which JD supports via plugin, please also provide example URLs which can be used to reproduce the issue you are having.

Bitte poste deine Log-ID hier.
Falls dein gemeldetes Problem ein Problem mit einer Webseite ist, die per Plugin unterstützt wird, stelle bitte zusätzlich Testlinks zur Verfügung, mit denen sich dein Problem nachstellen lässt.

Important notice:
Our ticket system & knowledgebase are currently under maintenance.
If this is still the case while you are reading my posts and you can't access help articles linked by our staff, use the Internet archive/wayback machine to be able to view those articles:
archive.org/web/
Enter the URL -> Click on "Browse history" -> Select one of the latest dates available
If the date you selected does not lead you to the support article try the next oldest one.

[MaybeGrimm]

TYSM! Waiting eagerly the update n.n

About the error 3, I have read the other thread and yes, can confirm that this happens a lot with Pinterest. However, it can be easily recognized by Organizing boards and clicking Select All, which usually gives the accurate amount of pins in the board as a counter.
I think in this case it also haves something to with Pinterest, which doesn't load the other images until you have reached the very end of the larger image, despite having space visually available on the board to display. I was wondering if this was something the plugin could solve by "scrolling down until the end a lot".
Sorry if the explanation isn't great, I could provide screenshots if it's useful.

[pspzockerscene]

The update has been released about one hour ago.

Originally Posted by MaybeGrimm

I was wondering if this was something the plugin could solve by "scrolling down until the end a lot".

The plugin already does this otherwise it would only be able to crawl all items of the first page.
This is called "pagination": en.wikipedia.org/wiki/Pagination

Again and to be absolutely clear:
Pinterest does in some cases return a wrong "total amount of items" value.
The plugin doesn't care about that but this means that you will in some cases get less items than proposed by pinterest and JD is not at fault.
Example:

pinterest.de/josielindatoth/deserts/

--> Website claims that the board contains 178 items but there are only 177.
Screenshot:


I guess maybe tis happens when items of existing board get deleted and pinterest doesn't update the total item count.
If this really is a serverside pinterest, it might be in your interest to report it to their support.

[MaybeGrimm]

Thanks for the reply! I have updated the app and, unfortunately, it doesn't seem to recognize subboards anymore (in the sense of putting those images in different packages). It puts all the images in one package with the name of the main board.

[pspzockerscene]

Please post example URLs which contain "subboards".

[MaybeGrimm]

Sure! This one for example: **External links are only visible to Support Staff****External links are only visible to Support Staff** (is the same as the original error 3).

Strangely though, now it actually grabs the 107 images, so I guess the issue wasn't the Pinterest bug and now is fixed on the plugin somehow. Any ways to keep it this way while returning the subboards?

[pspzockerscene]

Originally Posted by MaybeGrimm

Strangely though, now it actually grabs the 107 images, so I guess the issue wasn't the Pinterest bug

I never claimed it was - my initial reply even states that during testing, I was able to find all items.
I just wanted to tell you about that potential pinterest bug for the future before you assume that it is a JD plugin bug.
If you're downloading a lot of pinterest items, you will sooner or later find a board where the number of the pinterest website does not match up with the number of items you see in JD.

Originally Posted by MaybeGrimm

Any ways to keep it this way while returning the subboards?

I've understood the problem, I can reproduce it and I'm working on a fix.

[pspzockerscene]

Addendum:
Getting the "sectionless board PINs" is actually not that easy:
The website is displaying all PINs in the "board view" and there looks to be no way to remove them.
This means that I'd need to first crawl all sections, then crawl all PINs, then filter all items that haven't been crawled inside sections already, then return the results.

Unless you got hints for me to do this in an easier way, I'll work on this tomorrow.

[MaybeGrimm]

Yeah sure, no problem. Honestly I don't know how to help on it, the only things I could help on are on user side saying that it worked well before it autoupdated, but as I said in my first post, I can't tell which version was cause I haven't done a backup in a while, and it's the only thing I use JD2 for. So sorry on that.

Edit: However, it still missed some pins for Error 3, so not perfectly perfectly, i don't know how to explain it.

[pspzockerscene]

I'm very unsure if that has ever worked "correctly" but looking that up would take more time than fixing it now plus the pinterest.com API has changed so most likely that old plugin version/code would fail anyways very soon.

I've found a more elegant way to do this so please update your JDownloader, try again and provide feedback.

[MaybeGrimm]

I have updated and tried it and now subboards are back and it grabs all the images on the board!

The only thing failing is that the ones that it "doesn't get" from the Styles - SFW subboard, it puts them in the general "Drawing Resources - My Favs" package.
So, 107 images are grabbed, but instead of the "Styles - SFW" package being 96 elements, it's 73; and the "Drawing Resources - My Favs" instead of being 3 elements, it's 26.

Hope I explained it well and that the feedback is useful.

Edit/Ps: Personally I prefer this 100% to the missing of images, but I think it could be useful to comment it.

[pspzockerscene]

Originally Posted by MaybeGrimm

Hope I explained it well and that the feedback is useful.

Yap, understood.
I will look into this some time within the next few days.

[MaybeGrimm]

Thanks for it! And thanks for what you've already done.

[pspzockerscene]

Fixed.
The problem was that pinterest.com is sometimes delivering pages containing less than the expected "max items per page" thus the section crawler did stop too early and all missing items were filled in by the "sectionless board PIN crawler".

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!
---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

-psp-

[MaybeGrimm]

Now it grabs it great! Both boards and subboards.

It has a problem of not recognizing the private ones though. I have successfully logged in with the cookies as password, but maybe it has more to do with Pinterest API changing? When you put a link of a private board, it shows a "Empty profile!pinterest" package, with the file "Empty profile!pinterest.com" inside.
It's easily fixable turning the boards to public while it grabs and downloads, so no big issue, but I thought the feedback would help.

[pspzockerscene]

Please send me the following information via private message:
- Login to a pinterest.com account
- Example link which goes to a private pinterest pin/board/section

[MaybeGrimm]

It's connected to my Google account, so I'm unable to do that. But if it works for you on private boards, I can try later again.

[pspzockerscene]

Next update contains an experimental change which may or may not make it work for you for private boards.
If said update doesn't help, I need login credentials to work on this.

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!
---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

-psp-

[MaybeGrimm]

New update didn't solve it, but I didn't find a way to share the credentials without the Google account. It can be solved making the board public for a while though, so it's good n.n
TYSM for your help!

[pspzockerscene]

Originally Posted by MaybeGrimm

New update didn't solve it

The update has just been released ~5 minutes ago. Are you sure you've tested after the update was installed?
Also, did you add your pinterest.com account to JDownloader before testing?

Originally Posted by MaybeGrimm

I didn't find a way to share the credentials without the Google account

That should be possible - you can simply share your exported login-cookies with me.
Instructions:
https://support.jdownloader.org/de/k...n-instructions

You can put the exported cookies in a .txt file and send this to me via private message
Do not forget to include a list of private boards for testing.
I'm offline for today.

[MaybeGrimm]

Oh, sorry! It's just that an update appeared around 10 minutes after your previous message, so I assumed it was that one.

I've tried the new update, but it makes the EmptyProfile thing with both public and private boards T_T

I'll pass the cookies by DM then!

Boards:
**External links are only visible to Support Staff****External links are only visible to Support Staff** (private with subboards)
**External links are only visible to Support Staff****External links are only visible to Support Staff** (private without subboards)
**External links are only visible to Support Staff****External links are only visible to Support Staff** (public with subboards)
**External links are only visible to Support Staff****External links are only visible to Support Staff** (public without subboards)

[pspzockerscene]

I didn't use your account yet since I was able to test most of the things with my account so I assume I also fixed private boards crawling.
Changes for the next update:
- fixed section titles sometimes being html-encoded
- fixed board/section crawler not working when logged in <-- the issue you reported
- added detection of private/offline items when user tries to crawl them without required permission
- hopefully also fixed crawling of private boards/sections

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!
---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

-psp-