JDownloader Community - Appwork GmbH
 

Notices

Reply
 
Thread Tools Display Modes
  #41  
Old 27.02.2016, 11:01
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

__________________
JD-Dev & Server-Admin
Reply With Quote
  #42  
Old 02.03.2016, 01:50
Randy Andy Randy Andy is offline
JD Fan
 
Join Date: Dec 2009
Posts: 73
Default

Quote:
Originally Posted by future2004eg View Post
Hi,
I believe the plugin needs a way to shorten the file names, some posts have very long title and case the file names to exceed the 255 character and JD get an error "Invalid download directory" while try to download it....
Yes, shorter/normal file names will be useful.
Actually in my case only ~50 of ~200 files could be downloaded the other 150 say "invalid downloadpath" and i have to re-do the 150 files by re-naming by hand.
Reply With Quote
  #43  
Old 02.03.2016, 06:44
future2004eg
Guest
 
Posts: n/a
Default

I think the file naming structure for the plugin now (PostID - PicNum - Information) is excellent as it is post specific except in one part, it gets the 3rd part of the name from the description which could be very long (most of the cases) and will case this problem in addition that it also could include special characters causing another problem to open the file in some software.

If it gets this part from the post Title there will be no more long file names as the title is already limited by tumblr itself and will never have any special characters.

I played around and created a Regex rule (my 1st so don't shoot me if it is wrong) to auto replace the 3rd part of the name with the title to avoid the need to manually rename every file in the list, maybe it will be useful for others until the plugin is fixed, the only problem with this rule so far that I can't remove the (-) between words.....

@raztoki
Is it possible to change the plugin this way?
Attached Thumbnails
Jdownloader Tumblr Rule.JPG  

Last edited by future2004eg; 02.03.2016 at 06:52.
Reply With Quote
  #44  
Old 02.03.2016, 08:59
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

Can you please provide some more example links where too long filenames happen?
__________________
JD-Dev & Server-Admin
Reply With Quote
  #45  
Old 02.03.2016, 09:19
future2004eg
Guest
 
Posts: n/a
Default

Sure, here we are

**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**

**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
Reply With Quote
  #46  
Old 02.03.2016, 19:17
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

Thanks, I've updated the ticket
__________________
JD-Dev & Server-Admin
Reply With Quote
  #47  
Old 08.03.2016, 07:17
shadorlsy
Guest
 
Posts: n/a
Angry JDownloader drastically changed behaviour after update and is now unusable

I have been using JDownloader with enthusiasm and delight for the past year but recent changes have made it unsuable.

First problem: I download almost exclusively from Tumblr, and the file naming has changed. Previously, for instance all images where named tumblr_NNNNNN.jpg but now they have a much longer and more descriptive name. Having a better name is nice but now more than half the files have "too long" names resulting in a "Invalid Download Directory" error due to the filename being too long. There is no option to limit the length of a filename and renaming manually thousand of files one-by-one is impractical.

Second problem: The definition of a package used to be one link. Now when I copy a link in the clipboard, it does generate an unmanageable amount of sub-folders. I have played around with the Packagizer to try to fix that with no success.

Example: copy to clipboard "cutest-cats.tumblr.com"
Before: **External links are only visible to Support Staff****External links are only visible to Support Staff**
Now: **External links are only visible to Support Staff****External links are only visible to Support Staff**

Third problem:
To prevent the problem mentioned just above and collated all the images in one folder, it is possible to use "Add New Links" and set the packagename field manually instead of going thru the clipboard. However this solution is not satisfactory either. First because it renders the clipboard useless, Second because it restricts you to add links manually one-by-one and properly setting the package name. Also even if I can manage to package one link in one folder manually, I end up with the First problem being that filenames are too long.

I hope that there's a configuration setting that will make it back to previous behaviour otherwise I will be reduce to either find a different software to download from Tumblr or I will have to download and compile the software from the source code and revert to previous changes before the problem occur.

Regards,
A once happy user that is now frustrated

Last edited by raztoki; 08.03.2016 at 08:31. Reason: Image not appearing
Reply With Quote
  #48  
Old 08.03.2016, 12:51
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

I agree,
__________________
JD-Dev & Server-Admin
Reply With Quote
  #49  
Old 12.03.2016, 08:02
Randy Andy Randy Andy is offline
JD Fan
 
Join Date: Dec 2009
Posts: 73
Default

I also think the file naming structure for the Tumblr plugin actually is great (PostID - PicNum - Information) with the only exception, that the filename or the 'Information' Tag must be limited to eg 80 characters.

Besides this, the plugin works great - Thanks for the work :-)
Reply With Quote
  #50  
Old 14.03.2016, 02:58
shadorlsy
Guest
 
Posts: n/a
Default Filename length limit mandatory

A filename length limit is not a Nice-to-have, it is an absolute prerequisite. otherwise the plugin is unusable.

A typical tumblr gallery has over 50% of posts with too long filename. I have sincerily stopped using JDownloader at the moment cuz it is simply unusable and a waste of my time to rename all the failing download due to too long filename.

Personally, i prefer the old naming convention which was ending with a picture quality (size) number and I could automatically filter lower quality pictures (JDownloader downloads all the different quality pictures and you end up with duplicates of different resolution).

Sincerely, I just wish i could have see this coming and I would have turned off the auto-update.
Reply With Quote
  #51  
Old 14.03.2016, 11:04
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

I think we will revert to old naming scheme as default and allowing to customize scheme in plugin settings.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #52  
Old 14.03.2016, 12:35
shadorlsy
Guest
 
Posts: n/a
Default Avoiding change of behavior

I agree that is the best strategy. Being a software engineer myself, I can recall several times we made a decision to change a default behavior and customers were pretty unhappy of it.

New options should always remain as-is, new options. Unless it is fixing a bug... "if ain't broken don't fix it".
Reply With Quote
  #53  
Old 15.03.2016, 09:49
Randy Andy Randy Andy is offline
JD Fan
 
Join Date: Dec 2009
Posts: 73
Default

Quote:
Originally Posted by Jiaz View Post
I think we will revert to old naming scheme as default and allowing to customize scheme in plugin settings.
Sounds great!
Reply With Quote
  #54  
Old 16.03.2016, 01:01
shadorlsy
Guest
 
Posts: n/a
Default

I have updated and I think it's a little bit better now (filenames seem shorter) but still a bit too long. I'd say that a lower percentage of filename has to be renamed but still...

I'd personally prefer to go back to old naming scheme (tumblr_ABCDEF..._RES.jpg) or at very least a setting to fix the maximum filename length.

Meanwhile, this software is still unusable (I can't seriously be renaming thousand files manually without loosing my sanity). Waiting for a fix to resume using JDownloader.
Reply With Quote
  #55  
Old 16.03.2016, 01:30
shadorlsy
Guest
 
Posts: n/a
Default

Or maybe a Dynamic Variable containing the source file name (ie.: tumblr_abcdef....ext) as opposed to the new name (12345 - id - desc.ext) could be added and I could use this in the Packagizer.
Reply With Quote
  #56  
Old 16.03.2016, 02:16
Randy Andy Randy Andy is offline
JD Fan
 
Join Date: Dec 2009
Posts: 73
Default

@shadorlsy
Cool down ;-)

Jiaz wrote, that they want to do a "real" Plugin with optional settings for the naming scheme. So everbody should his own prefered type of naming.

But on
https://svn.jdownloader.org/issues/77628
you can see, that still nothing happens
Reply With Quote
  #57  
Old 16.03.2016, 11:51
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

Our plugin developer currently has little time + is ill and therefore progress on plugin tickets are slow :(
__________________
JD-Dev & Server-Admin
Reply With Quote
  #58  
Old 16.03.2016, 14:20
shadorlsy
Guest
 
Posts: n/a
Default Sorry to here that

I hope he gets better soon. Sorry, I don't mean to be pushy. I understand.

I'd help if I could but i'm specialized C++/C# and pretty clueless in Java.
Reply With Quote
  #59  
Old 23.04.2016, 21:33
tomstom
Guest
 
Posts: n/a
Default Bug: Please allow to trim Filenames to a max length

Good evening

if we dowanload all found Images from
**External links are only visible to Support Staff****External links are only visible to Support Staff**

then JDownloader has problems with such annoying Packet / File-Names:
"I know I’m late but still posting thisSsssHarry’s hair looks sooooo fine����NIALLS CHEST HAIR��LOUIS EYES MAKES ME MELT ❤️❤️DANG DADDY LIAMS MUSCLES��Please give credits by liking_reblogging And request are free!"
Yes, this really is a package name... and will create an invalid directory & file-name.

Could you please add a config setting where whe can define the max len for Packages & File-Names?
Everything longer than this value will be truncated (but the filename-extension will be kept, of course )

Thanks a lot,
kind regards,
Tom
Reply With Quote
  #60  
Old 24.04.2016, 21:49
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

This is what is about
__________________
JD-Dev & Server-Admin
Reply With Quote
  #61  
Old 25.04.2016, 13:06
mgpai mgpai is offline
Script Master
 
Join Date: Sep 2013
Posts: 1,533
Default

Define maximum length for file (and package) name using event scripter.
Code:
/*
Script: Tumblr workaround
Trigger:"Packagizer Hook"
*/

var tumblr = /.*\.tumblr.com\/post\/.*/.test(link.getSourceUrls().join());

if (tumblr) {
    var fileName = link.name.replace(/(.+)\..+$/, "$1");
    var fileType = link.name.replace(/.+(\..+$)/, "$1");
    var packageName = link.packageName !== null ? link.packageName : "Unknown";
    var maxLength = 65; // set maximum allowed length for file name (maxLength - 20 will be used for package name)
    var newFileName = fileName.substring(0, maxLength).substr(0, Math.min(fileName.substring(0, maxLength).length, fileName.substring(0, maxLength).lastIndexOf(" ")));
    var newPackageName = packageName.substring(0, maxLength - 20).substr(0, Math.min(packageName.substring(0, maxLength - 20).length, packageName.substring(0, maxLength - 20).lastIndexOf(" ")));
    var user = link.getSourceUrls().join().replace(/.*http:\/\/([^.]+)[^/]+\/post\/.*/, "$1");
    var description = link.name.replace(/\d+\s+-\s+\d+\s+\-\s(.+)\..+$/, "$1");

    link.setName(user + " - " + newFileName + fileType); // filename with prefix (Easier to identify single files in "Various Files" package)
    link.setPackageName(user + " - " + newPackageName); // packageName with prefix

    //link.setName(newFileName + fileType); // filename without prefix
    //link.setPackageName(newPackageName); // packageName without prefix
    //link.setComment(description); // Set the original filename as comment
}
Reply With Quote
  #62  
Old 25.04.2016, 14:52
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

at least until I change it, thx mgpai. I'm waiting for core updates to come out before I tackle this ticket.

raztoki
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #63  
Old 28.04.2016, 02:13
tomstom
Guest
 
Posts: n/a
Default

Thanks to raztoki and Jiaz I've found this solution to shorten package & filenames:

I used your recipe and defined this Regex in a new Packagizer Rule:

Name: Limit package & filename length to 30 chars

If the following conditions match …
Active: Matches on any File or Link and ignores conditions below
File Name: Contains: (.{30}).*

… then set
Package Name: <jd:orgfilename:1>
Filename: <jd:orgfilename:1>

kind regards,
Tom
Reply With Quote
  #64  
Old 05.05.2016, 13:39
TimWill TimWill is offline
Vacuum Cleaner
 
Join Date: Apr 2016
Posts: 15
Default

This seems to be solved? Because I've done some tests a few minutes ago and jdownloader is handling the job flawlessly. I've got some pretty big titles here but there are no issues, everything downloads and runs perfectly.

Great job
Reply With Quote
  #65  
Old 05.05.2016, 14:04
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,611
Default

@tomstom
nicer solution than javascript for sure. ;p

@TimWill
No changes have been made as I'm aware. It's only a problem if the uploader has long content descriptions. So this maybe only effects 5% or less of tumblr posts.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #66  
Old 08.05.2016, 23:03
tomstom
Guest
 
Posts: n/a
Default

Because I sometimes had troubles with the Filename-Extensions, I extended my Packagizer Rule which should handle Filenameextension with 3 and 4 characters fine:

File Name: Contains: ^(.{30}).*(\..{3,4})$
Package Name: <jd:orgfilename:1><jd:orgfilename:2>
Filename: <jd:orgfilename:1><jd:orgfilename:2>

At least, in my tests I had no more problems.

Kind regards, Tom
Reply With Quote
  #67  
Old 09.05.2016, 13:27
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

@tomstom: thanks: btw you can also export your rules so others can easily import it
__________________
JD-Dev & Server-Admin
Reply With Quote
  #68  
Old 18.05.2016, 20:09
wanko wanko is offline
JD VIP
 
Join Date: Aug 2015
Posts: 300
Default

so, does anyone have a solution to fix long filename ?
Reply With Quote
  #69  
Old 18.05.2016, 21:54
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

We will work on it soon
__________________
JD-Dev & Server-Admin
Reply With Quote
  #70  
Old 19.05.2016, 20:13
wanko wanko is offline
JD VIP
 
Join Date: Aug 2015
Posts: 300
Default

Quote:
Originally Posted by Jiaz View Post
We will work on it soon
so why we dont have global filename limited ? and auto rename special characters like (",'', ..........)
Reply With Quote
  #71  
Old 19.05.2016, 21:55
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

auto rename of special chars is already in & working
filename limiting is on todo list
__________________
JD-Dev & Server-Admin
Reply With Quote
  #72  
Old 03.07.2016, 21:39
wanko wanko is offline
JD VIP
 
Join Date: Aug 2015
Posts: 300
Default Tumblr filename structure

Last version of JD have filename structure like this
[id post (146820416106)] - number - [desc]

but new update of JD have filename same as direct link (to prevent long path issue......)

**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff** -> e34a6354c6ba1930c213e43b2f5caebf/tumblr_o6divmOjVx1rcufwuo1_r1_540.gif


can we change filename structure to [id post] [number if post have 2+ img,....] [name of tumblr user] [source] ?

**External links are only visible to Support Staff****External links are only visible to Support Staff** (repost)

**External links are only visible to Support Staff****External links are only visible to Support Staff** (source)

so it might be [146836716983] [1-2] [aki-chancharacters] [kozuuki]

thank
Reply With Quote
  #73  
Old 05.07.2016, 02:49
kdbrink
Guest
 
Posts: n/a
Default

I've found that mgpai's script works best for me.
Reply With Quote
  #74  
Old 05.07.2016, 12:58
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

Thanks for the feedback and thx to mpgai
__________________
JD-Dev & Server-Admin
Reply With Quote
  #75  
Old 07.07.2016, 09:51
travestree travestree is offline
Giga Loader
 
Join Date: Oct 2013
Posts: 96
Default Tumblr site rip creates file names too long to download

I tried to rename all the files to a random file name hoping the auto rename on "existing" feature would work, but it simply assumed the rest were mirrors.
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**

06.07.16 22.34.57 <--> 06.07.16 23.44.44 jdlog://6288135891641/

Is there a way to truncate file names to be windows compatible?
Reply With Quote
  #76  
Old 22.07.2016, 15:11
Patr100 Patr100 is offline
JD VIP
 
Join Date: Jan 2010
Posts: 498
Default Tumblr images

JD is incorrectly reporting " invalid download directory" for some files only.
I think it is due to the filenames generated - either too log or forbidden characters

log file
19.07.16 18.17.52 <--> 22.07.16 13.03.14 jdlog://3396971887641/

Sample urls

**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
Reply With Quote
  #77  
Old 09.11.2016, 15:35
Kira300467 Kira300467 is offline
Wind Gust
 
Join Date: Mar 2009
Posts: 43
Default Temporary solution?

Under CRAWLER directory there is a file called "tumblr.com.json" its from September 10.
There is a definition variable inside:

"useoriginalfilenameenabled" : false

Changing this setting on "true", what will happen?

Is this already a solution, or I am barking up the wrong tree?

I would be very interested on a temporary solution, I only don't know which file to edit, would be happy to try the script above.;)
Reply With Quote
  #78  
Old 09.11.2016, 22:20
pspzockerscene's Avatar
pspzockerscene pspzockerscene is online now
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,915
Default

I closed the ticket as this needs a general fix/workaround - not plugin specific.

GreeZ pspzockerscene
EDIT
Ticket:
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #79  
Old 10.11.2016, 13:38
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,286
Default

@Kira300467:
Go to Settings-Plugins. there you will find tumblr.com twice (one for hoster, one for decrypter), there you can change this option to get shorter(original fileserver) name
__________________
JD-Dev & Server-Admin
Reply With Quote
  #80  
Old 14.04.2021, 14:04
pspzockerscene's Avatar
pspzockerscene pspzockerscene is online now
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,915
Default

The tumblr.com crawler has been fixed.
Regarding too long filenames:
Settings -> Plugins -> tumblr.com -> Use original filenames -> Enable this (is only applied to all items added after changing it)

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 17:11.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.