JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #121  
Old 17.08.2022, 23:51
CheatBaker CheatBaker is offline
Vacuum Cleaner
 
Join Date: May 2022
Posts: 17
Default

Oh, it's very nice ! thank you for this message which make me better wait. I'm sure you are doing the best. The result will surely be super. Are these reviews only for Arte plugin ?
CB
Reply With Quote
  #122  
Old 18.08.2022, 10:17
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

Quote:
Originally Posted by CheatBaker View Post
Are these reviews only for Arte plugin ?
no, they include all changes since the last update, especially some more major internal changes
__________________
JD-Dev & Server-Admin
Reply With Quote
  #123  
Old 20.08.2022, 12:50
CheatBaker CheatBaker is offline
Vacuum Cleaner
 
Join Date: May 2022
Posts: 17
Default

I see. What a work ! Good luck.
Reply With Quote
  #124  
Old 22.08.2022, 15:59
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

Quote:
Originally Posted by CheatBaker View Post
Good luck.
Thanks for your understanding!
__________________
JD-Dev & Server-Admin
Reply With Quote
  #125  
Old 29.08.2022, 17:55
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 63,059
Default

CORE-Updates have been released!
All announced bugfixes and features are live!
Please update your JDownloader and report any issues you find asap.

CORE-Updates wurden released!
Alle angekündigten Bugfixes/Features sind nun verfügbar!
Bitte JDownloader updaten und eventuelle Bugs schnellstmöglich an uns melden.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #126  
Old 29.08.2022, 20:31
CheatBaker CheatBaker is offline
Vacuum Cleaner
 
Join Date: May 2022
Posts: 17
Smile At last

Aaaaaahhh ! It'so good to download properly again. Thank you ! Thank you ! Thank you !
It works very good for little files and it seems to work for series too. Fine !

However, will you keep the ARTE_NEXT word in place of 'arte' in old version (named legacy in parameters of plugin) ? And some thumbnails name keep the same name as the file in place of a simple name like older version.

Good job guys
See you later, alligator
Charles Baker
Reply With Quote
  #127  
Old 29.08.2022, 20:44
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

Quote:
Originally Posted by CheatBaker View Post
However, will you keep the ARTE_NEXT word in place of 'arte' in old version (named legacy in parameters of plugin) ? And some thumbnails name keep the same name as the file in place of a simple name like older version.
Will look into that by tomorrow, can you provide a screenshot?can also send to support@jdownloader.org
__________________
JD-Dev & Server-Admin
Reply With Quote
  #128  
Old 29.08.2022, 21:56
guardao's Avatar
guardao guardao is offline
JD-Team
 
Join Date: Mar 2009
Posts: 1,796
Default

Congratulations from a CHAT user

August 29, 2020 [19:57:07]

"Ojisanofgun:
Hey! Thank you very much for adding old functions to the new arte plugin. You folks are amazing! Take care! "
Reply With Quote
  #129  
Old 29.08.2022, 23:44
CheatBaker CheatBaker is offline
Vacuum Cleaner
 
Join Date: May 2022
Posts: 17
Thumbs up screenshot

The screenshot is sent to support@jdownloader.org
Reply With Quote
  #130  
Old 30.08.2022, 09:50
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

@CheatBaker: Thanks, we'll look into it
__________________
JD-Dev & Server-Admin
Reply With Quote
  #131  
Old 30.08.2022, 09:55
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 63,059
Default

@CheatBaker
The "ARTE_NEXT" is the "platform" parameter of filenames. That is not a bug.
Either remove that and set custom filenames or set "Filename scheme type" to "Legacy" to get the filenames of the old ARTE plugin.

@guardao
Thanks for forwarding that nice feedback.
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #132  
Old 31.08.2022, 11:07
CheatBaker CheatBaker is offline
Vacuum Cleaner
 
Join Date: May 2022
Posts: 17
Default

@ pspzockerscene
I tried the "legacy" scheme and it works perfectly. Thanks for the hint.

For the thumbnails, I detect that if it remains two items in a package after filtered by the plugin parameters, the thumbnail name is the same as the filename (with jpg extension). Otherwise it is shorted to a more simple name.

I send an example screenshot with parameter and urls.
Reply With Quote
  #133  
Old 31.08.2022, 11:32
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 63,059
Default

Quote:
Originally Posted by CheatBaker View Post
For the thumbnails, I detect that if it remains two items in a package after filtered by the plugin parameters, the thumbnail name is the same as the filename (with jpg extension). Otherwise it is shorted to a more simple name.
Yes and so far that sounds like it's working as expected.
Please describe which name you'd like to have instead.
If your wish is "too far off" from the current handling, I might as well just add an extra "Custom filename" field for thumbnails though I was trying to avoid that.
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #134  
Old 31.08.2022, 11:58
CheatBaker CheatBaker is offline
Vacuum Cleaner
 
Join Date: May 2022
Posts: 17
Default

If you please, I can base myself on the screenshots I have sent to support@jdownloader.org.
In the "La petite voiture" package or in the "Le Havre" one, you have 'short' names : "La petite voiture.jpg" or "Le Havre.jpg".
In the "Le combat dans l'île" package, this is a 'long' name : "Le combat dans l'île_107358-000-A_Français_VOF_1280x720_2200.jpg".
The difference is that in the second case there are only 2 items in the package, and in the first cases there are more.
Is this really the good result you expect ?
I think that 'short' names are more suitable for a thumbnail name as in the old version of this plugin.
Reply With Quote
  #135  
Old 31.08.2022, 13:59
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 63,059
Default

Quote:
Originally Posted by CheatBaker View Post
The difference is that in the second case there are only 2 items in the package, and in the first cases there are more.
Is this really the good result you expect ?
Yes this is the result I expect but I admit that I'm not using the ARTE plugin myself so I only got my perspective as a programmer.
What you call "Short name" is really just the package name + extension of that thumbnail / image file
The wording for this in the new plugin settings will be like in this forum post.

I will add an option to satisfy your needs.

Quote:
Originally Posted by CheatBaker View Post
I think that 'short' names are more suitable for a thumbnail name as in the old version of this plugin.
Well the really old versions of that plugin never had thumbnail support if I remember correctly.

Regarding your private support ticket:
I'll answer that one publicly as it didn't contain any special/private data/questions so my answer might be helpful for other users too.
I didn't understand your question 100% but since it was about "Audio description" versions I think I got your point:

Looks like I forgot to add a setting for "Audio description" versions.
I'll add it as a part of the "hardcoded subtitles" settings so you will be able to deselect those.

If I was a user of our JDownloader ARTE plugin, I'd configure it as follows:
(I'll only list the options relevant for me, set the rest according to your preference.)
Warning: Some of those settings are not publicly available yet or will be named slightly different with the release of our next set of CORE-updates.
  • Thumbnail filename mode: Auto
  • Disable all subtitle settings except maybe: Crawl subtitled birned in versions (none/partial/forced)
  • Define how this plugin should pick qualities -> Best
  • Language selection mode: Auto
  • Define what to add if based on your selection no video results are found: Nothing (Or thumbnail only)
I'd choose those settings as they should return exactly one video version most of all times.

EDIT

I will add another post later containing screenshot(s) of the newly added plugin settings.
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist

Last edited by pspzockerscene; 31.08.2022 at 16:46.
Reply With Quote
  #136  
Old 31.08.2022, 16:45
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 63,059
Default

Changes for the next CORE-update (not included in the update released ~45 minutes ago!):
  • New setting: Thumbnail filename mode
  • New setting: Crawl subtitled burned in versions (audio description) --> Yes the "Audio description" version might theoretically not be a "Subtitled version" but it fits for us that way. The wording can still be changed in future versions of those plugin settings.
  • Changed Language selection mode "By URL e.g. arte.tv/de/... -> German" to "Auto: e.g. URL contains arte.tv/de/... -> Allow german and original versions" and updated the logic accordingly. What this should basically do (together with my other "preferred settings") is to always only find the most reasonable version e.g. the one that would be auto-played in your browser. Note that this does not select subtitled versions in any intelligent way e.g. if you add an arte link with /de/ in the URL, it will pick the original french version as no german version is present while the browser would preferably play the original french version with german subtitles.

Screenshot of the new plugin settings (green = new, orange = changed):
Spoiler:


Bitte auf das nächste CORE-Update warten!

Please wait for the next CORE-Update!

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!


-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #137  
Old 31.08.2022, 19:20
CheatBaker CheatBaker is offline
Vacuum Cleaner
 
Join Date: May 2022
Posts: 17
Thumbs up understood

Thank you for your diligence.
I have read your previous message. I hope I have understood everything.
I will wait "wisely" for the next Core update and test your new features according to your advice.
Reply With Quote
  #138  
Old 01.09.2022, 10:01
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

@CheatBaker: Updates are live, please test and provide feedback
__________________
JD-Dev & Server-Admin
Reply With Quote
  #139  
Old 02.09.2022, 16:57
CheatBaker CheatBaker is offline
Vacuum Cleaner
 
Join Date: May 2022
Posts: 17
Cool Feedback

Hello,
At first, I realize that it is a big job to do all of that. Thank you for this work.
I've tested some features as you asked.
I Have found the right settings for getting what I desire :
- Checking "Crawl thumbnail"
- Setting "thumbnail filename mode" to Package name
- Checking "Crawl subtitled burned in versions (partial/forced)"
- Setting "Define how this plugin should pick your desired qualities" to Best quality
- Setting "language selection mode" to Auto
- Setting "what to add if based ..." to Best quality
- Setting "select file name scheme type" to Legacy
- Setting "select Package name scheme type" to Legacy
All seem to work perfectly : I get the thumbnail in the version I expect and the file in french version, except for files which exist only in original version with subtitles. In this case, I get german subtitled versions too. So, I delete them by hand and all is correct.

As my computer is desperatly old and slow, I didn't test every case. The variety of files and cases is too big. However, sometimes, I noticed some weird results. But I am not sure. I'll try to get back later on these cases.
So long guys and good job
Reply With Quote
  #140  
Old 02.09.2022, 17:43
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 77,777
Default

@CheatBaker: Thank you very much for your feedback Please report findings/issues
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 15:35.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2022, Jelsoft Enterprises Ltd.