[rabidman]

I'm hoping to move packages to a separate folder after completion. I know the feature does not exist in JDownload 2. I found a script at https://board.jdownloader.org/showpo...7&postcount=29 .

However, it moves all download files to a single directory, without preserving any of the original directory structure. Is there any way to fix that ?

If this was C or C++, I wouldn't have any issue doing it myself, but I'm unfortunately useless with JavaScript, and ChatGPT doesn't seem sufficiently versed in EventScripter to make the change for me, despite the very clear prompt I gave it. It keeps producing code using identifiers that are not part of EventScripter.

[mgpai]

/*
    move finished
    trigger : jdownloader started
*/

getAllFilePackages().forEach(function(package) {
    if (package.finished) {
        var curFolder = package.downloadFolder;
        var newFolder = curFolder.replace("\\downloading", "\\finished");

        if (curFolder != newFolder) {
            package.downloadFolder = newFolder;
        }
    }
})

Should work fine, but better run/try it on test install first.

[rabidman]

Hi,

Thanks for your answer. Response below.

Originally Posted by mgpai

/*
    move finished
    trigger : jdownloader started
*/

getAllFilePackages().forEach(function(package) {
    if (package.finished) {
        var curFolder = package.downloadFolder;
        var newFolder = curFolder.replace("\\downloading", "\\finished");

        if (curFolder != newFolder) {
            package.downloadFolder = newFolder;
        }
    }
})

Should work fine, but better run/try it on test install first.

Thanks for your response.
I tried it, as the following :

/*
    move finished
    trigger : jdownloader started
*/

getAllFilePackages().forEach(function(package) {
    if (package.finished) {
        var curFolder = package.downloadFolder;
        var newFolder = curFolder.replace("d:\\Downloads\\JDownloader", "d:\\Downloads\\Complete");

        if (curFolder != newFolder) {
            package.downloadFolder = newFolder;
        }
    }
})

Unfortunately, it had no effect, even after I restarted JDownloader. It seems to be a no-op. I have recently downloaded packages under D:\Downloads\JDownloader, each with their own directory structure, and nothing got moved to d:\Downloads\Complete .

Thanks again.

[mgpai]

Only files which were downloaded by JD into that folder (and still exist there) will be moved. Files subsequently copied or extracted to that folder will not be moved.

This is by design, since multiple packages can share a (that) common download folder and it might contain files belonging to other packages.

I haver read your reply in the other thread. You can test/use this to to move the entire folder, keeping in mind it moves ALL the files/folders in it.

/*
    demo
    trigger : click test run in top panel
*/    

var myPackage = getPath("d:\\downloads\\jdownloader\\myPackage");
var complete = "d:\\downloads\\complete";
var moved = getPath(myPackage).moveTo(complete);

alert(moved);

If you prefer, you can also use CLI commands in eventscripter (using callSync/callAsync) to do the same.

[rabidman]

Hi,

Thanks again for your response. More inline.

Originally Posted by mgpai

Only files which were downloaded by JD into that folder (and still exist there) will be moved. Files subsequently copied or extracted to that folder will not be moved.

Why / how would files be subsequently copied, without manual intervention ?
And why would extraction cause an issue, as long as the extraction is performed inside the package folder ?

This is by design, since multiple packages can share a (that) common download folder and it might contain files belonging to other packages.

Is there a way to prevent this, ie. creating unique folder names for each package ?
Or alternately, perform the move only after the last package with a shared folder name has completed downloading ?

If you prefer, you can also use CLI commands in eventscripter (using callSync/callAsync) to do the same.

Thank you ! That script worked. But of course, I had to hardcode the package name in there, which I don't want to do. How can I fix that ?

Also, what would be the correct trigger to use ?

Thanks again !

[mgpai]

Originally Posted by rabidman

Why / how would files be subsequently copied, without manual intervention ?
And why would extraction cause an issue, as long as the extraction is performed inside the package folder ?

The script uses a package object method to 'set' the download folder. It will update the new path only to the links belonging to that package and moves the files correspondng to those links, to the new location. Thus, the connection between the download link and file on disk will be preserved. It will not be aware of any othe files in that folder, belonging to a different package or copied or extracted into it manually or otherwise, and hence they will not be moved.

Originally Posted by rabidman

Is there a way to prevent this, ie. creating unique folder names for each package ?
Or alternately, perform the move only after the last package with a shared folder
name has completed downloading ?

Extracted files would still not be moved.

Originally Posted by rabidman

Thank you ! That script worked. But of course, I had to hardcode the package name in there, which I don't want to do. How can I fix that ?

Also, what would be the correct trigger to use ?

That was just for you to check if it works as intended. "moveTo" can be used to replace "setFolder" method in the original script.

It would not be wise to 'set' the new path while extraction is active. So, the script uses 'jdownloader started' trigger, at which point extraction presumably will have been completed. A better option is to create a "toolbar button pressed" and manually run the script by clicking the button.

Point to note: "moveTo" is a filePath object method, when used to move files will sever all connection between the downloadPath and the file on disk. The link in the download list may no longer point to the correct location on disk

Recommedation:

• Extract the files directly to the 'complete' folder. (Can be configured in Settings > Archive Extractor)
• Use the first script in this thread, to move the downloaded files. (Any files in the folder belonging to other packages will continue to remain there.)

[rabidman]

Originally Posted by mgpai

The script uses a package object method to 'set' the download folder. It will update the new path only to the links belonging to that package and moves the files correspondng to those links, to the new location. Thus, the connection between the download link and file on disk will be preserved. It will not be aware of any othe files in that folder, belonging to a different package or copied or extracted into it manually or otherwise, and hence they will not be moved.

Thanks, that explains it, but I didn't test the case where there are files from different packages in the same folder, so I don't know how it would behave.

Extracted files would still not be moved.

Couldn't the "Archive extraction finished" trigger be used to deal with this, extract first in place, and then move ?

That was just for you to check if it works as intended. "moveTo" can be used to replace "setFolder" method in the original script.

I see.

It would not be wise to 'set' the new path while extraction is active. So, the script uses 'jdownloader started' trigger, at which point extraction presumably will have been completed. A better option is to create a "toolbar button pressed" and manually run the script by clicking the button.

Thanks. I'm really hoping for something automatic. Manually restarting JD2 isn't my favorite option, but perhaps a script could perform that action periodically ?

I do however see a slight a problem with doing extraction after move. I would prefer the move to be atomic, so that I can subsequently safely perform manual actions on anything under Complete, such as move, delete, etc. without running the risk of having extraction accidentally fail, due to not being aware of it running in any given subfolder. It's a similar problem for the move/copy operation. My preferred way would be to extracted everything in-place in the JDownloader directory, then just move/rename the directory, which works atomically under Windows if it's on the same drive.
However, I think I can work around this by checking the last modified date on any folders in the Complete directory before performing any further move/delete manually.

Point to note: "moveTo" is a filePath object method, when used to move files will sever all connection between the downloadPath and the file on disk. The link in the download list may no longer point to the correct location on disk

Would it be OK to use the setting that automatically removes finished downloads in this case - say "when package is ready" ? Or will that cause problems for the move operation after extraction and restart ?

Recommedation:[*]Extract the files directly to the 'complete' folder. (Can be configured in Settings > Archive Extractor)

Could you please be more specific as to how I should configure it ?
Would D:\Downloads\Complete\<jd:packagename> be OK for the destination ?

[*]Use the first script in this thread, to move the downloaded files. (Any files in the folder belonging to other packages will continue to remain there.)

The very first script in this thread was a no-op for me. Which one did you mean I should use ?

Thanks

[rabidman]

Originally Posted by Jiaz

You manually move files somewhere else without JDownloader *being aware* of this. It looks at old location
for part files for extraction and other stuff. That's why the scripts should only move finished non archive files
or wait for extraction to finish and then move the extracted files.

OK. So, is there a better way to run the script only once extraction has completed, if any ?

Thanks.

[Jiaz]

@mgpai: see here for desired behaviour, https://board.jdownloader.org/showpo...22&postcount=5

[mgpai]

• Do the packages contain only archives?
• Do you want to keep the links in the downloadlist after they are downloads/extiracted/moved?

[pspzockerscene]

Correct me if I'm wrong but at least for packages with only archives && when auto extract is enabled, you could use a Packagizer rule instead of a script or alternatively just define a custom global extraction path.

[mgpai]

Originally Posted by pspzockerscene

Correct me if I'm wrong but at least for packages with only archives && when auto extract is enabled, you could use a Packagizer rule instead of a script or ...

Yes, if the destination folder is static or can be generated with packagizer variables. Can also be used if the package contains non-arhives, but then only extracted files will be moved.

Originally Posted by pspzockerscene

...alternatively just define a custom global extraction path.

Best solution, suggested in one of the posts above.

[pspzockerscene]

Originally Posted by mgpai

Can also be used if the package contains non-arhives, but then only extracted files will be moved.

Yap.
This is a huge design flaw which a lot of users have asked us to properly implement.

It looks like the use case "move finished downloads to another place than the one they were initially downloaded to" is something that a lot of users want.

[rabidman]

Originally Posted by mgpai

• Do the packages contain only archives?
• Do you want to keep the links in the downloadlist after they are downloads/extiracted/moved?

No to both.

[mgpai]

Script:

/*
    change download folder
    trigger : interval (set interval in ms as desired, e.g. 3600000 for 1 hour)
*/

getAllFilePackages().forEach(function(package) {
    if (package.finished && !package.archives.length) {
        var curFolder = package.downloadFolder
        var newFolder = curFolder.replace("\\jdownloader\\", "\\complete\\");

        if (curFolder != newFolder) {
            package.downloadFolder = newFolder
            callAPI("downloadsV2", "removeLinks", [], [package.UUID]);
        }
    }
})

Archive extractor settings:


Workflow:

• archive files will be extracted
• if extracted file exists in the destination fodler it will be renamed
• archive files will be removed
• archive links will be removed from download list
• script will run on interval and check if package does not contain any archives (wait till extraction process is finished)
• new downloadFolder will be set (non-archive files will be moved)
• package will be removed from downloadList

Please try on test install first.

[rabidman]

Thank you ! This seems to be working, at least initially. I'll report if I find any issues.

[rabidman]

Originally Posted by rabidman

Thank you ! This seems to be working, at least initially. I'll report if I find any issues.

OK, I spoke too soon. Only two packages were moved. I believe both were archives and extracted. The vast majority of the packages are not archived, and are not getting moved.

[mgpai]

Should be working fine:



Please note, while the archives will be removed immediately, the non-archive files will be removed only when the eventscript is triggered after that, which will depend on the interval you set in the script.

[rabidman]

Originally Posted by mgpai

Should be working fine:



Please note, while the archives will be removed immediately, the non-archive files will be removed only when the eventscript is triggered after that, which will depend on the interval you set in the script.

I set the interval to 5 minutes. The non-archive files are really not getting moved.

[mgpai]

Check if the string used in replace function matches exactly to the one on disk. It is case-sensitve

Edit: The script has been updated to remove the package only if the replace was successful.

[rabidman]

Hi,

Originally Posted by mgpai

Check if the string used in replace function matches exactly to the one on disk. It is case-sensitve

Edit: The script has been updated to remove the package only if the replace was successful.

Thanks. This is what I'm using :

/*
    change download folder
    trigger : interval (set interval in ms as desired, e.g. 3600000 for 1 hour)
*/

getAllFilePackages().forEach(function(package) {
    if (package.finished && !package.archives.length) {
        var curFolder = package.downloadFolder
        var newFolder = curFolder.replace("D:\\Downloads\\JDownloader\\", "D:\\Downloads\\Complete\\");

        if (curFolder != newFolder) {
            package.downloadFolder = newFolder
            callAPI("downloadsV2", "removeLinks", [], [package.UUID]);
        }
    }
})

My file system is NTFS on Windows, so the string should not be case-sensitive. Nevertheless, the case I used for these directory names is the same as shown by Windows explorer.

Unfortunately, the previously downloaded packages not containing archives are still not getting moved, even after a manual test run.

[mgpai]

Originally Posted by rabidman

My file system is NTFS on Windows, so the string should not be case-sensitive. Nevertheless, the case I used for these directory names is the same as shown by Windows explorer.

While the file system is not case-sensitive, the replace function is. But since you confirm it is being replaced I cannot think of any reason why new path is not set.

Originally Posted by rabidman

Unfortunately, the previously downloaded packages not containing archives are still not getting moved, even after a manual test run.

Maybe @Jiaz or @psp can shed some light as to why it is working for me and not for you.

[rabidman]

Originally Posted by mgpai

While the file system is not case-sensitive, the replace function is. But since you confirm it is being replaced I cannot think of any reason why new path is not set.

It worked earlier for 2 packages that had archives. It hasn't worked since., but I don't think I have any other extractible packages downloaded or pending. If you are able to give me a link to one, I could retest it.

Thanks.

[mgpai]

Originally Posted by rabidman

If you are able to give me a link to one, I could retest it.

Here is the downloadlist I used to test the script. Just drag 'n' drop it to the download tab.

file.io/q1pSdqTxMtJG

Edit: move will fail if the file exists in the destination fodler.

[rabidman]

Hi,

Originally Posted by mgpai

Here is the downloadlist I used to test the script. Just drag 'n' drop it to the download tab.

file.io/q1pSdqTxMtJG

Edit: move will fail if the file exists in the destination fodler.

Thanks.

Should I drag the ZIP file, or its contents ?

The former results in an error : "Processing the following container failed for unknown reasons : D:\Downloads\downloadlist.zip"

The later appears to have no effect.

[mgpai]

Originally Posted by rabidman

Hi,
Should I drag the ZIP file, or its contents ?

The former results in an error : "Processing the following container failed for unknown reasons : D:\Downloads\downloadlist.zip"

The later appears to have no effect.

Sorry. I posted the wrong link. Use this:

file.io/W2dGFbdzLuEP

Download it to disk and dran 'n' drop to downloads tab. JD will prompt to import 7 links click yes.

Alternatively, since the links are removed from ths list, the files can be moved independently, rather than set the package folder. Here too the move will fail if the file exists in the destination folder. Links will be removed from the list, only if the move is successful.

/*
    move non-archive links
    trigger : interval (set as desired)
*/

getAllFilePackages().forEach(function(package) {
    if (package.finished) {
        package.downloadLinks.forEach(function(link) {
            if (!link.archive) {
                var curPath = link.downloadPath;
                var newPath = getPath(curPath.replace("\\jdownloader\\", "\\complete\\")).parent;
                var moved = getPath(curPath).moveTo(newPath);

                if (moved) {
                    link.remove();
                }
            }
        })
    }
})

[rabidman]

Hi,

Originally Posted by mgpai

Sorry. I posted the wrong link. Use this:

file.io/W2dGFbdzLuEP

Download it to disk and dran 'n' drop to downloads tab. JD will prompt to import 7 links click yes.

Alternatively, since the links are removed from ths list, the files can be moved independently, rather than set the package folder. Here too the move will fail if the file exists in the destination folder. Links will be removed from the list, only if the move is successful.

/*
    move non-archive links
    trigger : interval (set as desired)
*/

getAllFilePackages().forEach(function(package) {
    if (package.finished) {
        package.downloadLinks.forEach(function(link) {
            if (!link.archive) {
                var curPath = link.downloadPath;
                var newPath = getPath(curPath.replace("\\jdownloader\\", "\\complete\\")).parent;
                var moved = getPath(curPath).moveTo(newPath);

                if (moved) {
                    link.remove();
                }
            }
        })
    }
})

Thanks. Sadly, the result is the same. The folders for the extracted files got moved. The file-*.txt files did not get
moved. The links for these files got removed from the Downloads list, though.

Perhaps you could compare the before & after path to see if they truly got moved, rather than just checking for non-NULL string.

I see that there is a _MACOSX folder in one of your packages. I'm guessing you are using Mac OS X. I'm using Windows 11. Perhaps there is some sort of platform-specific bug here.

[mgpai]

Originally Posted by rabidman

Perhaps you could compare the before & after path to see if they truly got moved, rather than just checking for non-NULL string.

Can be compared, but not necesssary when using moveTo. The result will be True or False.

Originally Posted by rabidman

I see that there is a _MACOSX folder in one of your packages. I'm guessing you are using Mac OS X. I'm using Windows 11. Perhaps there is some sort of platform-specific bug here.

I too am on windows platform That folder was extracted from one of the sample fils. Most likely the files from it were moved and empty folder was left behind.

Try a script which uses native commands:

/*
    move non-archive links
    trigger : interval (set as disired)
*/

getAllFilePackages().forEach(function(package) {
    if (package.finished) {
        package.downloadLinks.forEach(function(link) {
            if (!link.archive) {
                var src = link.downloadPath;
                var dest = getPath(src.replace("\\jdownloader\\", "\\complete\\")).parent;

                dest.mkdirs();

                callAsync(function(exitCode, stdOut, errOut) {
                    stdOut && alert(stdOut);
                    errOut && alert(errOut);
                }, "cmd", "/c", "move", "/-Y", src, dest);
            }
        })
    }
})

[rabidman]

Hi,

Your latest script still did not work, unfortunately. It think we were going around in circles, so I added some logging after the getPath call.

var dest = getPath(src.replace("D:\\Downloads\\JDownloader", "D:\\Downloads\\Complete")).parent;
log("After getPath");
log("Destination is " + dest);

The result was this :

--ID:2828TS:1733978490404-12/11/24, 8:41:30 PM - [org.jdownloader.extensions.eventscripter.sandboxobjects.ScriptEnvironment(log)] -> After getPath
--ID:2828TS:1733978490404-12/11/24, 8:41:30 PM - [org.jdownloader.extensions.eventscripter.sandboxobjects.ScriptEnvironment(log)] -> Destination is D:\downloads\jdownloader\myPackage

Ie, the destination is the same as the source, which is why nothing is getting moved.

I see above that the target directory is the wrong one. It points to the source directory, like because the src.replace call was a no-op. And it is logged with different case than it does in Windows Explorer. Explorer shows it as D:\Downloads\JDownloader . But dest is logged as D:\downloads\jdownloader . Ie. the drive letter in uppercase, but the directory names are in lowercase. That is quite strange, and I could never have guessed that's how it it worked.

So, I modified the getPath call as follows :

var dest = getPath(src.replace("D:\\downloads\\jdownloader\\", "D:\\Downloads\\Complete\\")).parent;

And this time, it worked ! The non-archive file-*.txt files were moved, finally.

I'm guessing your directory names don't have any uppercase letters, and that's why the script worked for you, but not for me.

I have a few remarks here :
a) link.downloadPath probably shouldn't have an upper-case drive letter, and lowercase directory names
b) a case-sensitive function like replace probably isn't the right one to use for substitution on a case-insensitive file system path name

A few issues remain :

1) When running the script again, it tries to move the same non-archive files again. I know this because the pop-ups continue to show up every time the script runs. This is presumably because these moved files need to be removed from the Downloads list. I can of course just remove the pop-ups, but the script should be cleaned up too.

2) For archived files, the source files do not get deleted. That's an issue with the Archive extractor rather than the script, though. It wastes disk space, and requires manual cleanup. Archives should be deleted after extraction.

3) The source directory structure does not get deleted, whether for archive or non-archive files.

4) The move and extraction process is non-atomic, with some files being moved, some extracted to the destination, and so on. I feel like :
a) everything should be moved/extracted to a temporary subdirectory on the same file system as the target
b) once that's complete, move that temporary subdirectory to the target directory
c) delete all source archive files & paths
That's more of a "want" than a "must", though. And it isn't trivial to achieve. I'm not sure if it's possible to do in a script or not. But I hope we can get there some day, still. In the meantime, the current working script will do ! Thanks again.

[rabidman]

Spoke too soon. Standalone files, ie. in the multiple virtual "Various files" packages, do not get moved.

[mgpai]

b) can use regex:

var newPath = link.downloadPath.replace(/\\JDownloader\\/i,"\\complete\\");

1)

if(moved){
    link.remove();
}

2) There is a setting to delete archives after (check my screenshot above) If they are not being deleted, report here so that the devs. can look into it.

3)

if (moved) {
    getPath(srcPath).delete();
}

4)
a) You can insert timepstamp to the save path before package name and get unique folder.
b & c) When the package is finished and archive files are not present (extracted/moved/deleted) in the package, move the entire folder. (no empty folders will be left behind).

[mgpai]

Originally Posted by rabidman

Spoke too soon. Standalone files, ie. in the multiple virtual "Various files" packages, do not get moved.

Found out why?

Since the archive part is handled by the archive extractor, the script will have only to deal with non-archive files. Also, since you are using a pattern to save and move files, it is also possible to just move the non-archive files to the new location using a pattern.

/*
    move finished file
    trigger : download stopped
*/

if (link.finished && !link.archive) {
    var src = getPath(link.downloadPath);
    var packageName = link.package.name;
    var dest = getPath("d:/downloads/complete/" + packageName);
    var moved = src.moveTo(dest);

    if (moved) {
        link.remove();
        getPath(src.parent).delete();
    } else {
        alert(src + " was not moved.");
    }
}

Edit: added !link.archive check.

[rabidman]

Originally Posted by mgpai

Found out why?

Since the archive part is handled by the archive extractor, the script will have only to deal with non-archive files. Also, since you are using a pattern to save and move files, it is also possible to just move the non-archive files to the new location using a pattern.

/*
    move finished file
    trigger : download stopped
*/

if (link.finished && !link.archive) {
    var src = getPath(link.downloadPath);
    var packageName = link.package.name;
    var dest = getPath("d:/downloads/complete/" + packageName);
    var moved = src.moveTo(dest);

    if (moved) {
        link.remove();
        getPath(src.parent).delete();
    } else {
        alert(src + " was not moved.");
    }
}

Edit: added !link.archive check.

Thanks ! It seems to be working well so far. I'm going to do more testing, but this is looking good.

[mgpai]

Originally Posted by rabidman

Thanks ! It seems to be working well so far. I'm going to do more testing, but this is looking good.

If necessary, additanol alerts when move fails can be added. e.g 'src file does not exist' and 'dest file exists".

[rabidman]

Originally Posted by mgpai

If necessary, additanol alerts when move fails can be added. e.g 'src file does not exist' and 'dest file exists".

I haven't seen the first case, but I believe I have seen the later. Sometimes, the same file exists in multiple packages of the same name. Thus, the move for the 2nd+ fails.

I would prefer fewer pop-ups, if possible. Ideally, comparing the files, and just deleting the source if it's identical to the destination, with an alert only if it's different, or the move fails.

[pspzockerscene]

Instead of popups you could also just write all possible alerts into one text-file.
If in the end, you got that error text-file left in your folder, you can look into it without unnerving alerts.