JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 26.04.2020, 00:01
ztgasdf ztgasdf is offline
I will play nice!
 
Join Date: Jan 2020
Posts: 3
Default Apostrophes, encoded or not, breaks direct HTTP download

I pasted a direct link to a file that contains an apostrophe into JDownloader today, and the LinkGrabber was able to parse the link, show file size and everything, but when I try to start it, it fails.

One strange thing I noticed, is when you click on "Change url", the end of the link has an extra / and the filename with the apostrophe unencoded.

So the expected link would be:
**External links are only visible to Support Staff****External links are only visible to Support Staff**

But JDownloader thinks it is:
**External links are only visible to Support Staff****External links are only visible to Support Staff**

Log:
25.04.20 17.55.01 <--> 25.04.20 17.55.37 jdlog://6460915302851/

Example links:
**External links are only visible to Support Staff****External links are only visible to Support Staff**
**External links are only visible to Support Staff****External links are only visible to Support Staff**
Reply With Quote
  #2  
Old 26.04.2020, 06:42
tony2long's Avatar
tony2long tony2long is offline
English Supporter
 
Join Date: Jun 2009
Posts: 6,381
Default

Just a note: "workers.dev" links are grabbed by GoogleDriveDirectoryIndex decrypter plugin.
__________________
FAQ: How to upload a Log
Reply With Quote
  #3  
Old 26.04.2020, 11:33
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 67,320
Default

Issue is caused by error in plugin, not connected to Apostrophes only but happens on other special chars as well

__________________
JD-Dev & Server-Admin
Reply With Quote
  #4  
Old 26.04.2020, 11:49
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,195
Default

should be fixed,
it was a bug in the decrypter plugin psp created the other month. wasn't really fault of directhttp class

raztoki
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #5  
Old 26.04.2020, 22:27
ztgasdf ztgasdf is offline
I will play nice!
 
Join Date: Jan 2020
Posts: 3
Default Still broken

It's still be broken.

JDownloader now thinks it's:
**External links are only visible to Support Staff****External links are only visible to Support Staff**

When it's supposed to be:
**External links are only visible to Support Staff****External links are only visible to Support Staff**
Reply With Quote
  #6  
Old 27.04.2020, 04:20
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,195
Default

@ztgasdf
since they are added when the plugin was broken, they all contain bugged downloadlink set by the decrypter.

you will need to delete and re-add the links

raztoki
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #7  
Old 28.04.2020, 04:12
ztgasdf ztgasdf is offline
I will play nice!
 
Join Date: Jan 2020
Posts: 3
Default I disagree

I'm not trying to sound rude, but did you even check? I just did a clean re-install of JDownloader, and it still does not work.

Here's another log, if it's needed.
27.04.20 22.01.56 <--> 27.04.20 22.02.39 jdlog://0741915302851/
Reply With Quote
  #8  
Old 28.04.2020, 09:25
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,195
Default

yes I did test and it did work. Just double checked local history, seems that I committed the wrong version. I must have pressed command z too many times without realising. I was adding password handling so I went back a couple changes to commit without the unfinished work, and went too far.

fyi: reinstalling isn't required typically you want to make sure you have the latest plugin you can just delete that plugin and JD will re-download it.

thanks for the post.
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #9  
Old 28.04.2020, 15:12
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 67,320
Default

No need to reinstall JDownloader, updates will take care of this! Currently I'm working on core update and that's why normal updates are blocked. Should be finished later this day
__________________
JD-Dev & Server-Admin
Reply With Quote
  #10  
Old 28.04.2020, 18:12
raztoki's Avatar
raztoki raztoki is offline
English Supporter
 
Join Date: Apr 2010
Location: Australia
Posts: 17,195
Default

thx jiaz
__________________
raztoki @ jDownloader reporter/developer
http://svn.jdownloader.org/users/170

Don't fight the system, use it to your advantage. :]
Reply With Quote
  #11  
Old 28.04.2020, 18:35
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 67,320
Default

Updates will be released tomorrow, I'm still working on a blocking core update
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 02:11.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.