JDownloader Community - Appwork GmbH
 

Reply
 
Thread Tools Display Modes
  #1  
Old 09.04.2021, 11:23
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 241
Default reddit: plugin outdated?

**External links are only visible to Support Staff****External links are only visible to Support Staff**

crawling the above link and starting the download gives -
Try restarting this link (plugin outdated?)
Reply With Quote
  #2  
Old 09.04.2021, 11:56
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 58,827
Default

Hi,

Please post your log-ID here | bitte poste deine Log-ID hier.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #3  
Old 09.04.2021, 12:12
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 241
Default

I tried it 5-6 times earlier, but it gave the same error. But now it downloaded, i will pm you the logs just in case.
Reply With Quote
  #4  
Old 09.04.2021, 12:14
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 58,827
Default

I'm quite sure what the problem is but I'm not able to reproduce it:
The filename (= your download path) is too long but you're not getting the correct errormessage.

It would be good to get a log of this...
This issue is most likely related to our FFmpeg implementation.

Ahh and before you#re asking why some/all reddit videos come with no sound: Click here!


-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #5  
Old 09.04.2021, 12:21
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 241
Default

Yes, I was able to reproduce the error again as well, the filename is too long, and it is related to FFmpeg (i checked the logs)
Here is the log id:
09.04.21 15.49.42 <--> 09.04.21 15.49.58 jdlog://9430825302851/
Reply With Quote
  #6  
Old 09.04.2021, 12:38
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 58,827
Default

Jiaz will investigate this issue once he finds time.

Meanwhile the "too long path" issue is not a bug of JD but rather a limit of your OS.
What you should get instead would be the errormessage "Invalid download directory" so HERE are possible solutions for this underlying issue.

-psp-
__________________
JD Supporter, Plugin Dev. & Community Manager
JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
That's true James
Quote:
Originally Posted by James
Die Leute verstehen einfach nicht dass nur weil man mit einer Waffe auch auf Menschen schießen kann dass ein Schützenver​ein kein Ort für Amoklaufide​en ist
Reply With Quote
  #7  
Old 09.04.2021, 14:40
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 72,126
Default

check again after next update
__________________
JD-Dev & Server-Admin
Reply With Quote
  #8  
Old 20.04.2021, 13:16
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 241
Default

Would it be possible to add a auto-trim-filename configuration that would trim the file to be within the file name limits?

--------------------------------------------------------------------------
As a side note, i have enabled Windows long file name feature that they added a long time back, but it is very buggy, and i have noticed this kind of issues when using other applications as well.
Reply With Quote
  #9  
Old 21.04.2021, 10:53
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 72,126
Default

Can you please provide a new log? I've updated ffmpeg handling to better support/handle this.
__________________
JD-Dev & Server-Admin
Reply With Quote
  #10  
Old 21.04.2021, 10:57
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 241
Default

Hi Jiaz,
You patch works fine and for long file names I do get a proper error now. However I was just wondering if an auto trim filename option can be added or not.
Do you still require a log for that?
Reply With Quote
  #11  
Old 21.04.2021, 11:21
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 72,126
Default

The patch should auto handle those long names to make them *auto* work and no longer fail with *too long* filename That's why I'm asking for a log
__________________
JD-Dev & Server-Admin
Reply With Quote
  #12  
Old 21.04.2021, 12:10
plaintext plaintext is offline
BugMeNot Account
 
Join Date: Sep 2016
Posts: 241
Default

Here's the log -
21.04.21 15.35.11 <--> 21.04.21 15.35.56 jdlog://5390825302851/

Things to note -
1) I crawled an image and a video and renamed them both to some random long name.
2) The "auto" thing is only implemented for videos at the moment. It should preferably be implemented for other file types as well. In the log, you will see that for reddit image, it does not work at all and gives error instead.
3) I don't know if this auto thing is website specific or not, but it should work for all file types from all websites.
4) Even for the video, it does not work properly, it downloads a portion of the video and then gives some error.
Reply With Quote
  #13  
Old 21.04.2021, 15:17
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 72,126
Default

Thanks for the log. Sorry, we were talking about different topics I just tried to fix the issue that too long(still working) flienames might cause issues with ffmpeg (because of length, special chars...) and that should be fixed with latest update. You are talking about handling of too long/unsupported filenames

About Auto-Trim, I prefer plugins to have correct/good filename set instead of auto trim/modify filename.
Auto trim/modify can easily result in *broken* name so extraction will also fail. It's not just about filename, package
name can also be too long and I think best would be to have different error message to inform about *too long* name
instead of invalid directory.
I think plugins should take care of this and make sure to avoid filenames that end up in this error but on manually
rename it should not auto correct it. Linux just fails but doesn't auto trim it, for example
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 11:43.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2021, Jelsoft Enterprises Ltd.