JDownloader Community - Appwork GmbH
 

Notices

Reply
 
Thread Tools Display Modes
  #41  
Old 08.06.2022, 19:47
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,922
Default

Quote:
Originally Posted by StefanM View Post
What is your guess?
I'd say more because the way we e.g. provided a lot of wildcard-rules throughout time is now wrong.

Luckily I often used RegEx right away^^
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #42  
Old 08.06.2022, 20:21
mgpai mgpai is offline
Script Master
 
Join Date: Sep 2013
Posts: 1,533
Default

Quote:
Originally Posted by Jiaz View Post
It's the same method for searchbar and packagizer/filter/view rules, hence my fear that it may easily break user configuration
It wasn't. Search bar was only partial (contains) match, but in the rest it was possible to control if the pattern was a full or partial match, using conditions.

contains | equals | contains not | equals not

For example:
contains : *.txt would match *.txt as well as *.txt.doc
equals : *.txt would match *.txt but not *.txt.doc
Reply With Quote
  #43  
Old 09.06.2022, 11:24
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

@mgpai: I mean the *same method to build auto pattern from user input* was used. I will do some more changes (next core update) to create different auto pattern depending on contains or equals
__________________
JD-Dev & Server-Admin
Reply With Quote
  #44  
Old 09.06.2022, 11:28
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 485
Default

Quote:
Originally Posted by mgpai View Post
It wasn't. Search bar was only partial (contains) match, but in the rest it was possible to control if the pattern was a full or partial match, using conditions.

contains | equals | contains not | equals not

For example:
contains : *.txt would match *.txt as well as *.txt.doc
equals : *.txt would match *.txt but not *.txt.doc
@mgpai @Jiaz
So, if I understand you - @mgpai - correctly, wildcards in JD rules already worked according to the official wildcard definitions before?
Code:
*.txt would match *.txt but not *.txt.doc
@Jiaz
But '?' (representing a single character) still doesn't seem to work at all (as tested in the bottom search field).

e.g. *.?? should find all files with an extension which is only two characters.
*.?? should find video.rm, it should not find video.ram.

Would it be possible to add/enable that, too?
Reply With Quote
  #45  
Old 09.06.2022, 11:54
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

Quote:
Originally Posted by StefanM View Post
@Jiaz
But '?' (representing a single character) still doesn't seem to work at all (as tested in the bottom search field).

e.g. *.?? should find all files with an extension which is only two characters.
*.?? should find video.rm, it should not find video.ram.

Would it be possible to add/enable that, too?
Not yet supported but I will add support for it with next core update
__________________
JD-Dev & Server-Admin
Reply With Quote
  #46  
Old 09.06.2022, 11:55
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

Quote:
Originally Posted by StefanM View Post
@mgpai @Jiaz
So, if I understand you - @mgpai - correctly, wildcards in JD rules already worked according to the official wildcard definitions before?
Code:
*.txt would match *.txt but not *.txt.doc
Yes and no. It worked by coincidence because of contains = Pattern.find and equals = Pattern.matches mode. With next core update I will update auto wildcard mode to handle to create different pattern according to mode
__________________
JD-Dev & Server-Admin
Reply With Quote
  #47  
Old 09.06.2022, 13:47
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 485
Default

e.g. *.?? should find all files with an extension which is only two characters.
*.?? should find video.rm, it should not find video.ram.

Quote:
Originally Posted by Jiaz View Post
Not yet supported but I will add support for it with next core update
Hey, that's great!
Thanks a lot!
Reply With Quote
  #48  
Old 09.06.2022, 13:53
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

Quote:
Originally Posted by StefanM View Post
Hey, that's great!
Thanks a lot!
wait for next core update and then test it
__________________
JD-Dev & Server-Admin
Reply With Quote
  #49  
Old 09.06.2022, 14:12
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 485
Default

Quote:
Originally Posted by Jiaz View Post
wait for next core update and then test it
I will!
Will have to open the 'About' window now and then to find out, when the core update has been made.
Reply With Quote
  #50  
Old 09.06.2022, 14:15
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

@StefanM: I will ping you here
__________________
JD-Dev & Server-Admin
Reply With Quote
  #51  
Old 09.06.2022, 14:22
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,922
Default

Quote:
Originally Posted by StefanM View Post
I will!
Will have to open the 'About' window now and then to find out, when the core update has been made.
With your experience you could also easily get our source code and provide live feedback if you want
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #52  
Old 09.06.2022, 14:44
mgpai mgpai is offline
Script Master
 
Join Date: Sep 2013
Posts: 1,533
Default

Quote:
Originally Posted by StefanM View Post
I will!
Will have to open the 'About' window now and then to find out, when the core update has been made.
You can modify THIS script to get an alert.

Replace:
Code:
callAPI("system", "restartJD");
with:
Code:
alert("" + revision);
Reply With Quote
  #53  
Old 09.06.2022, 16:02
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 485
Default

[QUOTE=mgpai;504148]You can modify **External links are only visible to Support Staff**... script to get an alert.

First of all, thanks for the prompt reply.

I modified and installed that script.
Then I clicked on Test Run.
I had to confirm the permission and "Don't show this again".
It showed me the core revision number.

But I could not get the Test Run work once again.
I click on the 'Test Run' button, the button 'responds'.
But then nothing happens.

Also restarting JD wouldn't help.

Can you help?
Reply With Quote
  #54  
Old 09.06.2022, 16:11
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 485
Default

Quote:
Originally Posted by Jiaz View Post
@StefanM: I will ping you here
Thanks, I appreciate this.
BTW, what about VK.com issues?
I understand, that they have not been addressed in the current core revision #46157.
Could you ping me for that one as well, please?
So I know when it makes sense testing it.
Reply With Quote
  #55  
Old 09.06.2022, 16:12
pspzockerscene's Avatar
pspzockerscene pspzockerscene is offline
Community Manager
 
Join Date: Mar 2009
Location: Deutschland
Posts: 70,922
Default

Quote:
Originally Posted by StefanM View Post
I understand, that they have not been addressed in the current core revision #46157.
Yes they have been released.
Please post vk related reports in the vk thread.
__________________
JD Supporter, Plugin Dev. & Community Manager

Erste Schritte & Tutorials || JDownloader 2 Setup Download
Spoiler:

A users' JD crashes and the first thing to ask is:
Quote:
Originally Posted by Jiaz View Post
Do you have Nero installed?
Reply With Quote
  #56  
Old 09.06.2022, 16:15
mgpai mgpai is offline
Script Master
 
Join Date: Sep 2013
Posts: 1,533
Default

Quote:
Originally Posted by StefanM View Post
But I could not get the Test Run work once again.
I click on the 'Test Run' button, the button 'responds'.
But then nothing happens.
Script tracks the versions by storing them in "JD\revisions.txt". If the current version number is not present in that file, it will add it to that file and display an alert, which is what happened on the first run.

It will repeat the task on each run and display an alert only if the version has since changed and does not exist in that file.
Reply With Quote
  #57  
Old 09.06.2022, 22:36
StefanM's Avatar
StefanM StefanM is offline
JD VIP
 
Join Date: Oct 2020
Posts: 485
Default

Quote:
Originally Posted by mgpai View Post
Script tracks the versions by storing them in "JD\revisions.txt". If the current version number is not present in that file, it will add it to that file and display an alert, which is what happened on the first run.

It will repeat the task on each run and display an alert only if the version has since changed and does not exist in that file.
Got it!
Changed the number in that txt-file to 46156, and I did get the alert again. Now I have

46156
46157


in that file as you explained.

BTW: I've been using JD for more than 12 years now, but today it was the first time I installed a script. Thanks to you!

And maybe I can learn to write scripts by 'combining' or replacing lines from some other scripts, as soon as I understand parts of those scripts.

Again, thank you very much!
Reply With Quote
  #58  
Old 10.06.2022, 19:05
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

Quote:
Originally Posted by Jiaz View Post
@StefanM: I will ping you here
ping
__________________
JD-Dev & Server-Admin
Reply With Quote
  #59  
Old 13.06.2022, 18:58
Derp Derp is offline
JD VIP
 
Join Date: Oct 2011
Posts: 336
Default

Did these recent changes also affect filtering entries in the Downloads/LinkGrabber-panes with wildcards?

I.e. entering arte lists all packages/filenames with the string anywhere in the name.
Entering arte*2200 only lists files which start with arte and end with 2200, so like the regex ^arte.*2200$.

But I'm sure before these changes entering arte*2200 was treated like ^.*arte.*2200.*$, at least in the older May-18th-build I tried.

Any way to get the old behavior back, or is this changed for good?
Reply With Quote
  #60  
Old 13.06.2022, 19:12
Jiaz's Avatar
Jiaz Jiaz is offline
JD Manager
 
Join Date: Mar 2009
Location: Germany
Posts: 79,290
Default

@Derp: yes, caused by recent change, see https://board.jdownloader.org/showpo...08&postcount=5

I don't know which one is better
Quote:
*arte*2200
would be correct wildcard now
or add option to use old mode like
Quote:
arte*2200
__________________
JD-Dev & Server-Admin
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

All times are GMT +2. The time now is 09:25.
Provided By AppWork GmbH | Privacy | Imprint
Parts of the Design are used from Kirsch designed by Andrew & Austin
Powered by vBulletin® Version 3.8.10 Beta 1
Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.