[pspzockerscene]

Originally Posted by CheatBaker

Actually, I didn't see other case, but il do not means it can't occur.
I thought : Maybe if you put [A-Z] in your regular expression, you will not have any trouble with this kind of problem, except if it causes unwanted effects.

Done.

Originally Posted by CheatBaker

If I dared, I would suggest you some other improvements :
In a file name, when you encounter a character forbidden, especially by MS-DOS, you replace it by an underscore one. It is clever.
But some of them are useful to explain and light the structure and the meaning of this file name. So I have to replace them manually by other acceptable characters. My correspondances are the following :

Agreed and done:
We already got a function for this but we are not yet using it globally.
Therefore, I've updated the arte.tv plugin to make use of it.
You can see our current character replacements here in our source code:
github.com/mirror/jdownloader/blob/master/src/jd/plugins/Plugin.java#L779

For all code changes mentioned in this post, the following information applies:
Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!
---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

-psp-

[pspzockerscene]

Additional information:
We got a ticket regarding this topic:


Once that is done, we will provide a default set of replacements which can be user-defined.
The "replace invalid to underscore" functionality will remain but only after the user-defined replacements are done so mostly you shouldn't "loose" any information anymore then.
Once the mentioned ticket is done, I'll reply in this thread one more time.

[CheatBaker]

Originally Posted by pspzockerscene

Additional information:
Controlling: customized(advanced settings) filename characters replacer
Status: Assigned Created:
2017-06-16T07:58:49Z
Priority: Normal Progress: 0%
Last Update:
2023-07-25T11:17:59Z
Details: here

Hello,
I saw that you have changed the way of handle filenames. Thanks. I did guess that you used the old way (before the great revolution of Arte, last year). It is better. Maybe you can apply that to the package name too, even if it doesn't matter for downloadings, just esthetic.
I'm very interested by your user-defined replacement. It will better more. Thanks too for that.

About the quote : If I try to click on "here" after "details", I obtain a message wich ask me to identify me and it doesn't want me to give my log Id . I suppose I'm not granted .

About github.com/mirror/jdownloader/blob/master/src/jd/plugins/Plugin.java#L779 :
I saw in this code the characters changes, except the double quote (") which must be treated in another function, but I don't understand some details :
- The "!" is converted in "¡" and that is not useful because MS-DOS accepts it. In spite of the instruction is flagged "not illegal" two lines upper, it is conserved. Maybe the need of this conversion is elsewhere, or is it a forgetting ?
- Maybe the slash (\) could be replaced by "∖"(Ascii=92) like double slash (\\), instead of "'" (single quote) which is not very logical.
Otherwise, it seems correct (except the colon. I prefer minus, but it is my own convenience, and I can't impose it to everybody)

Your user-defined adding will solve it, I presume.

Last minute :
ARTE_NEXT is back. I don't understand why this platform appears again. It gives to me twice more work for creating good filenames. Happily, on the package name, it doesn't, and that help me for correcting. I hope that it is temporary.

Regards
CB

[pspzockerscene]

Originally Posted by CheatBaker

Maybe you can apply that to the package name too, even if it doesn't matter for downloadings, just esthetic

Done.

Originally Posted by CheatBaker

About the quote : If I try to click on "here" after "details", I obtain a message wich ask me to identify me and it doesn't want me to give my log Id . I suppose I'm not granted .

The details view is only for internal usage / developers.

Originally Posted by CheatBaker

I saw in this code the characters changes, except the double quote (") which must be treated in another function, but I don't understand some details

Double-quote is changed to single quote, see:
github.com/mirror/jdownloader/blob/5f50ef81a535c64d31713ed043587eac7a3da057/src/jd/plugins/Plugin.java#L793C22-L793C22

Originally Posted by CheatBaker

- The "!" is converted in "¡" and that is not useful because MS-DOS accepts it. In spite of the instruction is flagged "not illegal" two lines upper, it is conserved. Maybe the need of this conversion is elsewhere, or is it a forgetting ?

That line is commented out - "!" is not changed as it is allowed in filenames.
Your English is hard to understand. Maybe you want to answer in your native language and/or use Google translage (sorry - I'm not meaning this in any bad way).

Originally Posted by CheatBaker

- Maybe the slash (\) could be replaced by "∖"(Ascii=92) like double slash (\\), instead of "'" (single quote) which is not very logical.

Looks like you mis-read that one too. Backslash is also already replaced by "∖" and slash by "⁄".

Originally Posted by CheatBaker

Otherwise, it seems correct (except the colon. I prefer minus, but it is my own convenience, and I can't impose it to everybody)

Your user-defined adding will solve it, I presume.

Yes, you will be able to customize this in the future.

Originally Posted by CheatBaker

Last minute :
ARTE_NEXT is back

I'm not an ARTE user so I have no idea what "ARTE_NEXT" is.

Fo all code changes mentioned in this post, the following information applies:
Bitte auf das nächste CORE-Update warten!

Please wait for the next CORE-Update!

Wartest du auf einen angekündigten Bugfix oder ein neues Feature?
Updates werden nicht immer sofort bereitgestellt!
Bitte lies unser Update FAQ! | Please read our Update FAQ!
---
Are you waiting for recently announced changes to get released?
Updates to not necessarily get released immediately!
Bitte lies unser Update FAQ! | Please read our Update FAQ!

-psp-

[CheatBaker]

Originally Posted by pspzockerscene

Your English is hard to understand. Maybe you want to answer in your native language and/or use Google translage (sorry - I'm not meaning this in any bad way).

I apologize for this delay in responding and also for my abominable English. I'm French, and we're not known to be good at languages. All the text is now translated by Google as you suggested to me. Hope you can understand it better.

Originally Posted by pspzockerscene

Done.

Ok, Thank You

Originally Posted by pspzockerscene

The details view is only for internal usage / developers.

OK, it's noted

Originally Posted by pspzockerscene

Double-quote is changed to single quote, see:
github.com/mirror/jdownloader/blob/5f50ef81a535c64d31713ed043587eac7a3da057/src/jd/plugins/Plugin.java#L793C22-L793C22

Looks like you mis-read that one too. Backslash is also already replaced by "" and slash by "/".

It's Ok. I didn't quite understand these instructions. Now, I do.

Originally Posted by pspzockerscene

That line is commented out - "!" is not changed as it is allowed in filenames.

In fact, the "!" always becomes "¡" as you can see on this url:
**External links are only visible to Support Staff****External links are only visible to Support Staff**

Originally Posted by pspzockerscene

Yes, you will be able to customize this in the future.

Understood, I can't wait.

Originally Posted by pspzockerscene

I'm not an ARTE user so I have no idea what "ARTE_NEXT" is.

It doesn't matter anymore: I found a setting that gives me the right result.

**********
Another problem
By the way, this url is not loading by JD
**External links are only visible to Support Staff****External links are only visible to Support Staff**

Thank you for your attention.

[pspzockerscene]

Regarding the character replacement setting:
I will post in this thread once we got news about that.
Until then, you can use external programs to e.g. revert replacements or change them. That shouldn't be hard to setup.

Regarding your last link:
That also fails here in browser.
Screenshot (open SPOILER to see):

Spoiler:

-> You might need to contact the ARTE support about this one.

[pspzockerscene]

Character replacer changes are live, see:
https://board.jdownloader.org/showthread.php?t=95411